* [PATCH 34/34] Staging: comedi: drivers: cd_pcidas: Compression of
@ 2016-07-30 20:04 Nadim almas
2016-08-02 17:42 ` Ian Abbott
2016-08-21 14:57 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Nadim almas @ 2016-07-30 20:04 UTC (permalink / raw)
To: abbotti; +Cc: gregkh, linux-kernel, devel, Nadim almas
This patch compresses two lines in to a single line in file
cb_pcidas.c
if immediate return statement is found. It also removes variable
bytes_written as it is no longer needed.
It is done using script Coccinelle. And coccinelle uses following
semantic patch for this compression function:
@@
expression e, ret;
@@
-ret =
+return
e;
-return ret
Signed-off-by: Nadim Almas <nadim.902@gmail.com>
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
index 1f9c08a..d30cf3d 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -1408,9 +1408,7 @@ static int set_ai_fifo_size(struct comedi_device *dev, unsigned int num_samples)
if (retval < 0)
return retval;
- num_samples = retval * fifo->num_segments * fifo->sample_packing_ratio;
-
- return num_samples;
+ return retval * fifo->num_segments * fifo->sample_packing_ratio;
}
/* query length of fifo */
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 34/34] Staging: comedi: drivers: cd_pcidas: Compression of
2016-07-30 20:04 [PATCH 34/34] Staging: comedi: drivers: cd_pcidas: Compression of Nadim almas
@ 2016-08-02 17:42 ` Ian Abbott
2016-08-21 14:57 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Ian Abbott @ 2016-08-02 17:42 UTC (permalink / raw)
To: Nadim almas; +Cc: gregkh, linux-kernel, devel
On 30/07/16 21:04, Nadim almas wrote:
> This patch compresses two lines in to a single line in file
> cb_pcidas.c
But this patch changes cb_pcidas64.c. Also, the Subject line says
'cd_pcidas'.
You can remove the 'drivers:' tag from the subject line to save some
space. It is sufficient to tag it as 'Staging: comedi: cb_pcidas64:'.
> if immediate return statement is found. It also removes variable
> bytes_written as it is no longer needed.
The patch does not remove any variables.
> It is done using script Coccinelle. And coccinelle uses following
> semantic patch for this compression function:
>
> @@
> expression e, ret;
> @@
>
> -ret =
> +return
> e;
> -return ret
>
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
>
> drivers/staging/comedi/drivers/cb_pcidas64.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
>
>
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
> index 1f9c08a..d30cf3d 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
> @@ -1408,9 +1408,7 @@ static int set_ai_fifo_size(struct comedi_device *dev, unsigned int num_samples)
> if (retval < 0)
> return retval;
>
> - num_samples = retval * fifo->num_segments * fifo->sample_packing_ratio;
> -
> - return num_samples;
> + return retval * fifo->num_segments * fifo->sample_packing_ratio;
> }
>
> /* query length of fifo */
>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 34/34] Staging: comedi: drivers: cd_pcidas: Compression of
2016-07-30 20:04 [PATCH 34/34] Staging: comedi: drivers: cd_pcidas: Compression of Nadim almas
2016-08-02 17:42 ` Ian Abbott
@ 2016-08-21 14:57 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-08-21 14:57 UTC (permalink / raw)
To: Nadim almas; +Cc: abbotti, linux-kernel, devel
On Sat, Jul 30, 2016 at 01:04:55PM -0700, Nadim almas wrote:
> This patch compresses two lines in to a single line in file
> cb_pcidas.c
> if immediate return statement is found. It also removes variable
> bytes_written as it is no longer needed.
>
> It is done using script Coccinelle. And coccinelle uses following
> semantic patch for this compression function:
>
> @@
> expression e, ret;
> @@
>
> -ret =
> +return
> e;
> -return ret
>
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
Your Subject: seems very odd, can you please fix it up?
And where are the other 33 patches in this series?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-21 21:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-30 20:04 [PATCH 34/34] Staging: comedi: drivers: cd_pcidas: Compression of Nadim almas
2016-08-02 17:42 ` Ian Abbott
2016-08-21 14:57 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.