All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] multipath-tools: Pillar/Axiom supports failback=immediate
@ 2016-07-30 21:15 Xose Vazquez Perez
  0 siblings, 0 replies; 5+ messages in thread
From: Xose Vazquez Perez @ 2016-07-30 21:15 UTC (permalink / raw)
  Cc: Srinivasan Ramani, Xose Vazquez Perez, device-mapper development

ALUA device with support for preferred_path. Confirmed by
the vendor's utils and docs:
https://docs.oracle.com/cd/E35311_02/E28846_08/E41503_01/conPathSelection.html

Auto-generated template from Oracle FS Path Manager 4.0:
        vendor                "^Pillar(  )?$"
        product               "^Axiom"
        path_grouping_policy  group_by_prio
        prio                  oraclefspm
        path_checker          oraclefspm
        failback              immediate
        path_selector         "round-robin 0"

Template from Axiom Path Manager 3.1 for RHEL-6.1:
        vendor               "Pillar"
        product              "*"
        path_grouping_policy group_by_prio
        prio                 pillarapm
        path_checker         pillarapm
        failback             immediate
        no_path_retry        60
        dev_loss_tmo         60
        fast_io_fail_tmo     30

Cc: Srinivasan Ramani <srinivas.ramani@oracle.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index fe4a51f..ed23c92 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -635,7 +635,6 @@ static struct hwentry default_hw[] = {
 		.vendor        = "Pillar",
 		.product       = "Axiom.*",
 		.prio_name     = PRIO_ALUA,
-		.pgfailback    = FAILBACK_UNDEF,
 	},
 	{
 		.vendor        = "^Oracle",
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] multipath-tools: Pillar/Axiom supports failback=immediate
@ 2016-08-01 14:18 Xose Vazquez Perez
  0 siblings, 0 replies; 5+ messages in thread
From: Xose Vazquez Perez @ 2016-08-01 14:18 UTC (permalink / raw)
  Cc: Srinivasan Ramani, Xose Vazquez Perez, device-mapper development

ALUA device with support for preferred_path. Confirmed by
the vendor's utils and docs: https://docs.oracle.com/cd/E35311_02/E28846_08/E41503_01/conPathSelection.html
and also the vendor: https://marc.info/?l=dm-devel&m=147004019524938

Cc: Srinivasan Ramani <srinivas.ramani@oracle.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index d53cd34..6655c98 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -597,7 +597,7 @@ static struct hwentry default_hw[] = {
 		.vendor        = "Pillar",
 		.product       = "Axiom.*",
 		.pgpolicy      = GROUP_BY_PRIO,
-		.pgfailback    = FAILBACK_UNDEF,
+		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.prio_name     = PRIO_ALUA,
 	},
 	/*
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] multipath-tools: Pillar/Axiom supports failback=immediate
  2016-07-31  0:02   ` Xose Vazquez Perez
@ 2016-07-31 22:09     ` Srinivas Ramani
  0 siblings, 0 replies; 5+ messages in thread
From: Srinivas Ramani @ 2016-07-31 22:09 UTC (permalink / raw)
  To: Xose Vazquez Perez; +Cc: development, device-mapper

[-- Attachment #1: Type: text/plain, Size: 3549 bytes --]

Hi Xose;

I agree.

/*
         * Pillar Data controller family
         *
         * Maintainer : Srinivasan Ramani
         * Mail : srinivas.ramani@oracle.com
         */
        {
                .vendor        = "^Pillar(  )?$",
                .product       = "^Axiom"
                .getuid        = DEFAULT_GETUID,
                .features      = DEFAULT_FEATURES,
                .hwhandler     = DEFAULT_HWHANDLER,
                .selector      = DEFAULT_SELECTOR,
                .pgpolicy      = GROUP_BY_PRIO,
                .pgfailback    = -FAILBACK_IMMEDIATE,
                .rr_weight     = RR_WEIGHT_NONE,
                .no_path_retry = NO_PATH_RETRY_UNDEF,
                .minio         = DEFAULT_MINIO,
                .checker_name  = TUR,
                .prio_name     = PRIO_ALUA,
        },
        /*
         * Oracle FS controller family
         *
         * Maintainer : Srinivasan Ramani
         * Mail : srinivas.ramani@oracle.com
         */
        {
                .vendor        = "^Oracle(  )?$",
                .product       = "^Oracle FS",
                .getuid        = DEFAULT_GETUID,
                .features      = DEFAULT_FEATURES,
                .hwhandler     = DEFAULT_HWHANDLER,
                .selector      = DEFAULT_SELECTOR,
                .pgpolicy      = GROUP_BY_PRIO,
                .pgfailback    = -FAILBACK_IMMEDIATE,
                .rr_weight     = RR_WEIGHT_NONE,
                .no_path_retry = NO_PATH_RETRY_UNDEF,
                .minio         = DEFAULT_MINIO,
                .checker_name  = TUR,
                .prio_name     = PRIO_ALUA,
        },




The patch would be attached patch.txt file.


Best Regards
Srini

-----Original Message-----
From: Xose Vazquez Perez [mailto:xose.vazquez@gmail.com] 
Sent: Saturday, July 30, 2016 5:03 PM
To: Srinivas Ramani
Cc: Christophe Varoqui; device-mapper development
Subject: Re: [PATCH] multipath-tools: Pillar/Axiom supports failback=immediate

On 07/31/2016 01:18 AM, Srinivas Ramani wrote:

Pillar/Axiom and "Oracle FS" configs look the same.

>                 .vendor        = "^Pillar(  )?$",
>                 .product       = "^Axiom"
>                 .getuid        = DEFAULT_GETUID,
>                 .features      = DEFAULT_FEATURES,
>                 .hwhandler     = DEFAULT_HWHANDLER,
>                 .selector      = DEFAULT_SELECTOR,
>                 .pgpolicy      = GROUP_BY_PRIO,
>                 .pgfailback    = FAILBACK_UNDEF, <<<<<-----------

Why pgfailback is FAILBACK_UNDEF(manual)?, when in your /etc/multipath.conf template it's "immediate".

> Auto-generated template from Oracle FS Path Manager 4.0:
>         vendor                "^Pillar(  )?$"
>         product               "^Axiom"
>         path_grouping_policy  group_by_prio
>         prio                  oraclefspm
>         path_checker          oraclefspm
>         failback              immediate          <<<<<-----------
>         path_selector         "round-robin 0"
> 
> Template from Axiom Path Manager 3.1 for RHEL-6.1:
>         vendor               "Pillar"
>         product              "*"
>         path_grouping_policy group_by_prio
>         prio                 pillarapm
>         path_checker         pillarapm
>         failback             immediate          <<<<<-----------
>         no_path_retry        60
>         dev_loss_tmo         60
>         fast_io_fail_tmo     30

Thank you.

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 1976 bytes --]

--- 1/hwtable.c 2016-07-31 15:03:56.614527157 -0700
+++ 2/hwtable.c 2016-07-31 15:04:02.599057789 -0700
@@ -764,17 +764,38 @@
         * Pillar Data controller family
         *
         * Maintainer : Srinivasan Ramani
-        * Mail : sramani@pillardata.com
+        * Mail : srinivas.ramani@oracle.com
         */
        {
-               .vendor        = "Pillar",
-               .product       = "Axiom.*",
+               .vendor        = "^Pillar(  )?$",
+               .product       = "^Axiom"
                .getuid        = DEFAULT_GETUID,
                .features      = DEFAULT_FEATURES,
                .hwhandler     = DEFAULT_HWHANDLER,
                .selector      = DEFAULT_SELECTOR,
                .pgpolicy      = GROUP_BY_PRIO,
-               .pgfailback    = FAILBACK_UNDEF,
+               .pgfailback    = -FAILBACK_IMMEDIATE,
+               .rr_weight     = RR_WEIGHT_NONE,
+               .no_path_retry = NO_PATH_RETRY_UNDEF,
+               .minio         = DEFAULT_MINIO,
+               .checker_name  = TUR,
+               .prio_name     = PRIO_ALUA,
+       },
+       /*
+        * Oracle FS controller family
+        *
+        * Maintainer : Srinivasan Ramani
+        * Mail : srinivas.ramani@oracle.com
+        */
+       {
+               .vendor        = "^Oracle(  )?$",
+               .product       = "^Oracle FS",
+               .getuid        = DEFAULT_GETUID,
+               .features      = DEFAULT_FEATURES,
+               .hwhandler     = DEFAULT_HWHANDLER,
+               .selector      = DEFAULT_SELECTOR,
+               .pgpolicy      = GROUP_BY_PRIO,
+               .pgfailback    = -FAILBACK_IMMEDIATE,
+               .rr_weight     = RR_WEIGHT_NONE,
+               .no_path_retry = NO_PATH_RETRY_UNDEF,
+               .minio         = DEFAULT_MINIO,
+               .checker_name  = TUR,
+               .prio_name     = PRIO_ALUA,
+       },
       

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] multipath-tools: Pillar/Axiom supports failback=immediate
  2016-07-30 23:18 ` Srinivas Ramani
@ 2016-07-31  0:02   ` Xose Vazquez Perez
  2016-07-31 22:09     ` Srinivas Ramani
  0 siblings, 1 reply; 5+ messages in thread
From: Xose Vazquez Perez @ 2016-07-31  0:02 UTC (permalink / raw)
  To: Srinivas Ramani; +Cc: device-mapper development

On 07/31/2016 01:18 AM, Srinivas Ramani wrote:

Pillar/Axiom and "Oracle FS" configs look the same.

>                 .vendor        = "^Pillar(  )?$",
>                 .product       = "^Axiom"
>                 .getuid        = DEFAULT_GETUID,
>                 .features      = DEFAULT_FEATURES,
>                 .hwhandler     = DEFAULT_HWHANDLER,
>                 .selector      = DEFAULT_SELECTOR,
>                 .pgpolicy      = GROUP_BY_PRIO,
>                 .pgfailback    = FAILBACK_UNDEF, <<<<<-----------

Why pgfailback is FAILBACK_UNDEF(manual)?, when in your
/etc/multipath.conf template it's "immediate".

> Auto-generated template from Oracle FS Path Manager 4.0:
>         vendor                "^Pillar(  )?$"
>         product               "^Axiom"
>         path_grouping_policy  group_by_prio
>         prio                  oraclefspm
>         path_checker          oraclefspm
>         failback              immediate          <<<<<-----------
>         path_selector         "round-robin 0"
> 
> Template from Axiom Path Manager 3.1 for RHEL-6.1:
>         vendor               "Pillar"
>         product              "*"
>         path_grouping_policy group_by_prio
>         prio                 pillarapm
>         path_checker         pillarapm
>         failback             immediate          <<<<<-----------
>         no_path_retry        60
>         dev_loss_tmo         60
>         fast_io_fail_tmo     30

Thank you.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] multipath-tools: Pillar/Axiom supports failback=immediate
       [not found] <<1469913348-9350-1-git-send-email-xose.vazquez@gmail.com>
@ 2016-07-30 23:18 ` Srinivas Ramani
  2016-07-31  0:02   ` Xose Vazquez Perez
  0 siblings, 1 reply; 5+ messages in thread
From: Srinivas Ramani @ 2016-07-30 23:18 UTC (permalink / raw)
  To: Xose Vazquez Perez; +Cc: Srinivasan Ramani, device-mapper development

Hi;

The changes needed would be :


/*
         * Pillar Data controller family
         *
         * Maintainer : Srinivasan Ramani
         * Mail : srinivas.ramani@oracle.com
         */
        {
                .vendor        = "^Pillar(  )?$",
                .product       = "^Axiom"
                .getuid        = DEFAULT_GETUID,
                .features      = DEFAULT_FEATURES,
                .hwhandler     = DEFAULT_HWHANDLER,
                .selector      = DEFAULT_SELECTOR,
                .pgpolicy      = GROUP_BY_PRIO,
                .pgfailback    = FAILBACK_UNDEF,
                .rr_weight     = RR_WEIGHT_NONE,
                .no_path_retry = NO_PATH_RETRY_UNDEF,
                .minio         = DEFAULT_MINIO,
                .checker_name  = TUR,
                .prio_name     = PRIO_ALUA,
        },
        /*
         * Oracle FS controller family
         *
         * Maintainer : Srinivasan Ramani
         * Mail : srinivas.ramani@oracle.com
         */
        {
                .vendor        = "^Oracle(  )?$",
                .product       = "^Oracle FS",
                .getuid        = DEFAULT_GETUID,
                .features      = DEFAULT_FEATURES,
                .hwhandler     = DEFAULT_HWHANDLER,
                .selector      = DEFAULT_SELECTOR,
                .pgpolicy      = GROUP_BY_PRIO,
                .pgfailback    = FAILBACK_UNDEF,
                .rr_weight     = RR_WEIGHT_NONE,
                .no_path_retry = NO_PATH_RETRY_UNDEF,
                .minio         = DEFAULT_MINIO,
                .checker_name  = TUR,
                .prio_name     = PRIO_ALUA,
        },



With Best Regards
Srini
-----Original Message-----
From: Xose Vazquez Perez [mailto:xose.vazquez@gmail.com] 
Sent: Saturday, July 30, 2016 2:16 PM
Cc: Xose Vazquez Perez; Srinivasan Ramani; Christophe Varoqui; device-mapper development
Subject: [PATCH] multipath-tools: Pillar/Axiom supports failback=immediate

ALUA device with support for preferred_path. Confirmed by the vendor's utils and docs:
https://docs.oracle.com/cd/E35311_02/E28846_08/E41503_01/conPathSelection.html

Auto-generated template from Oracle FS Path Manager 4.0:
        vendor                "^Pillar(  )?$"
        product               "^Axiom"
        path_grouping_policy  group_by_prio
        prio                  oraclefspm
        path_checker          oraclefspm
        failback              immediate
        path_selector         "round-robin 0"

Template from Axiom Path Manager 3.1 for RHEL-6.1:
        vendor               "Pillar"
        product              "*"
        path_grouping_policy group_by_prio
        prio                 pillarapm
        path_checker         pillarapm
        failback             immediate
        no_path_retry        60
        dev_loss_tmo         60
        fast_io_fail_tmo     30

Cc: Srinivasan Ramani <srinivas.ramani@oracle.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index fe4a51f..ed23c92 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -635,7 +635,6 @@ static struct hwentry default_hw[] = {
 		.vendor        = "Pillar",
 		.product       = "Axiom.*",
 		.prio_name     = PRIO_ALUA,
-		.pgfailback    = FAILBACK_UNDEF,
 	},
 	{
 		.vendor        = "^Oracle",
--
2.7.4

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-08-01 14:18 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-30 21:15 [PATCH] multipath-tools: Pillar/Axiom supports failback=immediate Xose Vazquez Perez
     [not found] <<1469913348-9350-1-git-send-email-xose.vazquez@gmail.com>
2016-07-30 23:18 ` Srinivas Ramani
2016-07-31  0:02   ` Xose Vazquez Perez
2016-07-31 22:09     ` Srinivas Ramani
2016-08-01 14:18 Xose Vazquez Perez

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.