All of lore.kernel.org
 help / color / mirror / Atom feed
* [v4] Fix to avoid IS_ERR_VALUE and IS_ERR abuses on 64bit systems.
@ 2016-07-31 11:18 ` Arvind Yadav
  0 siblings, 0 replies; 14+ messages in thread
From: Arvind Yadav @ 2016-07-31 11:18 UTC (permalink / raw)
  To: zajec5, leoli
  Cc: qiang.zhao, scottwood, viresh.kumar, akpm, linux-wireless,
	netdev, linuxppc-dev, linux, arnd, davem, David.Laight,
	Arvind Yadav

IS_ERR_VALUE() assumes that parameter is an unsigned long.
It can not be used to check if 'unsigned int' is passed insted.
Which tends to reflect an error.

In 64bit architectures sizeof (int) == 4 && sizeof (long) == 8.
IS_ERR_VALUE(x) is ((x) >= (unsigned long)-4095).

IS_ERR_VALUE() of 'unsigned int' is always false because the 32bit
value is zero extended to 64 bits.

Value of (unsigned int)-4095 is always less than value of
(unsigned long)-4095.

Now We are taking only first 32 bit for error checking rest of the 32 bit
we ignore such that we get appropriate comparison on 64bit system as well.

First 32bit of Value of (unsigned int)-4095 and (unsigned long)-4095 will
be equal.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 include/linux/err.h | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/include/linux/err.h b/include/linux/err.h
index 1e35588..c2a2789 100644
--- a/include/linux/err.h
+++ b/include/linux/err.h
@@ -18,7 +18,17 @@
 
 #ifndef __ASSEMBLY__
 
-#define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO)
+#define IS_ERR_VALUE(x) unlikely(is_error_check(x))
+
+static inline int is_error_check(unsigned long error)
+{
+	unsigned int first32bit = (error & 0xFFFFFFFF);
+
+	if (first32bit >= (unsigned int)-MAX_ERRNO)
+		return 1;
+	else
+		return 0;
+}
 
 static inline void * __must_check ERR_PTR(long error)
 {
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2016-08-03 13:56 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-31 11:18 [v4] Fix to avoid IS_ERR_VALUE and IS_ERR abuses on 64bit systems Arvind Yadav
2016-07-31 11:18 ` Arvind Yadav
2016-08-01  7:02 ` Arnd Bergmann
2016-08-01  7:02   ` Arnd Bergmann
2016-08-01 16:55   ` Scott Wood
2016-08-01 16:55     ` Scott Wood
2016-08-02  7:45     ` Arnd Bergmann
2016-08-02  7:45       ` Arnd Bergmann
2016-08-02 15:34       ` arvind Yadav
2016-08-02 15:34         ` arvind Yadav
2016-08-02 19:57         ` Scott Wood
2016-08-02 19:57           ` Scott Wood
2016-08-03 13:55           ` arvind Yadav
2016-08-02 15:48       ` arvind Yadav

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.