All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cfg80211: fix missing break in NL8211_CHAN_WIDTH_80P80 case
@ 2016-07-17 18:55 Colin King
  2016-08-02  7:44 ` Johannes Berg
  0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-07-17 18:55 UTC (permalink / raw)
  To: Johannes Berg, David S . Miller, linux-wireless, netdev; +Cc: linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The switch on chandef->width is missing a break on the
NL8211_CHAN_WIDTH_80P80 case; currently we get a WARN_ON when
center_freq2 is non-zero because of the missing break.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 net/wireless/chan.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/wireless/chan.c b/net/wireless/chan.c
index b0e11b6..0f50622 100644
--- a/net/wireless/chan.c
+++ b/net/wireless/chan.c
@@ -513,6 +513,7 @@ static bool cfg80211_chandef_dfs_available(struct wiphy *wiphy,
 		r = cfg80211_get_chans_dfs_available(wiphy,
 						     chandef->center_freq2,
 						     width);
+		break;
 	default:
 		WARN_ON(chandef->center_freq2);
 		break;
-- 
2.8.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] cfg80211: fix missing break in NL8211_CHAN_WIDTH_80P80 case
  2016-07-17 18:55 [PATCH] cfg80211: fix missing break in NL8211_CHAN_WIDTH_80P80 case Colin King
@ 2016-08-02  7:44 ` Johannes Berg
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2016-08-02  7:44 UTC (permalink / raw)
  To: Colin King, David S . Miller, linux-wireless, netdev; +Cc: linux-kernel

On Sun, 2016-07-17 at 19:55 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The switch on chandef->width is missing a break on the
> NL8211_CHAN_WIDTH_80P80 case; currently we get a WARN_ON when
> center_freq2 is non-zero because of the missing break.
> 
Applied, thanks.

johannes

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-02  8:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-17 18:55 [PATCH] cfg80211: fix missing break in NL8211_CHAN_WIDTH_80P80 case Colin King
2016-08-02  7:44 ` Johannes Berg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.