All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mac80211: fix check for buffered powersave frames with txq
@ 2016-07-11 13:09 Felix Fietkau
  2016-08-02  7:45 ` Johannes Berg
  0 siblings, 1 reply; 2+ messages in thread
From: Felix Fietkau @ 2016-07-11 13:09 UTC (permalink / raw)
  To: linux-wireless; +Cc: johannes

The logic was inverted here, set the bit if frames are pending.

Fixes: ba8c3d6f16a1 ("mac80211: add an intermediate software queue implementation")
Signed-off-by: Felix Fietkau <nbd@nbd.name>
---
 net/mac80211/rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
index 9a1eb70..aaa9373 100644
--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -1268,7 +1268,7 @@ static void sta_ps_start(struct sta_info *sta)
 	for (tid = 0; tid < ARRAY_SIZE(sta->sta.txq); tid++) {
 		struct txq_info *txqi = to_txq_info(sta->sta.txq[tid]);
 
-		if (!txqi->tin.backlog_packets)
+		if (txqi->tin.backlog_packets)
 			set_bit(tid, &sta->txq_buffered_tids);
 		else
 			clear_bit(tid, &sta->txq_buffered_tids);
-- 
2.8.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mac80211: fix check for buffered powersave frames with txq
  2016-07-11 13:09 [PATCH] mac80211: fix check for buffered powersave frames with txq Felix Fietkau
@ 2016-08-02  7:45 ` Johannes Berg
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2016-08-02  7:45 UTC (permalink / raw)
  To: Felix Fietkau, linux-wireless

On Mon, 2016-07-11 at 15:09 +0200, Felix Fietkau wrote:
> The logic was inverted here, set the bit if frames are pending.
> 
Applied, thanks.

johannes

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-02  8:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-11 13:09 [PATCH] mac80211: fix check for buffered powersave frames with txq Felix Fietkau
2016-08-02  7:45 ` Johannes Berg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.