* [PATCH] ath9k: fix GPIO mask for AR9462 and AR9565
@ 2016-06-03 5:46 miaoqing
2016-06-14 13:24 ` Kalle Valo
2016-07-17 21:05 ` [PATCH] " Stefan Lippers-Hollmann
0 siblings, 2 replies; 6+ messages in thread
From: miaoqing @ 2016-06-03 5:46 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, ath9k-devel, sudipm.mukherjee, Miaoqing Pan
From: Miaoqing Pan <miaoqing@codeaurora.org>
The incorrect GPIO mask cause kernel warning, when AR9462 access GPIO11.
Also fix the mask for AR9565.
WARNING: CPU: 1 PID: 199 at ../drivers/net/wireless/ath/ath9k/hw.c:2778 ath9k_hw_gpio_get+0x1a9/0x1b0 [ath9k_hw]
CPU: 1 PID: 199 Comm: kworker/u16:9 Not tainted 4.7.0-rc1-next-20160530+ #5
Hardware name: Acer TravelMate P243/BA40_HC, BIOS V1.01 04/20/2012
Workqueue: events_power_efficient rfkill_poll
0000000000000000 ffff88002cf73d28 ffffffff813b8ddc 0000000000000000
0000000000000000 ffff88002cf73d68 ffffffff8107a331 00000ada00000086
ffff880148d9c018 000000000000000b ffff880147e68720 0000000000000200
Call Trace:
[<ffffffff813b8ddc>] dump_stack+0x63/0x87
[<ffffffff8107a331>] __warn+0xd1/0xf0
[<ffffffff8107a41d>] warn_slowpath_null+0x1d/0x20
[<ffffffffc0775b19>] ath9k_hw_gpio_get+0x1a9/0x1b0 [ath9k_hw]
[<ffffffffc047f3e4>] ath9k_rfkill_poll_state+0x34/0x60 [ath9k]
[<ffffffffc06dbb53>] ieee80211_rfkill_poll+0x33/0x40 [mac80211]
[<ffffffffc03ad65a>] cfg80211_rfkill_poll+0x2a/0xc0 [cfg80211]
[<ffffffff817c5514>] rfkill_poll+0x24/0x50
[<ffffffff81093183>] process_one_work+0x153/0x3f0
[<ffffffff8109393b>] worker_thread+0x12b/0x4b0
[<ffffffff81093810>] ? rescuer_thread+0x340/0x340
[<ffffffff81099129>] kthread+0xc9/0xe0
[<ffffffff817d8f1f>] ret_from_fork+0x1f/0x40
[<ffffffff81099060>] ? kthread_park+0x60/0x60
Signed-off-by: Miaoqing Pan <miaoqing@codeaurora.org>
---
drivers/net/wireless/ath/ath9k/reg.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/reg.h b/drivers/net/wireless/ath/ath9k/reg.h
index 9272ca9..80ff69f 100644
--- a/drivers/net/wireless/ath/ath9k/reg.h
+++ b/drivers/net/wireless/ath/ath9k/reg.h
@@ -1122,12 +1122,12 @@ enum {
#define AR9300_NUM_GPIO 16
#define AR9330_NUM_GPIO 16
#define AR9340_NUM_GPIO 23
-#define AR9462_NUM_GPIO 10
+#define AR9462_NUM_GPIO 14
#define AR9485_NUM_GPIO 12
#define AR9531_NUM_GPIO 18
#define AR9550_NUM_GPIO 24
#define AR9561_NUM_GPIO 23
-#define AR9565_NUM_GPIO 12
+#define AR9565_NUM_GPIO 14
#define AR9580_NUM_GPIO 16
#define AR7010_NUM_GPIO 16
@@ -1139,12 +1139,12 @@ enum {
#define AR9300_GPIO_MASK 0x0000F4FF
#define AR9330_GPIO_MASK 0x0000F4FF
#define AR9340_GPIO_MASK 0x0000000F
-#define AR9462_GPIO_MASK 0x000003FF
+#define AR9462_GPIO_MASK 0x00003FFF
#define AR9485_GPIO_MASK 0x00000FFF
#define AR9531_GPIO_MASK 0x0000000F
#define AR9550_GPIO_MASK 0x0000000F
#define AR9561_GPIO_MASK 0x0000000F
-#define AR9565_GPIO_MASK 0x00000FFF
+#define AR9565_GPIO_MASK 0x00003FFF
#define AR9580_GPIO_MASK 0x0000F4FF
#define AR7010_GPIO_MASK 0x0000FFFF
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: ath9k: fix GPIO mask for AR9462 and AR9565
2016-06-03 5:46 [PATCH] ath9k: fix GPIO mask for AR9462 and AR9565 miaoqing
@ 2016-06-14 13:24 ` Kalle Valo
2016-07-17 21:05 ` [PATCH] " Stefan Lippers-Hollmann
1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2016-06-14 13:24 UTC (permalink / raw)
To: miaoqing pan; +Cc: linux-wireless, ath9k-devel, sudipm.mukherjee, Miaoqing Pan
miaoqing pan <miaoqing@codeaurora.org> wrote:
> From: Miaoqing Pan <miaoqing@codeaurora.org>
>
> The incorrect GPIO mask cause kernel warning, when AR9462 access GPIO11.
> Also fix the mask for AR9565.
>
> WARNING: CPU: 1 PID: 199 at ../drivers/net/wireless/ath/ath9k/hw.c:2778 ath9k_hw_gpio_get+0x1a9/0x1b0 [ath9k_hw]
> CPU: 1 PID: 199 Comm: kworker/u16:9 Not tainted 4.7.0-rc1-next-20160530+ #5
> Hardware name: Acer TravelMate P243/BA40_HC, BIOS V1.01 04/20/2012
> Workqueue: events_power_efficient rfkill_poll
> 0000000000000000 ffff88002cf73d28 ffffffff813b8ddc 0000000000000000
> 0000000000000000 ffff88002cf73d68 ffffffff8107a331 00000ada00000086
> ffff880148d9c018 000000000000000b ffff880147e68720 0000000000000200
> Call Trace:
> [<ffffffff813b8ddc>] dump_stack+0x63/0x87
> [<ffffffff8107a331>] __warn+0xd1/0xf0
> [<ffffffff8107a41d>] warn_slowpath_null+0x1d/0x20
> [<ffffffffc0775b19>] ath9k_hw_gpio_get+0x1a9/0x1b0 [ath9k_hw]
> [<ffffffffc047f3e4>] ath9k_rfkill_poll_state+0x34/0x60 [ath9k]
> [<ffffffffc06dbb53>] ieee80211_rfkill_poll+0x33/0x40 [mac80211]
> [<ffffffffc03ad65a>] cfg80211_rfkill_poll+0x2a/0xc0 [cfg80211]
> [<ffffffff817c5514>] rfkill_poll+0x24/0x50
> [<ffffffff81093183>] process_one_work+0x153/0x3f0
> [<ffffffff8109393b>] worker_thread+0x12b/0x4b0
> [<ffffffff81093810>] ? rescuer_thread+0x340/0x340
> [<ffffffff81099129>] kthread+0xc9/0xe0
> [<ffffffff817d8f1f>] ret_from_fork+0x1f/0x40
> [<ffffffff81099060>] ? kthread_park+0x60/0x60
>
> Signed-off-by: Miaoqing Pan <miaoqing@codeaurora.org>
Thanks, 1 patch applied to ath-current branch of ath.git:
e024111f6946 ath9k: fix GPIO mask for AR9462 and AR9565
--
Sent by pwcli
https://patchwork.kernel.org/patch/9151847/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k: fix GPIO mask for AR9462 and AR9565
2016-06-03 5:46 [PATCH] ath9k: fix GPIO mask for AR9462 and AR9565 miaoqing
2016-06-14 13:24 ` Kalle Valo
@ 2016-07-17 21:05 ` Stefan Lippers-Hollmann
2016-08-03 13:54 ` Valo, Kalle
1 sibling, 1 reply; 6+ messages in thread
From: Stefan Lippers-Hollmann @ 2016-07-17 21:05 UTC (permalink / raw)
To: miaoqing; +Cc: kvalo, linux-wireless, ath9k-devel, sudipm.mukherjee
Hi
On 2016-06-03, miaoqing@codeaurora.org wrote:
> From: Miaoqing Pan <miaoqing@codeaurora.org>
>
> The incorrect GPIO mask cause kernel warning, when AR9462 access GPIO11.
> Also fix the mask for AR9565.
[...]
I think I'm seeing a very similar issue on AR5008/ AR5416+AR2133 and
4.7-rc7 (mainline v4.7-rc7-92-g47ef4ad, to be exact).
[ 4.958874] ath9k 0000:02:02.0: enabling device (0000 -> 0002)
[...]
[ 5.401086] ------------[ cut here ]------------
[ 5.401093] WARNING: CPU: 1 PID: 1159 at /build/linux-aptosid-4.7~rc7/drivers/net/wireless/ath/ath9k/hw.c:2776 ath9k_hw_gpio_get+0x148/0x1a0 [ath9k_hw]
[ 5.401116] Modules linked in: iTCO_wdt gpio_ich iTCO_vendor_support evdev intel_rapl x86_pkg_temp_thermal intel_powerclamp coretemp ir_lirc_codec lirc_dev kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul rtl2832_sdr videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 videobuf2_core videodev ghash_clmulni_intel fc0013 rtl2832 i2c_mux regmap_i2c sha256_ssse3 sha256_generic drbg ansi_cprng rc_medion_x10_digitainer dvb_usb_rtl28xxu dvb_usb_v2 dvb_usb_dw2102(+) dvb_usb aesni_intel dvb_core aes_x86_64 lrw ati_remote media gf128mul glue_helper ablk_helper cryptd intel_cstate intel_rapl_perf snd_hda_codec_hdmi(+) i915 snd_hda_codec_realtek snd_hda_codec_generic pcspkr serio_raw i2c_i801 ath9k(+) ath9k_common video ath9k_hw i2c_algo_bit drm_kms_helper ath snd_hda_intel drm snd_hda_codec mac80211 snd_hda_core
[ 5.401135] snd_hwdep snd_pcm cfg80211 i2c_core intel_gtt rfkill snd_timer syscopyarea lpc_ich sysfillrect snd sg sysimgblt mfd_core mei_me soundcore fb_sys_fops mei nuvoton_cir floppy(+) rc_core button w83627ehf hwmon_vid parport_pc ppdev lp parport autofs4 ext4 crc16 jbd2 mbcache hid_generic usbhid hid dm_mod sd_mod sr_mod cdrom ohci_pci crc32c_intel psmouse r8169 ahci libahci libata scsi_mod xhci_pci xhci_hcd ohci_hcd e100 mii ehci_pci ehci_hcd usbcore usb_common e1000e ptp pps_core fjes
[ 5.401137] CPU: 1 PID: 1159 Comm: systemd-udevd Not tainted 4.7.0-rc7-aptosid-amd64 #1 aptosid 4.7~rc7-1~git92.slh.3
[ 5.401138] Hardware name: /DH67CL, BIOS BLH6710H.86A.0160.2012.1204.1156 12/04/2012
[ 5.401140] 0000000000000286 00000000f912d633 ffffffff81290fd3 0000000000000000
[ 5.401141] 0000000000000000 ffffffff81063fd4 ffff88040c6dc018 0000000000000000
[ 5.401143] 0000000000000002 0000000000000000 0000000000000100 ffff88040c6dc018
[ 5.401143] Call Trace:
[ 5.401148] [<ffffffff81290fd3>] ? dump_stack+0x5c/0x79
[ 5.401150] [<ffffffff81063fd4>] ? __warn+0xb4/0xd0
[ 5.401153] [<ffffffffa0668fb8>] ? ath9k_hw_gpio_get+0x148/0x1a0 [ath9k_hw]
[ 5.401156] [<ffffffffa0669653>] ? ath9k_hw_fill_cap_info+0x163/0x830 [ath9k_hw]
[ 5.401159] [<ffffffffa066a384>] ? ath9k_hw_init+0x664/0xb10 [ath9k_hw]
[ 5.401167] [<ffffffffa06fa7df>] ? ath9k_init_device+0x4df/0xe00 [ath9k]
[ 5.401170] [<ffffffff810b1e51>] ? request_threaded_irq+0xf1/0x1a0
[ 5.401176] [<ffffffffa070a259>] ? ath_pci_probe+0x1c9/0x370 [ath9k]
[ 5.401178] [<ffffffff812dad6a>] ? local_pci_probe+0x3a/0x90
[ 5.401179] [<ffffffff812dbccf>] ? pci_match_device+0xcf/0xf0
[ 5.401180] [<ffffffff812dc08b>] ? pci_device_probe+0xfb/0x140
[ 5.401183] [<ffffffff813b7dcd>] ? driver_probe_device+0x1ed/0x2b0
[ 5.401184] [<ffffffff813b7f1f>] ? __driver_attach+0x8f/0xa0
[ 5.401185] [<ffffffff813b7e90>] ? driver_probe_device+0x2b0/0x2b0
[ 5.401186] [<ffffffff813b5e12>] ? bus_for_each_dev+0x62/0xb0
[ 5.401188] [<ffffffff813b71ca>] ? bus_add_driver+0x19a/0x210
[ 5.401189] [<ffffffffa0718000>] ? 0xffffffffa0718000
[ 5.401190] [<ffffffff813b85b2>] ? driver_register+0x52/0xc0
[ 5.401195] [<ffffffffa0718005>] ? ath9k_init+0x5/0x34 [ath9k]
[ 5.401197] [<ffffffff81002147>] ? do_one_initcall+0x47/0x180
[ 5.401199] [<ffffffff8111b0a8>] ? do_init_module+0x51/0x1b9
[ 5.401201] [<ffffffff810d6e37>] ? load_module+0x1f77/0x23a0
[ 5.401202] [<ffffffff810d4330>] ? __symbol_put+0x80/0x80
[ 5.401205] [<ffffffff812277ac>] ? security_capable+0x3c/0x50
[ 5.401207] [<ffffffff810d7462>] ? SYSC_finit_module+0xc2/0xd0
[ 5.401210] [<ffffffff8153cd72>] ? entry_SYSCALL_64_fastpath+0x1a/0xa4
[ 5.401211] ---[ end trace ac762697fb0d9f1d ]---
[ 5.401211] ------------[ cut here ]------------
[ 5.401214] WARNING: CPU: 1 PID: 1159 at /build/linux-aptosid-4.7~rc7/drivers/net/wireless/ath/ath9k/hw.c:2796 ath9k_hw_gpio_get+0xb4/0x1a0 [ath9k_hw]
[ 5.401234] Modules linked in: iTCO_wdt gpio_ich iTCO_vendor_support evdev intel_rapl x86_pkg_temp_thermal intel_powerclamp coretemp ir_lirc_codec lirc_dev kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul rtl2832_sdr videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 videobuf2_core videodev ghash_clmulni_intel fc0013 rtl2832 i2c_mux regmap_i2c sha256_ssse3 sha256_generic drbg ansi_cprng rc_medion_x10_digitainer dvb_usb_rtl28xxu dvb_usb_v2 dvb_usb_dw2102(+) dvb_usb aesni_intel dvb_core aes_x86_64 lrw ati_remote media gf128mul glue_helper ablk_helper cryptd intel_cstate intel_rapl_perf snd_hda_codec_hdmi(+) i915 snd_hda_codec_realtek snd_hda_codec_generic pcspkr serio_raw i2c_i801 ath9k(+) ath9k_common video ath9k_hw i2c_algo_bit drm_kms_helper ath snd_hda_intel drm snd_hda_codec mac80211 snd_hda_core
[ 5.401254] snd_hwdep snd_pcm cfg80211 i2c_core intel_gtt rfkill snd_timer syscopyarea lpc_ich sysfillrect snd sg sysimgblt mfd_core mei_me soundcore fb_sys_fops mei nuvoton_cir floppy(+) rc_core button w83627ehf hwmon_vid parport_pc ppdev lp parport autofs4 ext4 crc16 jbd2 mbcache hid_generic usbhid hid dm_mod sd_mod sr_mod cdrom ohci_pci crc32c_intel psmouse r8169 ahci libahci libata scsi_mod xhci_pci xhci_hcd ohci_hcd e100 mii ehci_pci ehci_hcd usbcore usb_common e1000e ptp pps_core fjes
[ 5.401255] CPU: 1 PID: 1159 Comm: systemd-udevd Tainted: G W 4.7.0-rc7-aptosid-amd64 #1 aptosid 4.7~rc7-1~git92.slh.3
[ 5.401256] Hardware name: /DH67CL, BIOS BLH6710H.86A.0160.2012.1204.1156 12/04/2012
[ 5.401257] 0000000000000286 00000000f912d633 ffffffff81290fd3 0000000000000000
[ 5.401258] 0000000000000000 ffffffff81063fd4 ffff88040c6dc018 0000000000000000
[ 5.401260] 0000000000000002 0000000000000000 0000000000000100 ffff88040c6dc018
[ 5.401260] Call Trace:
[ 5.401262] [<ffffffff81290fd3>] ? dump_stack+0x5c/0x79
[ 5.401263] [<ffffffff81063fd4>] ? __warn+0xb4/0xd0
[ 5.401266] [<ffffffffa0668f24>] ? ath9k_hw_gpio_get+0xb4/0x1a0 [ath9k_hw]
[ 5.401268] [<ffffffffa0669653>] ? ath9k_hw_fill_cap_info+0x163/0x830 [ath9k_hw]
[ 5.401271] [<ffffffffa066a384>] ? ath9k_hw_init+0x664/0xb10 [ath9k_hw]
[ 5.401275] [<ffffffffa06fa7df>] ? ath9k_init_device+0x4df/0xe00 [ath9k]
[ 5.401277] [<ffffffff810b1e51>] ? request_threaded_irq+0xf1/0x1a0
[ 5.401282] [<ffffffffa070a259>] ? ath_pci_probe+0x1c9/0x370 [ath9k]
[ 5.401283] [<ffffffff812dad6a>] ? local_pci_probe+0x3a/0x90
[ 5.401284] [<ffffffff812dbccf>] ? pci_match_device+0xcf/0xf0
[ 5.401285] [<ffffffff812dc08b>] ? pci_device_probe+0xfb/0x140
[ 5.401287] [<ffffffff813b7dcd>] ? driver_probe_device+0x1ed/0x2b0
[ 5.401288] [<ffffffff813b7f1f>] ? __driver_attach+0x8f/0xa0
[ 5.401289] [<ffffffff813b7e90>] ? driver_probe_device+0x2b0/0x2b0
[ 5.401290] [<ffffffff813b5e12>] ? bus_for_each_dev+0x62/0xb0
[ 5.401291] [<ffffffff813b71ca>] ? bus_add_driver+0x19a/0x210
[ 5.401292] [<ffffffffa0718000>] ? 0xffffffffa0718000
[ 5.401293] [<ffffffff813b85b2>] ? driver_register+0x52/0xc0
[ 5.401297] [<ffffffffa0718005>] ? ath9k_init+0x5/0x34 [ath9k]
[ 5.401298] [<ffffffff81002147>] ? do_one_initcall+0x47/0x180
[ 5.401300] [<ffffffff8111b0a8>] ? do_init_module+0x51/0x1b9
[ 5.401301] [<ffffffff810d6e37>] ? load_module+0x1f77/0x23a0
[ 5.401303] [<ffffffff810d4330>] ? __symbol_put+0x80/0x80
[ 5.401304] [<ffffffff812277ac>] ? security_capable+0x3c/0x50
[ 5.401306] [<ffffffff810d7462>] ? SYSC_finit_module+0xc2/0xd0
[ 5.401307] [<ffffffff8153cd72>] ? entry_SYSCALL_64_fastpath+0x1a/0xa4
[ 5.401308] ---[ end trace ac762697fb0d9f1e ]---
[ 5.403236] ath: EEPROM regdomain: 0x809c
[ 5.403236] ath: EEPROM indicates we should expect a country code
[ 5.403237] ath: doing EEPROM country->regdmn map search
[ 5.403237] ath: country maps to regdmn code: 0x52
[ 5.403238] ath: Country alpha2 being used: CN
[ 5.403238] ath: Regpair used: 0x52
[...]
[ 5.411361] ieee80211 phy0: Selected rate control algorithm 'minstrel_ht'
[ 5.411655] ieee80211 phy0: Atheros AR5416 MAC/BB Rev:2 AR2133 RF Rev:81 mem=0xffffc90002aa0000, irq=18
[ 5.414043] ath9k 0000:02:02.0 wlp2s2: renamed from wlan0
02:02.0 Network controller [0280]: Qualcomm Atheros AR5416 Wireless Network Adapter [AR5008 802.11(a)bgn] [168c:0023] (rev 01)
Subsystem: Qualcomm Atheros AR5416 Wireless Network Adapter [AR5008 802.11(a)bgn] [168c:3071]
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
Latency: 168, Cache Line Size: 64 bytes
Interrupt: pin A routed to IRQ 18
Region 0: Memory at fe100000 (32-bit, non-prefetchable) [size=64K]
Capabilities: [40] #80 [0000]
Kernel driver in use: ath9k
Kernel modules: ath9k
Bisecting leads me to:
$ git bisect log
git bisect start 'drivers/net/wireless/ath/'
# good: [2dcd0af568b0cf583645c8a317dd12e344b1c72a] Linux 4.6
git bisect good 2dcd0af568b0cf583645c8a317dd12e344b1c72a
# bad: [47ef4ad2684d380dd6d596140fb79395115c3950] Merge tag 'for-linus-20160715' of git://git.infradead.org/linux-mtd
git bisect bad 47ef4ad2684d380dd6d596140fb79395115c3950
# bad: [b131129d96575479e2447d134cb1797cf430b3a4] ath10k: fix calibration init sequence of qca99x0
git bisect bad b131129d96575479e2447d134cb1797cf430b3a4
# good: [27ae9cd258a84ce7259afbee38dbe7841e723a68] ath9k: enable manual peak cal for all ar9300 chips
git bisect good 27ae9cd258a84ce7259afbee38dbe7841e723a68
# bad: [9d71d47eed20f34620e54e29bcc90f959d5873b8] ath10k: fix tx hang
git bisect bad 9d71d47eed20f34620e54e29bcc90f959d5873b8
# bad: [c8770bcf5cefa8cbfae21c07c4fe3428f5a9d42a] ath9k: Allow platform override BTCoex pin
git bisect bad c8770bcf5cefa8cbfae21c07c4fe3428f5a9d42a
# good: [c8c91b02a8ddb802259b712245ee97f9c3067a7f] ath9k_htc: fix up indents with spaces
git bisect good c8c91b02a8ddb802259b712245ee97f9c3067a7f
# bad: [b2d70d4944c1789bc64376ad97a811f37e230c87] ath9k: make GPIO API to support both of WMAC and SOC
git bisect bad b2d70d4944c1789bc64376ad97a811f37e230c87
Reverting this, and the other patches depending on it, fixes the
problem for me:
e024111f6946f45cf1559a8c6fd48d2d0f696d07 Revert "ath9k: fix GPIO mask for AR9462 and AR9565"
db2221901fbded787daed153281ed875de489692 Revert "ath9k: free GPIO resource for SOC GPIOs"
c7212b7136ba69efb9785df68b669381cb893920 Revert "ath9k: fix BTCoex configuration for SOC chips"
dfcf02cd2998e2240b2bc7b4f4412578b8070bdb Revert "ath9k: fix BTCoex access invalid registers for SOC chips"
668ae0a3e48ac6811f431915b466514bf167e2f4 Revert "ath9k: add bits definition of BTCoex MODE2/3 for SOC chips"
c8770bcf5cefa8cbfae21c07c4fe3428f5a9d42a Revert "ath9k: Allow platform override BTCoex pin"
79d4db1214a0c7b1818aaf64d0606b17ff1acea7 Revert "ath9k: cleanup led_pin initial"
b2d70d4944c1789bc64376ad97a811f37e230c87 Revert "ath9k: make GPIO API to support both of WMAC and SOC"
a01ab81b09c55025365c1de1345b941a18e05529 Revert "ath9k: define correct GPIO numbers and bits mask"
AR9285 (168c:002b) is fine either way.
Regards
Stefan Lippers-Hollmann
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ath9k: fix GPIO mask for AR9462 and AR9565
2016-07-17 21:05 ` [PATCH] " Stefan Lippers-Hollmann
@ 2016-08-03 13:54 ` Valo, Kalle
2016-08-04 5:30 ` Pan, Miaoqing
0 siblings, 1 reply; 6+ messages in thread
From: Valo, Kalle @ 2016-08-03 13:54 UTC (permalink / raw)
To: Stefan Lippers-Hollmann, miaoqing
Cc: linux-wireless, ath9k-devel, sudipm.mukherjee
Stefan Lippers-Hollmann <s.l-h@gmx.de> writes:
> Hi
>
> On 2016-06-03, miaoqing@codeaurora.org wrote:
>> From: Miaoqing Pan <miaoqing@codeaurora.org>
>>
>> The incorrect GPIO mask cause kernel warning, when AR9462 access GPIO11.
>> Also fix the mask for AR9565.
> [...]
>
> I think I'm seeing a very similar issue on AR5008/ AR5416+AR2133 and
> 4.7-rc7 (mainline v4.7-rc7-92-g47ef4ad, to be exact).
>
> [ 4.958874] ath9k 0000:02:02.0: enabling device (0000 -> 0002)
> [...]
> [ 5.401086] ------------[ cut here ]------------
> [ 5.401093] WARNING: CPU: 1 PID: 1159 at /build/linux-aptosid-4.7~rc7/drivers/net/wireless/ath/ath9k/hw.c:2776 ath9k_hw_gpio_get+0x148/0x1a0 [ath9k_hw]
[...]
> Reverting this, and the other patches depending on it, fixes the
> problem for me:
>
> e024111f6946f45cf1559a8c6fd48d2d0f696d07 Revert "ath9k: fix GPIO mask for AR9462 and AR9565"
> db2221901fbded787daed153281ed875de489692 Revert "ath9k: free GPIO resource for SOC GPIOs"
> c7212b7136ba69efb9785df68b669381cb893920 Revert "ath9k: fix BTCoex configuration for SOC chips"
> dfcf02cd2998e2240b2bc7b4f4412578b8070bdb Revert "ath9k: fix BTCoex access invalid registers for SOC chips"
> 668ae0a3e48ac6811f431915b466514bf167e2f4 Revert "ath9k: add bits definition of BTCoex MODE2/3 for SOC chips"
> c8770bcf5cefa8cbfae21c07c4fe3428f5a9d42a Revert "ath9k: Allow platform override BTCoex pin"
> 79d4db1214a0c7b1818aaf64d0606b17ff1acea7 Revert "ath9k: cleanup led_pin initial"
> b2d70d4944c1789bc64376ad97a811f37e230c87 Revert "ath9k: make GPIO API to support both of WMAC and SOC"
> a01ab81b09c55025365c1de1345b941a18e05529 Revert "ath9k: define correct GPIO numbers and bits mask"
>
> AR9285 (168c:002b) is fine either way.
Miaoqing, have you looked at this? Looks like another regression which
should be fixed.
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k: fix GPIO mask for AR9462 and AR9565
2016-08-03 13:54 ` Valo, Kalle
@ 2016-08-04 5:30 ` Pan, Miaoqing
2016-08-04 6:24 ` Stefan Lippers-Hollmann
0 siblings, 1 reply; 6+ messages in thread
From: Pan, Miaoqing @ 2016-08-04 5:30 UTC (permalink / raw)
To: Valo, Kalle, Stefan Lippers-Hollmann, miaoqing
Cc: linux-wireless, ath9k-devel, sudipm.mukherjee
[-- Attachment #1: Type: text/plain, Size: 2282 bytes --]
Sorry, try the patch. AR5416 will invoke ath9k_hw_gpio_get() before gpio initialized correctly.
Thanks,
Miaoqing
________________________________________
From: Valo, Kalle
Sent: Wednesday, August 3, 2016 9:54 PM
To: Stefan Lippers-Hollmann; miaoqing@codeaurora.org
Cc: linux-wireless@vger.kernel.org; ath9k-devel; sudipm.mukherjee@gmail.com
Subject: Re: [PATCH] ath9k: fix GPIO mask for AR9462 and AR9565
Stefan Lippers-Hollmann <s.l-h@gmx.de> writes:
> Hi
>
> On 2016-06-03, miaoqing@codeaurora.org wrote:
>> From: Miaoqing Pan <miaoqing@codeaurora.org>
>>
>> The incorrect GPIO mask cause kernel warning, when AR9462 access GPIO11.
>> Also fix the mask for AR9565.
> [...]
>
> I think I'm seeing a very similar issue on AR5008/ AR5416+AR2133 and
> 4.7-rc7 (mainline v4.7-rc7-92-g47ef4ad, to be exact).
>
> [ 4.958874] ath9k 0000:02:02.0: enabling device (0000 -> 0002)
> [...]
> [ 5.401086] ------------[ cut here ]------------
> [ 5.401093] WARNING: CPU: 1 PID: 1159 at /build/linux-aptosid-4.7~rc7/drivers/net/wireless/ath/ath9k/hw.c:2776 ath9k_hw_gpio_get+0x148/0x1a0 [ath9k_hw]
[...]
> Reverting this, and the other patches depending on it, fixes the
> problem for me:
>
> e024111f6946f45cf1559a8c6fd48d2d0f696d07 Revert "ath9k: fix GPIO mask for AR9462 and AR9565"
> db2221901fbded787daed153281ed875de489692 Revert "ath9k: free GPIO resource for SOC GPIOs"
> c7212b7136ba69efb9785df68b669381cb893920 Revert "ath9k: fix BTCoex configuration for SOC chips"
> dfcf02cd2998e2240b2bc7b4f4412578b8070bdb Revert "ath9k: fix BTCoex access invalid registers for SOC chips"
> 668ae0a3e48ac6811f431915b466514bf167e2f4 Revert "ath9k: add bits definition of BTCoex MODE2/3 for SOC chips"
> c8770bcf5cefa8cbfae21c07c4fe3428f5a9d42a Revert "ath9k: Allow platform override BTCoex pin"
> 79d4db1214a0c7b1818aaf64d0606b17ff1acea7 Revert "ath9k: cleanup led_pin initial"
> b2d70d4944c1789bc64376ad97a811f37e230c87 Revert "ath9k: make GPIO API to support both of WMAC and SOC"
> a01ab81b09c55025365c1de1345b941a18e05529 Revert "ath9k: define correct GPIO numbers and bits mask"
>
> AR9285 (168c:002b) is fine either way.
Miaoqing, have you looked at this? Looks like another regression which
should be fixed.
--
Kalle Valo
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ath9k-fix-accessing-gpio-warning.patch --]
[-- Type: text/x-diff; name="ath9k-fix-accessing-gpio-warning.patch", Size: 538 bytes --]
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -2482,6 +2482,8 @@ int ath9k_hw_fill_cap_info(struct ath_hw *ah)
return -EINVAL;
}
+ ath9k_gpio_cap_init(ah);
+
if (AR_SREV_9485(ah) ||
AR_SREV_9285(ah) ||
AR_SREV_9330(ah) ||
@@ -2531,8 +2533,6 @@ int ath9k_hw_fill_cap_info(struct ath_hw *ah)
else
pCap->hw_caps &= ~ATH9K_HW_CAP_HT;
- ath9k_gpio_cap_init(ah);
-
if (AR_SREV_9160_10_OR_LATER(ah) || AR_SREV_9100(ah))
pCap->rts_aggr_limit = ATH_AMPDU_LIMIT_MAX;
else
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k: fix GPIO mask for AR9462 and AR9565
2016-08-04 5:30 ` Pan, Miaoqing
@ 2016-08-04 6:24 ` Stefan Lippers-Hollmann
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Lippers-Hollmann @ 2016-08-04 6:24 UTC (permalink / raw)
To: Pan, Miaoqing
Cc: Valo, Kalle, miaoqing, linux-wireless, ath9k-devel, sudipm.mukherjee
Hi
On 2016-08-04, Pan, Miaoqing wrote:
> Sorry, try the patch. AR5416 will invoke ath9k_hw_gpio_get() before gpio initialized correctly.
>
> Thanks,
> Miaoqing
Thanks a lot, the patch appears to work. Feel free to add
Tested-by: Stefan Lippers-Hollmann <s.l-h@gmx.de>
and please also send it to stable-4.7 (confirmed working).
Cc: stable-4.7+ <stable@vger.kernel.org> #4.7+
Regards
Stefan Lippers-Hollmann
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-04 6:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-03 5:46 [PATCH] ath9k: fix GPIO mask for AR9462 and AR9565 miaoqing
2016-06-14 13:24 ` Kalle Valo
2016-07-17 21:05 ` [PATCH] " Stefan Lippers-Hollmann
2016-08-03 13:54 ` Valo, Kalle
2016-08-04 5:30 ` Pan, Miaoqing
2016-08-04 6:24 ` Stefan Lippers-Hollmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.