From: Stephen Boyd <stephen.boyd@linaro.org> To: Peter Chen <hzpeterchen@gmail.com> Cc: Felipe Balbi <balbi@kernel.org>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, Arnd Bergmann <arnd@arndb.de>, Neil Armstrong <narmstrong@baylibre.com>, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>, devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andy Gross <andy.gross@linaro.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 03/22] usb: ulpi: Support device discovery via device properties Date: Fri, 05 Aug 2016 14:27:35 -0700 [thread overview] Message-ID: <147043245520.26915.14153612182716236022@sboyd-linaro> (raw) In-Reply-To: <20160708090458.GB20485@shlinux2> Quoting Peter Chen (2016-07-08 02:04:58) > On Thu, Jul 07, 2016 at 03:20:54PM -0700, Stephen Boyd wrote: > > @@ -39,6 +42,10 @@ static int ulpi_match(struct device *dev, struct device_driver *driver) > > struct ulpi *ulpi = to_ulpi_dev(dev); > > const struct ulpi_device_id *id; > > > > + /* Some ULPI devices don't have a product id so rely on OF match */ > > + if (ulpi->id.product == 0) > > + return of_driver_match_device(dev, driver); > > + > > How about using vendor id? It can't be 0, but pid may be 0. > See: http://www.linux-usb.org/usb.ids Heikki suggested a product id of 0 would mean we need to use DT matching. Should it be changed to vendor id instead? > > > +static int ulpi_of_register(struct ulpi *ulpi) > > +{ > > + struct device_node *np = NULL, *child; > > + > > + /* Find a ulpi bus underneath the parent or the parent of the parent */ > > + if (ulpi->dev.parent->of_node) > > + np = of_find_node_by_name(ulpi->dev.parent->of_node, "ulpi"); > > + else if (ulpi->dev.parent->parent && ulpi->dev.parent->parent->of_node) > > + np = of_find_node_by_name(ulpi->dev.parent->parent->of_node, > > + "ulpi"); > > + if (!np) > > + return 0; > > + > > + child = of_get_next_available_child(np, NULL); > > + if (!child) > > + return -EINVAL; > > You may need to call of_node_put on parent (np), not on child node > below. Fixed, thanks. > > > + > > + ulpi->dev.of_node = child; > > + > > + return 0; > > +} > > + > > +static int ulpi_read_id(struct ulpi *ulpi) > > { > > int ret; > > > > @@ -174,14 +218,39 @@ static int ulpi_register(struct device *dev, struct ulpi *ulpi) > > ulpi->id.product = ulpi_read(ulpi, ULPI_PRODUCT_ID_LOW); > > ulpi->id.product |= ulpi_read(ulpi, ULPI_PRODUCT_ID_HIGH) << 8; > > > > + return 0; > > +} > > + > > What does this API for? Why it still needs to be called after > vid/pid gets from firmware? Ideally we get the vid/pid from the ULPI registers instead of from firmware. So we typically want to call ulpi_read_id() because most likely the ulpi-vendor and ulpi-product properties are missing.
WARNING: multiple messages have this Message-ID (diff)
From: stephen.boyd@linaro.org (Stephen Boyd) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 03/22] usb: ulpi: Support device discovery via device properties Date: Fri, 05 Aug 2016 14:27:35 -0700 [thread overview] Message-ID: <147043245520.26915.14153612182716236022@sboyd-linaro> (raw) In-Reply-To: <20160708090458.GB20485@shlinux2> Quoting Peter Chen (2016-07-08 02:04:58) > On Thu, Jul 07, 2016 at 03:20:54PM -0700, Stephen Boyd wrote: > > @@ -39,6 +42,10 @@ static int ulpi_match(struct device *dev, struct device_driver *driver) > > struct ulpi *ulpi = to_ulpi_dev(dev); > > const struct ulpi_device_id *id; > > > > + /* Some ULPI devices don't have a product id so rely on OF match */ > > + if (ulpi->id.product == 0) > > + return of_driver_match_device(dev, driver); > > + > > How about using vendor id? It can't be 0, but pid may be 0. > See: http://www.linux-usb.org/usb.ids Heikki suggested a product id of 0 would mean we need to use DT matching. Should it be changed to vendor id instead? > > > +static int ulpi_of_register(struct ulpi *ulpi) > > +{ > > + struct device_node *np = NULL, *child; > > + > > + /* Find a ulpi bus underneath the parent or the parent of the parent */ > > + if (ulpi->dev.parent->of_node) > > + np = of_find_node_by_name(ulpi->dev.parent->of_node, "ulpi"); > > + else if (ulpi->dev.parent->parent && ulpi->dev.parent->parent->of_node) > > + np = of_find_node_by_name(ulpi->dev.parent->parent->of_node, > > + "ulpi"); > > + if (!np) > > + return 0; > > + > > + child = of_get_next_available_child(np, NULL); > > + if (!child) > > + return -EINVAL; > > You may need to call of_node_put on parent (np), not on child node > below. Fixed, thanks. > > > + > > + ulpi->dev.of_node = child; > > + > > + return 0; > > +} > > + > > +static int ulpi_read_id(struct ulpi *ulpi) > > { > > int ret; > > > > @@ -174,14 +218,39 @@ static int ulpi_register(struct device *dev, struct ulpi *ulpi) > > ulpi->id.product = ulpi_read(ulpi, ULPI_PRODUCT_ID_LOW); > > ulpi->id.product |= ulpi_read(ulpi, ULPI_PRODUCT_ID_HIGH) << 8; > > > > + return 0; > > +} > > + > > What does this API for? Why it still needs to be called after > vid/pid gets from firmware? Ideally we get the vid/pid from the ULPI registers instead of from firmware. So we typically want to call ulpi_read_id() because most likely the ulpi-vendor and ulpi-product properties are missing.
next prev parent reply other threads:[~2016-08-05 21:27 UTC|newest] Thread overview: 165+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-07 22:20 [PATCH v2 00/22] Support qcom's HSIC USB and rewrite USB2 HS phy support Stephen Boyd 2016-07-07 22:20 ` Stephen Boyd 2016-07-07 22:20 ` [PATCH v2 02/22] of: device: Export of_device_{get_modalias,uvent_modalias} to modules Stephen Boyd 2016-07-07 22:20 ` [PATCH v2 02/22] of: device: Export of_device_{get_modalias, uvent_modalias} " Stephen Boyd 2016-07-07 22:20 ` [PATCH v2 04/22] usb: chipidea: Only read/write OTGSC from one place Stephen Boyd 2016-07-07 22:20 ` Stephen Boyd 2016-07-07 22:20 ` Stephen Boyd 2016-07-08 9:14 ` Peter Chen 2016-07-08 9:14 ` Peter Chen 2016-08-05 21:41 ` Stephen Boyd 2016-08-05 21:41 ` Stephen Boyd 2016-08-06 7:42 ` Peter Chen 2016-08-06 7:42 ` Peter Chen 2016-08-06 7:42 ` Peter Chen 2016-07-07 22:20 ` [PATCH v2 05/22] usb: chipidea: Handle extcon events properly Stephen Boyd 2016-07-07 22:20 ` Stephen Boyd 2016-07-07 22:20 ` Stephen Boyd 2016-07-07 22:20 ` [PATCH v2 06/22] usb: chipidea: Add platform flag for wrapper phy management Stephen Boyd 2016-07-07 22:20 ` Stephen Boyd 2016-07-07 22:20 ` Stephen Boyd 2016-07-08 9:25 ` Peter Chen 2016-07-08 9:25 ` Peter Chen 2016-08-05 21:46 ` Stephen Boyd 2016-08-05 21:46 ` Stephen Boyd 2016-08-06 7:59 ` Peter Chen 2016-08-06 7:59 ` Peter Chen 2016-08-06 7:59 ` Peter Chen 2016-08-08 23:46 ` Stephen Boyd 2016-08-08 23:46 ` Stephen Boyd 2016-08-09 0:36 ` Peter Chen 2016-08-09 0:36 ` Peter Chen 2016-08-09 0:36 ` Peter Chen 2016-07-07 22:20 ` [PATCH v2 07/22] usb: chipidea: Notify events when switching host mode Stephen Boyd 2016-07-07 22:20 ` Stephen Boyd 2016-07-07 22:20 ` Stephen Boyd 2016-07-08 9:29 ` Peter Chen 2016-07-08 9:29 ` Peter Chen 2016-07-08 9:29 ` Peter Chen 2016-07-07 22:20 ` [PATCH v2 08/22] usb: chipidea: Remove locking in ci_udc_start() Stephen Boyd 2016-07-07 22:20 ` Stephen Boyd 2016-07-07 22:20 ` Stephen Boyd [not found] ` <20160707222114.1673-9-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-07-08 9:45 ` Peter Chen 2016-07-08 9:45 ` Peter Chen 2016-07-08 9:45 ` Peter Chen 2016-08-05 21:53 ` Stephen Boyd 2016-08-05 21:53 ` Stephen Boyd 2016-08-06 7:54 ` Peter Chen 2016-08-06 7:54 ` Peter Chen 2016-08-06 7:54 ` Peter Chen 2016-08-08 23:47 ` Stephen Boyd 2016-08-08 23:47 ` Stephen Boyd 2016-08-09 0:42 ` Peter Chen 2016-08-09 0:42 ` Peter Chen 2016-08-09 0:42 ` Peter Chen 2016-07-07 22:21 ` [PATCH v2 09/22] usb: chipidea: Kick OTG state machine for AVVIS with vbus extcon Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd [not found] ` <20160707222114.1673-10-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-07-11 2:25 ` Peter Chen 2016-07-11 2:25 ` Peter Chen 2016-07-11 2:25 ` Peter Chen 2016-07-07 22:21 ` [PATCH v2 11/22] usb: chipidea: msm: Mark device as runtime pm active Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-11 3:19 ` Peter Chen 2016-07-11 3:19 ` Peter Chen [not found] ` <20160707222114.1673-1-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-07-07 22:20 ` [PATCH v2 01/22] of: device: Support loading a module with OF based modalias Stephen Boyd 2016-07-07 22:20 ` Stephen Boyd 2016-07-07 22:20 ` Stephen Boyd 2016-07-07 22:20 ` [PATCH v2 03/22] usb: ulpi: Support device discovery via device properties Stephen Boyd 2016-07-07 22:20 ` Stephen Boyd 2016-07-07 22:20 ` Stephen Boyd 2016-07-08 9:04 ` Peter Chen 2016-07-08 9:04 ` Peter Chen 2016-08-05 21:27 ` Stephen Boyd [this message] 2016-08-05 21:27 ` Stephen Boyd 2016-08-23 19:58 ` Stephen Boyd 2016-08-23 19:58 ` Stephen Boyd 2016-08-23 19:58 ` Stephen Boyd 2016-08-24 7:31 ` Heikki Krogerus 2016-08-24 7:31 ` Heikki Krogerus 2016-08-24 7:31 ` Heikki Krogerus 2016-08-26 18:54 ` Stephen Boyd 2016-08-26 18:54 ` Stephen Boyd [not found] ` <20160707222114.1673-4-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-07-18 2:23 ` Rob Herring 2016-07-18 2:23 ` Rob Herring 2016-07-18 2:23 ` Rob Herring 2016-08-05 21:40 ` Stephen Boyd 2016-08-05 21:40 ` Stephen Boyd 2016-08-23 20:00 ` Stephen Boyd 2016-08-23 20:00 ` Stephen Boyd 2016-08-23 20:00 ` Stephen Boyd [not found] ` <CAJOFmgwTPDwdL_cc7f5N09enZNhKwSkWAxdpF39vOBQLfEdVSg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-08-23 23:06 ` Rob Herring 2016-08-23 23:06 ` Rob Herring 2016-08-23 23:06 ` Rob Herring 2016-08-24 1:06 ` Stephen Boyd 2016-08-24 1:06 ` Stephen Boyd 2016-07-07 22:21 ` [PATCH v2 10/22] usb: chipidea: Add support for ULPI PHY bus Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-11 3:10 ` Peter Chen 2016-07-11 3:10 ` Peter Chen 2016-07-11 22:02 ` Stephen Boyd 2016-07-11 22:02 ` Stephen Boyd 2016-07-07 22:21 ` [PATCH v2 12/22] usb: chipidea: msm: Rely on core to override AHBBURST Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-11 3:24 ` Peter Chen 2016-07-11 3:24 ` Peter Chen 2016-07-07 22:21 ` [PATCH v2 13/22] usb: chipidea: msm: Use hw_write_id_reg() instead of writel Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-07 22:21 ` [PATCH v2 14/22] usb: chipidea: msm: Add proper clk and reset support Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-11 4:32 ` Peter Chen 2016-07-11 4:32 ` Peter Chen 2016-07-07 22:21 ` [PATCH v2 15/22] usb: chipidea: msm: Mux over secondary phy at the right time Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd [not found] ` <20160707222114.1673-16-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-07-11 4:43 ` Peter Chen 2016-07-11 4:43 ` Peter Chen 2016-07-11 4:43 ` Peter Chen 2016-07-11 22:03 ` Stephen Boyd 2016-07-11 22:03 ` Stephen Boyd 2016-07-11 22:03 ` Stephen Boyd 2016-07-12 1:07 ` Peter Chen 2016-07-12 1:07 ` Peter Chen 2016-07-07 22:21 ` [PATCH v2 16/22] usb: chipidea: msm: Restore wrapper settings after reset Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-11 5:24 ` Peter Chen 2016-07-11 5:24 ` Peter Chen 2016-07-07 22:21 ` [PATCH v2 17/22] usb: chipidea: msm: Make platform data driver local instead of global Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-11 5:26 ` Peter Chen 2016-07-11 5:26 ` Peter Chen 2016-07-07 22:21 ` [PATCH v2 19/22] usb: chipidea: msm: Handle phy power states Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-11 5:38 ` Peter Chen 2016-07-11 5:38 ` Peter Chen 2016-07-07 22:21 ` [PATCH v2 21/22] phy: Add support for Qualcomm's USB HSIC phy Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-18 2:27 ` Rob Herring 2016-07-18 2:27 ` Rob Herring 2016-07-07 22:21 ` [PATCH v2 22/22] phy: Add support for Qualcomm's USB HS phy Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd [not found] ` <20160707222114.1673-23-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-07-18 2:28 ` Rob Herring 2016-07-18 2:28 ` Rob Herring 2016-07-18 2:28 ` Rob Herring 2016-07-07 22:21 ` [PATCH v2 18/22] usb: chipidea: msm: Add reset controller for PHY POR bit Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd [not found] ` <20160707222114.1673-19-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-07-11 5:32 ` Peter Chen 2016-07-11 5:32 ` Peter Chen 2016-07-11 5:32 ` Peter Chen 2016-07-11 22:07 ` Stephen Boyd 2016-07-11 22:07 ` Stephen Boyd 2016-07-12 1:09 ` Peter Chen 2016-07-12 1:09 ` Peter Chen 2016-07-07 22:21 ` [PATCH v2 20/22] usb: chipidea: msm: Be silent on probe defer errors Stephen Boyd 2016-07-07 22:21 ` Stephen Boyd 2016-07-11 5:39 ` Peter Chen 2016-07-11 5:39 ` Peter Chen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=147043245520.26915.14153612182716236022@sboyd-linaro \ --to=stephen.boyd@linaro.org \ --cc=andy.gross@linaro.org \ --cc=arnd@arndb.de \ --cc=balbi@kernel.org \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=heikki.krogerus@linux.intel.com \ --cc=hzpeterchen@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=narmstrong@baylibre.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.