From: Lyude <cpaul@redhat.com> To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, xorg-driver-ati@lists.freedesktop.org Cc: Lyude <cpaul@redhat.com>, "Alex Deucher" <alexander.deucher@amd.com>, "Christian König" <christian.koenig@amd.com>, "David Airlie" <airlied@linux.ie>, "Ken Wang" <Qingqing.Wang@amd.com>, "Harry Wentland" <harry.wentland@amd.com>, linux-kernel@vger.kernel.org Subject: [PATCH 4/7] drm/amdgpu: Don't print error on aux transaction timeouts Date: Fri, 5 Aug 2016 20:30:36 -0400 [thread overview] Message-ID: <1470443443-27252-5-git-send-email-cpaul@redhat.com> (raw) In-Reply-To: <1470443443-27252-1-git-send-email-cpaul@redhat.com> Since it's normal for DRM to retry our aux transaction helpers multiple times in a row, up to 32 times for each attempted transaction, we're making a lot of noise that is no longer necessary now that DRM will just print the return code we give it. Signed-off-by: Lyude <cpaul@redhat.com> --- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_dp.c b/drivers/gpu/drm/amd/amdgpu/atombios_dp.c index 7f85c2c..166dc7b 100644 --- a/drivers/gpu/drm/amd/amdgpu/atombios_dp.c +++ b/drivers/gpu/drm/amd/amdgpu/atombios_dp.c @@ -88,7 +88,6 @@ static int amdgpu_atombios_dp_process_aux_ch(struct amdgpu_i2c_chan *chan, /* timeout */ if (args.v2.ucReplyStatus == 1) { - DRM_DEBUG_KMS("dp_aux_ch timeout\n"); r = -ETIMEDOUT; goto done; } -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Lyude <cpaul@redhat.com> To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, xorg-driver-ati@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, "Alex Deucher" <alexander.deucher@amd.com>, "Ken Wang" <Qingqing.Wang@amd.com>, Lyude <cpaul@redhat.com>, "Christian König" <christian.koenig@amd.com> Subject: [PATCH 4/7] drm/amdgpu: Don't print error on aux transaction timeouts Date: Fri, 5 Aug 2016 20:30:36 -0400 [thread overview] Message-ID: <1470443443-27252-5-git-send-email-cpaul@redhat.com> (raw) In-Reply-To: <1470443443-27252-1-git-send-email-cpaul@redhat.com> Since it's normal for DRM to retry our aux transaction helpers multiple times in a row, up to 32 times for each attempted transaction, we're making a lot of noise that is no longer necessary now that DRM will just print the return code we give it. Signed-off-by: Lyude <cpaul@redhat.com> --- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_dp.c b/drivers/gpu/drm/amd/amdgpu/atombios_dp.c index 7f85c2c..166dc7b 100644 --- a/drivers/gpu/drm/amd/amdgpu/atombios_dp.c +++ b/drivers/gpu/drm/amd/amdgpu/atombios_dp.c @@ -88,7 +88,6 @@ static int amdgpu_atombios_dp_process_aux_ch(struct amdgpu_i2c_chan *chan, /* timeout */ if (args.v2.ucReplyStatus == 1) { - DRM_DEBUG_KMS("dp_aux_ch timeout\n"); r = -ETIMEDOUT; goto done; } -- 2.7.4 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-08-06 20:26 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-06 0:30 [PATCH 0/7] Minor DP aux transaction fixes Lyude 2016-08-06 0:30 ` Lyude 2016-08-06 0:30 ` [PATCH 1/7] drm/dp_helper: Print first error received on failure in drm_dp_dpcd_access() Lyude 2016-08-06 0:30 ` Lyude 2016-08-06 0:30 ` [PATCH 2/7] drm/radeon: Don't print error on aux transaction timeouts Lyude 2016-08-06 0:30 ` Lyude 2016-08-06 0:30 ` [PATCH 3/7] drm/radeon: Don't retry 7 times in radeon_dp_dpcd() Lyude 2016-08-06 0:30 ` Lyude 2016-08-06 0:30 ` Lyude [this message] 2016-08-06 0:30 ` [PATCH 4/7] drm/amdgpu: Don't print error on aux transaction timeouts Lyude 2016-08-06 0:30 ` [PATCH 5/7] drm/amdgpu: Don't retry 7 times in amdgpu_atombios_dp_get_dpcd() Lyude 2016-08-06 0:30 ` Lyude 2016-08-06 0:30 ` [PATCH 6/7] drm: Add ratelimited versions of the DRM_DEBUG* macros Lyude 2016-08-06 0:30 ` Lyude 2016-08-06 20:32 ` Joe Perches 2016-08-06 20:32 ` Joe Perches 2016-08-06 0:30 ` [PATCH 7/7] drm/dp_helper: Rate limit timeout errors from drm_dp_i2c_do_msg() Lyude 2016-08-06 0:30 ` Lyude 2016-08-06 10:22 ` [PATCH 0/7] Minor DP aux transaction fixes Christian König 2016-08-06 10:22 ` Christian König 2016-08-08 17:30 ` Alex Deucher 2016-08-09 6:11 ` Daniel Vetter 2016-08-09 6:11 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1470443443-27252-5-git-send-email-cpaul@redhat.com \ --to=cpaul@redhat.com \ --cc=Qingqing.Wang@amd.com \ --cc=airlied@linux.ie \ --cc=alexander.deucher@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=christian.koenig@amd.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=harry.wentland@amd.com \ --cc=linux-kernel@vger.kernel.org \ --cc=xorg-driver-ati@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.