* [Buildroot] [PATCH v2 1/1] package/x11r7/xserver_xorg-server: needs dri/dri2/dri3 for libdrm support
@ 2016-08-07 16:04 Bernd Kuhls
2016-08-10 22:05 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Bernd Kuhls @ 2016-08-07 16:04 UTC (permalink / raw)
To: buildroot
Rework dependency handling as pointed out by Thomas:
http://lists.busybox.net/pipermail/buildroot/2016-July/168433.html
Fixes
http://autobuild.buildroot.net/results/2d3/2d38637e7904f3e382e41745a82ee1a1cf19ba71/
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
v2: simplified udev kms check (Peter)
package/x11r7/xserver_xorg-server/Config.in | 11 +++++++++--
package/x11r7/xserver_xorg-server/xserver_xorg-server.mk | 6 +++---
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/package/x11r7/xserver_xorg-server/Config.in b/package/x11r7/xserver_xorg-server/Config.in
index df3801c..5715a56 100644
--- a/package/x11r7/xserver_xorg-server/Config.in
+++ b/package/x11r7/xserver_xorg-server/Config.in
@@ -55,6 +55,10 @@ config BR2_PACKAGE_XSERVER_XORG_SERVER
if BR2_PACKAGE_XSERVER_XORG_SERVER
+config BR2_PACKAGE_XSERVER_XORG_SERVER_NEEDS_LIBDRM
+ bool
+ select BR2_PACKAGE_LIBDRM
+
config BR2_PACKAGE_XSERVER_XORG_SERVER_VIDEODRV_ABI_14
bool
@@ -103,10 +107,13 @@ choice
config BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR
bool "Modular X.org"
depends on BR2_INSTALL_LIBSTDCPP
- select BR2_PACKAGE_LIBDRM if (BR2_PACKAGE_XPROTO_XF86DRIPROTO || \
- BR2_PACKAGE_XPROTO_DRI2PROTO)
+ select BR2_PACKAGE_XSERVER_XORG_SERVER_NEEDS_LIBDRM if \
+ (BR2_PACKAGE_XPROTO_XF86DRIPROTO || \
+ BR2_PACKAGE_XPROTO_DRI2PROTO || \
+ BR2_PACKAGE_XPROTO_DRI3PROTO)
select BR2_PACKAGE_LIBPCIACCESS
select BR2_PACKAGE_XLIB_LIBXSHMFENCE if BR2_PACKAGE_XPROTO_DRI3PROTO
+
help
This variant of the X.org server is the full-blown variant,
as used by desktop GNU/Linux distributions. The drivers (for
diff --git a/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk b/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
index 85d7e98..751be94 100644
--- a/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
+++ b/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
@@ -97,7 +97,7 @@ endif
ifeq ($(BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR),y)
XSERVER_XORG_SERVER_CONF_OPTS += --enable-xorg
XSERVER_XORG_SERVER_DEPENDENCIES += libpciaccess
-ifeq ($(BR2_PACKAGE_LIBDRM),y)
+ifeq ($(BR2_PACKAGE_XSERVER_XORG_SERVER_NEEDS_LIBDRM),y)
XSERVER_XORG_SERVER_DEPENDENCIES += libdrm
XSERVER_XORG_SERVER_CONF_OPTS += --enable-libdrm
else
@@ -163,8 +163,8 @@ endif
ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
XSERVER_XORG_SERVER_DEPENDENCIES += udev
XSERVER_XORG_SERVER_CONF_OPTS += --enable-config-udev
-# udev kms support depends on libdrm and dri2
-ifeq ($(BR2_PACKAGE_LIBDRM)$(BR2_PACKAGE_XPROTO_DRI2PROTO),yy)
+# udev kms support depends on dri2
+ifeq ($(BR2_PACKAGE_XPROTO_DRI2PROTO),y)
XSERVER_XORG_SERVER_CONF_OPTS += --enable-config-udev-kms
else
XSERVER_XORG_SERVER_CONF_OPTS += --disable-config-udev-kms
--
2.8.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/x11r7/xserver_xorg-server: needs dri/dri2/dri3 for libdrm support
2016-08-07 16:04 [Buildroot] [PATCH v2 1/1] package/x11r7/xserver_xorg-server: needs dri/dri2/dri3 for libdrm support Bernd Kuhls
@ 2016-08-10 22:05 ` Thomas Petazzoni
2016-08-12 16:45 ` Bernd Kuhls
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2016-08-10 22:05 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 7 Aug 2016 18:04:34 +0200, Bernd Kuhls wrote:
> Rework dependency handling as pointed out by Thomas:
> http://lists.busybox.net/pipermail/buildroot/2016-July/168433.html
>
> Fixes
> http://autobuild.buildroot.net/results/2d3/2d38637e7904f3e382e41745a82ee1a1cf19ba71/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Could you verify if this issue still exists? Indeed, since the bump
from 1.18.3 to 1.18.4 of the X.org server, we were missing one patch.
See my commit:
https://git.buildroot.org/buildroot/commit/?id=3686101a2ae9ec37b4d34a368db03c325f7f92e3
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/x11r7/xserver_xorg-server: needs dri/dri2/dri3 for libdrm support
2016-08-10 22:05 ` Thomas Petazzoni
@ 2016-08-12 16:45 ` Bernd Kuhls
2016-10-25 10:46 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Bernd Kuhls @ 2016-08-12 16:45 UTC (permalink / raw)
To: buildroot
Am Thu, 11 Aug 2016 00:05:12 +0200 schrieb Thomas Petazzoni:
> Hello,
>
> On Sun, 7 Aug 2016 18:04:34 +0200, Bernd Kuhls wrote:
>> Rework dependency handling as pointed out by Thomas:
>> http://lists.busybox.net/pipermail/buildroot/2016-July/168433.html
>>
>> Fixes
>> http://autobuild.buildroot.net/results/2d3/2d38637e7904f3e382e41745a82ee1a1cf19ba71/
>>
>> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
>
> Could you verify if this issue still exists? Indeed, since the bump
> from 1.18.3 to 1.18.4 of the X.org server, we were missing one patch.
Hi Thomas,
re-adding the missing patch solved the problem, I could not
reproduce the build error anymore.
Regards, Bernd
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/x11r7/xserver_xorg-server: needs dri/dri2/dri3 for libdrm support
2016-08-12 16:45 ` Bernd Kuhls
@ 2016-10-25 10:46 ` Thomas Petazzoni
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2016-10-25 10:46 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 12 Aug 2016 18:45:49 +0200, Bernd Kuhls wrote:
> re-adding the missing patch solved the problem, I could not
> reproduce the build error anymore.
OK, so I've marked your patch as Rejected in patchwork.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-25 10:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-07 16:04 [Buildroot] [PATCH v2 1/1] package/x11r7/xserver_xorg-server: needs dri/dri2/dri3 for libdrm support Bernd Kuhls
2016-08-10 22:05 ` Thomas Petazzoni
2016-08-12 16:45 ` Bernd Kuhls
2016-10-25 10:46 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.