From: Wolfram Sang <wsa-dev@sang-engineering.com> To: linux-usb@vger.kernel.org Cc: Wolfram Sang <wsa-dev@sang-engineering.com>, Larry Finger <Larry.Finger@lwfinger.net>, Chaoming Li <chaoming_li@realsil.com.cn>, Kalle Valo <kvalo@codeaurora.org>, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 16/16] net: wireless: realtek: rtlwifi: usb: don't print error when allocating urb fails Date: Thu, 11 Aug 2016 23:13:08 +0200 [thread overview] Message-ID: <1470949988-25705-4-git-send-email-wsa-dev@sang-engineering.com> (raw) In-Reply-To: <1470949988-25705-1-git-send-email-wsa-dev@sang-engineering.com> kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com> --- drivers/net/wireless/realtek/rtlwifi/usb.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.c b/drivers/net/wireless/realtek/rtlwifi/usb.c index 41617b7b082260..32aa5c1d070a07 100644 --- a/drivers/net/wireless/realtek/rtlwifi/usb.c +++ b/drivers/net/wireless/realtek/rtlwifi/usb.c @@ -739,11 +739,8 @@ static int _rtl_usb_receive(struct ieee80211_hw *hw) for (i = 0; i < rtlusb->rx_urb_num; i++) { err = -ENOMEM; urb = usb_alloc_urb(0, GFP_KERNEL); - if (!urb) { - RT_TRACE(rtlpriv, COMP_USB, DBG_EMERG, - "Failed to alloc URB!!\n"); + if (!urb) goto err_out; - } err = _rtl_prep_rx_urb(hw, rtlusb, urb, GFP_KERNEL); if (err < 0) { @@ -907,15 +904,12 @@ static void _rtl_tx_complete(struct urb *urb) static struct urb *_rtl_usb_tx_urb_setup(struct ieee80211_hw *hw, struct sk_buff *skb, u32 ep_num) { - struct rtl_priv *rtlpriv = rtl_priv(hw); struct rtl_usb *rtlusb = rtl_usbdev(rtl_usbpriv(hw)); struct urb *_urb; WARN_ON(NULL == skb); _urb = usb_alloc_urb(0, GFP_ATOMIC); if (!_urb) { - RT_TRACE(rtlpriv, COMP_USB, DBG_EMERG, - "Can't allocate URB for bulk out!\n"); kfree_skb(skb); return NULL; } -- 2.8.1
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> To: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Wolfram Sang <wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>, Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>, Chaoming Li <chaoming_li-kXabqFNEczNtrwSWzY7KCg@public.gmane.org>, Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: [PATCH 16/16] net: wireless: realtek: rtlwifi: usb: don't print error when allocating urb fails Date: Thu, 11 Aug 2016 23:13:08 +0200 [thread overview] Message-ID: <1470949988-25705-4-git-send-email-wsa-dev@sang-engineering.com> (raw) In-Reply-To: <1470949988-25705-1-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang <wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> --- drivers/net/wireless/realtek/rtlwifi/usb.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.c b/drivers/net/wireless/realtek/rtlwifi/usb.c index 41617b7b082260..32aa5c1d070a07 100644 --- a/drivers/net/wireless/realtek/rtlwifi/usb.c +++ b/drivers/net/wireless/realtek/rtlwifi/usb.c @@ -739,11 +739,8 @@ static int _rtl_usb_receive(struct ieee80211_hw *hw) for (i = 0; i < rtlusb->rx_urb_num; i++) { err = -ENOMEM; urb = usb_alloc_urb(0, GFP_KERNEL); - if (!urb) { - RT_TRACE(rtlpriv, COMP_USB, DBG_EMERG, - "Failed to alloc URB!!\n"); + if (!urb) goto err_out; - } err = _rtl_prep_rx_urb(hw, rtlusb, urb, GFP_KERNEL); if (err < 0) { @@ -907,15 +904,12 @@ static void _rtl_tx_complete(struct urb *urb) static struct urb *_rtl_usb_tx_urb_setup(struct ieee80211_hw *hw, struct sk_buff *skb, u32 ep_num) { - struct rtl_priv *rtlpriv = rtl_priv(hw); struct rtl_usb *rtlusb = rtl_usbdev(rtl_usbpriv(hw)); struct urb *_urb; WARN_ON(NULL == skb); _urb = usb_alloc_urb(0, GFP_ATOMIC); if (!_urb) { - RT_TRACE(rtlpriv, COMP_USB, DBG_EMERG, - "Can't allocate URB for bulk out!\n"); kfree_skb(skb); return NULL; } -- 2.8.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-08-11 21:13 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-11 21:05 [PATCH 00/16] net: don't print error when allocating urb fails Wolfram Sang 2016-08-11 21:05 ` Wolfram Sang [not found] ` <1470949539-25392-1-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> 2016-08-11 21:05 ` [PATCH 01/16] net: can: usb: ems_usb: " Wolfram Sang 2016-08-11 21:05 ` [PATCH 02/16] net: can: usb: esd_usb2: " Wolfram Sang 2016-08-11 21:05 ` [PATCH 03/16] net: can: usb: gs_usb: " Wolfram Sang 2016-08-11 21:05 ` [PATCH 04/16] net: can: usb: kvaser_usb: " Wolfram Sang 2016-08-11 21:05 ` [PATCH 05/16] net: can: usb: peak_usb: pcan_usb_core: " Wolfram Sang 2016-08-11 21:05 ` [PATCH 06/16] net: can: usb: usb_8dev: " Wolfram Sang 2016-08-11 21:05 ` [PATCH 07/16] net: usb: hso: " Wolfram Sang 2016-08-11 21:05 ` [PATCH 08/16] net: usb: lan78xx: " Wolfram Sang [not found] ` <1470949539-25392-9-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> 2016-08-11 21:42 ` Woojung.Huh-UWL1GkI3JZL3oGB3hsPCZA 2016-08-11 21:05 ` [PATCH 09/16] net: usb: usbnet: " Wolfram Sang 2016-08-11 21:05 ` [PATCH 10/16] net: wimax: i2400m: usb-notif: " Wolfram Sang 2016-08-11 21:05 ` [PATCH 11/16] net: wireless: ath: ar5523: ar5523: " Wolfram Sang 2016-08-11 21:05 ` Wolfram Sang 2016-08-11 21:05 ` [PATCH 12/16] net: wireless: broadcom: brcm80211: brcmfmac: usb: " Wolfram Sang 2016-08-11 21:05 ` Wolfram Sang 2016-08-11 21:13 ` [PATCH 13/16] net: wireless: intersil: orinoco: orinoco_usb: " Wolfram Sang 2016-08-11 21:13 ` [PATCH 14/16] net: wireless: marvell: libertas_tf: if_usb: " Wolfram Sang 2016-08-11 21:13 ` [PATCH 15/16] net: wireless: marvell: mwifiex: usb: " Wolfram Sang 2016-08-11 21:13 ` Wolfram Sang [this message] 2016-08-11 21:13 ` [PATCH 16/16] net: wireless: realtek: rtlwifi: " Wolfram Sang 2016-08-11 21:35 ` Larry Finger 2016-08-13 21:55 ` [PATCH 00/16] net: " David Miller 2016-08-13 21:55 ` David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1470949988-25705-4-git-send-email-wsa-dev@sang-engineering.com \ --to=wsa-dev@sang-engineering.com \ --cc=Larry.Finger@lwfinger.net \ --cc=chaoming_li@realsil.com.cn \ --cc=kvalo@codeaurora.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.