* [PATCH 0/6] staging: don't print error when allocating urb fails
@ 2016-08-11 21:23 Wolfram Sang
2016-08-11 21:23 ` [PATCH 2/6] staging: media: lirc: lirc_imon: " Wolfram Sang
2016-08-11 21:23 ` [PATCH 3/6] staging: media: lirc: lirc_sasem: " Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:23 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, devel, linux-media
This per-subsystem series is part of a tree wide cleanup. usb_alloc_urb() uses
kmalloc which already prints enough information on failure. So, let's simply
remove those "allocation failed" messages from drivers like we did already for
other -ENOMEM cases. gkh acked this approach when we talked about it at LCJ in
Tokyo a few weeks ago.
Wolfram Sang (6):
staging: comedi: drivers: usbduxfast: don't print error when
allocating urb fails
staging: media: lirc: lirc_imon: don't print error when allocating urb
fails
staging: media: lirc: lirc_sasem: don't print error when allocating
urb fails
staging: most: hdm-usb: hdm_usb: don't print error when allocating urb
fails
staging: rtl8192u: r8192U_core: don't print error when allocating urb
fails
staging: vt6656: main_usb: don't print error when allocating urb fails
drivers/staging/comedi/drivers/usbduxfast.c | 4 +---
drivers/staging/media/lirc/lirc_imon.c | 9 ++-------
drivers/staging/media/lirc/lirc_sasem.c | 5 -----
drivers/staging/most/hdm-usb/hdm_usb.c | 4 +---
drivers/staging/rtl8192u/r8192U_core.c | 5 +----
drivers/staging/vt6656/main_usb.c | 12 +++---------
6 files changed, 8 insertions(+), 31 deletions(-)
--
2.8.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/6] staging: media: lirc: lirc_imon: don't print error when allocating urb fails
2016-08-11 21:23 [PATCH 0/6] staging: don't print error when allocating urb fails Wolfram Sang
@ 2016-08-11 21:23 ` Wolfram Sang
2016-08-11 21:23 ` [PATCH 3/6] staging: media: lirc: lirc_sasem: " Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:23 UTC (permalink / raw)
To: linux-usb
Cc: Wolfram Sang, Jarod Wilson, Mauro Carvalho Chehab,
Greg Kroah-Hartman, linux-media, devel
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/staging/media/lirc/lirc_imon.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c
index ff1926ca1f96f5..a183e68ec32089 100644
--- a/drivers/staging/media/lirc/lirc_imon.c
+++ b/drivers/staging/media/lirc/lirc_imon.c
@@ -797,16 +797,11 @@ static int imon_probe(struct usb_interface *interface,
goto free_rbuf;
}
rx_urb = usb_alloc_urb(0, GFP_KERNEL);
- if (!rx_urb) {
- dev_err(dev, "%s: usb_alloc_urb failed for IR urb\n", __func__);
+ if (!rx_urb)
goto free_lirc_buf;
- }
tx_urb = usb_alloc_urb(0, GFP_KERNEL);
- if (!tx_urb) {
- dev_err(dev, "%s: usb_alloc_urb failed for display urb\n",
- __func__);
+ if (!tx_urb)
goto free_rx_urb;
- }
mutex_init(&context->ctx_lock);
context->vfd_proto_6p = vfd_proto_6p;
--
2.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 3/6] staging: media: lirc: lirc_sasem: don't print error when allocating urb fails
2016-08-11 21:23 [PATCH 0/6] staging: don't print error when allocating urb fails Wolfram Sang
2016-08-11 21:23 ` [PATCH 2/6] staging: media: lirc: lirc_imon: " Wolfram Sang
@ 2016-08-11 21:23 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:23 UTC (permalink / raw)
To: linux-usb
Cc: Wolfram Sang, Jarod Wilson, Mauro Carvalho Chehab,
Greg Kroah-Hartman, linux-media, devel
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/staging/media/lirc/lirc_sasem.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c
index 2218d0042030ed..b080fde6d740c9 100644
--- a/drivers/staging/media/lirc/lirc_sasem.c
+++ b/drivers/staging/media/lirc/lirc_sasem.c
@@ -758,17 +758,12 @@ static int sasem_probe(struct usb_interface *interface,
}
rx_urb = usb_alloc_urb(0, GFP_KERNEL);
if (!rx_urb) {
- dev_err(&interface->dev,
- "%s: usb_alloc_urb failed for IR urb\n", __func__);
alloc_status = 5;
goto alloc_status_switch;
}
if (vfd_ep_found) {
tx_urb = usb_alloc_urb(0, GFP_KERNEL);
if (!tx_urb) {
- dev_err(&interface->dev,
- "%s: usb_alloc_urb failed for VFD urb",
- __func__);
alloc_status = 6;
goto alloc_status_switch;
}
--
2.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-11 21:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-11 21:23 [PATCH 0/6] staging: don't print error when allocating urb fails Wolfram Sang
2016-08-11 21:23 ` [PATCH 2/6] staging: media: lirc: lirc_imon: " Wolfram Sang
2016-08-11 21:23 ` [PATCH 3/6] staging: media: lirc: lirc_sasem: " Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.