From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [RFC PATCH] meminfo: Break apart a very long seq_printf with #ifdefs
Date: Thu, 11 Aug 2016 14:57:53 -0700 [thread overview]
Message-ID: <1470952673.14552.32.camel@perches.com> (raw)
In-Reply-To: <20160811145012.3285b5bd289a8d2155ae78a3@linux-foundation.org>
On Thu, 2016-08-11 at 14:50 -0700, Andrew Morton wrote:
> On Tue, 9 Aug 2016 23:38:56 -0700 Joe Perches <joe@perches.com> wrote:
> > Use a specific routine to emit most lines so that the code is
> > easier to read and maintain.
> huh.
>
> text data bss dec hex filename
> 2976 8 0 2984 ba8 fs/proc/meminfo.o before
> 2669 8 0 2677 a75 fs/proc/meminfo.o after
>
> Nice. I wonder why that happened.
Fewer shifts via removal of K macro.
Much smaller call stack in seq_printf.
prev parent reply other threads:[~2016-08-11 21:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-06 12:56 [PATCH] proc: faster /proc/*/status Alexey Dobriyan
2016-08-06 22:41 ` Joe Perches
2016-08-09 3:02 ` [PATCH] seq/proc: Modify seq_put_decimal_[u]ll to take a const char *, not char Joe Perches
2016-08-07 3:16 ` [PATCH] proc: faster /proc/*/status Andi Kleen
2016-08-07 8:53 ` Alexey Dobriyan
2016-08-07 16:59 ` Andi Kleen
2016-08-07 17:39 ` Joe Perches
2016-08-07 17:44 ` Andi Kleen
2016-08-07 21:22 ` Joe Perches
2016-08-09 23:25 ` Andrew Morton
2016-08-10 6:38 ` [RFC PATCH] meminfo: Break apart a very long seq_printf with #ifdefs Joe Perches
2016-08-11 21:50 ` Andrew Morton
2016-08-11 21:57 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470952673.14552.32.camel@perches.com \
--to=joe@perches.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.