[PATCH 0/4] Clarify License information : m4, stubdom, tools/blktap2, xen/crypto

[PATCH 0/4] Clarify License information : m4, stubdom, tools/blktap2, xen/crypto

[Lars Kurth]

This series contains some of the easier license clean-up cases, which can be fixed
by adding COPYING files or README.source files. The series specially contains:

xen/crypto and xen/include/crypto
Added a README.source file
Does not need a COPYING file: all files are imported 

m4
Updated README.source to include ax_compare_version.m4
Does not need a COPYING file: all files are GPLv2  
Exceptions are exclusively from imported files: GPLv2+ 
and Laurikari (https://enterprise.dejacode.com/license_library/Demo/laurikari/)

stubdom
Added a COPYING file as a boilerplate to explain license oddities in this directory
Added a vtpm/COPYING file which contains MIT licensed files only
Added a vtpmmgr/README.source file which contains many BSD-3-Clause files only,
that originally came from tools/vtpm_manager

tools/blktap2
Added a COPYING file 
There is some complexity here, but I believe it is not necessary to fix this at this
stage, as for some time we were discussing to remove blktap2.

-- 
2.5.4 (Apple Git-61)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 1/4] Add information on sources for vmac.* and rijndael.*

[Lars Kurth]

I added these, as I came across the sources during
a license scan.

Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
---
 xen/crypto/README.source         | 17 +++++++++++++++++
 xen/include/crypto/README.source | 17 +++++++++++++++++
 2 files changed, 34 insertions(+)
 create mode 100644 xen/crypto/README.source
 create mode 100644 xen/include/crypto/README.source

diff --git a/xen/crypto/README.source b/xen/crypto/README.source
new file mode 100644
index 0000000..894045d
--- /dev/null
+++ b/xen/crypto/README.source
@@ -0,0 +1,17 @@
+About
+=====
+This documents the upstream sources for files in this directory.
+
+rijndael.c
+==========
+This file comes from 
+http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/crypto/
+
+vmac.c
+======
+This file was developed by Ted Krovetz and Wei Dai (more details 
+are in the files). 
+
+See
+- https://en.wikipedia.org/wiki/VMAC
+- http://www.fastcrypto.org/vmac/vmac.c
diff --git a/xen/include/crypto/README.source b/xen/include/crypto/README.source
new file mode 100644
index 0000000..68de1cd
--- /dev/null
+++ b/xen/include/crypto/README.source
@@ -0,0 +1,17 @@
+About
+=====
+This documents the upstream sources for files in this directory.
+
+rijndael.h
+==========
+This file comes from 
+http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/crypto/
+
+vmac.h
+======
+This file was developed by Ted Krovetz and Wei Dai (more details 
+are in the files). 
+
+See
+- https://en.wikipedia.org/wiki/VMAC
+- http://www.fastcrypto.org/vmac/vmac.h
-- 
2.5.4 (Apple Git-61)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 2/4] Added source of ax_compare_version.m4 to import log

[Lars Kurth]

In addition:
- fixed a reference, which was incorrect

Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
---
 m4/README.source | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/m4/README.source b/m4/README.source
index 21850a6..be7bc5a 100644
--- a/m4/README.source
+++ b/m4/README.source
@@ -3,6 +3,13 @@ About
 This documents the upstream sources for the different slew of different
 m4 sources we have picked up or developed.
 
+ax_compare_version.m4
+=====================
+This file was fetched from 
+http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_compare_version.m4
+
+Also see http://www.gnu.org/software/autoconf-archive/ax_compare_version.html
+
 pkg.m4
 ======
 The pkg-config m4 macro library comes from the upstream pkg-config
@@ -13,7 +20,7 @@ on how to use this read the pkg-config(1) man page.
 Do not modify this file yourself, if you want to evolve it send
 patches upstream and then synch back here.
 
-Tree: git://anongit.freedesktop.org/pkg-config
+[0]: git://anongit.freedesktop.org/pkg-config
 
 The last synch was from commit:
 
-- 
2.5.4 (Apple Git-61)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 3/4] [STUBDOM] Added COPYING files and README.source files

[Lars Kurth]

Added a COPYING file as a boilerplate to explain license oddities in
this directory

Added a vtpm/COPYING file which contains MIT licensed files only

Added a vtpmmgr/README.source file which contains many BSD-3-Clause
files that originally came from tools/vtpm_manager

Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
---
 stubdom/COPYING               | 31 +++++++++++++++++++++++++++++++
 stubdom/vtpm/COPYING          | 26 ++++++++++++++++++++++++++
 stubdom/vtpmmgr/README.source | 23 +++++++++++++++++++++++
 3 files changed, 80 insertions(+)
 create mode 100644 stubdom/COPYING
 create mode 100644 stubdom/vtpm/COPYING
 create mode 100644 stubdom/vtpmmgr/README.source

diff --git a/stubdom/COPYING b/stubdom/COPYING
new file mode 100644
index 0000000..a5071b3
--- /dev/null
+++ b/stubdom/COPYING
@@ -0,0 +1,31 @@
+Most files in this directory are covered by version 2 of the 
+GNU General Public License except where explicitly stated.
+See the main COPYING file in xen.git for more information.
+
+Notable exceptions are in the following directories
+
+vtpm
+==== 
+Exclusively contains code licensed under a MIT license
+Also see vtpm/COPYING
+
+vtpmmgr
+=======
+Contains a significant portion of files which are licensed
+under a BSD-3-Clause license. These files were imported from
+elsewhere and are copyrighted as follows:
+
+Copyright (c) 2005, Intel Corp.
+All rights reserved.
+
+See README.source for a complete list of files
+
+Otherwise, this directory contains several files licensed under
+GPLv2+, or without copyright headers. 
+
+*.patch and *.diff files
+========================
+This directory contains a number of *.patch and *.diff files. 
+These files describe changes to source files and are thus 
+licensed under the license from which the *.patch and *.diff
+were generated.
diff --git a/stubdom/vtpm/COPYING b/stubdom/vtpm/COPYING
new file mode 100644
index 0000000..80780b8
--- /dev/null
+++ b/stubdom/vtpm/COPYING
@@ -0,0 +1,26 @@
+This copyright applies to all files within this subdirectory and its
+subdirectories, unless explicitly stated otherwise within individual 
+source files.
+
+All other files in the Xen source distribution are covered by version
+2 of the GNU General Public License except where explicitly stated.
+See the main COPYING file in xen.git for more information.
+
+=====================================================================
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to
+deal in the Software without restriction, including without limitation the
+rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+sell copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THIS SOFTWARE AND ITS DOCUMENTATION ARE PROVIDED AS IS AND WITHOUT
+ANY EXPRESS OR IMPLIED WARRANTIES WHATSOEVER. ALL WARRANTIES
+INCLUDING, BUT NOT LIMITED TO, PERFORMANCE, MERCHANTABILITY, FITNESS
+FOR A PARTICULAR  PURPOSE, AND NONINFRINGEMENT ARE HEREBY
+DISCLAIMED. USERS ASSUME THE ENTIRE RISK AND LIABILITY OF USING THE
+SOFTWARE.
\ No newline at end of file
diff --git a/stubdom/vtpmmgr/README.source b/stubdom/vtpmmgr/README.source
new file mode 100644
index 0000000..1b45997
--- /dev/null
+++ b/stubdom/vtpmmgr/README.source
@@ -0,0 +1,23 @@
+About
+=====
+This documents the upstream sources for files in this directory.
+
+The following files are based off of the original 
+tools/vtpm_manager code base in xen.git, which has since been 
+deleted: 
+
+init.c
+log.c
+log.h
+marshal.h
+tcg.h
+tpm.c
+tpm.h
+tpm2.c
+tpm2.h
+tpm2_marshal.h
+uuid.h
+vtpm_cmd_handler.c
+vtpm_manager.h
+vtpmmgr.c
+vtpmmgr.h
\ No newline at end of file
-- 
2.5.4 (Apple Git-61)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 4/4] blktap2: Added COPYING file

[Lars Kurth]

Blktap2 has some complexity, as some files do not have (c) headers
and the directory did not have a COPYING file. At this stage, we
have not verified the intention of (c) holders. We may do this in
future, if the need arises.

Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
---
 tools/blktap2/COPYING | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 72 insertions(+)
 create mode 100644 tools/blktap2/COPYING

diff --git a/tools/blktap2/COPYING b/tools/blktap2/COPYING
new file mode 100644
index 0000000..f3d7a10
--- /dev/null
+++ b/tools/blktap2/COPYING
@@ -0,0 +1,72 @@
+Most files in this directory are covered by a BSD-3-Clause
+license as stated in the text below, unless explicitly otherwise 
+stated.
+
+New contributions to existing files in this directory are 
+governed by the license that applies to the relevant specific 
+file. New contributions to the files listed in [1] are to be
+taken under a BSD-3-Clause license. We believe that most 
+(if not all) of the existing copyright holders intended 
+to make their contribution under BSD-3 even for the files 
+with no copyright headers. But this has not been verified.
+
+New files are to be taken under BSD-3-Clause, unless otherwise
+explicitly stated in the copyright header.
+
+If you want to deal in this code you may do so under GPLv2, 
+at least.
+
+Files without (c) headers
+=========================
+The following source files did not have a (c) notice at the 
+time this COPYING notice was added to the source tree:
+
+[1]
+./drivers/aes.h
+./drivers/blk_linux.c
+./drivers/blk_netbsd.c
+./drivers/block-remus.c
+./drivers/bswap.h
+./drivers/check_gcrypt
+./drivers/md5.h
+./drivers/xmsnap
+./include/list.h
+
+QCOW files 
+==========
+The following files are dually licensed under an MIT and GPLv2
+license
+
+[2]
+./drivers/img2qcow.c
+./drivers/qcow2raw.c
+./drivers/qcow-create.c
+
+=====================================================================
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions 
+are met:
+
+1. Redistributions of source code must retain the above copyright
+   notice, this list of conditions and the following disclaimer.
+
+2. Redistributions in binary form must reproduce the above copyright
+   notice, this list of conditions and the following disclaimer in the
+   documentation and/or other materials provided with the distribution.
+
+3. Neither the name of the copyright holder Inc. nor the names of its 
+   contributors may be used to endorse or promote products derived 
+   from this software without specific prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 
+OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 
+SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 
+LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 
+DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 
+THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 
+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 
+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-- 
2.5.4 (Apple Git-61)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 0/4] Clarify License information : m4, stubdom, tools/blktap2, xen/crypto

[Wei Liu]

Cc Ian's correct email address

On Fri, Aug 12, 2016 at 06:32:32PM +0100, Lars Kurth wrote:
> This series contains some of the easier license clean-up cases, which can be fixed
> by adding COPYING files or README.source files. The series specially contains:
> 
> xen/crypto and xen/include/crypto
> Added a README.source file
> Does not need a COPYING file: all files are imported 
> 
> m4
> Updated README.source to include ax_compare_version.m4
> Does not need a COPYING file: all files are GPLv2  
> Exceptions are exclusively from imported files: GPLv2+ 
> and Laurikari (https://enterprise.dejacode.com/license_library/Demo/laurikari/)
> 
> stubdom
> Added a COPYING file as a boilerplate to explain license oddities in this directory
> Added a vtpm/COPYING file which contains MIT licensed files only
> Added a vtpmmgr/README.source file which contains many BSD-3-Clause files only,
> that originally came from tools/vtpm_manager
> 
> tools/blktap2
> Added a COPYING file 
> There is some complexity here, but I believe it is not necessary to fix this at this
> stage, as for some time we were discussing to remove blktap2.
> 
> -- 
> 2.5.4 (Apple Git-61)
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 2/4] Added source of ax_compare_version.m4 to import log

[Wei Liu]

On Fri, Aug 12, 2016 at 06:32:34PM +0100, Lars Kurth wrote:
> In addition:
> - fixed a reference, which was incorrect
> 
> Signed-off-by: Lars Kurth <lars.kurth@citrix.com>

Reviewed-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 4/4] blktap2: Added COPYING file

[Wei Liu]

On Fri, Aug 12, 2016 at 06:32:36PM +0100, Lars Kurth wrote:
> Blktap2 has some complexity, as some files do not have (c) headers
> and the directory did not have a COPYING file. At this stage, we
> have not verified the intention of (c) holders. We may do this in
> future, if the need arises.
> 
> Signed-off-by: Lars Kurth <lars.kurth@citrix.com>

I think this is going to be dropped since I'm going to remove blktap2
altogether.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 3/4] [STUBDOM] Added COPYING files and README.source files

[Wei Liu]

On Fri, Aug 12, 2016 at 06:32:35PM +0100, Lars Kurth wrote:
> Added a COPYING file as a boilerplate to explain license oddities in
> this directory
> 
> Added a vtpm/COPYING file which contains MIT licensed files only
> 
> Added a vtpmmgr/README.source file which contains many BSD-3-Clause
> files that originally came from tools/vtpm_manager
> 
> Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
> ---
>  stubdom/COPYING               | 31 +++++++++++++++++++++++++++++++
>  stubdom/vtpm/COPYING          | 26 ++++++++++++++++++++++++++
>  stubdom/vtpmmgr/README.source | 23 +++++++++++++++++++++++
>  3 files changed, 80 insertions(+)
>  create mode 100644 stubdom/COPYING
>  create mode 100644 stubdom/vtpm/COPYING
>  create mode 100644 stubdom/vtpmmgr/README.source
> 
> diff --git a/stubdom/COPYING b/stubdom/COPYING
> new file mode 100644
> index 0000000..a5071b3
> --- /dev/null
> +++ b/stubdom/COPYING
> @@ -0,0 +1,31 @@
> +Most files in this directory are covered by version 2 of the 
> +GNU General Public License except where explicitly stated.
> +See the main COPYING file in xen.git for more information.
> +
> +Notable exceptions are in the following directories
> +
> +vtpm
> +==== 
> +Exclusively contains code licensed under a MIT license
> +Also see vtpm/COPYING
> +
> +vtpmmgr
> +=======
> +Contains a significant portion of files which are licensed
> +under a BSD-3-Clause license. These files were imported from
> +elsewhere and are copyrighted as follows:
> +
> +Copyright (c) 2005, Intel Corp.
> +All rights reserved.
> +
> +See README.source for a complete list of files
> +
> +Otherwise, this directory contains several files licensed under
> +GPLv2+, or without copyright headers. 
> +
> +*.patch and *.diff files
> +========================
> +This directory contains a number of *.patch and *.diff files. 
> +These files describe changes to source files and are thus 
> +licensed under the license from which the *.patch and *.diff
> +were generated.
> diff --git a/stubdom/vtpm/COPYING b/stubdom/vtpm/COPYING
> new file mode 100644
> index 0000000..80780b8
> --- /dev/null
> +++ b/stubdom/vtpm/COPYING
> @@ -0,0 +1,26 @@
> +This copyright applies to all files within this subdirectory and its
> +subdirectories, unless explicitly stated otherwise within individual 
> +source files.
> +
> +All other files in the Xen source distribution are covered by version
> +2 of the GNU General Public License except where explicitly stated.
> +See the main COPYING file in xen.git for more information.
> +
> +=====================================================================
> +
> +Permission is hereby granted, free of charge, to any person obtaining a copy
> +of this software and associated documentation files (the "Software"), to
> +deal in the Software without restriction, including without limitation the
> +rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
> +sell copies of the Software, and to permit persons to whom the Software is
> +furnished to do so, subject to the following conditions:
> +
> +The above copyright notice and this permission notice shall be included in
> +all copies or substantial portions of the Software.
> +
> +THIS SOFTWARE AND ITS DOCUMENTATION ARE PROVIDED AS IS AND WITHOUT
> +ANY EXPRESS OR IMPLIED WARRANTIES WHATSOEVER. ALL WARRANTIES
> +INCLUDING, BUT NOT LIMITED TO, PERFORMANCE, MERCHANTABILITY, FITNESS
> +FOR A PARTICULAR  PURPOSE, AND NONINFRINGEMENT ARE HEREBY
> +DISCLAIMED. USERS ASSUME THE ENTIRE RISK AND LIABILITY OF USING THE
> +SOFTWARE.
> \ No newline at end of file

Here, please add a new line.

> diff --git a/stubdom/vtpmmgr/README.source b/stubdom/vtpmmgr/README.source
> new file mode 100644
> index 0000000..1b45997
> --- /dev/null
> +++ b/stubdom/vtpmmgr/README.source
> @@ -0,0 +1,23 @@
> +About
> +=====
> +This documents the upstream sources for files in this directory.
> +
> +The following files are based off of the original 
> +tools/vtpm_manager code base in xen.git, which has since been 
> +deleted: 
> +

It doesn't seem obvious to me during my archeology.

tools/vtpm_manager was deleted in
b918dce5bb2a665a34ff893a9df5392fb8ea429d, but it is not clear whether
your claim (the new code based off the deleted files) is true.

For one, there is no uuid.h in the deleted code -- apparently vtpm
wouldn't have to ship its own uuid library because OS has one. But then,
there is such claim in the new uuid.h, so I'm rather confused. I'm
inclined to believe that this uuid.h is either written afresh or
imported from somewhere else.

It would also be helpful if you can post your methodology for getting
the list of file so that I can check if there is something either you or
I miss.

> +init.c
> +log.c
> +log.h
> +marshal.h
> +tcg.h
> +tpm.c
> +tpm.h
> +tpm2.c
> +tpm2.h
> +tpm2_marshal.h
> +uuid.h
> +vtpm_cmd_handler.c
> +vtpm_manager.h
> +vtpmmgr.c
> +vtpmmgr.h
> \ No newline at end of file

New line please.

> -- 
> 2.5.4 (Apple Git-61)
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 3/4] [STUBDOM] Added COPYING files and README.source files

[Wei Liu]

On Wed, Aug 24, 2016 at 11:10:02AM +0100, Wei Liu wrote:
> On Fri, Aug 12, 2016 at 06:32:35PM +0100, Lars Kurth wrote:
> > Added a COPYING file as a boilerplate to explain license oddities in
> > this directory
> > 
> > Added a vtpm/COPYING file which contains MIT licensed files only
> > 
> > Added a vtpmmgr/README.source file which contains many BSD-3-Clause
> > files that originally came from tools/vtpm_manager
> > 
> > Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
> > ---
> >  stubdom/COPYING               | 31 +++++++++++++++++++++++++++++++
> >  stubdom/vtpm/COPYING          | 26 ++++++++++++++++++++++++++
> >  stubdom/vtpmmgr/README.source | 23 +++++++++++++++++++++++
> >  3 files changed, 80 insertions(+)
> >  create mode 100644 stubdom/COPYING
> >  create mode 100644 stubdom/vtpm/COPYING
> >  create mode 100644 stubdom/vtpmmgr/README.source
> > 
> > diff --git a/stubdom/COPYING b/stubdom/COPYING
> > new file mode 100644
> > index 0000000..a5071b3
> > --- /dev/null
> > +++ b/stubdom/COPYING
> > @@ -0,0 +1,31 @@
> > +Most files in this directory are covered by version 2 of the 
> > +GNU General Public License except where explicitly stated.
> > +See the main COPYING file in xen.git for more information.
> > +
> > +Notable exceptions are in the following directories
> > +
> > +vtpm
> > +==== 
> > +Exclusively contains code licensed under a MIT license
> > +Also see vtpm/COPYING
> > +
> > +vtpmmgr
> > +=======
> > +Contains a significant portion of files which are licensed
> > +under a BSD-3-Clause license. These files were imported from
> > +elsewhere and are copyrighted as follows:
> > +
> > +Copyright (c) 2005, Intel Corp.
> > +All rights reserved.
> > +
> > +See README.source for a complete list of files
> > +
> > +Otherwise, this directory contains several files licensed under
> > +GPLv2+, or without copyright headers. 
> > +
> > +*.patch and *.diff files
> > +========================
> > +This directory contains a number of *.patch and *.diff files. 
> > +These files describe changes to source files and are thus 
> > +licensed under the license from which the *.patch and *.diff
> > +were generated.
> > diff --git a/stubdom/vtpm/COPYING b/stubdom/vtpm/COPYING
> > new file mode 100644
> > index 0000000..80780b8
> > --- /dev/null
> > +++ b/stubdom/vtpm/COPYING
> > @@ -0,0 +1,26 @@
> > +This copyright applies to all files within this subdirectory and its
> > +subdirectories, unless explicitly stated otherwise within individual 
> > +source files.
> > +
> > +All other files in the Xen source distribution are covered by version
> > +2 of the GNU General Public License except where explicitly stated.
> > +See the main COPYING file in xen.git for more information.
> > +
> > +=====================================================================
> > +
> > +Permission is hereby granted, free of charge, to any person obtaining a copy
> > +of this software and associated documentation files (the "Software"), to
> > +deal in the Software without restriction, including without limitation the
> > +rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
> > +sell copies of the Software, and to permit persons to whom the Software is
> > +furnished to do so, subject to the following conditions:
> > +
> > +The above copyright notice and this permission notice shall be included in
> > +all copies or substantial portions of the Software.
> > +
> > +THIS SOFTWARE AND ITS DOCUMENTATION ARE PROVIDED AS IS AND WITHOUT
> > +ANY EXPRESS OR IMPLIED WARRANTIES WHATSOEVER. ALL WARRANTIES
> > +INCLUDING, BUT NOT LIMITED TO, PERFORMANCE, MERCHANTABILITY, FITNESS
> > +FOR A PARTICULAR  PURPOSE, AND NONINFRINGEMENT ARE HEREBY
> > +DISCLAIMED. USERS ASSUME THE ENTIRE RISK AND LIABILITY OF USING THE
> > +SOFTWARE.
> > \ No newline at end of file
> 
> Here, please add a new line.
> 
> > diff --git a/stubdom/vtpmmgr/README.source b/stubdom/vtpmmgr/README.source
> > new file mode 100644
> > index 0000000..1b45997
> > --- /dev/null
> > +++ b/stubdom/vtpmmgr/README.source
> > @@ -0,0 +1,23 @@
> > +About
> > +=====
> > +This documents the upstream sources for files in this directory.
> > +
> > +The following files are based off of the original 
> > +tools/vtpm_manager code base in xen.git, which has since been 
> > +deleted: 
> > +
> 
> It doesn't seem obvious to me during my archeology.
> 
> tools/vtpm_manager was deleted in
> b918dce5bb2a665a34ff893a9df5392fb8ea429d, but it is not clear whether
> your claim (the new code based off the deleted files) is true.
> 
> For one, there is no uuid.h in the deleted code -- apparently vtpm
> wouldn't have to ship its own uuid library because OS has one. But then,
> there is such claim in the new uuid.h, so I'm rather confused. I'm
> inclined to believe that this uuid.h is either written afresh or
> imported from somewhere else.
> 

For uuid.h, the code resembles neither Linux's nor FreeBSD's.  The
closest thing I can find is libxl_uuid.h. If that's the case, my
understanding is that he license, depending on when the code is
imported, can be either GPL or LGPL...

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 3/4] [STUBDOM] Added COPYING files and README.source files

[Lars Kurth]

On 24/08/2016 06:10, "Wei Liu" <wei.liu2@citrix.com> wrote:

>
>> diff --git a/stubdom/vtpmmgr/README.source
>>b/stubdom/vtpmmgr/README.source
>> new file mode 100644
>> index 0000000..1b45997
>> --- /dev/null
>> +++ b/stubdom/vtpmmgr/README.source
>> @@ -0,0 +1,23 @@
>> +About
>> +=====
>> +This documents the upstream sources for files in this directory.
>> +
>> +The following files are based off of the original
>> +tools/vtpm_manager code base in xen.git, which has since been
>> +deleted: 
>> +
>
>It doesn't seem obvious to me during my archeology.
>
>tools/vtpm_manager was deleted in
>b918dce5bb2a665a34ff893a9df5392fb8ea429d, but it is not clear whether
>your claim (the new code based off the deleted files) is true.
>
>For one, there is no uuid.h in the deleted code -- apparently vtpm
>wouldn't have to ship its own uuid library because OS has one. But then,
>there is such claim in the new uuid.h, so I'm rather confused. I'm
>inclined to believe that this uuid.h is either written afresh or
>imported from somewhere else.
>
>It would also be helpful if you can post your methodology for getting
>the list of file so that I can check if there is something either you or
>I miss.

I merely copied the claims from the existing (c) header files in the
files below, which all say

  5 * based off of the original tools/vtpm_manager code base which is:
  6 * Copyright (c) 2005, Intel Corp.
  7 * All rights reserved.


So I was merely restating the information, which was already present,
assuming that it is in fact correct. Uuid.h seems to have been introduced
in the same commit as all the files below.

>
>New line please.

Will fix the newline and other issues.

Lars

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel