From: Srinivas Pandruvada <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> To: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Jiri Kosina <jikos-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH v4 5/7] iio: hid-sensors: use asynchronous resume Date: Mon, 15 Aug 2016 10:29:23 -0700 [thread overview] Message-ID: <1471282163.20508.21.camel@linux.intel.com> (raw) In-Reply-To: <CAKdAkRRjh+21qOzq28=vSX59RcZsMOAt3pTUhjw4wXdpXXQg-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> On Mon, 2016-08-15 at 10:14 -0700, Dmitry Torokhov wrote: > On Mon, Aug 15, 2016 at 9:42 AM, Srinivas Pandruvada > <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> wrote: > > > > On Mon, 2016-08-15 at 08:45 -0700, Dmitry Torokhov wrote: > > > > > > On Mon, Aug 15, 2016 at 7:52 AM, Jonathan Cameron <jic23@kernel.o > > > rg> > > > wrote: > > > > > > > > > > > > On 15/08/16 15:07, Jonathan Cameron wrote: > > > > > > > > > > > > > > > On 07/08/16 11:15, Jiri Kosina wrote: > > > > > > > > > > > > > > > > > > On Sun, 7 Aug 2016, Srinivas Pandruvada wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > Some platforms power off sensor hubs during S3 suspend, > > > > > > > which > > > > > > > will require > > > > > > > longer time to resume. This hurts system resume time, so > > > > > > > resume > > > > > > > asynchronously. > > > > > > > > > > > > > > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@l > > > > > > > inux > > > > > > > .intel.com> > > > > > > Jonathan, are you going to cherry-pick this patch from the > > > > > > series? > > > > > > Alternatively, if you're okay with it, I can pull it in > > > > > > together with the > > > > > > whole set with your Acked-by or Reviewed-by. > > > > > > > > > > > I'll take it via IIO. Got a bit of catching up to do (been on > > > > > holiday) > > > > Applied to the togreg branch of iio.git - initially pushed out > > > > as > > > > testing for the autobuilders to play with it. > > > > This one is not really connected to the others so makes sense > > > > to > > > > take it separately. > > > > > > > > I'm out of my depth on the rest of the patches in this series > > > > and don't have time to learn enough to follow them! Sorry I > > > > can't help on that front. > > > About this patch: me sees a new work, me does not see new calls > > > to > > > cancel_work_sync() or flush_work() anywhere, me gets worried. > > This work is scheduled during resume and is not delayed call. Only > > time > > really we need to cancel or flush if module is unloaded before > > resume > > work, not sure if this case realistic. Do you see any other case > > possible? > Runtime resume can happen at any time, I can unload module or unbind > it at any time. I also wasn't aware that our implementation goal for > locking rules/lifetime rules/etc was "realistic" instead of > "correct". This is not for runtime_resume, this is for regular S3 suspend. But I agree, I will submit a patch for correctness. Thanks, Srinivas > > Thanks. >
WARNING: multiple messages have this Message-ID (diff)
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> To: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Jonathan Cameron <jic23@kernel.org>, Jiri Kosina <jikos@kernel.org>, "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>, linux-iio@vger.kernel.org Subject: Re: [PATCH v4 5/7] iio: hid-sensors: use asynchronous resume Date: Mon, 15 Aug 2016 10:29:23 -0700 [thread overview] Message-ID: <1471282163.20508.21.camel@linux.intel.com> (raw) In-Reply-To: <CAKdAkRRjh+21qOzq28=vSX59RcZsMOAt3pTUhjw4wXdpXXQg-w@mail.gmail.com> On Mon, 2016-08-15 at 10:14 -0700, Dmitry Torokhov wrote: > On Mon, Aug 15, 2016 at 9:42 AM, Srinivas Pandruvada > <srinivas.pandruvada@linux.intel.com> wrote: > > > > On Mon, 2016-08-15 at 08:45 -0700, Dmitry Torokhov wrote: > > > > > > On Mon, Aug 15, 2016 at 7:52 AM, Jonathan Cameron <jic23@kernel.o > > > rg> > > > wrote: > > > > > > > > > > > > On 15/08/16 15:07, Jonathan Cameron wrote: > > > > > > > > > > > > > > > On 07/08/16 11:15, Jiri Kosina wrote: > > > > > > > > > > > > > > > > > > On Sun, 7 Aug 2016, Srinivas Pandruvada wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > Some platforms power off sensor hubs during S3 suspend, > > > > > > > which > > > > > > > will require > > > > > > > longer time to resume. This hurts system resume time, so > > > > > > > resume > > > > > > > asynchronously. > > > > > > > > > > > > > > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@l > > > > > > > inux > > > > > > > .intel.com> > > > > > > Jonathan, are you going to cherry-pick this patch from the > > > > > > series? > > > > > > Alternatively, if you're okay with it, I can pull it in > > > > > > together with the > > > > > > whole set with your Acked-by or Reviewed-by. > > > > > > > > > > > I'll take it via IIO. Got a bit of catching up to do (been on > > > > > holiday) > > > > Applied to the togreg branch of iio.git - initially pushed out > > > > as > > > > testing for the autobuilders to play with it. > > > > This one is not really connected to the others so makes sense > > > > to > > > > take it separately. > > > > > > > > I'm out of my depth on the rest of the patches in this series > > > > and don't have time to learn enough to follow them! Sorry I > > > > can't help on that front. > > > About this patch: me sees a new work, me does not see new calls > > > to > > > cancel_work_sync() or flush_work() anywhere, me gets worried. > > This work is scheduled during resume and is not delayed call. Only > > time > > really we need to cancel or flush if module is unloaded before > > resume > > work, not sure if this case realistic. Do you see any other case > > possible? > Runtime resume can happen at any time, I can unload module or unbind > it at any time. I also wasn't aware that our implementation goal for > locking rules/lifetime rules/etc was "realistic" instead of > "correct". This is not for runtime_resume, this is for regular S3 suspend. But I agree, I will submit a patch for correctness. Thanks, Srinivas > > Thanks. >
next prev parent reply other threads:[~2016-08-15 17:29 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-07 9:25 [PATCH v4 0/7] Intel Integrated Sensor Hub Support (ISH) Srinivas Pandruvada 2016-08-07 9:25 ` [PATCH v4 1/7] Documentation: hid: Intel ISH HID document Srinivas Pandruvada 2016-08-07 9:25 ` [PATCH v4 2/7] hid: intel_ish-hid: ISH Transport layer Srinivas Pandruvada 2016-08-07 9:25 ` [PATCH v4 3/7] hid: intel-ish-hid: ipc layer Srinivas Pandruvada [not found] ` <1470561939-14278-1-git-send-email-srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> 2016-08-07 9:25 ` [PATCH v4 4/7] hid: intel-ish-hid: ISH HID client driver Srinivas Pandruvada 2016-08-07 9:25 ` Srinivas Pandruvada 2016-08-07 9:25 ` [PATCH v4 7/7] MAINTAINERS: Add Intel ISH Srinivas Pandruvada 2016-08-07 9:25 ` Srinivas Pandruvada 2016-08-17 9:17 ` [PATCH v4 0/7] Intel Integrated Sensor Hub Support (ISH) Jiri Kosina 2016-08-17 9:17 ` Jiri Kosina 2016-08-07 9:25 ` [PATCH v4 5/7] iio: hid-sensors: use asynchronous resume Srinivas Pandruvada 2016-08-07 10:15 ` Jiri Kosina [not found] ` <alpine.LNX.2.00.1608071214500.22028-YHPUNQjx9ReKbouaWp301Q@public.gmane.org> 2016-08-15 14:07 ` Jonathan Cameron 2016-08-15 14:07 ` Jonathan Cameron [not found] ` <884e74df-569e-8218-fbda-f9c7ecfe1e5a-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2016-08-15 14:52 ` Jonathan Cameron 2016-08-15 14:52 ` Jonathan Cameron [not found] ` <af2d1c90-a0ec-0888-8048-76463bf98ece-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2016-08-15 15:45 ` Dmitry Torokhov 2016-08-15 15:45 ` Dmitry Torokhov [not found] ` <CAKdAkRS-sVHqQ1tUZWVxNTfX5=ZxFzbCAxvsJPHV4=85mdEeRA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-08-15 15:49 ` Jonathan Cameron 2016-08-15 15:49 ` Jonathan Cameron 2016-08-15 16:42 ` Srinivas Pandruvada [not found] ` <1471279360.20508.20.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> 2016-08-15 17:14 ` Dmitry Torokhov 2016-08-15 17:14 ` Dmitry Torokhov [not found] ` <CAKdAkRRjh+21qOzq28=vSX59RcZsMOAt3pTUhjw4wXdpXXQg-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-08-15 17:29 ` Srinivas Pandruvada [this message] 2016-08-15 17:29 ` Srinivas Pandruvada 2016-08-15 17:53 ` Dmitry Torokhov 2016-08-15 18:24 ` Srinivas Pandruvada 2016-08-15 18:24 ` Srinivas Pandruvada 2016-08-07 9:25 ` [PATCH v4 6/7] hid: hid-sensor-hub: Add ISH quirk Srinivas Pandruvada 2016-08-07 17:03 ` [PATCH v4 0/7] Intel Integrated Sensor Hub Support (ISH) Atri Bhattacharya
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1471282163.20508.21.camel@linux.intel.com \ --to=srinivas.pandruvada-vuqaysv1563yd54fqh9/ca@public.gmane.org \ --cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=jikos-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.