All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] Makefile: Check availability of `a2ping` and `inkscape`
@ 2016-08-16  1:16 SeongJae Park
  2016-08-16  1:16 ` [PATCH 2/2] FAQ-BUILD: Add package requirements for Fedora 24 SeongJae Park
  2016-08-16  2:46 ` [PATCH 1/2] Makefile: Check availability of `a2ping` and `inkscape` Paul E. McKenney
  0 siblings, 2 replies; 3+ messages in thread
From: SeongJae Park @ 2016-08-16  1:16 UTC (permalink / raw)
  To: paulmck; +Cc: perfbook, SeongJae Park

This commit modifies Makefile to check availability of `a2ping` and
`inkscape` command as it already does for `dot` and `fig2eps`.

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
 Makefile | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Makefile b/Makefile
index b3d7c4c..60e8e96 100644
--- a/Makefile
+++ b/Makefile
@@ -41,6 +41,10 @@ DOT := $(shell which dot 2>/dev/null)

 FIG2EPS := $(shell which fig2eps 2>/dev/null)

+A2PING := $(shell which a2ping 2>/dev/null)
+
+INKSCAPE := $(shell which inkscape 2>/dev/null)
+
 default = $(PERFBOOK_DEFAULT)

 ifeq ($(default),)
@@ -127,10 +131,16 @@ endif

 $(PDFTARGETS_OF_EPS): %.pdf: %.eps
 	@echo "$< --> $@"
+ifndef A2PING
+	$(error "$< --> $@: a2ping not found. Please install it.")
+endif
 	@a2ping --below --hires --bboxfrom=compute-gs $< $@ > /dev/null 2>&1

 $(PDFTARGETS_OF_SVG): %.pdf: %.svg
 	@echo "$< --> $@"
+ifndef INKSCAPE
+	$(error "$< --> $@: inkscape not found. Please install it.")
+endif
 	@inkscape --export-pdf=$@ $<

 clean:
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] FAQ-BUILD: Add package requirements for Fedora 24
  2016-08-16  1:16 [PATCH 1/2] Makefile: Check availability of `a2ping` and `inkscape` SeongJae Park
@ 2016-08-16  1:16 ` SeongJae Park
  2016-08-16  2:46 ` [PATCH 1/2] Makefile: Check availability of `a2ping` and `inkscape` Paul E. McKenney
  1 sibling, 0 replies; 3+ messages in thread
From: SeongJae Park @ 2016-08-16  1:16 UTC (permalink / raw)
  To: paulmck; +Cc: perfbook, SeongJae Park

This commit adds package requirements for Fedora 24.  It has been tested
on `fedora:24` docker image.

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
 FAQ-BUILD.txt | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/FAQ-BUILD.txt b/FAQ-BUILD.txt
index d2c5352..6627bbb 100644
--- a/FAQ-BUILD.txt
+++ b/FAQ-BUILD.txt
@@ -43,6 +43,11 @@
 			texlive-science texlive-bibtex-extra latex2html
 			gnuplot-x11 xfig inkscape graphviz fig2ps

+		On Fedora 24, installing the following set of packages
+		suffices:
+			fig2ps graphviz texlive-epstopdf inkscape latex2html
+			texlive-collection-latexextra
+
 		Other systems might provide similarly named packages.
 		For example, Doug Miller noted that the following list
 		of teTeX components worked for him on RHEL5:
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] Makefile: Check availability of `a2ping` and `inkscape`
  2016-08-16  1:16 [PATCH 1/2] Makefile: Check availability of `a2ping` and `inkscape` SeongJae Park
  2016-08-16  1:16 ` [PATCH 2/2] FAQ-BUILD: Add package requirements for Fedora 24 SeongJae Park
@ 2016-08-16  2:46 ` Paul E. McKenney
  1 sibling, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2016-08-16  2:46 UTC (permalink / raw)
  To: SeongJae Park; +Cc: perfbook

On Tue, Aug 16, 2016 at 10:16:51AM +0900, SeongJae Park wrote:
> This commit modifies Makefile to check availability of `a2ping` and
> `inkscape` command as it already does for `dot` and `fig2eps`.
> 
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>

Applied both, thank you!

							Thanx, Paul

> ---
>  Makefile | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index b3d7c4c..60e8e96 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -41,6 +41,10 @@ DOT := $(shell which dot 2>/dev/null)
> 
>  FIG2EPS := $(shell which fig2eps 2>/dev/null)
> 
> +A2PING := $(shell which a2ping 2>/dev/null)
> +
> +INKSCAPE := $(shell which inkscape 2>/dev/null)
> +
>  default = $(PERFBOOK_DEFAULT)
> 
>  ifeq ($(default),)
> @@ -127,10 +131,16 @@ endif
> 
>  $(PDFTARGETS_OF_EPS): %.pdf: %.eps
>  	@echo "$< --> $@"
> +ifndef A2PING
> +	$(error "$< --> $@: a2ping not found. Please install it.")
> +endif
>  	@a2ping --below --hires --bboxfrom=compute-gs $< $@ > /dev/null 2>&1
> 
>  $(PDFTARGETS_OF_SVG): %.pdf: %.svg
>  	@echo "$< --> $@"
> +ifndef INKSCAPE
> +	$(error "$< --> $@: inkscape not found. Please install it.")
> +endif
>  	@inkscape --export-pdf=$@ $<
> 
>  clean:
> -- 
> 1.9.1
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-08-16  2:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-16  1:16 [PATCH 1/2] Makefile: Check availability of `a2ping` and `inkscape` SeongJae Park
2016-08-16  1:16 ` [PATCH 2/2] FAQ-BUILD: Add package requirements for Fedora 24 SeongJae Park
2016-08-16  2:46 ` [PATCH 1/2] Makefile: Check availability of `a2ping` and `inkscape` Paul E. McKenney

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.