All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "iommu/amd: Update Alias-DTE in update_device_table()" has been added to the 4.4-stable tree
@ 2016-08-18 10:57 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-08-18 10:57 UTC (permalink / raw)
  To: jroedel, gregkh; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    iommu/amd: Update Alias-DTE in update_device_table()

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     iommu-amd-update-alias-dte-in-update_device_table.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 3254de6bf74fe94c197c9f819fe62a3a3c36f073 Mon Sep 17 00:00:00 2001
From: Joerg Roedel <jroedel@suse.de>
Date: Tue, 26 Jul 2016 15:18:54 +0200
Subject: iommu/amd: Update Alias-DTE in update_device_table()

From: Joerg Roedel <jroedel@suse.de>

commit 3254de6bf74fe94c197c9f819fe62a3a3c36f073 upstream.

Not doing so might cause IO-Page-Faults when a device uses
an alias request-id and the alias-dte is left in a lower
page-mode which does not cover the address allocated from
the iova-allocator.

Fixes: 492667dacc0a ('x86/amd-iommu: Remove amd_iommu_pd_table')
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/iommu/amd_iommu.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -2324,8 +2324,15 @@ static void update_device_table(struct p
 {
 	struct iommu_dev_data *dev_data;
 
-	list_for_each_entry(dev_data, &domain->dev_list, list)
+	list_for_each_entry(dev_data, &domain->dev_list, list) {
 		set_dte_entry(dev_data->devid, domain, dev_data->ats.enabled);
+
+		if (dev_data->devid == dev_data->alias)
+			continue;
+
+		/* There is an alias, update device table entry for it */
+		set_dte_entry(dev_data->alias, domain, dev_data->ats.enabled);
+	}
 }
 
 static void update_domain(struct protection_domain *domain)


Patches currently in stable-queue which might be from jroedel@suse.de are

queue-4.4/iommu-amd-handle-iommu_domain_dma-in-ops-domain_free-call-back.patch
queue-4.4/iommu-amd-update-alias-dte-in-update_device_table.patch
queue-4.4/iommu-amd-init-unity-mappings-only-for-dma_ops-domains.patch
queue-4.4/iommu-vt-d-return-error-code-in-domain_context_mapping_one.patch
queue-4.4/iommu-exynos-suppress-unbinding-to-prevent-system-failure.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-18 10:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-18 10:57 Patch "iommu/amd: Update Alias-DTE in update_device_table()" has been added to the 4.4-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.