* [PATCH 0/5] clk: samsung: exynos: Fix the checkpatch warnings
@ 2016-08-22 9:48 ` Chanwoo Choi
0 siblings, 0 replies; 14+ messages in thread
From: Chanwoo Choi @ 2016-08-22 9:48 UTC (permalink / raw)
To: s.nawrocki, tomasz.figa
Cc: mturquette, sboyd, kgene, k.kozlowski, chanwoo,
linux-samsung-soc, linux-clk, linux-arm-kernel, linux-kernel,
Chanwoo Choi
This patches just fix the checkpatch warnings for exynos5433/3250/5260/5420/4
series without the behavior changes.
Chanwoo Choi (5):
clk: samsung: exynos5433: Fix the checkpatch warnings
clk: samsung: exynos3250: Fix the checkpatch warnings
clk: samsung: exynos5260: Fix the checkpatch warnings
clk: samsung: exynos5420: Fix the checkpatch warnings
clk: samsung: exynos4: Fix the checkpatch warnings
drivers/clk/samsung/clk-exynos3250.c | 97 ++++++++++++++++++++----------------
drivers/clk/samsung/clk-exynos4.c | 51 ++++++++++---------
drivers/clk/samsung/clk-exynos5260.c | 4 +-
drivers/clk/samsung/clk-exynos5420.c | 11 ++--
drivers/clk/samsung/clk-exynos5433.c | 6 ++-
5 files changed, 88 insertions(+), 81 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 0/5] clk: samsung: exynos: Fix the checkpatch warnings
@ 2016-08-22 9:48 ` Chanwoo Choi
0 siblings, 0 replies; 14+ messages in thread
From: Chanwoo Choi @ 2016-08-22 9:48 UTC (permalink / raw)
To: linux-arm-kernel
This patches just fix the checkpatch warnings for exynos5433/3250/5260/5420/4
series without the behavior changes.
Chanwoo Choi (5):
clk: samsung: exynos5433: Fix the checkpatch warnings
clk: samsung: exynos3250: Fix the checkpatch warnings
clk: samsung: exynos5260: Fix the checkpatch warnings
clk: samsung: exynos5420: Fix the checkpatch warnings
clk: samsung: exynos4: Fix the checkpatch warnings
drivers/clk/samsung/clk-exynos3250.c | 97 ++++++++++++++++++++----------------
drivers/clk/samsung/clk-exynos4.c | 51 ++++++++++---------
drivers/clk/samsung/clk-exynos5260.c | 4 +-
drivers/clk/samsung/clk-exynos5420.c | 11 ++--
drivers/clk/samsung/clk-exynos5433.c | 6 ++-
5 files changed, 88 insertions(+), 81 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/5] clk: samsung: exynos5433: Fix the checkpatch warnings
2016-08-22 9:48 ` Chanwoo Choi
@ 2016-08-22 9:48 ` Chanwoo Choi
-1 siblings, 0 replies; 14+ messages in thread
From: Chanwoo Choi @ 2016-08-22 9:48 UTC (permalink / raw)
To: s.nawrocki, tomasz.figa
Cc: mturquette, sboyd, kgene, k.kozlowski, chanwoo,
linux-samsung-soc, linux-clk, linux-arm-kernel, linux-kernel,
Chanwoo Choi
This patch fixes the line over 80 characters by using checkpatch.pl script.
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/clk/samsung/clk-exynos5433.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
index ea1608682d7f..6842d3833f1e 100644
--- a/drivers/clk/samsung/clk-exynos5433.c
+++ b/drivers/clk/samsung/clk-exynos5433.c
@@ -1826,11 +1826,13 @@ static const struct samsung_gate_clock peris_gate_clks[] __initconst = {
/* ENABLE_PCLK_PERIS_SECURE_SECKEY_APBIF */
GATE(CLK_PCLK_SECKEY_APBIF, "pclk_seckey_apbif", "aclk_peris_66",
- ENABLE_PCLK_PERIS_SECURE_SECKEY_APBIF, 0, CLK_IGNORE_UNUSED, 0),
+ ENABLE_PCLK_PERIS_SECURE_SECKEY_APBIF, 0,
+ CLK_IGNORE_UNUSED, 0),
/* ENABLE_PCLK_PERIS_SECURE_CHIPID_APBIF */
GATE(CLK_PCLK_CHIPID_APBIF, "pclk_chipid_apbif", "aclk_peris_66",
- ENABLE_PCLK_PERIS_SECURE_CHIPID_APBIF, 0, CLK_IGNORE_UNUSED, 0),
+ ENABLE_PCLK_PERIS_SECURE_CHIPID_APBIF, 0,
+ CLK_IGNORE_UNUSED, 0),
/* ENABLE_PCLK_PERIS_SECURE_TOPRTC */
GATE(CLK_PCLK_TOPRTC, "pclk_toprtc", "aclk_peris_66",
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 1/5] clk: samsung: exynos5433: Fix the checkpatch warnings
@ 2016-08-22 9:48 ` Chanwoo Choi
0 siblings, 0 replies; 14+ messages in thread
From: Chanwoo Choi @ 2016-08-22 9:48 UTC (permalink / raw)
To: linux-arm-kernel
This patch fixes the line over 80 characters by using checkpatch.pl script.
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/clk/samsung/clk-exynos5433.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
index ea1608682d7f..6842d3833f1e 100644
--- a/drivers/clk/samsung/clk-exynos5433.c
+++ b/drivers/clk/samsung/clk-exynos5433.c
@@ -1826,11 +1826,13 @@ static const struct samsung_gate_clock peris_gate_clks[] __initconst = {
/* ENABLE_PCLK_PERIS_SECURE_SECKEY_APBIF */
GATE(CLK_PCLK_SECKEY_APBIF, "pclk_seckey_apbif", "aclk_peris_66",
- ENABLE_PCLK_PERIS_SECURE_SECKEY_APBIF, 0, CLK_IGNORE_UNUSED, 0),
+ ENABLE_PCLK_PERIS_SECURE_SECKEY_APBIF, 0,
+ CLK_IGNORE_UNUSED, 0),
/* ENABLE_PCLK_PERIS_SECURE_CHIPID_APBIF */
GATE(CLK_PCLK_CHIPID_APBIF, "pclk_chipid_apbif", "aclk_peris_66",
- ENABLE_PCLK_PERIS_SECURE_CHIPID_APBIF, 0, CLK_IGNORE_UNUSED, 0),
+ ENABLE_PCLK_PERIS_SECURE_CHIPID_APBIF, 0,
+ CLK_IGNORE_UNUSED, 0),
/* ENABLE_PCLK_PERIS_SECURE_TOPRTC */
GATE(CLK_PCLK_TOPRTC, "pclk_toprtc", "aclk_peris_66",
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/5] clk: samsung: exynos3250: Fix the checkpatch warnings
2016-08-22 9:48 ` Chanwoo Choi
@ 2016-08-22 9:48 ` Chanwoo Choi
-1 siblings, 0 replies; 14+ messages in thread
From: Chanwoo Choi @ 2016-08-22 9:48 UTC (permalink / raw)
To: s.nawrocki, tomasz.figa
Cc: mturquette, sboyd, kgene, k.kozlowski, chanwoo,
linux-samsung-soc, linux-clk, linux-arm-kernel, linux-kernel,
Chanwoo Choi
This patch fixes the following warnings by using checkpatch.pl script.
- Fix line 80 over characters
- Remove the space prohibited after that open parenthesis '('
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/clk/samsung/clk-exynos3250.c | 97 ++++++++++++++++++++----------------
1 file changed, 53 insertions(+), 44 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos3250.c b/drivers/clk/samsung/clk-exynos3250.c
index 1b81e283f605..cda6a85dbf9d 100644
--- a/drivers/clk/samsung/clk-exynos3250.c
+++ b/drivers/clk/samsung/clk-exynos3250.c
@@ -258,28 +258,38 @@ static const struct samsung_mux_clock mux_clks[] __initconst = {
/* SRC_TOP0 */
MUX(CLK_MOUT_EBI, "mout_ebi", mout_ebi_p, SRC_TOP0, 28, 1),
- MUX(CLK_MOUT_ACLK_200, "mout_aclk_200", group_div_mpll_pre_p,SRC_TOP0, 24, 1),
- MUX(CLK_MOUT_ACLK_160, "mout_aclk_160", group_div_mpll_pre_p, SRC_TOP0, 20, 1),
- MUX(CLK_MOUT_ACLK_100, "mout_aclk_100", group_div_mpll_pre_p, SRC_TOP0, 16, 1),
- MUX(CLK_MOUT_ACLK_266_1, "mout_aclk_266_1", mout_aclk_266_1_p, SRC_TOP0, 14, 1),
- MUX(CLK_MOUT_ACLK_266_0, "mout_aclk_266_0", mout_aclk_266_0_p, SRC_TOP0, 13, 1),
- MUX(CLK_MOUT_ACLK_266, "mout_aclk_266", mout_aclk_266_p, SRC_TOP0, 12, 1),
+ MUX(CLK_MOUT_ACLK_200, "mout_aclk_200", group_div_mpll_pre_p,
+ SRC_TOP0, 24, 1),
+ MUX(CLK_MOUT_ACLK_160, "mout_aclk_160", group_div_mpll_pre_p,
+ SRC_TOP0, 20, 1),
+ MUX(CLK_MOUT_ACLK_100, "mout_aclk_100", group_div_mpll_pre_p,
+ SRC_TOP0, 16, 1),
+ MUX(CLK_MOUT_ACLK_266_1, "mout_aclk_266_1", mout_aclk_266_1_p,
+ SRC_TOP0, 14, 1),
+ MUX(CLK_MOUT_ACLK_266_0, "mout_aclk_266_0", mout_aclk_266_0_p,
+ SRC_TOP0, 13, 1),
+ MUX(CLK_MOUT_ACLK_266, "mout_aclk_266", mout_aclk_266_p,
+ SRC_TOP0, 12, 1),
MUX(CLK_MOUT_VPLL, "mout_vpll", mout_vpll_p, SRC_TOP0, 8, 1),
- MUX(CLK_MOUT_EPLL_USER, "mout_epll_user", mout_epll_user_p, SRC_TOP0, 4, 1),
+ MUX(CLK_MOUT_EPLL_USER, "mout_epll_user", mout_epll_user_p,
+ SRC_TOP0, 4, 1),
MUX(CLK_MOUT_EBI_1, "mout_ebi_1", mout_ebi_1_p, SRC_TOP0, 0, 1),
/* SRC_TOP1 */
MUX(CLK_MOUT_UPLL, "mout_upll", mout_upll_p, SRC_TOP1, 28, 1),
- MUX(CLK_MOUT_ACLK_400_MCUISP_SUB, "mout_aclk_400_mcuisp_sub", mout_aclk_400_mcuisp_sub_p,
- SRC_TOP1, 24, 1),
- MUX(CLK_MOUT_ACLK_266_SUB, "mout_aclk_266_sub", mout_aclk_266_sub_p, SRC_TOP1, 20, 1),
+ MUX(CLK_MOUT_ACLK_400_MCUISP_SUB, "mout_aclk_400_mcuisp_sub",
+ mout_aclk_400_mcuisp_sub_p, SRC_TOP1, 24, 1),
+ MUX(CLK_MOUT_ACLK_266_SUB, "mout_aclk_266_sub", mout_aclk_266_sub_p,
+ SRC_TOP1, 20, 1),
MUX(CLK_MOUT_MPLL, "mout_mpll", mout_mpll_p, SRC_TOP1, 12, 1),
- MUX(CLK_MOUT_ACLK_400_MCUISP, "mout_aclk_400_mcuisp", group_div_mpll_pre_p, SRC_TOP1, 8, 1),
+ MUX(CLK_MOUT_ACLK_400_MCUISP, "mout_aclk_400_mcuisp",
+ group_div_mpll_pre_p, SRC_TOP1, 8, 1),
MUX(CLK_MOUT_VPLLSRC, "mout_vpllsrc", mout_vpllsrc_p, SRC_TOP1, 0, 1),
/* SRC_CAM */
MUX(CLK_MOUT_CAM1, "mout_cam1", group_sclk_p, SRC_CAM, 20, 4),
- MUX(CLK_MOUT_CAM_BLK, "mout_cam_blk", group_sclk_cam_blk_p, SRC_CAM, 0, 4),
+ MUX(CLK_MOUT_CAM_BLK, "mout_cam_blk", group_sclk_cam_blk_p,
+ SRC_CAM, 0, 4),
/* SRC_MFC */
MUX(CLK_MOUT_MFC, "mout_mfc", mout_mfc_p, SRC_MFC, 8, 1),
@@ -670,23 +680,23 @@ static const struct samsung_gate_clock gate_clks[] __initconst = {
/* APLL & MPLL & BPLL & UPLL */
static const struct samsung_pll_rate_table exynos3250_pll_rates[] __initconst = {
- PLL_35XX_RATE(1200000000, 400, 4, 1),
- PLL_35XX_RATE(1100000000, 275, 3, 1),
- PLL_35XX_RATE(1066000000, 533, 6, 1),
- PLL_35XX_RATE(1000000000, 250, 3, 1),
- PLL_35XX_RATE( 960000000, 320, 4, 1),
- PLL_35XX_RATE( 900000000, 300, 4, 1),
- PLL_35XX_RATE( 850000000, 425, 6, 1),
- PLL_35XX_RATE( 800000000, 200, 3, 1),
- PLL_35XX_RATE( 700000000, 175, 3, 1),
- PLL_35XX_RATE( 667000000, 667, 12, 1),
- PLL_35XX_RATE( 600000000, 400, 4, 2),
- PLL_35XX_RATE( 533000000, 533, 6, 2),
- PLL_35XX_RATE( 520000000, 260, 3, 2),
- PLL_35XX_RATE( 500000000, 250, 3, 2),
- PLL_35XX_RATE( 400000000, 200, 3, 2),
- PLL_35XX_RATE( 200000000, 200, 3, 3),
- PLL_35XX_RATE( 100000000, 200, 3, 4),
+ PLL_35XX_RATE(1200000000, 400, 4, 1),
+ PLL_35XX_RATE(1100000000, 275, 3, 1),
+ PLL_35XX_RATE(1066000000, 533, 6, 1),
+ PLL_35XX_RATE(1000000000, 250, 3, 1),
+ PLL_35XX_RATE(960000000, 320, 4, 1),
+ PLL_35XX_RATE(900000000, 300, 4, 1),
+ PLL_35XX_RATE(850000000, 425, 6, 1),
+ PLL_35XX_RATE(800000000, 200, 3, 1),
+ PLL_35XX_RATE(700000000, 175, 3, 1),
+ PLL_35XX_RATE(667000000, 667, 12, 1),
+ PLL_35XX_RATE(600000000, 400, 4, 2),
+ PLL_35XX_RATE(533000000, 533, 6, 2),
+ PLL_35XX_RATE(520000000, 260, 3, 2),
+ PLL_35XX_RATE(500000000, 250, 3, 2),
+ PLL_35XX_RATE(400000000, 200, 3, 2),
+ PLL_35XX_RATE(200000000, 200, 3, 3),
+ PLL_35XX_RATE(100000000, 200, 3, 4),
{ /* sentinel */ }
};
@@ -696,16 +706,16 @@ static const struct samsung_pll_rate_table exynos3250_epll_rates[] __initconst =
PLL_36XX_RATE(288000000, 96, 2, 2, 0),
PLL_36XX_RATE(192000000, 128, 2, 3, 0),
PLL_36XX_RATE(144000000, 96, 2, 3, 0),
- PLL_36XX_RATE( 96000000, 128, 2, 4, 0),
- PLL_36XX_RATE( 84000000, 112, 2, 4, 0),
- PLL_36XX_RATE( 80000004, 106, 2, 4, 43691),
- PLL_36XX_RATE( 73728000, 98, 2, 4, 19923),
- PLL_36XX_RATE( 67737598, 270, 3, 5, 62285),
- PLL_36XX_RATE( 65535999, 174, 2, 5, 49982),
- PLL_36XX_RATE( 50000000, 200, 3, 5, 0),
- PLL_36XX_RATE( 49152002, 131, 2, 5, 4719),
- PLL_36XX_RATE( 48000000, 128, 2, 5, 0),
- PLL_36XX_RATE( 45158401, 180, 3, 5, 41524),
+ PLL_36XX_RATE(96000000, 128, 2, 4, 0),
+ PLL_36XX_RATE(84000000, 112, 2, 4, 0),
+ PLL_36XX_RATE(80000004, 106, 2, 4, 43691),
+ PLL_36XX_RATE(73728000, 98, 2, 4, 19923),
+ PLL_36XX_RATE(67737598, 270, 3, 5, 62285),
+ PLL_36XX_RATE(65535999, 174, 2, 5, 49982),
+ PLL_36XX_RATE(50000000, 200, 3, 5, 0),
+ PLL_36XX_RATE(49152002, 131, 2, 5, 4719),
+ PLL_36XX_RATE(48000000, 128, 2, 5, 0),
+ PLL_36XX_RATE(45158401, 180, 3, 5, 41524),
{ /* sentinel */ }
};
@@ -733,10 +743,10 @@ static const struct samsung_pll_rate_table exynos3250_vpll_rates[] __initconst =
PLL_36XX_RATE(148500000, 99, 2, 3, 0),
PLL_36XX_RATE(148352005, 98, 2, 3, 59070),
PLL_36XX_RATE(108000000, 144, 2, 4, 0),
- PLL_36XX_RATE( 74250000, 99, 2, 4, 0),
- PLL_36XX_RATE( 74176002, 98, 3, 4, 59070),
- PLL_36XX_RATE( 54054000, 216, 3, 5, 14156),
- PLL_36XX_RATE( 54000000, 144, 2, 5, 0),
+ PLL_36XX_RATE(74250000, 99, 2, 4, 0),
+ PLL_36XX_RATE(74176002, 98, 3, 4, 59070),
+ PLL_36XX_RATE(54054000, 216, 3, 5, 14156),
+ PLL_36XX_RATE(54000000, 144, 2, 5, 0),
{ /* sentinel */ }
};
@@ -1098,4 +1108,3 @@ static int __init exynos3250_cmu_platform_init(void)
exynos3250_cmu_isp_probe);
}
subsys_initcall(exynos3250_cmu_platform_init);
-
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/5] clk: samsung: exynos3250: Fix the checkpatch warnings
@ 2016-08-22 9:48 ` Chanwoo Choi
0 siblings, 0 replies; 14+ messages in thread
From: Chanwoo Choi @ 2016-08-22 9:48 UTC (permalink / raw)
To: linux-arm-kernel
This patch fixes the following warnings by using checkpatch.pl script.
- Fix line 80 over characters
- Remove the space prohibited after that open parenthesis '('
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/clk/samsung/clk-exynos3250.c | 97 ++++++++++++++++++++----------------
1 file changed, 53 insertions(+), 44 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos3250.c b/drivers/clk/samsung/clk-exynos3250.c
index 1b81e283f605..cda6a85dbf9d 100644
--- a/drivers/clk/samsung/clk-exynos3250.c
+++ b/drivers/clk/samsung/clk-exynos3250.c
@@ -258,28 +258,38 @@ static const struct samsung_mux_clock mux_clks[] __initconst = {
/* SRC_TOP0 */
MUX(CLK_MOUT_EBI, "mout_ebi", mout_ebi_p, SRC_TOP0, 28, 1),
- MUX(CLK_MOUT_ACLK_200, "mout_aclk_200", group_div_mpll_pre_p,SRC_TOP0, 24, 1),
- MUX(CLK_MOUT_ACLK_160, "mout_aclk_160", group_div_mpll_pre_p, SRC_TOP0, 20, 1),
- MUX(CLK_MOUT_ACLK_100, "mout_aclk_100", group_div_mpll_pre_p, SRC_TOP0, 16, 1),
- MUX(CLK_MOUT_ACLK_266_1, "mout_aclk_266_1", mout_aclk_266_1_p, SRC_TOP0, 14, 1),
- MUX(CLK_MOUT_ACLK_266_0, "mout_aclk_266_0", mout_aclk_266_0_p, SRC_TOP0, 13, 1),
- MUX(CLK_MOUT_ACLK_266, "mout_aclk_266", mout_aclk_266_p, SRC_TOP0, 12, 1),
+ MUX(CLK_MOUT_ACLK_200, "mout_aclk_200", group_div_mpll_pre_p,
+ SRC_TOP0, 24, 1),
+ MUX(CLK_MOUT_ACLK_160, "mout_aclk_160", group_div_mpll_pre_p,
+ SRC_TOP0, 20, 1),
+ MUX(CLK_MOUT_ACLK_100, "mout_aclk_100", group_div_mpll_pre_p,
+ SRC_TOP0, 16, 1),
+ MUX(CLK_MOUT_ACLK_266_1, "mout_aclk_266_1", mout_aclk_266_1_p,
+ SRC_TOP0, 14, 1),
+ MUX(CLK_MOUT_ACLK_266_0, "mout_aclk_266_0", mout_aclk_266_0_p,
+ SRC_TOP0, 13, 1),
+ MUX(CLK_MOUT_ACLK_266, "mout_aclk_266", mout_aclk_266_p,
+ SRC_TOP0, 12, 1),
MUX(CLK_MOUT_VPLL, "mout_vpll", mout_vpll_p, SRC_TOP0, 8, 1),
- MUX(CLK_MOUT_EPLL_USER, "mout_epll_user", mout_epll_user_p, SRC_TOP0, 4, 1),
+ MUX(CLK_MOUT_EPLL_USER, "mout_epll_user", mout_epll_user_p,
+ SRC_TOP0, 4, 1),
MUX(CLK_MOUT_EBI_1, "mout_ebi_1", mout_ebi_1_p, SRC_TOP0, 0, 1),
/* SRC_TOP1 */
MUX(CLK_MOUT_UPLL, "mout_upll", mout_upll_p, SRC_TOP1, 28, 1),
- MUX(CLK_MOUT_ACLK_400_MCUISP_SUB, "mout_aclk_400_mcuisp_sub", mout_aclk_400_mcuisp_sub_p,
- SRC_TOP1, 24, 1),
- MUX(CLK_MOUT_ACLK_266_SUB, "mout_aclk_266_sub", mout_aclk_266_sub_p, SRC_TOP1, 20, 1),
+ MUX(CLK_MOUT_ACLK_400_MCUISP_SUB, "mout_aclk_400_mcuisp_sub",
+ mout_aclk_400_mcuisp_sub_p, SRC_TOP1, 24, 1),
+ MUX(CLK_MOUT_ACLK_266_SUB, "mout_aclk_266_sub", mout_aclk_266_sub_p,
+ SRC_TOP1, 20, 1),
MUX(CLK_MOUT_MPLL, "mout_mpll", mout_mpll_p, SRC_TOP1, 12, 1),
- MUX(CLK_MOUT_ACLK_400_MCUISP, "mout_aclk_400_mcuisp", group_div_mpll_pre_p, SRC_TOP1, 8, 1),
+ MUX(CLK_MOUT_ACLK_400_MCUISP, "mout_aclk_400_mcuisp",
+ group_div_mpll_pre_p, SRC_TOP1, 8, 1),
MUX(CLK_MOUT_VPLLSRC, "mout_vpllsrc", mout_vpllsrc_p, SRC_TOP1, 0, 1),
/* SRC_CAM */
MUX(CLK_MOUT_CAM1, "mout_cam1", group_sclk_p, SRC_CAM, 20, 4),
- MUX(CLK_MOUT_CAM_BLK, "mout_cam_blk", group_sclk_cam_blk_p, SRC_CAM, 0, 4),
+ MUX(CLK_MOUT_CAM_BLK, "mout_cam_blk", group_sclk_cam_blk_p,
+ SRC_CAM, 0, 4),
/* SRC_MFC */
MUX(CLK_MOUT_MFC, "mout_mfc", mout_mfc_p, SRC_MFC, 8, 1),
@@ -670,23 +680,23 @@ static const struct samsung_gate_clock gate_clks[] __initconst = {
/* APLL & MPLL & BPLL & UPLL */
static const struct samsung_pll_rate_table exynos3250_pll_rates[] __initconst = {
- PLL_35XX_RATE(1200000000, 400, 4, 1),
- PLL_35XX_RATE(1100000000, 275, 3, 1),
- PLL_35XX_RATE(1066000000, 533, 6, 1),
- PLL_35XX_RATE(1000000000, 250, 3, 1),
- PLL_35XX_RATE( 960000000, 320, 4, 1),
- PLL_35XX_RATE( 900000000, 300, 4, 1),
- PLL_35XX_RATE( 850000000, 425, 6, 1),
- PLL_35XX_RATE( 800000000, 200, 3, 1),
- PLL_35XX_RATE( 700000000, 175, 3, 1),
- PLL_35XX_RATE( 667000000, 667, 12, 1),
- PLL_35XX_RATE( 600000000, 400, 4, 2),
- PLL_35XX_RATE( 533000000, 533, 6, 2),
- PLL_35XX_RATE( 520000000, 260, 3, 2),
- PLL_35XX_RATE( 500000000, 250, 3, 2),
- PLL_35XX_RATE( 400000000, 200, 3, 2),
- PLL_35XX_RATE( 200000000, 200, 3, 3),
- PLL_35XX_RATE( 100000000, 200, 3, 4),
+ PLL_35XX_RATE(1200000000, 400, 4, 1),
+ PLL_35XX_RATE(1100000000, 275, 3, 1),
+ PLL_35XX_RATE(1066000000, 533, 6, 1),
+ PLL_35XX_RATE(1000000000, 250, 3, 1),
+ PLL_35XX_RATE(960000000, 320, 4, 1),
+ PLL_35XX_RATE(900000000, 300, 4, 1),
+ PLL_35XX_RATE(850000000, 425, 6, 1),
+ PLL_35XX_RATE(800000000, 200, 3, 1),
+ PLL_35XX_RATE(700000000, 175, 3, 1),
+ PLL_35XX_RATE(667000000, 667, 12, 1),
+ PLL_35XX_RATE(600000000, 400, 4, 2),
+ PLL_35XX_RATE(533000000, 533, 6, 2),
+ PLL_35XX_RATE(520000000, 260, 3, 2),
+ PLL_35XX_RATE(500000000, 250, 3, 2),
+ PLL_35XX_RATE(400000000, 200, 3, 2),
+ PLL_35XX_RATE(200000000, 200, 3, 3),
+ PLL_35XX_RATE(100000000, 200, 3, 4),
{ /* sentinel */ }
};
@@ -696,16 +706,16 @@ static const struct samsung_pll_rate_table exynos3250_epll_rates[] __initconst =
PLL_36XX_RATE(288000000, 96, 2, 2, 0),
PLL_36XX_RATE(192000000, 128, 2, 3, 0),
PLL_36XX_RATE(144000000, 96, 2, 3, 0),
- PLL_36XX_RATE( 96000000, 128, 2, 4, 0),
- PLL_36XX_RATE( 84000000, 112, 2, 4, 0),
- PLL_36XX_RATE( 80000004, 106, 2, 4, 43691),
- PLL_36XX_RATE( 73728000, 98, 2, 4, 19923),
- PLL_36XX_RATE( 67737598, 270, 3, 5, 62285),
- PLL_36XX_RATE( 65535999, 174, 2, 5, 49982),
- PLL_36XX_RATE( 50000000, 200, 3, 5, 0),
- PLL_36XX_RATE( 49152002, 131, 2, 5, 4719),
- PLL_36XX_RATE( 48000000, 128, 2, 5, 0),
- PLL_36XX_RATE( 45158401, 180, 3, 5, 41524),
+ PLL_36XX_RATE(96000000, 128, 2, 4, 0),
+ PLL_36XX_RATE(84000000, 112, 2, 4, 0),
+ PLL_36XX_RATE(80000004, 106, 2, 4, 43691),
+ PLL_36XX_RATE(73728000, 98, 2, 4, 19923),
+ PLL_36XX_RATE(67737598, 270, 3, 5, 62285),
+ PLL_36XX_RATE(65535999, 174, 2, 5, 49982),
+ PLL_36XX_RATE(50000000, 200, 3, 5, 0),
+ PLL_36XX_RATE(49152002, 131, 2, 5, 4719),
+ PLL_36XX_RATE(48000000, 128, 2, 5, 0),
+ PLL_36XX_RATE(45158401, 180, 3, 5, 41524),
{ /* sentinel */ }
};
@@ -733,10 +743,10 @@ static const struct samsung_pll_rate_table exynos3250_vpll_rates[] __initconst =
PLL_36XX_RATE(148500000, 99, 2, 3, 0),
PLL_36XX_RATE(148352005, 98, 2, 3, 59070),
PLL_36XX_RATE(108000000, 144, 2, 4, 0),
- PLL_36XX_RATE( 74250000, 99, 2, 4, 0),
- PLL_36XX_RATE( 74176002, 98, 3, 4, 59070),
- PLL_36XX_RATE( 54054000, 216, 3, 5, 14156),
- PLL_36XX_RATE( 54000000, 144, 2, 5, 0),
+ PLL_36XX_RATE(74250000, 99, 2, 4, 0),
+ PLL_36XX_RATE(74176002, 98, 3, 4, 59070),
+ PLL_36XX_RATE(54054000, 216, 3, 5, 14156),
+ PLL_36XX_RATE(54000000, 144, 2, 5, 0),
{ /* sentinel */ }
};
@@ -1098,4 +1108,3 @@ static int __init exynos3250_cmu_platform_init(void)
exynos3250_cmu_isp_probe);
}
subsys_initcall(exynos3250_cmu_platform_init);
-
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/5] clk: samsung: exynos5260: Fix the checkpatch warnings
2016-08-22 9:48 ` Chanwoo Choi
@ 2016-08-22 9:48 ` Chanwoo Choi
-1 siblings, 0 replies; 14+ messages in thread
From: Chanwoo Choi @ 2016-08-22 9:48 UTC (permalink / raw)
To: s.nawrocki, tomasz.figa
Cc: mturquette, sboyd, kgene, k.kozlowski, chanwoo,
linux-samsung-soc, linux-clk, linux-arm-kernel, linux-kernel,
Chanwoo Choi
This patch removes the the prohibited space by using checkscript.pl script.
- ERROR: space prohibited before that ','
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/clk/samsung/clk-exynos5260.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos5260.c b/drivers/clk/samsung/clk-exynos5260.c
index fd1d9bfc151b..e613b03f1acd 100644
--- a/drivers/clk/samsung/clk-exynos5260.c
+++ b/drivers/clk/samsung/clk-exynos5260.c
@@ -1446,7 +1446,7 @@ static const struct samsung_fixed_rate_clock fixed_rate_clks[] __initconst = {
FRATE(PHYCLK_HDMI_LINK_O_TMDS_CLKHI, "phyclk_hdmi_link_o_tmds_clkhi",
NULL, 0, 125000000),
FRATE(PHYCLK_MIPI_DPHY_4L_M_TXBYTECLKHS,
- "phyclk_mipi_dphy_4l_m_txbyte_clkhs" , NULL,
+ "phyclk_mipi_dphy_4l_m_txbyte_clkhs", NULL,
0, 187500000),
FRATE(PHYCLK_DPTX_PHY_O_REF_CLK_24M, "phyclk_dptx_phy_o_ref_clk_24m",
NULL, 0, 24000000),
@@ -1617,7 +1617,7 @@ static const struct samsung_mux_clock top_mux_clks[] __initconst = {
mout_isp1_media_400_p,
MUX_SEL_TOP_ISP10, 4, 1),
MUX(TOP_MOUT_ACLK_ISP1_400, "mout_aclk_isp1_400", mout_aclk_isp1_400_p,
- MUX_SEL_TOP_ISP10, 8 , 1),
+ MUX_SEL_TOP_ISP10, 8, 1),
MUX(TOP_MOUT_ISP1_MEDIA_266, "mout_isp1_media_266",
mout_isp1_media_266_p,
MUX_SEL_TOP_ISP10, 16, 1),
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/5] clk: samsung: exynos5260: Fix the checkpatch warnings
@ 2016-08-22 9:48 ` Chanwoo Choi
0 siblings, 0 replies; 14+ messages in thread
From: Chanwoo Choi @ 2016-08-22 9:48 UTC (permalink / raw)
To: linux-arm-kernel
This patch removes the the prohibited space by using checkscript.pl script.
- ERROR: space prohibited before that ','
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/clk/samsung/clk-exynos5260.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos5260.c b/drivers/clk/samsung/clk-exynos5260.c
index fd1d9bfc151b..e613b03f1acd 100644
--- a/drivers/clk/samsung/clk-exynos5260.c
+++ b/drivers/clk/samsung/clk-exynos5260.c
@@ -1446,7 +1446,7 @@ static const struct samsung_fixed_rate_clock fixed_rate_clks[] __initconst = {
FRATE(PHYCLK_HDMI_LINK_O_TMDS_CLKHI, "phyclk_hdmi_link_o_tmds_clkhi",
NULL, 0, 125000000),
FRATE(PHYCLK_MIPI_DPHY_4L_M_TXBYTECLKHS,
- "phyclk_mipi_dphy_4l_m_txbyte_clkhs" , NULL,
+ "phyclk_mipi_dphy_4l_m_txbyte_clkhs", NULL,
0, 187500000),
FRATE(PHYCLK_DPTX_PHY_O_REF_CLK_24M, "phyclk_dptx_phy_o_ref_clk_24m",
NULL, 0, 24000000),
@@ -1617,7 +1617,7 @@ static const struct samsung_mux_clock top_mux_clks[] __initconst = {
mout_isp1_media_400_p,
MUX_SEL_TOP_ISP10, 4, 1),
MUX(TOP_MOUT_ACLK_ISP1_400, "mout_aclk_isp1_400", mout_aclk_isp1_400_p,
- MUX_SEL_TOP_ISP10, 8 , 1),
+ MUX_SEL_TOP_ISP10, 8, 1),
MUX(TOP_MOUT_ISP1_MEDIA_266, "mout_isp1_media_266",
mout_isp1_media_266_p,
MUX_SEL_TOP_ISP10, 16, 1),
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 4/5] clk: samsung: exynos5420: Fix the checkpatch warnings
2016-08-22 9:48 ` Chanwoo Choi
@ 2016-08-22 9:48 ` Chanwoo Choi
-1 siblings, 0 replies; 14+ messages in thread
From: Chanwoo Choi @ 2016-08-22 9:48 UTC (permalink / raw)
To: s.nawrocki, tomasz.figa
Cc: mturquette, sboyd, kgene, k.kozlowski, chanwoo,
linux-samsung-soc, linux-clk, linux-arm-kernel, linux-kernel,
Chanwoo Choi
This patch fixes the following warnings by using checkpatch.pl script.
- WARNING: void function return statements are not generally useful
- ERROR: space prohibited before that ','
- ERROR: Use of __initconst requires a separate use of const
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/clk/samsung/clk-exynos5420.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c
index c99d05cd37b7..16b7d160fbdf 100644
--- a/drivers/clk/samsung/clk-exynos5420.c
+++ b/drivers/clk/samsung/clk-exynos5420.c
@@ -336,7 +336,6 @@ err_soc:
kfree(exynos5x_save);
pr_warn("%s: failed to allocate sleep save data, no sleep support!\n",
__func__);
- return;
}
#else
static void __init exynos5420_clk_sleep_init(void) {}
@@ -345,8 +344,8 @@ static void __init exynos5420_clk_sleep_init(void) {}
/* list of all parent clocks */
PNAME(mout_mspll_cpu_p) = {"mout_sclk_cpll", "mout_sclk_dpll",
"mout_sclk_mpll", "mout_sclk_spll"};
-PNAME(mout_cpu_p) = {"mout_apll" , "mout_mspll_cpu"};
-PNAME(mout_kfc_p) = {"mout_kpll" , "mout_mspll_kfc"};
+PNAME(mout_cpu_p) = {"mout_apll", "mout_mspll_cpu"};
+PNAME(mout_kfc_p) = {"mout_kpll", "mout_mspll_kfc"};
PNAME(mout_apll_p) = {"fin_pll", "fout_apll"};
PNAME(mout_bpll_p) = {"fin_pll", "fout_bpll"};
PNAME(mout_cpll_p) = {"fin_pll", "fout_cpll"};
@@ -503,14 +502,12 @@ static const struct samsung_fixed_rate_clock exynos5x_fixed_rate_clks[] __initco
FRATE(0, "sclk_usbh20_scan_clk", NULL, 0, 480000000),
};
-static const struct samsung_fixed_factor_clock
- exynos5x_fixed_factor_clks[] __initconst = {
+static const struct samsung_fixed_factor_clock exynos5x_fixed_factor_clks[] __initconst = {
FFACTOR(0, "ff_hsic_12m", "fin_pll", 1, 2, 0),
FFACTOR(0, "ff_sw_aclk66", "mout_sw_aclk66", 1, 2, 0),
};
-static const struct samsung_fixed_factor_clock
- exynos5800_fixed_factor_clks[] __initconst = {
+static const struct samsung_fixed_factor_clock exynos5800_fixed_factor_clks[] __initconst = {
FFACTOR(0, "ff_dout_epll2", "mout_sclk_epll", 1, 2, 0),
FFACTOR(0, "ff_dout_spll2", "mout_sclk_spll", 1, 2, 0),
};
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 4/5] clk: samsung: exynos5420: Fix the checkpatch warnings
@ 2016-08-22 9:48 ` Chanwoo Choi
0 siblings, 0 replies; 14+ messages in thread
From: Chanwoo Choi @ 2016-08-22 9:48 UTC (permalink / raw)
To: linux-arm-kernel
This patch fixes the following warnings by using checkpatch.pl script.
- WARNING: void function return statements are not generally useful
- ERROR: space prohibited before that ','
- ERROR: Use of __initconst requires a separate use of const
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/clk/samsung/clk-exynos5420.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c
index c99d05cd37b7..16b7d160fbdf 100644
--- a/drivers/clk/samsung/clk-exynos5420.c
+++ b/drivers/clk/samsung/clk-exynos5420.c
@@ -336,7 +336,6 @@ err_soc:
kfree(exynos5x_save);
pr_warn("%s: failed to allocate sleep save data, no sleep support!\n",
__func__);
- return;
}
#else
static void __init exynos5420_clk_sleep_init(void) {}
@@ -345,8 +344,8 @@ static void __init exynos5420_clk_sleep_init(void) {}
/* list of all parent clocks */
PNAME(mout_mspll_cpu_p) = {"mout_sclk_cpll", "mout_sclk_dpll",
"mout_sclk_mpll", "mout_sclk_spll"};
-PNAME(mout_cpu_p) = {"mout_apll" , "mout_mspll_cpu"};
-PNAME(mout_kfc_p) = {"mout_kpll" , "mout_mspll_kfc"};
+PNAME(mout_cpu_p) = {"mout_apll", "mout_mspll_cpu"};
+PNAME(mout_kfc_p) = {"mout_kpll", "mout_mspll_kfc"};
PNAME(mout_apll_p) = {"fin_pll", "fout_apll"};
PNAME(mout_bpll_p) = {"fin_pll", "fout_bpll"};
PNAME(mout_cpll_p) = {"fin_pll", "fout_cpll"};
@@ -503,14 +502,12 @@ static const struct samsung_fixed_rate_clock exynos5x_fixed_rate_clks[] __initco
FRATE(0, "sclk_usbh20_scan_clk", NULL, 0, 480000000),
};
-static const struct samsung_fixed_factor_clock
- exynos5x_fixed_factor_clks[] __initconst = {
+static const struct samsung_fixed_factor_clock exynos5x_fixed_factor_clks[] __initconst = {
FFACTOR(0, "ff_hsic_12m", "fin_pll", 1, 2, 0),
FFACTOR(0, "ff_sw_aclk66", "mout_sw_aclk66", 1, 2, 0),
};
-static const struct samsung_fixed_factor_clock
- exynos5800_fixed_factor_clks[] __initconst = {
+static const struct samsung_fixed_factor_clock exynos5800_fixed_factor_clks[] __initconst = {
FFACTOR(0, "ff_dout_epll2", "mout_sclk_epll", 1, 2, 0),
FFACTOR(0, "ff_dout_spll2", "mout_sclk_spll", 1, 2, 0),
};
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 5/5] clk: samsung: exynos4: Fix the checkpatch warnings
2016-08-22 9:48 ` Chanwoo Choi
@ 2016-08-22 9:48 ` Chanwoo Choi
-1 siblings, 0 replies; 14+ messages in thread
From: Chanwoo Choi @ 2016-08-22 9:48 UTC (permalink / raw)
To: s.nawrocki, tomasz.figa
Cc: mturquette, sboyd, kgene, k.kozlowski, chanwoo,
linux-samsung-soc, linux-clk, linux-arm-kernel, linux-kernel,
Chanwoo Choi
This patch fixes the following warnings by using checkpatch.pl script.
- Remove the space prohibited after that open parenthesis '('
- Remove the unneeded blank line
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/clk/samsung/clk-exynos4.c | 51 +++++++++++++++++++--------------------
1 file changed, 25 insertions(+), 26 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk-exynos4.c
index faab9b31baf5..9809e6d8dadd 100644
--- a/drivers/clk/samsung/clk-exynos4.c
+++ b/drivers/clk/samsung/clk-exynos4.c
@@ -1267,13 +1267,13 @@ static const struct of_device_id ext_clk_match[] __initconst = {
static const struct samsung_pll_rate_table exynos4210_apll_rates[] __initconst = {
PLL_45XX_RATE(1200000000, 150, 3, 1, 28),
PLL_45XX_RATE(1000000000, 250, 6, 1, 28),
- PLL_45XX_RATE( 800000000, 200, 6, 1, 28),
- PLL_45XX_RATE( 666857142, 389, 14, 1, 13),
- PLL_45XX_RATE( 600000000, 100, 4, 1, 13),
- PLL_45XX_RATE( 533000000, 533, 24, 1, 5),
- PLL_45XX_RATE( 500000000, 250, 6, 2, 28),
- PLL_45XX_RATE( 400000000, 200, 6, 2, 28),
- PLL_45XX_RATE( 200000000, 200, 6, 3, 28),
+ PLL_45XX_RATE(800000000, 200, 6, 1, 28),
+ PLL_45XX_RATE(666857142, 389, 14, 1, 13),
+ PLL_45XX_RATE(600000000, 100, 4, 1, 13),
+ PLL_45XX_RATE(533000000, 533, 24, 1, 5),
+ PLL_45XX_RATE(500000000, 250, 6, 2, 28),
+ PLL_45XX_RATE(400000000, 200, 6, 2, 28),
+ PLL_45XX_RATE(200000000, 200, 6, 3, 28),
{ /* sentinel */ }
};
@@ -1281,10 +1281,10 @@ static const struct samsung_pll_rate_table exynos4210_epll_rates[] __initconst =
PLL_4600_RATE(192000000, 48, 3, 1, 0, 0),
PLL_4600_RATE(180633605, 45, 3, 1, 10381, 0),
PLL_4600_RATE(180000000, 45, 3, 1, 0, 0),
- PLL_4600_RATE( 73727996, 73, 3, 3, 47710, 1),
- PLL_4600_RATE( 67737602, 90, 4, 3, 20762, 1),
- PLL_4600_RATE( 49151992, 49, 3, 3, 9961, 0),
- PLL_4600_RATE( 45158401, 45, 3, 3, 10381, 0),
+ PLL_4600_RATE(73727996, 73, 3, 3, 47710, 1),
+ PLL_4600_RATE(67737602, 90, 4, 3, 20762, 1),
+ PLL_4600_RATE(49151992, 49, 3, 3, 9961, 0),
+ PLL_4600_RATE(45158401, 45, 3, 3, 10381, 0),
{ /* sentinel */ }
};
@@ -1293,7 +1293,7 @@ static const struct samsung_pll_rate_table exynos4210_vpll_rates[] __initconst =
PLL_4650_RATE(324000000, 53, 2, 1, 1024, 1, 1, 1),
PLL_4650_RATE(259617187, 63, 3, 1, 1950, 0, 20, 1),
PLL_4650_RATE(110000000, 53, 3, 2, 2048, 0, 17, 0),
- PLL_4650_RATE( 55360351, 53, 3, 3, 2417, 0, 17, 0),
+ PLL_4650_RATE(55360351, 53, 3, 3, 2417, 0, 17, 0),
{ /* sentinel */ }
};
@@ -1304,14 +1304,14 @@ static const struct samsung_pll_rate_table exynos4x12_apll_rates[] __initconst =
PLL_35XX_RATE(1200000000, 200, 4, 0),
PLL_35XX_RATE(1100000000, 275, 6, 0),
PLL_35XX_RATE(1000000000, 125, 3, 0),
- PLL_35XX_RATE( 900000000, 150, 4, 0),
- PLL_35XX_RATE( 800000000, 100, 3, 0),
- PLL_35XX_RATE( 700000000, 175, 3, 1),
- PLL_35XX_RATE( 600000000, 200, 4, 1),
- PLL_35XX_RATE( 500000000, 125, 3, 1),
- PLL_35XX_RATE( 400000000, 100, 3, 1),
- PLL_35XX_RATE( 300000000, 200, 4, 2),
- PLL_35XX_RATE( 200000000, 100, 3, 2),
+ PLL_35XX_RATE(900000000, 150, 4, 0),
+ PLL_35XX_RATE(800000000, 100, 3, 0),
+ PLL_35XX_RATE(700000000, 175, 3, 1),
+ PLL_35XX_RATE(600000000, 200, 4, 1),
+ PLL_35XX_RATE(500000000, 125, 3, 1),
+ PLL_35XX_RATE(400000000, 100, 3, 1),
+ PLL_35XX_RATE(300000000, 200, 4, 2),
+ PLL_35XX_RATE(200000000, 100, 3, 2),
{ /* sentinel */ }
};
@@ -1319,10 +1319,10 @@ static const struct samsung_pll_rate_table exynos4x12_epll_rates[] __initconst =
PLL_36XX_RATE(192000000, 48, 3, 1, 0),
PLL_36XX_RATE(180633605, 45, 3, 1, 10381),
PLL_36XX_RATE(180000000, 45, 3, 1, 0),
- PLL_36XX_RATE( 73727996, 73, 3, 3, 47710),
- PLL_36XX_RATE( 67737602, 90, 4, 3, 20762),
- PLL_36XX_RATE( 49151992, 49, 3, 3, 9961),
- PLL_36XX_RATE( 45158401, 45, 3, 3, 10381),
+ PLL_36XX_RATE(73727996, 73, 3, 3, 47710),
+ PLL_36XX_RATE(67737602, 90, 4, 3, 20762),
+ PLL_36XX_RATE(49151992, 49, 3, 3, 9961),
+ PLL_36XX_RATE(45158401, 45, 3, 3, 10381),
{ /* sentinel */ }
};
@@ -1333,7 +1333,7 @@ static const struct samsung_pll_rate_table exynos4x12_vpll_rates[] __initconst =
PLL_36XX_RATE(266000000, 133, 3, 2, 0),
PLL_36XX_RATE(160000000, 160, 3, 3, 0),
PLL_36XX_RATE(106031250, 53, 3, 2, 1024),
- PLL_36XX_RATE( 53015625, 53, 3, 3, 1024),
+ PLL_36XX_RATE(53015625, 53, 3, 3, 1024),
{ /* sentinel */ }
};
@@ -1559,7 +1559,6 @@ static void __init exynos4_clk_init(struct device_node *np,
_get_rate("div_core2"));
}
-
static void __init exynos4210_clk_init(struct device_node *np)
{
exynos4_clk_init(np, EXYNOS4210);
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 5/5] clk: samsung: exynos4: Fix the checkpatch warnings
@ 2016-08-22 9:48 ` Chanwoo Choi
0 siblings, 0 replies; 14+ messages in thread
From: Chanwoo Choi @ 2016-08-22 9:48 UTC (permalink / raw)
To: linux-arm-kernel
This patch fixes the following warnings by using checkpatch.pl script.
- Remove the space prohibited after that open parenthesis '('
- Remove the unneeded blank line
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/clk/samsung/clk-exynos4.c | 51 +++++++++++++++++++--------------------
1 file changed, 25 insertions(+), 26 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk-exynos4.c
index faab9b31baf5..9809e6d8dadd 100644
--- a/drivers/clk/samsung/clk-exynos4.c
+++ b/drivers/clk/samsung/clk-exynos4.c
@@ -1267,13 +1267,13 @@ static const struct of_device_id ext_clk_match[] __initconst = {
static const struct samsung_pll_rate_table exynos4210_apll_rates[] __initconst = {
PLL_45XX_RATE(1200000000, 150, 3, 1, 28),
PLL_45XX_RATE(1000000000, 250, 6, 1, 28),
- PLL_45XX_RATE( 800000000, 200, 6, 1, 28),
- PLL_45XX_RATE( 666857142, 389, 14, 1, 13),
- PLL_45XX_RATE( 600000000, 100, 4, 1, 13),
- PLL_45XX_RATE( 533000000, 533, 24, 1, 5),
- PLL_45XX_RATE( 500000000, 250, 6, 2, 28),
- PLL_45XX_RATE( 400000000, 200, 6, 2, 28),
- PLL_45XX_RATE( 200000000, 200, 6, 3, 28),
+ PLL_45XX_RATE(800000000, 200, 6, 1, 28),
+ PLL_45XX_RATE(666857142, 389, 14, 1, 13),
+ PLL_45XX_RATE(600000000, 100, 4, 1, 13),
+ PLL_45XX_RATE(533000000, 533, 24, 1, 5),
+ PLL_45XX_RATE(500000000, 250, 6, 2, 28),
+ PLL_45XX_RATE(400000000, 200, 6, 2, 28),
+ PLL_45XX_RATE(200000000, 200, 6, 3, 28),
{ /* sentinel */ }
};
@@ -1281,10 +1281,10 @@ static const struct samsung_pll_rate_table exynos4210_epll_rates[] __initconst =
PLL_4600_RATE(192000000, 48, 3, 1, 0, 0),
PLL_4600_RATE(180633605, 45, 3, 1, 10381, 0),
PLL_4600_RATE(180000000, 45, 3, 1, 0, 0),
- PLL_4600_RATE( 73727996, 73, 3, 3, 47710, 1),
- PLL_4600_RATE( 67737602, 90, 4, 3, 20762, 1),
- PLL_4600_RATE( 49151992, 49, 3, 3, 9961, 0),
- PLL_4600_RATE( 45158401, 45, 3, 3, 10381, 0),
+ PLL_4600_RATE(73727996, 73, 3, 3, 47710, 1),
+ PLL_4600_RATE(67737602, 90, 4, 3, 20762, 1),
+ PLL_4600_RATE(49151992, 49, 3, 3, 9961, 0),
+ PLL_4600_RATE(45158401, 45, 3, 3, 10381, 0),
{ /* sentinel */ }
};
@@ -1293,7 +1293,7 @@ static const struct samsung_pll_rate_table exynos4210_vpll_rates[] __initconst =
PLL_4650_RATE(324000000, 53, 2, 1, 1024, 1, 1, 1),
PLL_4650_RATE(259617187, 63, 3, 1, 1950, 0, 20, 1),
PLL_4650_RATE(110000000, 53, 3, 2, 2048, 0, 17, 0),
- PLL_4650_RATE( 55360351, 53, 3, 3, 2417, 0, 17, 0),
+ PLL_4650_RATE(55360351, 53, 3, 3, 2417, 0, 17, 0),
{ /* sentinel */ }
};
@@ -1304,14 +1304,14 @@ static const struct samsung_pll_rate_table exynos4x12_apll_rates[] __initconst =
PLL_35XX_RATE(1200000000, 200, 4, 0),
PLL_35XX_RATE(1100000000, 275, 6, 0),
PLL_35XX_RATE(1000000000, 125, 3, 0),
- PLL_35XX_RATE( 900000000, 150, 4, 0),
- PLL_35XX_RATE( 800000000, 100, 3, 0),
- PLL_35XX_RATE( 700000000, 175, 3, 1),
- PLL_35XX_RATE( 600000000, 200, 4, 1),
- PLL_35XX_RATE( 500000000, 125, 3, 1),
- PLL_35XX_RATE( 400000000, 100, 3, 1),
- PLL_35XX_RATE( 300000000, 200, 4, 2),
- PLL_35XX_RATE( 200000000, 100, 3, 2),
+ PLL_35XX_RATE(900000000, 150, 4, 0),
+ PLL_35XX_RATE(800000000, 100, 3, 0),
+ PLL_35XX_RATE(700000000, 175, 3, 1),
+ PLL_35XX_RATE(600000000, 200, 4, 1),
+ PLL_35XX_RATE(500000000, 125, 3, 1),
+ PLL_35XX_RATE(400000000, 100, 3, 1),
+ PLL_35XX_RATE(300000000, 200, 4, 2),
+ PLL_35XX_RATE(200000000, 100, 3, 2),
{ /* sentinel */ }
};
@@ -1319,10 +1319,10 @@ static const struct samsung_pll_rate_table exynos4x12_epll_rates[] __initconst =
PLL_36XX_RATE(192000000, 48, 3, 1, 0),
PLL_36XX_RATE(180633605, 45, 3, 1, 10381),
PLL_36XX_RATE(180000000, 45, 3, 1, 0),
- PLL_36XX_RATE( 73727996, 73, 3, 3, 47710),
- PLL_36XX_RATE( 67737602, 90, 4, 3, 20762),
- PLL_36XX_RATE( 49151992, 49, 3, 3, 9961),
- PLL_36XX_RATE( 45158401, 45, 3, 3, 10381),
+ PLL_36XX_RATE(73727996, 73, 3, 3, 47710),
+ PLL_36XX_RATE(67737602, 90, 4, 3, 20762),
+ PLL_36XX_RATE(49151992, 49, 3, 3, 9961),
+ PLL_36XX_RATE(45158401, 45, 3, 3, 10381),
{ /* sentinel */ }
};
@@ -1333,7 +1333,7 @@ static const struct samsung_pll_rate_table exynos4x12_vpll_rates[] __initconst =
PLL_36XX_RATE(266000000, 133, 3, 2, 0),
PLL_36XX_RATE(160000000, 160, 3, 3, 0),
PLL_36XX_RATE(106031250, 53, 3, 2, 1024),
- PLL_36XX_RATE( 53015625, 53, 3, 3, 1024),
+ PLL_36XX_RATE(53015625, 53, 3, 3, 1024),
{ /* sentinel */ }
};
@@ -1559,7 +1559,6 @@ static void __init exynos4_clk_init(struct device_node *np,
_get_rate("div_core2"));
}
-
static void __init exynos4210_clk_init(struct device_node *np)
{
exynos4_clk_init(np, EXYNOS4210);
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 0/5] clk: samsung: exynos: Fix the checkpatch warnings
2016-08-22 9:48 ` Chanwoo Choi
@ 2016-08-22 10:06 ` Sylwester Nawrocki
-1 siblings, 0 replies; 14+ messages in thread
From: Sylwester Nawrocki @ 2016-08-22 10:06 UTC (permalink / raw)
To: Chanwoo Choi
Cc: tomasz.figa, mturquette, sboyd, kgene, k.kozlowski, chanwoo,
linux-samsung-soc, linux-clk, linux-arm-kernel, linux-kernel
Hi Chanwoo,
On 08/22/2016 11:48 AM, Chanwoo Choi wrote:
> This patches just fix the checkpatch warnings for exynos5433/3250/5260/5420/4
> series without the behavior changes.
>
> Chanwoo Choi (5):
> clk: samsung: exynos5433: Fix the checkpatch warnings
> clk: samsung: exynos3250: Fix the checkpatch warnings
> clk: samsung: exynos5260: Fix the checkpatch warnings
> clk: samsung: exynos5420: Fix the checkpatch warnings
> clk: samsung: exynos4: Fix the checkpatch warnings
>
> drivers/clk/samsung/clk-exynos3250.c | 97 ++++++++++++++++++++----------------
> drivers/clk/samsung/clk-exynos4.c | 51 ++++++++++---------
> drivers/clk/samsung/clk-exynos5260.c | 4 +-
> drivers/clk/samsung/clk-exynos5420.c | 11 ++--
> drivers/clk/samsung/clk-exynos5433.c | 6 ++-
> 5 files changed, 88 insertions(+), 81 deletions(-)
Sorry, but I have to NAK this whole series. It's just an unnecessary
churn and will cause problems when applying real development patches
that are being worked on.
--
Thanks,
Sylwester
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 0/5] clk: samsung: exynos: Fix the checkpatch warnings
@ 2016-08-22 10:06 ` Sylwester Nawrocki
0 siblings, 0 replies; 14+ messages in thread
From: Sylwester Nawrocki @ 2016-08-22 10:06 UTC (permalink / raw)
To: linux-arm-kernel
Hi Chanwoo,
On 08/22/2016 11:48 AM, Chanwoo Choi wrote:
> This patches just fix the checkpatch warnings for exynos5433/3250/5260/5420/4
> series without the behavior changes.
>
> Chanwoo Choi (5):
> clk: samsung: exynos5433: Fix the checkpatch warnings
> clk: samsung: exynos3250: Fix the checkpatch warnings
> clk: samsung: exynos5260: Fix the checkpatch warnings
> clk: samsung: exynos5420: Fix the checkpatch warnings
> clk: samsung: exynos4: Fix the checkpatch warnings
>
> drivers/clk/samsung/clk-exynos3250.c | 97 ++++++++++++++++++++----------------
> drivers/clk/samsung/clk-exynos4.c | 51 ++++++++++---------
> drivers/clk/samsung/clk-exynos5260.c | 4 +-
> drivers/clk/samsung/clk-exynos5420.c | 11 ++--
> drivers/clk/samsung/clk-exynos5433.c | 6 ++-
> 5 files changed, 88 insertions(+), 81 deletions(-)
Sorry, but I have to NAK this whole series. It's just an unnecessary
churn and will cause problems when applying real development patches
that are being worked on.
--
Thanks,
Sylwester
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2016-08-22 10:06 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-22 9:48 [PATCH 0/5] clk: samsung: exynos: Fix the checkpatch warnings Chanwoo Choi
2016-08-22 9:48 ` Chanwoo Choi
2016-08-22 9:48 ` [PATCH 1/5] clk: samsung: exynos5433: " Chanwoo Choi
2016-08-22 9:48 ` Chanwoo Choi
2016-08-22 9:48 ` [PATCH 2/5] clk: samsung: exynos3250: " Chanwoo Choi
2016-08-22 9:48 ` Chanwoo Choi
2016-08-22 9:48 ` [PATCH 3/5] clk: samsung: exynos5260: " Chanwoo Choi
2016-08-22 9:48 ` Chanwoo Choi
2016-08-22 9:48 ` [PATCH 4/5] clk: samsung: exynos5420: " Chanwoo Choi
2016-08-22 9:48 ` Chanwoo Choi
2016-08-22 9:48 ` [PATCH 5/5] clk: samsung: exynos4: " Chanwoo Choi
2016-08-22 9:48 ` Chanwoo Choi
2016-08-22 10:06 ` [PATCH 0/5] clk: samsung: exynos: " Sylwester Nawrocki
2016-08-22 10:06 ` Sylwester Nawrocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.