All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/skl: Set dirty_pipes to active_crtcs, not ~0
@ 2016-08-22 16:52 ` Lyude
  0 siblings, 0 replies; 3+ messages in thread
From: Lyude @ 2016-08-22 16:52 UTC (permalink / raw)
  To: Maarten Lankhorst, intel-gfx
  Cc: Lyude, Daniel Vetter, Jani Nikula, David Airlie, dri-devel, linux-kernel

Using intel_state->active_crtcs allows us to more easily check whether
or not we've updated all of the CRTCs that needed ddb updates since we
can just do:

	mask_of_crtcs_we_updated == intel_state->wm_results.dirty_pipes

Signed-off-by: Lyude <cpaul@redhat.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 2f4438d..f4fe942 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -4117,7 +4117,7 @@ skl_compute_ddb(struct drm_atomic_state *state)
 	 */
 	if (intel_state->active_pipe_changes) {
 		realloc_pipes = ~0;
-		intel_state->wm_results.dirty_pipes = ~0;
+		intel_state->wm_results.dirty_pipes = intel_state->active_crtcs;
 	}
 
 	for_each_intel_crtc_mask(dev, intel_crtc, realloc_pipes) {
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH] drm/i915/skl: Set dirty_pipes to active_crtcs, not ~0
@ 2016-08-22 16:52 ` Lyude
  0 siblings, 0 replies; 3+ messages in thread
From: Lyude @ 2016-08-22 16:52 UTC (permalink / raw)
  To: Maarten Lankhorst, intel-gfx
  Cc: linux-kernel, dri-devel, Daniel Vetter, Lyude

Using intel_state->active_crtcs allows us to more easily check whether
or not we've updated all of the CRTCs that needed ddb updates since we
can just do:

	mask_of_crtcs_we_updated == intel_state->wm_results.dirty_pipes

Signed-off-by: Lyude <cpaul@redhat.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 2f4438d..f4fe942 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -4117,7 +4117,7 @@ skl_compute_ddb(struct drm_atomic_state *state)
 	 */
 	if (intel_state->active_pipe_changes) {
 		realloc_pipes = ~0;
-		intel_state->wm_results.dirty_pipes = ~0;
+		intel_state->wm_results.dirty_pipes = intel_state->active_crtcs;
 	}
 
 	for_each_intel_crtc_mask(dev, intel_crtc, realloc_pipes) {
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* ✗ Ro.CI.BAT: failure for drm/i915/skl: Set dirty_pipes to active_crtcs, not ~0
  2016-08-22 16:52 ` Lyude
  (?)
@ 2016-08-23  5:45 ` Patchwork
  -1 siblings, 0 replies; 3+ messages in thread
From: Patchwork @ 2016-08-23  5:45 UTC (permalink / raw)
  To: cpaul; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/skl: Set dirty_pipes to active_crtcs, not ~0
URL   : https://patchwork.freedesktop.org/series/11425/
State : failure

== Summary ==

Series 11425v1 drm/i915/skl: Set dirty_pipes to active_crtcs, not ~0
http://patchwork.freedesktop.org/api/1.0/series/11425/revisions/1/mbox

Test drv_module_reload_basic:
                pass       -> SKIP       (ro-hsw-i3-4010u)
Test gem_exec_suspend:
        Subgroup basic-s3:
                dmesg-warn -> PASS       (ro-bdw-i7-5600u)
Test kms_cursor_legacy:
        Subgroup basic-flip-vs-cursor-varying-size:
                pass       -> FAIL       (fi-hsw-i7-4770k)
                pass       -> FAIL       (ro-bdw-i5-5250u)
                fail       -> PASS       (ro-skl3-i5-6260u)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                pass       -> DMESG-WARN (ro-bdw-i7-5600u)
        Subgroup suspend-read-crc-pipe-c:
                skip       -> DMESG-WARN (ro-bdw-i5-5250u)
Test prime_vgem:
        Subgroup basic-fence-flip:
                dmesg-warn -> PASS       (fi-hsw-i7-4770k)

fi-hsw-i7-4770k  total:249  pass:219  dwarn:6   dfail:0   fail:2   skip:22 
fi-kbl-qkkr      total:249  pass:189  dwarn:30  dfail:0   fail:3   skip:27 
fi-skl-i7-6700k  total:249  pass:214  dwarn:4   dfail:2   fail:1   skip:28 
fi-snb-i7-2600   total:249  pass:202  dwarn:4   dfail:0   fail:1   skip:42 
ro-bdw-i5-5250u  total:240  pass:218  dwarn:5   dfail:0   fail:1   skip:16 
ro-bdw-i7-5557U  total:240  pass:218  dwarn:3   dfail:0   fail:0   skip:19 
ro-bdw-i7-5600u  total:240  pass:205  dwarn:1   dfail:0   fail:2   skip:32 
ro-bsw-n3050     total:240  pass:195  dwarn:0   dfail:0   fail:3   skip:42 
ro-byt-n2820     total:240  pass:196  dwarn:0   dfail:0   fail:4   skip:40 
ro-hsw-i3-4010u  total:240  pass:212  dwarn:0   dfail:0   fail:1   skip:27 
ro-hsw-i7-4770r  total:240  pass:185  dwarn:0   dfail:0   fail:0   skip:55 
ro-ilk1-i5-650   total:235  pass:174  dwarn:0   dfail:0   fail:2   skip:59 
ro-ivb2-i7-3770  total:240  pass:208  dwarn:0   dfail:0   fail:1   skip:31 
ro-skl3-i5-6260u total:240  pass:225  dwarn:0   dfail:0   fail:1   skip:14 

Results at /archive/results/CI_IGT_test/RO_Patchwork_1967/

f1707bb drm-intel-nightly: 2016y-08m-22d-17h-43m-22s UTC integration manifest
2e57143 drm/i915/skl: Set dirty_pipes to active_crtcs, not ~0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-23  5:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-22 16:52 [PATCH] drm/i915/skl: Set dirty_pipes to active_crtcs, not ~0 Lyude
2016-08-22 16:52 ` Lyude
2016-08-23  5:45 ` ✗ Ro.CI.BAT: failure for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.