* [PATCH -next] net: dsa: bcm_sf2: Remove redundant dev_err call in bcm_sf2_sw_probe()
@ 2016-08-23 15:09 Wei Yongjun
2016-08-23 16:12 ` kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-08-23 15:09 UTC (permalink / raw)
To: David S . Miller, Florian Fainelli, Vivien Didelot, Andrew Lunn,
Jiri Pirko
Cc: Wei Yongjun, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/dsa/bcm_sf2.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c
index 8e6fe13..3952302 100644
--- a/drivers/net/dsa/bcm_sf2.c
+++ b/drivers/net/dsa/bcm_sf2.c
@@ -1643,10 +1643,8 @@ static int bcm_sf2_sw_probe(struct platform_device *pdev)
for (i = 0; i < BCM_SF2_REGS_NUM; i++) {
r = platform_get_resource(pdev, IORESOURCE_MEM, i);
*base = devm_ioremap_resource(&pdev->dev, r);
- if (IS_ERR(*base)) {
- pr_err("unable to find register: %s\n", reg_names[i]);
+ if (IS_ERR(*base))
return PTR_ERR(*base);
- }
base++;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: dsa: bcm_sf2: Remove redundant dev_err call in bcm_sf2_sw_probe()
2016-08-23 15:09 [PATCH -next] net: dsa: bcm_sf2: Remove redundant dev_err call in bcm_sf2_sw_probe() Wei Yongjun
@ 2016-08-23 16:12 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2016-08-23 16:12 UTC (permalink / raw)
To: Wei Yongjun
Cc: kbuild-all, David S . Miller, Florian Fainelli, Vivien Didelot,
Andrew Lunn, Jiri Pirko, Wei Yongjun, netdev
[-- Attachment #1: Type: text/plain, Size: 3250 bytes --]
Hi Wei,
[auto build test WARNING on next-20160823]
url: https://github.com/0day-ci/linux/commits/Wei-Yongjun/net-dsa-bcm_sf2-Remove-redundant-dev_err-call-in-bcm_sf2_sw_probe/20160823-233314
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sparc64
All warnings (new ones prefixed by >>):
drivers/net/dsa/bcm_sf2.c: In function 'bcm_sf2_sw_probe':
>> drivers/net/dsa/bcm_sf2.c:1613:14: warning: unused variable 'reg_names' [-Wunused-variable]
const char *reg_names[BCM_SF2_REGS_NUM] = BCM_SF2_REGS_NAME;
^
vim +/reg_names +1613 drivers/net/dsa/bcm_sf2.c
d9338023 Florian Fainelli 2016-08-18 1597 .port_bridge_join = bcm_sf2_sw_br_join,
d9338023 Florian Fainelli 2016-08-18 1598 .port_bridge_leave = bcm_sf2_sw_br_leave,
d9338023 Florian Fainelli 2016-08-18 1599 .port_stp_state_set = bcm_sf2_sw_br_set_stp_state,
d9338023 Florian Fainelli 2016-08-18 1600 .port_fdb_prepare = bcm_sf2_sw_fdb_prepare,
d9338023 Florian Fainelli 2016-08-18 1601 .port_fdb_add = bcm_sf2_sw_fdb_add,
d9338023 Florian Fainelli 2016-08-18 1602 .port_fdb_del = bcm_sf2_sw_fdb_del,
d9338023 Florian Fainelli 2016-08-18 1603 .port_fdb_dump = bcm_sf2_sw_fdb_dump,
d9338023 Florian Fainelli 2016-08-18 1604 .port_vlan_filtering = bcm_sf2_sw_vlan_filtering,
d9338023 Florian Fainelli 2016-08-18 1605 .port_vlan_prepare = bcm_sf2_sw_vlan_prepare,
d9338023 Florian Fainelli 2016-08-18 1606 .port_vlan_add = bcm_sf2_sw_vlan_add,
d9338023 Florian Fainelli 2016-08-18 1607 .port_vlan_del = bcm_sf2_sw_vlan_del,
d9338023 Florian Fainelli 2016-08-18 1608 .port_vlan_dump = bcm_sf2_sw_vlan_dump,
d9338023 Florian Fainelli 2016-08-18 1609 };
d9338023 Florian Fainelli 2016-08-18 1610
d9338023 Florian Fainelli 2016-08-18 1611 static int bcm_sf2_sw_probe(struct platform_device *pdev)
d9338023 Florian Fainelli 2016-08-18 1612 {
d9338023 Florian Fainelli 2016-08-18 @1613 const char *reg_names[BCM_SF2_REGS_NUM] = BCM_SF2_REGS_NAME;
d9338023 Florian Fainelli 2016-08-18 1614 struct device_node *dn = pdev->dev.of_node;
d9338023 Florian Fainelli 2016-08-18 1615 struct bcm_sf2_priv *priv;
d9338023 Florian Fainelli 2016-08-18 1616 struct dsa_switch *ds;
d9338023 Florian Fainelli 2016-08-18 1617 void __iomem **base;
4bd11675 Florian Fainelli 2016-08-18 1618 struct resource *r;
7fbb1a92 Florian Fainelli 2016-06-09 1619 unsigned int i;
7fbb1a92 Florian Fainelli 2016-06-09 1620 u32 reg, rev;
7fbb1a92 Florian Fainelli 2016-06-09 1621 int ret;
:::::: The code at line 1613 was first introduced by commit
:::::: d9338023fb8e60aa09014034a993f8ddc86c65fa net: dsa: bcm_sf2: Make it a real platform device driver
:::::: TO: Florian Fainelli <f.fainelli@gmail.com>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 47221 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-23 16:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-23 15:09 [PATCH -next] net: dsa: bcm_sf2: Remove redundant dev_err call in bcm_sf2_sw_probe() Wei Yongjun
2016-08-23 16:12 ` kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.