All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 0/2] RFC: Detect and reject new ad-hoc CONFIG options
Date: Wed, 24 Aug 2016 08:44:12 -0600	[thread overview]
Message-ID: <1472049854-4891-1-git-send-email-sjg@chromium.org> (raw)

Despite the availability of Kconfig, the number of ad-hoc CONFIG options in
U-Boot is still at over 8000.

In February 2015 (commit 741e58e0) there were around 8387 ad-hoc CONFIGs.
As of this patch there are about 8336, only a little fewer.

One problem is that new ones are still being added, admittedly at a slower
rate. This series adds a Makefile check to detect that and produce a build
error. This provides immediate feedback that new CONFIG options should go in
Kconfig.

NOTE: This series needs work since there are some existing CONFIG options
that are not included in the whitelist. Assuming that the approach makes
sense, I will tweak my scripts to sort this out.


Simon Glass (2):
  Kconfig: Add a whitelist of ad-hoc CONFIG options
  Makefile: Give a build error if ad-hoc CONFIG options are added

 Makefile                     |   10 +-
 scripts/check-config.sh      |   55 +
 scripts/config_whitelist.txt | 9035 ++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 9099 insertions(+), 1 deletion(-)
 create mode 100755 scripts/check-config.sh
 create mode 100644 scripts/config_whitelist.txt

-- 
2.8.0.rc3.226.g39d4020

             reply	other threads:[~2016-08-24 14:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24 14:44 Simon Glass [this message]
2016-08-24 14:44 ` [U-Boot] [RFC PATCH 1/2] Kconfig: Add a whitelist of ad-hoc CONFIG options Simon Glass
2016-08-24 16:16   ` Stephen Warren
2016-08-24 14:44 ` [U-Boot] [RFC PATCH 2/2] Makefile: Give a build error if ad-hoc CONFIG options are added Simon Glass
2016-08-24 16:24   ` Stephen Warren
2016-08-25 12:04     ` Simon Glass
2016-08-29 19:38     ` Simon Glass
2016-09-12  4:19     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472049854-4891-1-git-send-email-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.