All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 2/2] Makefile: Give a build error if ad-hoc CONFIG options are added
Date: Sun, 11 Sep 2016 22:19:55 -0600	[thread overview]
Message-ID: <CAPnjgZ3HLZ1mWWcLEf-BTvujX7kmuCQRVjT3q-mvpL-xqgsiiA@mail.gmail.com> (raw)
In-Reply-To: <169169d2-61fc-cec2-7d02-87e7e5c6c99d@wwwdotorg.org>

Hi Stephen,

On 24 August 2016 at 10:24, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 08/24/2016 08:44 AM, Simon Glass wrote:
>>
>> New CONFIG options should be added via Kconfig. To help prevent new ad-hoc
>> CONFIGs from being added, give a build error when these are detected.
>
>
> Acked-by: Stephen Warren <swarren@nvidia.com>
> Tested-by: Stephen Warren <swarren@nvidia.com>
>
> I worried about the increased build time due to find/grep on all Kconfig
> files, but at least with a hot disk cache it seems to make no noticeable
> difference:-)

Yes it was pretty slow at first, but I fiddled with it to sort that.

The current approach is based on files that are already generated by
the build. There is a very small overhead but it is small enough that
I cannot reliably measure it.

[...]

Regards,
Simon

      parent reply	other threads:[~2016-09-12  4:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24 14:44 [U-Boot] [RFC PATCH 0/2] RFC: Detect and reject new ad-hoc CONFIG options Simon Glass
2016-08-24 14:44 ` [U-Boot] [RFC PATCH 1/2] Kconfig: Add a whitelist of " Simon Glass
2016-08-24 16:16   ` Stephen Warren
2016-08-24 14:44 ` [U-Boot] [RFC PATCH 2/2] Makefile: Give a build error if ad-hoc CONFIG options are added Simon Glass
2016-08-24 16:24   ` Stephen Warren
2016-08-25 12:04     ` Simon Glass
2016-08-29 19:38     ` Simon Glass
2016-09-12  4:19     ` Simon Glass [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ3HLZ1mWWcLEf-BTvujX7kmuCQRVjT3q-mvpL-xqgsiiA@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.