From: Sascha Silbe <silbe@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org, Fam Zheng <famz@redhat.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PATCH v2 3/7] docker: debian-bootstrap.pre: print helpful message if DEB_ARCH/DEB_TYPE unset
Date: Wed, 24 Aug 2016 20:30:59 +0200 [thread overview]
Message-ID: <1472063464-790-4-git-send-email-silbe@linux.vnet.ibm.com> (raw)
In-Reply-To: <1472063464-790-1-git-send-email-silbe@linux.vnet.ibm.com>
The debian-bootstrap image doesn't choose a default architecture and
distribution version, instead the user has to set both DEB_ARCH and
DEB_TYPE in the environment. Print a reasonably helpful message if
either of them isn't set instead of complaining about "qemu-" being
missing or erroring out because we cannot cd to the mirror URL.
Signed-off-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
---
tests/docker/dockerfiles/debian-bootstrap.pre | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/tests/docker/dockerfiles/debian-bootstrap.pre b/tests/docker/dockerfiles/debian-bootstrap.pre
index 5d9c8d5..2ae363f 100755
--- a/tests/docker/dockerfiles/debian-bootstrap.pre
+++ b/tests/docker/dockerfiles/debian-bootstrap.pre
@@ -15,6 +15,19 @@ exit_and_skip()
if [ -z $FAKEROOT ]; then
echo "Please install fakeroot to enable bootstraping"
exit_and_skip
+
+fi
+
+if [ -z "${DEB_ARCH}" ]; then
+ echo "Please set DEB_ARCH to choose an architecture (e.g. armhf)"
+ exit_and_skip
+
+fi
+
+if [ -z "${DEB_TYPE}" ]; then
+ echo "Please set DEB_TYPE to a Debian archive name (e.g. testing)"
+ exit_and_skip
+
fi
# We check in order for
--
1.9.1
next prev parent reply other threads:[~2016-08-24 18:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 18:30 [Qemu-devel] [PATCH v2 0/7] docker tests fixes Sascha Silbe
2016-08-24 18:30 ` [Qemu-devel] [PATCH v2 1/7] docker.py: don't hang on large docker output Sascha Silbe
2016-09-06 1:30 ` Fam Zheng
2016-09-06 18:31 ` Sascha Silbe
2016-09-07 1:53 ` Fam Zheng
2016-09-07 1:59 ` Eric Blake
2016-08-24 18:30 ` [Qemu-devel] [PATCH v2 2/7] docker: avoid dependency on 'realpath' package Sascha Silbe
2016-08-24 18:30 ` Sascha Silbe [this message]
2016-09-06 1:47 ` [Qemu-devel] [PATCH v2 3/7] docker: debian-bootstrap.pre: print helpful message if DEB_ARCH/DEB_TYPE unset Fam Zheng
2016-09-06 18:45 ` Sascha Silbe
2016-08-24 18:31 ` [Qemu-devel] [PATCH v2 4/7] docker: print warning if EXECUTABLE is not set when building debootstrap image Sascha Silbe
2016-08-24 18:31 ` [Qemu-devel] [PATCH v2 5/7] docker: make sure debootstrap is at least 1.0.67 Sascha Silbe
2016-09-06 1:43 ` Fam Zheng
2016-09-06 18:54 ` Sascha Silbe
2016-08-24 18:31 ` [Qemu-devel] [PATCH v2 6/7] docker: build debootstrap after cloning Sascha Silbe
2016-08-24 18:31 ` [Qemu-devel] [PATCH v2 7/7] docker: silence debootstrap when --quiet is given Sascha Silbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472063464-790-4-git-send-email-silbe@linux.vnet.ibm.com \
--to=silbe@linux.vnet.ibm.com \
--cc=alex.bennee@linaro.org \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.