From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>, Sascha Silbe <silbe@linux.vnet.ibm.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/7] docker.py: don't hang on large docker output
Date: Tue, 6 Sep 2016 20:59:27 -0500 [thread overview]
Message-ID: <9a5028af-9009-5009-0efc-a12c60f162ae@redhat.com> (raw)
In-Reply-To: <20160907015336.GB30281@lemon>
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
On 09/06/2016 08:53 PM, Fam Zheng wrote:
>>>
>>> Too many blank lines? Otherwise looks good.
>>
>> You caught me sneaking in a PEP-8 compliance fix. ;)
>
> Ah, no problem. I just didn't know.
>
>>
>> Is qemu using a custom code style for Python sources? If so, is it
>> documented somewhere?
>
> No, and following PEP-8 is completely fine.
Although it never hurts to mention stuff like this in the commit
message, to make it obvious that it was intentional :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-09-07 1:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 18:30 [Qemu-devel] [PATCH v2 0/7] docker tests fixes Sascha Silbe
2016-08-24 18:30 ` [Qemu-devel] [PATCH v2 1/7] docker.py: don't hang on large docker output Sascha Silbe
2016-09-06 1:30 ` Fam Zheng
2016-09-06 18:31 ` Sascha Silbe
2016-09-07 1:53 ` Fam Zheng
2016-09-07 1:59 ` Eric Blake [this message]
2016-08-24 18:30 ` [Qemu-devel] [PATCH v2 2/7] docker: avoid dependency on 'realpath' package Sascha Silbe
2016-08-24 18:30 ` [Qemu-devel] [PATCH v2 3/7] docker: debian-bootstrap.pre: print helpful message if DEB_ARCH/DEB_TYPE unset Sascha Silbe
2016-09-06 1:47 ` Fam Zheng
2016-09-06 18:45 ` Sascha Silbe
2016-08-24 18:31 ` [Qemu-devel] [PATCH v2 4/7] docker: print warning if EXECUTABLE is not set when building debootstrap image Sascha Silbe
2016-08-24 18:31 ` [Qemu-devel] [PATCH v2 5/7] docker: make sure debootstrap is at least 1.0.67 Sascha Silbe
2016-09-06 1:43 ` Fam Zheng
2016-09-06 18:54 ` Sascha Silbe
2016-08-24 18:31 ` [Qemu-devel] [PATCH v2 6/7] docker: build debootstrap after cloning Sascha Silbe
2016-08-24 18:31 ` [Qemu-devel] [PATCH v2 7/7] docker: silence debootstrap when --quiet is given Sascha Silbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a5028af-9009-5009-0efc-a12c60f162ae@redhat.com \
--to=eblake@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=silbe@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.