From: Zach Brown <zach.brown@ni.com> To: adrian.hunter@intel.com Cc: robh+dt@kernel.org, ulf.hansson@linaro.org, mark.rutland@arm.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, linux-arm-kernel@lists.infradead.org, zach.brown@ni.com Subject: [PATCH v2 1/2] sdhci-of-arasan: Modify arasan sdhci documentation about broken-cd and non-removable properties. Date: Thu, 25 Aug 2016 18:01:50 -0500 [thread overview] Message-ID: <1472166111-28872-1-git-send-email-zach.brown@ni.com> (raw) The sdhci controller on xilinx zynq devices will not function unless the CD bit is provided. http://www.xilinx.com/support/answers/61064.html In cases where it is impossible to provide the CD bit in hardware, setting the controller to test mode and then setting inserted to true will get the controller to function without the CD bit. Additionally in some situations it will make sense to use the "broken-cd" and "non-removable" property together. i.e the sd device is non-removable so polling doesn't make sense, but the CD is broken and the controller will need to be in test mode to function. This patch modifies the documentation to reflect those differences from the standard behaviours. Signed-off-by: Zach Brown <zach.brown@ni.com> --- v2: * improved commit messages * removed fake-cd device property * removed fake-cd quirk * use broken-cd device property * documented new usage of broken-cd Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt index 3404afa..b41c448 100644 --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt @@ -37,6 +37,14 @@ Optional Properties: in place we will export a clock representing the Card Clock. This clock is expected to be consumed by our PHY. You must also specify +Card detection: +The arasan controller does not work +when the CD bit is not supplied unless in test mode. +- broken-cd: The CD bit is not supplied and the controller will + need to be set to test mode to function. +- non-removable: like normal, except it can now be partnered with + broken-cd, which will turn off polling, but keep test mode on. + Example: sdhci@e0100000 { compatible = "arasan,sdhci-8.9a"; @@ -72,4 +80,4 @@ Example: phy-names = "phy_arasan"; #clock-cells = <0>; status = "disabled"; - }; + } ; -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: zach.brown@ni.com (Zach Brown) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/2] sdhci-of-arasan: Modify arasan sdhci documentation about broken-cd and non-removable properties. Date: Thu, 25 Aug 2016 18:01:50 -0500 [thread overview] Message-ID: <1472166111-28872-1-git-send-email-zach.brown@ni.com> (raw) The sdhci controller on xilinx zynq devices will not function unless the CD bit is provided. http://www.xilinx.com/support/answers/61064.html In cases where it is impossible to provide the CD bit in hardware, setting the controller to test mode and then setting inserted to true will get the controller to function without the CD bit. Additionally in some situations it will make sense to use the "broken-cd" and "non-removable" property together. i.e the sd device is non-removable so polling doesn't make sense, but the CD is broken and the controller will need to be in test mode to function. This patch modifies the documentation to reflect those differences from the standard behaviours. Signed-off-by: Zach Brown <zach.brown@ni.com> --- v2: * improved commit messages * removed fake-cd device property * removed fake-cd quirk * use broken-cd device property * documented new usage of broken-cd Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt index 3404afa..b41c448 100644 --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt @@ -37,6 +37,14 @@ Optional Properties: in place we will export a clock representing the Card Clock. This clock is expected to be consumed by our PHY. You must also specify +Card detection: +The arasan controller does not work +when the CD bit is not supplied unless in test mode. +- broken-cd: The CD bit is not supplied and the controller will + need to be set to test mode to function. +- non-removable: like normal, except it can now be partnered with + broken-cd, which will turn off polling, but keep test mode on. + Example: sdhci at e0100000 { compatible = "arasan,sdhci-8.9a"; @@ -72,4 +80,4 @@ Example: phy-names = "phy_arasan"; #clock-cells = <0>; status = "disabled"; - }; + } ; -- 2.7.4
next reply other threads:[~2016-08-25 23:02 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-25 23:01 Zach Brown [this message] 2016-08-25 23:01 ` [PATCH v2 1/2] sdhci-of-arasan: Modify arasan sdhci documentation about broken-cd and non-removable properties Zach Brown 2016-08-25 23:01 ` [PATCH v2 2/2] sdhci-of-arasan: Set controller to test mode when Card Detection is broken Zach Brown 2016-08-25 23:01 ` Zach Brown 2016-08-25 23:01 ` Zach Brown 2016-08-26 8:42 ` Mike Looijmans 2016-08-26 8:42 ` Mike Looijmans 2016-08-26 8:42 ` Mike Looijmans 2016-08-26 9:50 ` Shawn Lin 2016-08-26 9:50 ` Shawn Lin 2016-08-26 9:50 ` Shawn Lin 2016-08-26 7:19 ` [PATCH v2 1/2] sdhci-of-arasan: Modify arasan sdhci documentation about broken-cd and non-removable properties Michal Simek 2016-08-26 7:19 ` Michal Simek 2016-08-26 7:19 ` Michal Simek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1472166111-28872-1-git-send-email-zach.brown@ni.com \ --to=zach.brown@ni.com \ --cc=adrian.hunter@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=michal.simek@xilinx.com \ --cc=robh+dt@kernel.org \ --cc=soren.brinkmann@xilinx.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.