* [PATCH] ASoC: arizona: Don't change the FLLn_GAIN before entering FREERUN
@ 2016-08-30 9:30 Charles Keepax
2016-08-31 11:42 ` Applied "ASoC: arizona: Don't change the FLLn_GAIN before entering FREERUN" to the asoc tree Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Charles Keepax @ 2016-08-30 9:30 UTC (permalink / raw)
To: broonie; +Cc: alsa-devel, patches, lgirdwood, nariman
From: Nariman Poushin <nariman@opensource.wolfsonmicro.com>
When reclocking an active FLL, to ensure a clean transition, do
not change the gain setting until we have entered free run.
Signed-off-by: Nariman Poushin <nariman@opensource.wolfsonmicro.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
sound/soc/codecs/arizona.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/arizona.c b/sound/soc/codecs/arizona.c
index ecfdbfc..0fc3b4b 100644
--- a/sound/soc/codecs/arizona.c
+++ b/sound/soc/codecs/arizona.c
@@ -2218,11 +2218,11 @@ static int arizona_enable_fll(struct arizona_fll *fll)
if (already_enabled) {
/* Facilitate smooth refclk across the transition */
- regmap_update_bits_async(fll->arizona->regmap, fll->base + 0x9,
- ARIZONA_FLL1_GAIN_MASK, 0);
regmap_update_bits(fll->arizona->regmap, fll->base + 1,
ARIZONA_FLL1_FREERUN, ARIZONA_FLL1_FREERUN);
udelay(32);
+ regmap_update_bits_async(fll->arizona->regmap, fll->base + 0x9,
+ ARIZONA_FLL1_GAIN_MASK, 0);
}
/*
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Applied "ASoC: arizona: Don't change the FLLn_GAIN before entering FREERUN" to the asoc tree
2016-08-30 9:30 [PATCH] ASoC: arizona: Don't change the FLLn_GAIN before entering FREERUN Charles Keepax
@ 2016-08-31 11:42 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2016-08-31 11:42 UTC (permalink / raw)
Cc: alsa-devel, patches, nariman, lgirdwood, broonie, Charles Keepax
The patch
ASoC: arizona: Don't change the FLLn_GAIN before entering FREERUN
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From c9991052aedaa74c69f8198852c65a99caf1adec Mon Sep 17 00:00:00 2001
From: Nariman Poushin <nariman@opensource.wolfsonmicro.com>
Date: Tue, 30 Aug 2016 10:30:40 +0100
Subject: [PATCH] ASoC: arizona: Don't change the FLLn_GAIN before entering
FREERUN
When reclocking an active FLL, to ensure a clean transition, do
not change the gain setting until we have entered free run.
Signed-off-by: Nariman Poushin <nariman@opensource.wolfsonmicro.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/arizona.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/arizona.c b/sound/soc/codecs/arizona.c
index ecfdbfcae366..0fc3b4b61552 100644
--- a/sound/soc/codecs/arizona.c
+++ b/sound/soc/codecs/arizona.c
@@ -2218,11 +2218,11 @@ static int arizona_enable_fll(struct arizona_fll *fll)
if (already_enabled) {
/* Facilitate smooth refclk across the transition */
- regmap_update_bits_async(fll->arizona->regmap, fll->base + 0x9,
- ARIZONA_FLL1_GAIN_MASK, 0);
regmap_update_bits(fll->arizona->regmap, fll->base + 1,
ARIZONA_FLL1_FREERUN, ARIZONA_FLL1_FREERUN);
udelay(32);
+ regmap_update_bits_async(fll->arizona->regmap, fll->base + 0x9,
+ ARIZONA_FLL1_GAIN_MASK, 0);
}
/*
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-31 11:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-30 9:30 [PATCH] ASoC: arizona: Don't change the FLLn_GAIN before entering FREERUN Charles Keepax
2016-08-31 11:42 ` Applied "ASoC: arizona: Don't change the FLLn_GAIN before entering FREERUN" to the asoc tree Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.