* [U-Boot] [PATCH v4 0/4] rk3399: enable dwc3 gadget and fastboot
@ 2016-09-01 2:14 Kever Yang
2016-09-01 2:14 ` [U-Boot] [PATCH v4 1/4] rk3399: add a empty "sys_proto.h" header file Kever Yang
` (3 more replies)
0 siblings, 4 replies; 16+ messages in thread
From: Kever Yang @ 2016-09-01 2:14 UTC (permalink / raw)
To: u-boot
This patch set enable rk3399 dwc3 controller and gadget driver
for fastboot.
Changes in v4:
- parse DT for quirk, base address and maximum speed
- use 1 bit for usb2_phyif_utmi_width instead of 5bit
Changes in v3:
- remove utmi width DT parse from borad init
- Parse the DT for utmi+ interface width in dwc3 driver
- move the config into Kconfig file.
Changes in v2:
- parse dt for utmi width
- use a variable to identify utmi+ bus width instead of CONFIG MACRO
- remove config for USB2PHY UTMI BITS
Kever Yang (4):
rk3399: add a empty "sys_proto.h" header file
board: evb-rk3399: add api to support dwc3 gadget
usb: dwc3: add support for 16 bit UTMI+ interface
config: rk3399: add support for dwc3 gadget
arch/arm/include/asm/arch-rockchip/sys_proto.h | 10 +++++
board/rockchip/evb_rk3399/evb-rk3399.c | 51 ++++++++++++++++++++++++++
configs/evb-rk3399_defconfig | 17 +++++++++
drivers/usb/dwc3/core.c | 19 ++++++++++
drivers/usb/dwc3/core.h | 12 ++++++
5 files changed, 109 insertions(+)
create mode 100644 arch/arm/include/asm/arch-rockchip/sys_proto.h
--
1.9.1
^ permalink raw reply [flat|nested] 16+ messages in thread
* [U-Boot] [PATCH v4 1/4] rk3399: add a empty "sys_proto.h" header file
2016-09-01 2:14 [U-Boot] [PATCH v4 0/4] rk3399: enable dwc3 gadget and fastboot Kever Yang
@ 2016-09-01 2:14 ` Kever Yang
2016-09-05 23:17 ` Simon Glass
2016-09-01 2:14 ` [U-Boot] [PATCH v4 2/4] board: evb-rk3399: add api to support dwc3 gadget Kever Yang
` (2 subsequent siblings)
3 siblings, 1 reply; 16+ messages in thread
From: Kever Yang @ 2016-09-01 2:14 UTC (permalink / raw)
To: u-boot
driver/usb/dwc3/gadget.c need a "sys_proto.h" header file, add a
empty one to make compile success.
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
Acked-by: Simon Glass <sjg@chromium.org>
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/arm/include/asm/arch-rockchip/sys_proto.h | 10 ++++++++++
1 file changed, 10 insertions(+)
create mode 100644 arch/arm/include/asm/arch-rockchip/sys_proto.h
diff --git a/arch/arm/include/asm/arch-rockchip/sys_proto.h b/arch/arm/include/asm/arch-rockchip/sys_proto.h
new file mode 100644
index 0000000..35423e1
--- /dev/null
+++ b/arch/arm/include/asm/arch-rockchip/sys_proto.h
@@ -0,0 +1,10 @@
+/*
+ * (C) Copyright 2016 Rockchip Electronics Co.,Ltd
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#ifndef _ASM_ARCH_SYS_PROTO_H
+#define _ASM_ARCH_SYS_PROTO_H
+
+#endif /* _ASM_ARCH_SYS_PROTO_H */
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [U-Boot] [PATCH v4 2/4] board: evb-rk3399: add api to support dwc3 gadget
2016-09-01 2:14 [U-Boot] [PATCH v4 0/4] rk3399: enable dwc3 gadget and fastboot Kever Yang
2016-09-01 2:14 ` [U-Boot] [PATCH v4 1/4] rk3399: add a empty "sys_proto.h" header file Kever Yang
@ 2016-09-01 2:14 ` Kever Yang
2016-09-01 8:59 ` Marek Vasut
2016-09-01 2:14 ` [U-Boot] [PATCH v4 3/4] usb: dwc3: add support for 16 bit UTMI+ interface Kever Yang
2016-09-01 2:14 ` [U-Boot] [PATCH v4 4/4] config: rk3399: add support for dwc3 gadget Kever Yang
3 siblings, 1 reply; 16+ messages in thread
From: Kever Yang @ 2016-09-01 2:14 UTC (permalink / raw)
To: u-boot
This patch add board_usb_init() and interrupt callback
for dwc3 gadget.
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---
Changes in v4:
- parse DT for quirk, base address and maximum speed
Changes in v3:
- remove utmi width DT parse from borad init
Changes in v2:
- parse dt for utmi width
board/rockchip/evb_rk3399/evb-rk3399.c | 51 ++++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
diff --git a/board/rockchip/evb_rk3399/evb-rk3399.c b/board/rockchip/evb_rk3399/evb-rk3399.c
index d394276..58bfa78 100644
--- a/board/rockchip/evb_rk3399/evb-rk3399.c
+++ b/board/rockchip/evb_rk3399/evb-rk3399.c
@@ -7,6 +7,8 @@
#include <dm.h>
#include <dm/pinctrl.h>
#include <asm/arch/periph.h>
+#include <usb.h>
+#include <dwc3-uboot.h>
DECLARE_GLOBAL_DATA_PTR;
@@ -54,3 +56,52 @@ void dram_init_banksize(void)
gd->bd->bi_dram[0].start = 0x200000;
gd->bd->bi_dram[0].size = 0x80000000;
}
+
+#ifdef CONFIG_USB_DWC3
+static struct dwc3_device dwc3_device_data = {
+ .index = 0,
+};
+
+int usb_gadget_handle_interrupts(void)
+{
+ dwc3_uboot_handle_interrupt(0);
+ return 0;
+}
+
+int board_usb_init(int index, enum usb_init_type init)
+{
+ const void *blob = gd->fdt_blob;
+ int node;
+ const char *string;
+
+ node = fdt_node_offset_by_compatible(blob, -1,
+ "rockchip,rk3399-xhci");
+ if (node < 0) {
+ debug("%s dwc3 node not found\n", __func__);
+ } else {
+ dwc3_device_data.base = fdtdec_get_addr(blob, node, "reg");
+ dwc3_device_data.dis_u2_susphy_quirk =
+ fdtdec_get_int(blob, node,
+ "snps,dis-u2-susphy-quirk", -1);
+
+ string = fdt_getprop(blob, node, "maximum-speed", NULL);
+ if (string) {
+ if (0 == strcmp(string, "super-speed"))
+ dwc3_device_data.maximum_speed = USB_SPEED_SUPER;
+ else if (0 == strcmp(string, "high-speed"))
+ dwc3_device_data.maximum_speed = USB_SPEED_HIGH;
+ else if (0 == strcmp(string, "full-speed"))
+ dwc3_device_data.maximum_speed = USB_SPEED_FULL;
+ else
+ debug("%s: Cannot decode speed'%s'\n", __func__,
+ string);
+ } else {
+ dwc3_device_data.maximum_speed = USB_SPEED_HIGH;
+ }
+ /* Hardcode controller in peripheral mode */
+ dwc3_device_data.dr_mode = USB_DR_MODE_PERIPHERAL;
+ }
+
+ return dwc3_uboot_init(&dwc3_device_data);
+}
+#endif
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [U-Boot] [PATCH v4 3/4] usb: dwc3: add support for 16 bit UTMI+ interface
2016-09-01 2:14 [U-Boot] [PATCH v4 0/4] rk3399: enable dwc3 gadget and fastboot Kever Yang
2016-09-01 2:14 ` [U-Boot] [PATCH v4 1/4] rk3399: add a empty "sys_proto.h" header file Kever Yang
2016-09-01 2:14 ` [U-Boot] [PATCH v4 2/4] board: evb-rk3399: add api to support dwc3 gadget Kever Yang
@ 2016-09-01 2:14 ` Kever Yang
2016-09-01 9:09 ` Marek Vasut
2017-09-11 13:30 ` [U-Boot] [U-Boot, v4, " Philipp Tomsich
2016-09-01 2:14 ` [U-Boot] [PATCH v4 4/4] config: rk3399: add support for dwc3 gadget Kever Yang
3 siblings, 2 replies; 16+ messages in thread
From: Kever Yang @ 2016-09-01 2:14 UTC (permalink / raw)
To: u-boot
The dwc3 controller is using 8 bit UTMI+ interface for USB2.0 PHY,
add one variable in dwc3/dwc3_device struct to support 16 bit
UTMI+ interface on some SoCs like Rockchip rk3399.
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---
Changes in v4:
- use 1 bit for usb2_phyif_utmi_width instead of 5bit
Changes in v3:
- Parse the DT for utmi+ interface width in dwc3 driver
Changes in v2:
- use a variable to identify utmi+ bus width instead of CONFIG MACRO
drivers/usb/dwc3/core.c | 19 +++++++++++++++++++
drivers/usb/dwc3/core.h | 12 ++++++++++++
2 files changed, 31 insertions(+)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 85cc96a..8792f99 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -16,6 +16,7 @@
#include <common.h>
#include <malloc.h>
+#include <fdtdec.h>
#include <dwc3-uboot.h>
#include <asm/dma-mapping.h>
#include <linux/ioport.h>
@@ -29,6 +30,8 @@
#include "linux-compat.h"
+DECLARE_GLOBAL_DATA_PTR;
+
static LIST_HEAD(dwc3_list);
/* -------------------------------------------------------------------------- */
@@ -388,6 +391,11 @@ static void dwc3_phy_setup(struct dwc3 *dwc)
if (dwc->dis_u2_susphy_quirk)
reg &= ~DWC3_GUSB2PHYCFG_SUSPHY;
+ if (dwc->usb2_phyif_utmi_width == 1) {
+ reg &= ~DWC3_GUSB2PHYCFG_USBTRDTIM_MASK;
+ reg |= DWC3_GUSB2PHYCFG_USBTRDTIM_16BIT;
+ reg |= DWC3_GUSB2PHYCFG_PHYIF_16BIT;
+ }
dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg);
mdelay(100);
@@ -621,6 +629,8 @@ int dwc3_uboot_init(struct dwc3_device *dwc3_dev)
int ret;
void *mem;
+ const void *blob = gd->fdt_blob;
+ int node;
mem = devm_kzalloc(dev, sizeof(*dwc) + DWC3_ALIGN_MASK, GFP_KERNEL);
if (!mem)
@@ -682,6 +692,15 @@ int dwc3_uboot_init(struct dwc3_device *dwc3_dev)
dwc->index = dwc3_dev->index;
+ node = fdt_node_offset_by_compatible(blob, -1,
+ "rockchip,rk3399-xhci");
+ if (node < 0)
+ debug("%s dwc3 node not found\n", __func__);
+ else
+ dwc->usb2_phyif_utmi_width =
+ (fdtdec_get_int(blob, node, "snps,phyif-utmi-bits", -1)
+ == 16) ? 1 : 0;
+
dwc3_cache_hwparams(dwc);
ret = dwc3_alloc_event_buffers(dwc, DWC3_EVENT_BUFFERS_SIZE);
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 72d2fcd..7484d5f 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -74,6 +74,7 @@
#define DWC3_GCTL 0xc110
#define DWC3_GEVTEN 0xc114
#define DWC3_GSTS 0xc118
+#define DWC3_GUCTL1 0xc11c
#define DWC3_GSNPSID 0xc120
#define DWC3_GGPIO 0xc124
#define DWC3_GUID 0xc128
@@ -162,7 +163,17 @@
/* Global USB2 PHY Configuration Register */
#define DWC3_GUSB2PHYCFG_PHYSOFTRST (1 << 31)
+#define DWC3_GUSB2PHYCFG_ENBLSLPM (1 << 8)
#define DWC3_GUSB2PHYCFG_SUSPHY (1 << 6)
+#define DWC3_GUSB2PHYCFG_PHYIF_8BIT (0 << 3)
+#define DWC3_GUSB2PHYCFG_PHYIF_16BIT (1 << 3)
+#define DWC3_GUSB2PHYCFG_USBTRDTIM_SHIFT (10)
+#define DWC3_GUSB2PHYCFG_USBTRDTIM_MASK (0xf << \
+ DWC3_GUSB2PHYCFG_USBTRDTIM_SHIFT)
+#define DWC3_GUSB2PHYCFG_USBTRDTIM_16BIT (0x5 << \
+ DWC3_GUSB2PHYCFG_USBTRDTIM_SHIFT)
+#define DWC3_GUSB2PHYCFG_USBTRDTIM_8BIT (0x9 << \
+ DWC3_GUSB2PHYCFG_USBTRDTIM_SHIFT)
/* Global USB3 PIPE Control Register */
#define DWC3_GUSB3PIPECTL_PHYSOFTRST (1 << 31)
@@ -813,6 +824,7 @@ struct dwc3 {
unsigned tx_de_emphasis_quirk:1;
unsigned tx_de_emphasis:2;
+ unsigned usb2_phyif_utmi_width:1;
int index;
struct list_head list;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [U-Boot] [PATCH v4 4/4] config: rk3399: add support for dwc3 gadget
2016-09-01 2:14 [U-Boot] [PATCH v4 0/4] rk3399: enable dwc3 gadget and fastboot Kever Yang
` (2 preceding siblings ...)
2016-09-01 2:14 ` [U-Boot] [PATCH v4 3/4] usb: dwc3: add support for 16 bit UTMI+ interface Kever Yang
@ 2016-09-01 2:14 ` Kever Yang
3 siblings, 0 replies; 16+ messages in thread
From: Kever Yang @ 2016-09-01 2:14 UTC (permalink / raw)
To: u-boot
To support fastboot, we need to enable the controller first.
rk3399 is using dwc3 as usb device controller, this patch enable
the configs for dwc3 gadget.
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---
Changes in v4: None
Changes in v3:
- move the config into Kconfig file.
Changes in v2:
- remove config for USB2PHY UTMI BITS
configs/evb-rk3399_defconfig | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/configs/evb-rk3399_defconfig b/configs/evb-rk3399_defconfig
index 2951678..72f2224 100644
--- a/configs/evb-rk3399_defconfig
+++ b/configs/evb-rk3399_defconfig
@@ -36,3 +36,20 @@ CONFIG_DEBUG_UART_CLOCK=24000000
CONFIG_DEBUG_UART_SHIFT=2
CONFIG_USE_TINY_PRINTF=y
CONFIG_ERRNO_STR=y
+CONFIG_USB=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DUALSPEED=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_USB_DWC3=y
+CONFIG_USB_DWC3_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x330a
+CONFIG_FASTBOOT=y
+CONFIG_CMD_FASTBOOT=y
+CONFIG_USB_FUNCTION_FASTBOOT=y
+CONFIG_FASTBOOT_FLASH=y
+CONFIG_FASTBOOT_FLASH_MMC_DEV=1
+CONFIG_FASTBOOT_BUF_ADDR=0x00800800
+CONFIG_FASTBOOT_BUF_SIZE=0x08000000
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [U-Boot] [PATCH v4 2/4] board: evb-rk3399: add api to support dwc3 gadget
2016-09-01 2:14 ` [U-Boot] [PATCH v4 2/4] board: evb-rk3399: add api to support dwc3 gadget Kever Yang
@ 2016-09-01 8:59 ` Marek Vasut
2016-09-02 9:58 ` Kever Yang
0 siblings, 1 reply; 16+ messages in thread
From: Marek Vasut @ 2016-09-01 8:59 UTC (permalink / raw)
To: u-boot
On 09/01/2016 04:14 AM, Kever Yang wrote:
> This patch add board_usb_init() and interrupt callback
> for dwc3 gadget.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> Changes in v4:
> - parse DT for quirk, base address and maximum speed
>
> Changes in v3:
> - remove utmi width DT parse from borad init
>
> Changes in v2:
> - parse dt for utmi width
>
> board/rockchip/evb_rk3399/evb-rk3399.c | 51 ++++++++++++++++++++++++++++++++++
> 1 file changed, 51 insertions(+)
>
> diff --git a/board/rockchip/evb_rk3399/evb-rk3399.c b/board/rockchip/evb_rk3399/evb-rk3399.c
> index d394276..58bfa78 100644
> --- a/board/rockchip/evb_rk3399/evb-rk3399.c
> +++ b/board/rockchip/evb_rk3399/evb-rk3399.c
> @@ -7,6 +7,8 @@
> #include <dm.h>
> #include <dm/pinctrl.h>
> #include <asm/arch/periph.h>
> +#include <usb.h>
> +#include <dwc3-uboot.h>
>
> DECLARE_GLOBAL_DATA_PTR;
>
> @@ -54,3 +56,52 @@ void dram_init_banksize(void)
> gd->bd->bi_dram[0].start = 0x200000;
> gd->bd->bi_dram[0].size = 0x80000000;
> }
> +
> +#ifdef CONFIG_USB_DWC3
> +static struct dwc3_device dwc3_device_data = {
> + .index = 0,
> +};
> +
> +int usb_gadget_handle_interrupts(void)
> +{
> + dwc3_uboot_handle_interrupt(0);
> + return 0;
> +}
> +
> +int board_usb_init(int index, enum usb_init_type init)
> +{
> + const void *blob = gd->fdt_blob;
> + int node;
> + const char *string;
> +
> + node = fdt_node_offset_by_compatible(blob, -1,
> + "rockchip,rk3399-xhci");
> + if (node < 0) {
> + debug("%s dwc3 node not found\n", __func__);
> + } else {
> + dwc3_device_data.base = fdtdec_get_addr(blob, node, "reg");
> + dwc3_device_data.dis_u2_susphy_quirk =
> + fdtdec_get_int(blob, node,
> + "snps,dis-u2-susphy-quirk", -1);
> +
> + string = fdt_getprop(blob, node, "maximum-speed", NULL);
> + if (string) {
> + if (0 == strcmp(string, "super-speed"))
> + dwc3_device_data.maximum_speed = USB_SPEED_SUPER;
> + else if (0 == strcmp(string, "high-speed"))
> + dwc3_device_data.maximum_speed = USB_SPEED_HIGH;
> + else if (0 == strcmp(string, "full-speed"))
> + dwc3_device_data.maximum_speed = USB_SPEED_FULL;
> + else
> + debug("%s: Cannot decode speed'%s'\n", __func__,
> + string);
> + } else {
> + dwc3_device_data.maximum_speed = USB_SPEED_HIGH;
> + }
> + /* Hardcode controller in peripheral mode */
> + dwc3_device_data.dr_mode = USB_DR_MODE_PERIPHERAL;
> + }
> +
> + return dwc3_uboot_init(&dwc3_device_data);
> +}
> +#endif
>
So will every board have a copy of this exact code, verbatim ?
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 16+ messages in thread
* [U-Boot] [PATCH v4 3/4] usb: dwc3: add support for 16 bit UTMI+ interface
2016-09-01 2:14 ` [U-Boot] [PATCH v4 3/4] usb: dwc3: add support for 16 bit UTMI+ interface Kever Yang
@ 2016-09-01 9:09 ` Marek Vasut
2016-09-02 10:00 ` Kever Yang
2017-09-11 13:30 ` [U-Boot] [U-Boot, v4, " Philipp Tomsich
1 sibling, 1 reply; 16+ messages in thread
From: Marek Vasut @ 2016-09-01 9:09 UTC (permalink / raw)
To: u-boot
On 09/01/2016 04:14 AM, Kever Yang wrote:
> The dwc3 controller is using 8 bit UTMI+ interface for USB2.0 PHY,
> add one variable in dwc3/dwc3_device struct to support 16 bit
> UTMI+ interface on some SoCs like Rockchip rk3399.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> Changes in v4:
> - use 1 bit for usb2_phyif_utmi_width instead of 5bit
>
> Changes in v3:
> - Parse the DT for utmi+ interface width in dwc3 driver
>
> Changes in v2:
> - use a variable to identify utmi+ bus width instead of CONFIG MACRO
>
> drivers/usb/dwc3/core.c | 19 +++++++++++++++++++
> drivers/usb/dwc3/core.h | 12 ++++++++++++
> 2 files changed, 31 insertions(+)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 85cc96a..8792f99 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -16,6 +16,7 @@
>
> #include <common.h>
> #include <malloc.h>
> +#include <fdtdec.h>
> #include <dwc3-uboot.h>
> #include <asm/dma-mapping.h>
> #include <linux/ioport.h>
> @@ -29,6 +30,8 @@
>
> #include "linux-compat.h"
>
> +DECLARE_GLOBAL_DATA_PTR;
> +
> static LIST_HEAD(dwc3_list);
> /* -------------------------------------------------------------------------- */
>
> @@ -388,6 +391,11 @@ static void dwc3_phy_setup(struct dwc3 *dwc)
> if (dwc->dis_u2_susphy_quirk)
> reg &= ~DWC3_GUSB2PHYCFG_SUSPHY;
>
> + if (dwc->usb2_phyif_utmi_width == 1) {
> + reg &= ~DWC3_GUSB2PHYCFG_USBTRDTIM_MASK;
> + reg |= DWC3_GUSB2PHYCFG_USBTRDTIM_16BIT;
> + reg |= DWC3_GUSB2PHYCFG_PHYIF_16BIT;
> + }
> dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg);
>
> mdelay(100);
> @@ -621,6 +629,8 @@ int dwc3_uboot_init(struct dwc3_device *dwc3_dev)
> int ret;
>
> void *mem;
> + const void *blob = gd->fdt_blob;
> + int node;
>
> mem = devm_kzalloc(dev, sizeof(*dwc) + DWC3_ALIGN_MASK, GFP_KERNEL);
> if (!mem)
> @@ -682,6 +692,15 @@ int dwc3_uboot_init(struct dwc3_device *dwc3_dev)
>
> dwc->index = dwc3_dev->index;
>
> + node = fdt_node_offset_by_compatible(blob, -1,
> + "rockchip,rk3399-xhci");
> + if (node < 0)
> + debug("%s dwc3 node not found\n", __func__);
> + else
> + dwc->usb2_phyif_utmi_width =
> + (fdtdec_get_int(blob, node, "snps,phyif-utmi-bits", -1)
> + == 16) ? 1 : 0;
What happens if fdtdec_get_int() returns -1 here ? Is that an error?
I just took a look into Linux and they use "phy_type" property to
describe the PHY bus, with possible values being "utmi" "utmi_wide"
"ulpi" etc . Do we need to invent new vendor-specific property ?
See Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt in Linux
for example.
> dwc3_cache_hwparams(dwc);
>
> ret = dwc3_alloc_event_buffers(dwc, DWC3_EVENT_BUFFERS_SIZE);
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index 72d2fcd..7484d5f 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -74,6 +74,7 @@
> #define DWC3_GCTL 0xc110
> #define DWC3_GEVTEN 0xc114
> #define DWC3_GSTS 0xc118
> +#define DWC3_GUCTL1 0xc11c
> #define DWC3_GSNPSID 0xc120
> #define DWC3_GGPIO 0xc124
> #define DWC3_GUID 0xc128
> @@ -162,7 +163,17 @@
>
> /* Global USB2 PHY Configuration Register */
> #define DWC3_GUSB2PHYCFG_PHYSOFTRST (1 << 31)
> +#define DWC3_GUSB2PHYCFG_ENBLSLPM (1 << 8)
> #define DWC3_GUSB2PHYCFG_SUSPHY (1 << 6)
> +#define DWC3_GUSB2PHYCFG_PHYIF_8BIT (0 << 3)
> +#define DWC3_GUSB2PHYCFG_PHYIF_16BIT (1 << 3)
> +#define DWC3_GUSB2PHYCFG_USBTRDTIM_SHIFT (10)
> +#define DWC3_GUSB2PHYCFG_USBTRDTIM_MASK (0xf << \
> + DWC3_GUSB2PHYCFG_USBTRDTIM_SHIFT)
> +#define DWC3_GUSB2PHYCFG_USBTRDTIM_16BIT (0x5 << \
> + DWC3_GUSB2PHYCFG_USBTRDTIM_SHIFT)
> +#define DWC3_GUSB2PHYCFG_USBTRDTIM_8BIT (0x9 << \
> + DWC3_GUSB2PHYCFG_USBTRDTIM_SHIFT)
>
> /* Global USB3 PIPE Control Register */
> #define DWC3_GUSB3PIPECTL_PHYSOFTRST (1 << 31)
> @@ -813,6 +824,7 @@ struct dwc3 {
>
> unsigned tx_de_emphasis_quirk:1;
> unsigned tx_de_emphasis:2;
> + unsigned usb2_phyif_utmi_width:1;
> int index;
> struct list_head list;
> };
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 16+ messages in thread
* [U-Boot] [PATCH v4 2/4] board: evb-rk3399: add api to support dwc3 gadget
2016-09-01 8:59 ` Marek Vasut
@ 2016-09-02 9:58 ` Kever Yang
2016-09-02 12:14 ` Marek Vasut
0 siblings, 1 reply; 16+ messages in thread
From: Kever Yang @ 2016-09-02 9:58 UTC (permalink / raw)
To: u-boot
Hi Marek,
On 09/01/2016 04:59 PM, Marek Vasut wrote:
> On 09/01/2016 04:14 AM, Kever Yang wrote:
>> This patch add board_usb_init() and interrupt callback
>> for dwc3 gadget.
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>>
>> Changes in v4:
>> - parse DT for quirk, base address and maximum speed
>>
>> Changes in v3:
>> - remove utmi width DT parse from borad init
>>
>> Changes in v2:
>> - parse dt for utmi width
>>
>> board/rockchip/evb_rk3399/evb-rk3399.c | 51 ++++++++++++++++++++++++++++++++++
>> 1 file changed, 51 insertions(+)
>>
>> diff --git a/board/rockchip/evb_rk3399/evb-rk3399.c b/board/rockchip/evb_rk3399/evb-rk3399.c
>> index d394276..58bfa78 100644
>> --- a/board/rockchip/evb_rk3399/evb-rk3399.c
>> +++ b/board/rockchip/evb_rk3399/evb-rk3399.c
>> @@ -7,6 +7,8 @@
>> #include <dm.h>
>> #include <dm/pinctrl.h>
>> #include <asm/arch/periph.h>
>> +#include <usb.h>
>> +#include <dwc3-uboot.h>
>>
>> DECLARE_GLOBAL_DATA_PTR;
>>
>> @@ -54,3 +56,52 @@ void dram_init_banksize(void)
>> gd->bd->bi_dram[0].start = 0x200000;
>> gd->bd->bi_dram[0].size = 0x80000000;
>> }
>> +
>> +#ifdef CONFIG_USB_DWC3
>> +static struct dwc3_device dwc3_device_data = {
>> + .index = 0,
>> +};
>> +
>> +int usb_gadget_handle_interrupts(void)
>> +{
>> + dwc3_uboot_handle_interrupt(0);
>> + return 0;
>> +}
>> +
>> +int board_usb_init(int index, enum usb_init_type init)
>> +{
>> + const void *blob = gd->fdt_blob;
>> + int node;
>> + const char *string;
>> +
>> + node = fdt_node_offset_by_compatible(blob, -1,
>> + "rockchip,rk3399-xhci");
>> + if (node < 0) {
>> + debug("%s dwc3 node not found\n", __func__);
>> + } else {
>> + dwc3_device_data.base = fdtdec_get_addr(blob, node, "reg");
>> + dwc3_device_data.dis_u2_susphy_quirk =
>> + fdtdec_get_int(blob, node,
>> + "snps,dis-u2-susphy-quirk", -1);
>> +
>> + string = fdt_getprop(blob, node, "maximum-speed", NULL);
>> + if (string) {
>> + if (0 == strcmp(string, "super-speed"))
>> + dwc3_device_data.maximum_speed = USB_SPEED_SUPER;
>> + else if (0 == strcmp(string, "high-speed"))
>> + dwc3_device_data.maximum_speed = USB_SPEED_HIGH;
>> + else if (0 == strcmp(string, "full-speed"))
>> + dwc3_device_data.maximum_speed = USB_SPEED_FULL;
>> + else
>> + debug("%s: Cannot decode speed'%s'\n", __func__,
>> + string);
>> + } else {
>> + dwc3_device_data.maximum_speed = USB_SPEED_HIGH;
>> + }
>> + /* Hardcode controller in peripheral mode */
>> + dwc3_device_data.dr_mode = USB_DR_MODE_PERIPHERAL;
>> + }
>> +
>> + return dwc3_uboot_init(&dwc3_device_data);
>> +}
>> +#endif
>>
> So will every board have a copy of this exact code, verbatim ?
>
Yes for rk3399 based board.
Not sure why you ask this question, but I guess you still want these
parse happen in driver instead of board_init()?
I didn't make these code in dwc3 driver because other SoC dts are
different now, they are init in platdata data structure.
To be honest, I want to make the upstream code to support rk3399 dwc3,
but I don't want to touch too much code in other SoC.
Thanks,
- Kever
^ permalink raw reply [flat|nested] 16+ messages in thread
* [U-Boot] [PATCH v4 3/4] usb: dwc3: add support for 16 bit UTMI+ interface
2016-09-01 9:09 ` Marek Vasut
@ 2016-09-02 10:00 ` Kever Yang
0 siblings, 0 replies; 16+ messages in thread
From: Kever Yang @ 2016-09-02 10:00 UTC (permalink / raw)
To: u-boot
Hi Marek,
On 09/01/2016 05:09 PM, Marek Vasut wrote:
> On 09/01/2016 04:14 AM, Kever Yang wrote:
>> The dwc3 controller is using 8 bit UTMI+ interface for USB2.0 PHY,
>> add one variable in dwc3/dwc3_device struct to support 16 bit
>> UTMI+ interface on some SoCs like Rockchip rk3399.
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>>
>> Changes in v4:
>> - use 1 bit for usb2_phyif_utmi_width instead of 5bit
>>
>> Changes in v3:
>> - Parse the DT for utmi+ interface width in dwc3 driver
>>
>> Changes in v2:
>> - use a variable to identify utmi+ bus width instead of CONFIG MACRO
>>
>> drivers/usb/dwc3/core.c | 19 +++++++++++++++++++
>> drivers/usb/dwc3/core.h | 12 ++++++++++++
>> 2 files changed, 31 insertions(+)
>>
>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
>> index 85cc96a..8792f99 100644
>> --- a/drivers/usb/dwc3/core.c
>> +++ b/drivers/usb/dwc3/core.c
>> @@ -16,6 +16,7 @@
>>
>> #include <common.h>
>> #include <malloc.h>
>> +#include <fdtdec.h>
>> #include <dwc3-uboot.h>
>> #include <asm/dma-mapping.h>
>> #include <linux/ioport.h>
>> @@ -29,6 +30,8 @@
>>
>> #include "linux-compat.h"
>>
>> +DECLARE_GLOBAL_DATA_PTR;
>> +
>> static LIST_HEAD(dwc3_list);
>> /* -------------------------------------------------------------------------- */
>>
>> @@ -388,6 +391,11 @@ static void dwc3_phy_setup(struct dwc3 *dwc)
>> if (dwc->dis_u2_susphy_quirk)
>> reg &= ~DWC3_GUSB2PHYCFG_SUSPHY;
>>
>> + if (dwc->usb2_phyif_utmi_width == 1) {
>> + reg &= ~DWC3_GUSB2PHYCFG_USBTRDTIM_MASK;
>> + reg |= DWC3_GUSB2PHYCFG_USBTRDTIM_16BIT;
>> + reg |= DWC3_GUSB2PHYCFG_PHYIF_16BIT;
>> + }
>> dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg);
>>
>> mdelay(100);
>> @@ -621,6 +629,8 @@ int dwc3_uboot_init(struct dwc3_device *dwc3_dev)
>> int ret;
>>
>> void *mem;
>> + const void *blob = gd->fdt_blob;
>> + int node;
>>
>> mem = devm_kzalloc(dev, sizeof(*dwc) + DWC3_ALIGN_MASK, GFP_KERNEL);
>> if (!mem)
>> @@ -682,6 +692,15 @@ int dwc3_uboot_init(struct dwc3_device *dwc3_dev)
>>
>> dwc->index = dwc3_dev->index;
>>
>> + node = fdt_node_offset_by_compatible(blob, -1,
>> + "rockchip,rk3399-xhci");
>> + if (node < 0)
>> + debug("%s dwc3 node not found\n", __func__);
>> + else
>> + dwc->usb2_phyif_utmi_width =
>> + (fdtdec_get_int(blob, node, "snps,phyif-utmi-bits", -1)
>> + == 16) ? 1 : 0;
> What happens if fdtdec_get_int() returns -1 here ? Is that an error?
It may happen when the node is not defined, then we use 8bit as default,
and we don't break any of origin source code.
>
> I just took a look into Linux and they use "phy_type" property to
> describe the PHY bus, with possible values being "utmi" "utmi_wide"
> "ulpi" etc . Do we need to invent new vendor-specific property ?
> See Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt in Linux
> for example.
Well, I will parse "phy_type" for utmi width instead in next patch version.
Thanks,
- Kever
>
>> dwc3_cache_hwparams(dwc);
>>
>> ret = dwc3_alloc_event_buffers(dwc, DWC3_EVENT_BUFFERS_SIZE);
>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>> index 72d2fcd..7484d5f 100644
>> --- a/drivers/usb/dwc3/core.h
>> +++ b/drivers/usb/dwc3/core.h
>> @@ -74,6 +74,7 @@
>> #define DWC3_GCTL 0xc110
>> #define DWC3_GEVTEN 0xc114
>> #define DWC3_GSTS 0xc118
>> +#define DWC3_GUCTL1 0xc11c
>> #define DWC3_GSNPSID 0xc120
>> #define DWC3_GGPIO 0xc124
>> #define DWC3_GUID 0xc128
>> @@ -162,7 +163,17 @@
>>
>> /* Global USB2 PHY Configuration Register */
>> #define DWC3_GUSB2PHYCFG_PHYSOFTRST (1 << 31)
>> +#define DWC3_GUSB2PHYCFG_ENBLSLPM (1 << 8)
>> #define DWC3_GUSB2PHYCFG_SUSPHY (1 << 6)
>> +#define DWC3_GUSB2PHYCFG_PHYIF_8BIT (0 << 3)
>> +#define DWC3_GUSB2PHYCFG_PHYIF_16BIT (1 << 3)
>> +#define DWC3_GUSB2PHYCFG_USBTRDTIM_SHIFT (10)
>> +#define DWC3_GUSB2PHYCFG_USBTRDTIM_MASK (0xf << \
>> + DWC3_GUSB2PHYCFG_USBTRDTIM_SHIFT)
>> +#define DWC3_GUSB2PHYCFG_USBTRDTIM_16BIT (0x5 << \
>> + DWC3_GUSB2PHYCFG_USBTRDTIM_SHIFT)
>> +#define DWC3_GUSB2PHYCFG_USBTRDTIM_8BIT (0x9 << \
>> + DWC3_GUSB2PHYCFG_USBTRDTIM_SHIFT)
>>
>> /* Global USB3 PIPE Control Register */
>> #define DWC3_GUSB3PIPECTL_PHYSOFTRST (1 << 31)
>> @@ -813,6 +824,7 @@ struct dwc3 {
>>
>> unsigned tx_de_emphasis_quirk:1;
>> unsigned tx_de_emphasis:2;
>> + unsigned usb2_phyif_utmi_width:1;
>> int index;
>> struct list_head list;
>> };
>>
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [U-Boot] [PATCH v4 2/4] board: evb-rk3399: add api to support dwc3 gadget
2016-09-02 9:58 ` Kever Yang
@ 2016-09-02 12:14 ` Marek Vasut
0 siblings, 0 replies; 16+ messages in thread
From: Marek Vasut @ 2016-09-02 12:14 UTC (permalink / raw)
To: u-boot
On 09/02/2016 11:58 AM, Kever Yang wrote:
> Hi Marek,
>
> On 09/01/2016 04:59 PM, Marek Vasut wrote:
>> On 09/01/2016 04:14 AM, Kever Yang wrote:
>>> This patch add board_usb_init() and interrupt callback
>>> for dwc3 gadget.
>>>
>>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>>> ---
>>>
>>> Changes in v4:
>>> - parse DT for quirk, base address and maximum speed
>>>
>>> Changes in v3:
>>> - remove utmi width DT parse from borad init
>>>
>>> Changes in v2:
>>> - parse dt for utmi width
>>>
>>> board/rockchip/evb_rk3399/evb-rk3399.c | 51
>>> ++++++++++++++++++++++++++++++++++
>>> 1 file changed, 51 insertions(+)
>>>
>>> diff --git a/board/rockchip/evb_rk3399/evb-rk3399.c
>>> b/board/rockchip/evb_rk3399/evb-rk3399.c
>>> index d394276..58bfa78 100644
>>> --- a/board/rockchip/evb_rk3399/evb-rk3399.c
>>> +++ b/board/rockchip/evb_rk3399/evb-rk3399.c
>>> @@ -7,6 +7,8 @@
>>> #include <dm.h>
>>> #include <dm/pinctrl.h>
>>> #include <asm/arch/periph.h>
>>> +#include <usb.h>
>>> +#include <dwc3-uboot.h>
>>> DECLARE_GLOBAL_DATA_PTR;
>>> @@ -54,3 +56,52 @@ void dram_init_banksize(void)
>>> gd->bd->bi_dram[0].start = 0x200000;
>>> gd->bd->bi_dram[0].size = 0x80000000;
>>> }
>>> +
>>> +#ifdef CONFIG_USB_DWC3
>>> +static struct dwc3_device dwc3_device_data = {
>>> + .index = 0,
>>> +};
>>> +
>>> +int usb_gadget_handle_interrupts(void)
>>> +{
>>> + dwc3_uboot_handle_interrupt(0);
>>> + return 0;
>>> +}
>>> +
>>> +int board_usb_init(int index, enum usb_init_type init)
>>> +{
>>> + const void *blob = gd->fdt_blob;
>>> + int node;
>>> + const char *string;
>>> +
>>> + node = fdt_node_offset_by_compatible(blob, -1,
>>> + "rockchip,rk3399-xhci");
>>> + if (node < 0) {
>>> + debug("%s dwc3 node not found\n", __func__);
>>> + } else {
>>> + dwc3_device_data.base = fdtdec_get_addr(blob, node, "reg");
>>> + dwc3_device_data.dis_u2_susphy_quirk =
>>> + fdtdec_get_int(blob, node,
>>> + "snps,dis-u2-susphy-quirk", -1);
>>> +
>>> + string = fdt_getprop(blob, node, "maximum-speed", NULL);
>>> + if (string) {
>>> + if (0 == strcmp(string, "super-speed"))
>>> + dwc3_device_data.maximum_speed = USB_SPEED_SUPER;
>>> + else if (0 == strcmp(string, "high-speed"))
>>> + dwc3_device_data.maximum_speed = USB_SPEED_HIGH;
>>> + else if (0 == strcmp(string, "full-speed"))
>>> + dwc3_device_data.maximum_speed = USB_SPEED_FULL;
>>> + else
>>> + debug("%s: Cannot decode speed'%s'\n", __func__,
>>> + string);
>>> + } else {
>>> + dwc3_device_data.maximum_speed = USB_SPEED_HIGH;
>>> + }
>>> + /* Hardcode controller in peripheral mode */
>>> + dwc3_device_data.dr_mode = USB_DR_MODE_PERIPHERAL;
>>> + }
>>> +
>>> + return dwc3_uboot_init(&dwc3_device_data);
>>> +}
>>> +#endif
>>>
>> So will every board have a copy of this exact code, verbatim ?
>>
> Yes for rk3399 based board.
> Not sure why you ask this question, but I guess you still want these
> parse happen in driver instead of board_init()?
Of course.
> I didn't make these code in dwc3 driver because other SoC dts are
> different now, they are init in platdata data structure.
You can retain this behavior while adding the support for OF probing,
see my reply to your v3 patchset.
> To be honest, I want to make the upstream code to support rk3399 dwc3,
> but I don't want to touch too much code in other SoC.
This would result in having many various vendor hacks in board files,
which would be almost identical but only slightly broken and nightmare
to maintain. We have been there are we're glad we are getting out of
there. So no, I will not allow this. Instead, do changes to common code
and let others review/test them for you, this is perfectly fine.
btw the way of parsing DT in the driver I outlined in the reply to v3
should be pretty unintrusive.
> Thanks,
> - Kever
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 16+ messages in thread
* [U-Boot] [PATCH v4 1/4] rk3399: add a empty "sys_proto.h" header file
2016-09-01 2:14 ` [U-Boot] [PATCH v4 1/4] rk3399: add a empty "sys_proto.h" header file Kever Yang
@ 2016-09-05 23:17 ` Simon Glass
0 siblings, 0 replies; 16+ messages in thread
From: Simon Glass @ 2016-09-05 23:17 UTC (permalink / raw)
To: u-boot
On 31 August 2016 at 20:14, Kever Yang <kever.yang@rock-chips.com> wrote:
> driver/usb/dwc3/gadget.c need a "sys_proto.h" header file, add a
> empty one to make compile success.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
> arch/arm/include/asm/arch-rockchip/sys_proto.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> create mode 100644 arch/arm/include/asm/arch-rockchip/sys_proto.h
Applied to u-boot-rockchip/next, thanks!
^ permalink raw reply [flat|nested] 16+ messages in thread
* [U-Boot] [U-Boot, v4, 3/4] usb: dwc3: add support for 16 bit UTMI+ interface
2016-09-01 2:14 ` [U-Boot] [PATCH v4 3/4] usb: dwc3: add support for 16 bit UTMI+ interface Kever Yang
2016-09-01 9:09 ` Marek Vasut
@ 2017-09-11 13:30 ` Philipp Tomsich
2017-09-12 5:02 ` Kever Yang
1 sibling, 1 reply; 16+ messages in thread
From: Philipp Tomsich @ 2017-09-11 13:30 UTC (permalink / raw)
To: u-boot
Kever,
What is the status on this patch (and the encapsulating series)?
This seems to be stuck in 'changes requested' for about a year now...
Thanks,
Philipp.
On Thu, 1 Sep 2016, Kever Yang wrote:
> The dwc3 controller is using 8 bit UTMI+ interface for USB2.0 PHY,
> add one variable in dwc3/dwc3_device struct to support 16 bit
> UTMI+ interface on some SoCs like Rockchip rk3399.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> Changes in v4:
> - use 1 bit for usb2_phyif_utmi_width instead of 5bit
>
> Changes in v3:
> - Parse the DT for utmi+ interface width in dwc3 driver
>
> Changes in v2:
> - use a variable to identify utmi+ bus width instead of CONFIG MACRO
>
> drivers/usb/dwc3/core.c | 19 +++++++++++++++++++
> drivers/usb/dwc3/core.h | 12 ++++++++++++
> 2 files changed, 31 insertions(+)
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [U-Boot] [U-Boot, v4, 3/4] usb: dwc3: add support for 16 bit UTMI+ interface
2017-09-11 13:30 ` [U-Boot] [U-Boot, v4, " Philipp Tomsich
@ 2017-09-12 5:02 ` Kever Yang
2017-09-12 9:09 ` Dr. Philipp Tomsich
0 siblings, 1 reply; 16+ messages in thread
From: Kever Yang @ 2017-09-12 5:02 UTC (permalink / raw)
To: u-boot
Philipp,
I believe there are some request I think is not reasonable which
stop me from update new patch sets.
The usb/dwc3 is mess up now, separate in host mode and gadget mode, one
need init in board init
while another use DM. When I want to add a new feature like use 16bit
UTMI+ instead of 8bit(which suppose to be very very simple),
I don't think the maintainer have an idea where it should go and how it
should be, and the driver now
it's far away from upstream kernel.
I have send 4 patch set for this, everything should be clear, but...
Thanks,
- Kever
On 09/11/2017 09:30 PM, Philipp Tomsich wrote:
>
> Kever,
>
> What is the status on this patch (and the encapsulating series)?
> This seems to be stuck in 'changes requested' for about a year now...
>
> Thanks,
> Philipp.
>
> On Thu, 1 Sep 2016, Kever Yang wrote:
>
>> The dwc3 controller is using 8 bit UTMI+ interface for USB2.0 PHY,
>> add one variable in dwc3/dwc3_device struct to support 16 bit
>> UTMI+ interface on some SoCs like Rockchip rk3399.
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>>
>> Changes in v4:
>> - use 1 bit for usb2_phyif_utmi_width instead of 5bit
>>
>> Changes in v3:
>> - Parse the DT for utmi+ interface width in dwc3 driver
>>
>> Changes in v2:
>> - use a variable to identify utmi+ bus width instead of CONFIG MACRO
>>
>> drivers/usb/dwc3/core.c | 19 +++++++++++++++++++
>> drivers/usb/dwc3/core.h | 12 ++++++++++++
>> 2 files changed, 31 insertions(+)
>>
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [U-Boot] [U-Boot, v4, 3/4] usb: dwc3: add support for 16 bit UTMI+ interface
2017-09-12 5:02 ` Kever Yang
@ 2017-09-12 9:09 ` Dr. Philipp Tomsich
2017-09-12 10:22 ` Marek Vasut
0 siblings, 1 reply; 16+ messages in thread
From: Dr. Philipp Tomsich @ 2017-09-12 9:09 UTC (permalink / raw)
To: u-boot
Marek,
do you know whether there's an update of the DWC3 driver planned to get us back in sync with the kernel driver?
Thanks,
Philipp.
> On 12 Sep 2017, at 07:02, Kever Yang <kever.yang@rock-chips.com> wrote:
>
> Philipp,
>
> I believe there are some request I think is not reasonable which stop me from update new patch sets.
>
> The usb/dwc3 is mess up now, separate in host mode and gadget mode, one need init in board init
>
> while another use DM. When I want to add a new feature like use 16bit UTMI+ instead of 8bit(which suppose to be very very simple),
>
> I don't think the maintainer have an idea where it should go and how it should be, and the driver now
>
> it's far away from upstream kernel.
>
> I have send 4 patch set for this, everything should be clear, but...
>
>
>
> Thanks,
> - Kever
> On 09/11/2017 09:30 PM, Philipp Tomsich wrote:
>>
>> Kever,
>>
>> What is the status on this patch (and the encapsulating series)?
>> This seems to be stuck in 'changes requested' for about a year now...
>>
>> Thanks,
>> Philipp.
>>
>> On Thu, 1 Sep 2016, Kever Yang wrote:
>>
>>> The dwc3 controller is using 8 bit UTMI+ interface for USB2.0 PHY,
>>> add one variable in dwc3/dwc3_device struct to support 16 bit
>>> UTMI+ interface on some SoCs like Rockchip rk3399.
>>>
>>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>>> ---
>>>
>>> Changes in v4:
>>> - use 1 bit for usb2_phyif_utmi_width instead of 5bit
>>>
>>> Changes in v3:
>>> - Parse the DT for utmi+ interface width in dwc3 driver
>>>
>>> Changes in v2:
>>> - use a variable to identify utmi+ bus width instead of CONFIG MACRO
>>>
>>> drivers/usb/dwc3/core.c | 19 +++++++++++++++++++
>>> drivers/usb/dwc3/core.h | 12 ++++++++++++
>>> 2 files changed, 31 insertions(+)
>>>
>>
>
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [U-Boot] [U-Boot, v4, 3/4] usb: dwc3: add support for 16 bit UTMI+ interface
2017-09-12 9:09 ` Dr. Philipp Tomsich
@ 2017-09-12 10:22 ` Marek Vasut
2017-09-12 10:50 ` Dr. Philipp Tomsich
0 siblings, 1 reply; 16+ messages in thread
From: Marek Vasut @ 2017-09-12 10:22 UTC (permalink / raw)
To: u-boot
On 09/12/2017 11:09 AM, Dr. Philipp Tomsich wrote:
> Marek,
>
> do you know whether there's an update of the DWC3 driver planned to get us back in sync with the kernel driver?
To my knowledge, no. Patches welcome.
btw please stop top-posting
> Thanks,
> Philipp.
>
>
>> On 12 Sep 2017, at 07:02, Kever Yang <kever.yang@rock-chips.com> wrote:
>>
>> Philipp,
>>
>> I believe there are some request I think is not reasonable which stop me from update new patch sets.
>>
>> The usb/dwc3 is mess up now, separate in host mode and gadget mode, one need init in board init
>>
>> while another use DM. When I want to add a new feature like use 16bit UTMI+ instead of 8bit(which suppose to be very very simple),
>>
>> I don't think the maintainer have an idea where it should go and how it should be, and the driver now
>>
>> it's far away from upstream kernel.
>>
>> I have send 4 patch set for this, everything should be clear, but...
>>
>>
>>
>> Thanks,
>> - Kever
>> On 09/11/2017 09:30 PM, Philipp Tomsich wrote:
>>>
>>> Kever,
>>>
>>> What is the status on this patch (and the encapsulating series)?
>>> This seems to be stuck in 'changes requested' for about a year now...
>>>
>>> Thanks,
>>> Philipp.
>>>
>>> On Thu, 1 Sep 2016, Kever Yang wrote:
>>>
>>>> The dwc3 controller is using 8 bit UTMI+ interface for USB2.0 PHY,
>>>> add one variable in dwc3/dwc3_device struct to support 16 bit
>>>> UTMI+ interface on some SoCs like Rockchip rk3399.
>>>>
>>>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>>>> ---
>>>>
>>>> Changes in v4:
>>>> - use 1 bit for usb2_phyif_utmi_width instead of 5bit
>>>>
>>>> Changes in v3:
>>>> - Parse the DT for utmi+ interface width in dwc3 driver
>>>>
>>>> Changes in v2:
>>>> - use a variable to identify utmi+ bus width instead of CONFIG MACRO
>>>>
>>>> drivers/usb/dwc3/core.c | 19 +++++++++++++++++++
>>>> drivers/usb/dwc3/core.h | 12 ++++++++++++
>>>> 2 files changed, 31 insertions(+)
>>>>
>>>
>>
>>
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 16+ messages in thread
* [U-Boot] [U-Boot, v4, 3/4] usb: dwc3: add support for 16 bit UTMI+ interface
2017-09-12 10:22 ` Marek Vasut
@ 2017-09-12 10:50 ` Dr. Philipp Tomsich
0 siblings, 0 replies; 16+ messages in thread
From: Dr. Philipp Tomsich @ 2017-09-12 10:50 UTC (permalink / raw)
To: u-boot
Kever,
> On 12 Sep 2017, at 12:22, Marek Vasut <marex@denx.de> wrote:
>
> On 09/12/2017 11:09 AM, Dr. Philipp Tomsich wrote:
>> Marek,
>>
>> do you know whether there's an update of the DWC3 driver planned to get us back in sync with the kernel driver?
>
> To my knowledge, no. Patches welcome.
Could you summarise (for everyone involved) what the impact of this series not being merged is
in terms of functionality?
Once everyone is aware of what the objectives are, we can then try to revive the discussion and
agree on a specific set of changes (to the series) to move forward...
Cheers,
Philipp.
>
>> Thanks,
>> Philipp.
>>
>>
>>> On 12 Sep 2017, at 07:02, Kever Yang <kever.yang@rock-chips.com> wrote:
>>>
>>> Philipp,
>>>
>>> I believe there are some request I think is not reasonable which stop me from update new patch sets.
>>>
>>> The usb/dwc3 is mess up now, separate in host mode and gadget mode, one need init in board init
>>>
>>> while another use DM. When I want to add a new feature like use 16bit UTMI+ instead of 8bit(which suppose to be very very simple),
>>>
>>> I don't think the maintainer have an idea where it should go and how it should be, and the driver now
>>>
>>> it's far away from upstream kernel.
>>>
>>> I have send 4 patch set for this, everything should be clear, but...
>>>
>>>
>>>
>>> Thanks,
>>> - Kever
>>> On 09/11/2017 09:30 PM, Philipp Tomsich wrote:
>>>>
>>>> Kever,
>>>>
>>>> What is the status on this patch (and the encapsulating series)?
>>>> This seems to be stuck in 'changes requested' for about a year now...
>>>>
>>>> Thanks,
>>>> Philipp.
>>>>
>>>> On Thu, 1 Sep 2016, Kever Yang wrote:
>>>>
>>>>> The dwc3 controller is using 8 bit UTMI+ interface for USB2.0 PHY,
>>>>> add one variable in dwc3/dwc3_device struct to support 16 bit
>>>>> UTMI+ interface on some SoCs like Rockchip rk3399.
>>>>>
>>>>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>>>>> ---
>>>>>
>>>>> Changes in v4:
>>>>> - use 1 bit for usb2_phyif_utmi_width instead of 5bit
>>>>>
>>>>> Changes in v3:
>>>>> - Parse the DT for utmi+ interface width in dwc3 driver
>>>>>
>>>>> Changes in v2:
>>>>> - use a variable to identify utmi+ bus width instead of CONFIG MACRO
>>>>>
>>>>> drivers/usb/dwc3/core.c | 19 +++++++++++++++++++
>>>>> drivers/usb/dwc3/core.h | 12 ++++++++++++
>>>>> 2 files changed, 31 insertions(+)
>>>>>
>>>>
>>>
>>>
>>
>
>
> --
> Best regards,
> Marek Vasut
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2017-09-12 10:50 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-01 2:14 [U-Boot] [PATCH v4 0/4] rk3399: enable dwc3 gadget and fastboot Kever Yang
2016-09-01 2:14 ` [U-Boot] [PATCH v4 1/4] rk3399: add a empty "sys_proto.h" header file Kever Yang
2016-09-05 23:17 ` Simon Glass
2016-09-01 2:14 ` [U-Boot] [PATCH v4 2/4] board: evb-rk3399: add api to support dwc3 gadget Kever Yang
2016-09-01 8:59 ` Marek Vasut
2016-09-02 9:58 ` Kever Yang
2016-09-02 12:14 ` Marek Vasut
2016-09-01 2:14 ` [U-Boot] [PATCH v4 3/4] usb: dwc3: add support for 16 bit UTMI+ interface Kever Yang
2016-09-01 9:09 ` Marek Vasut
2016-09-02 10:00 ` Kever Yang
2017-09-11 13:30 ` [U-Boot] [U-Boot, v4, " Philipp Tomsich
2017-09-12 5:02 ` Kever Yang
2017-09-12 9:09 ` Dr. Philipp Tomsich
2017-09-12 10:22 ` Marek Vasut
2017-09-12 10:50 ` Dr. Philipp Tomsich
2016-09-01 2:14 ` [U-Boot] [PATCH v4 4/4] config: rk3399: add support for dwc3 gadget Kever Yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.