[LTP] [PATCH] utimensat: fix immutable file retcodes for 4.8.0 and newer.

[LTP] [PATCH] utimensat: fix immutable file retcodes for 4.8.0 and newer.

[Artem Savkov]

Kernel 4.8.0 contains patch "337684a fs: return EPERM on immutable inode" that
makes operations on immutable files return EPERM instead of EACCESS.

Adjust utimensat test to check new retcode for kernels 4.8.0 and newer.

Signed-off-by: Artem Savkov <asavkov@redhat.com>
---
 testcases/kernel/syscalls/utimensat/utimensat_tests.sh | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
index 4ae8651..708d454 100755
--- a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
+++ b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
@@ -30,6 +30,15 @@ if tst_kvercmp 2 6 22 ; then
 	tst_brkm TCONF "System kernel version is less than 2.6.22,cannot execute test"
 fi
 
+# Starting with 4.8.0 operations on immutable files return EPERM instead of
+# EACCES.
+if tst_kvercmp 4 8 0; then
+	imaccess=EACCES
+else
+	imaccess=EPERM
+fi
+
+
 RESULT_FILE=$TMPDIR/utimensat.result
 
 TEST_DIR=$TMPDIR/utimensat_tests
@@ -415,10 +424,10 @@ echo "Testing immutable file, owned by self"
 echo
 
 echo "***** Testing times==NULL case *****"
-run_test -W "" 600 "+i" "" EACCES
+run_test -W "" 600 "+i" "" $imaccess
 
 echo "***** Testing times=={ UTIME_NOW, UTIME_NOW } case *****"
-run_test -W "" 600 "+i" "0 n 0 n" EACCES
+run_test -W "" 600 "+i" "0 n 0 n" $imaccess
 
 echo "***** Testing times=={ UTIME_OMIT, UTIME_OMIT } case *****"
 run_test -W "" 600 "+i" "0 o 0 o" SUCCESS n n
@@ -441,10 +450,10 @@ echo "Testing immutable append-only file, owned by self"
 echo
 
 echo "***** Testing times==NULL case *****"
-run_test -W "" 600 "+ai" "" EACCES
+run_test -W "" 600 "+ai" "" $imaccess
 
 echo "***** Testing times=={ UTIME_NOW, UTIME_NOW } case *****"
-run_test -W "" 600 "+ai" "0 n 0 n" EACCES
+run_test -W "" 600 "+ai" "0 n 0 n" $imaccess
 
 echo "***** Testing times=={ UTIME_OMIT, UTIME_OMIT } case *****"
 run_test -W "" 600 "+ai" "0 o 0 o" SUCCESS n n
-- 
2.7.4

[LTP] [PATCH] utimensat: fix immutable file retcodes for 4.8.0 and newer.

[Jan Stancek]

----- Original Message -----
> From: "Artem Savkov" <asavkov@redhat.com>
> To: ltp@lists.linux.it
> Cc: chrubis@suse.cz, jstancek@redhat.com, "Artem Savkov" <asavkov@redhat.com>
> Sent: Thursday, 1 September, 2016 11:06:13 AM
> Subject: [PATCH] utimensat: fix immutable file retcodes for 4.8.0 and newer.
> 
> Kernel 4.8.0 contains patch "337684a fs: return EPERM on immutable inode"
> that
> makes operations on immutable files return EPERM instead of EACCESS.
> 
> Adjust utimensat test to check new retcode for kernels 4.8.0 and newer.
> 
> Signed-off-by: Artem Savkov <asavkov@redhat.com>
> ---

Looks good. 4.8 hasn't been released yet, so this patch is only in
-rc builds so far. We don't try to mirror -rc changes as closely
since things are sometimes unstable/get reverted/etc. So as fyi,
we'll probably push this only after 4.8 gets released.

Regards,
Jan

[LTP] [PATCH] utimensat: fix immutable file retcodes for 4.8.0 and newer.

[Jan Stancek]

----- Original Message -----
> From: "Artem Savkov" <asavkov@redhat.com>
> To: ltp@lists.linux.it
> Cc: chrubis@suse.cz, jstancek@redhat.com, "Artem Savkov" <asavkov@redhat.com>
> Sent: Thursday, 1 September, 2016 11:06:13 AM
> Subject: [PATCH] utimensat: fix immutable file retcodes for 4.8.0 and newer.
> 
> Kernel 4.8.0 contains patch "337684a fs: return EPERM on immutable inode"
> that
> makes operations on immutable files return EPERM instead of EACCESS.
> 
> Adjust utimensat test to check new retcode for kernels 4.8.0 and newer.
> 
> Signed-off-by: Artem Savkov <asavkov@redhat.com>

Pushed.

Thanks,
Jan