[B.A.T.M.A.N.] [PATCH] batman-adv: remove returns at the end of void functions

[B.A.T.M.A.N.] [PATCH] batman-adv: remove returns at the end of void functions

[Antonio Quartulli]

Return at the end of void functions is not needed.

Since most of the void functions in the code do not do so,
make all the others consistent by removing the useless
returns. Actually all the functions to be "fixed" are in
network-coding.h only.

Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
---
 network-coding.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/network-coding.h b/network-coding.h
index 6b1a5d7..b16639f 100644
--- a/network-coding.h
+++ b/network-coding.h
@@ -59,7 +59,6 @@ static inline int batadv_nc_mesh_init(struct batadv_priv *bat_priv)
 
 static inline void batadv_nc_mesh_free(struct batadv_priv *bat_priv)
 {
-	return;
 }
 
 static inline void
@@ -69,7 +68,6 @@ batadv_nc_update_nc_node(struct batadv_priv *bat_priv,
 			 struct batadv_ogm_packet *ogm_packet,
 			 int is_single_hop_neigh)
 {
-	return;
 }
 
 static inline void
@@ -78,17 +76,14 @@ batadv_nc_purge_orig(struct batadv_priv *bat_priv,
 		     bool (*to_purge)(struct batadv_priv *,
 				      struct batadv_nc_node *))
 {
-	return;
 }
 
 static inline void batadv_nc_init_bat_priv(struct batadv_priv *bat_priv)
 {
-	return;
 }
 
 static inline void batadv_nc_init_orig(struct batadv_orig_node *orig_node)
 {
-	return;
 }
 
 static inline bool batadv_nc_skb_forward(struct sk_buff *skb,
@@ -101,14 +96,12 @@ static inline void
 batadv_nc_skb_store_for_decoding(struct batadv_priv *bat_priv,
 				 struct sk_buff *skb)
 {
-	return;
 }
 
 static inline void
 batadv_nc_skb_store_sniffed_unicast(struct batadv_priv *bat_priv,
 				    struct sk_buff *skb)
 {
-	return;
 }
 
 static inline int batadv_nc_nodes_seq_print_text(struct seq_file *seq,
-- 
1.8.4.3

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: remove returns at the end of void functions

[Marek Lindner]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

On Saturday 16 November 2013 23:02:51 Antonio Quartulli wrote:
> Return at the end of void functions is not needed.
> 
> Since most of the void functions in the code do not do so,
> make all the others consistent by removing the useless
> returns. Actually all the functions to be "fixed" are in
> network-coding.h only.
> 
> Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
> ---
>  network-coding.h | 7 -------
>  1 file changed, 7 deletions(-)

Applied in revision 2826f30.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]