All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] arm64: marvell: MSI support updates
@ 2016-09-01 15:41 Thomas Petazzoni
  2016-09-01 15:41 ` [PATCH 1/2] arm64: dts: marvell: remove msi-parent from PCIe on Armada 3700 Thomas Petazzoni
  2016-09-01 15:41 ` [PATCH 2/2] arm64: dts: marvell: enable MSI for PCIe on Armada 7K/8K Thomas Petazzoni
  0 siblings, 2 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2016-09-01 15:41 UTC (permalink / raw)
  To: linux-arm-kernel

Hello,

This small set of patches brings some MSI updates on Armada 3700 and
Armada 7K/8K:

 - On Armada 3700, it removes a useless msi-parent property. This
   patch should only be merged once "pci: pci-aardvark: move to MSI
   handling using generic MSI support" has been applied and merged by
   the PCI maintainer, otherwise MSI support will be broken.

 - On Armada 7K/8K, it enables MSI support by using the GIC
   v2m. Adding an msi-parent property is enough to achieve this. This
   can be applied right away.

Thanks,

Thomas

Thomas Petazzoni (2):
  arm64: dts: marvell: remove msi-parent from PCIe on Armada 3700
  arm64: dts: marvell: enable MSI for PCIe on Armada 7K/8K

 arch/arm64/boot/dts/marvell/armada-37xx.dtsi         | 1 -
 arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi | 3 +++
 arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi  | 3 +++
 3 files changed, 6 insertions(+), 1 deletion(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 1/2] arm64: dts: marvell: remove msi-parent from PCIe on Armada 3700
  2016-09-01 15:41 [PATCH 0/2] arm64: marvell: MSI support updates Thomas Petazzoni
@ 2016-09-01 15:41 ` Thomas Petazzoni
  2017-02-15 14:12   ` Gregory CLEMENT
  2016-09-01 15:41 ` [PATCH 2/2] arm64: dts: marvell: enable MSI for PCIe on Armada 7K/8K Thomas Petazzoni
  1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2016-09-01 15:41 UTC (permalink / raw)
  To: linux-arm-kernel

Following the switch of the Aardvark PCIe controller driver to the
generic MSI support, the msi-parent property in the PCIe controller,
pointing to itself is no longer needed: since the MSI irq domain is
associated to the PCIe controller Device Tree node, this is sufficient
for the interrupt resolution logic to work.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
Please only apply once "pci: pci-aardvark: move to MSI handling using
generic MSI support" is merged, or it will break MSI support on Armada
3700.
---
 arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
index c476253..e56a34a 100644
--- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
@@ -187,7 +187,6 @@
 			bus-range = <0x00 0xff>;
 			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
 			#interrupt-cells = <1>;
-			msi-parent = <&pcie0>;
 			msi-controller;
 			ranges = <0x82000000 0 0xe8000000   0 0xe8000000 0 0x1000000 /* Port 0 MEM */
 				  0x81000000 0 0xe9000000   0 0xe9000000 0 0x10000>; /* Port 0 IO*/
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: marvell: enable MSI for PCIe on Armada 7K/8K
  2016-09-01 15:41 [PATCH 0/2] arm64: marvell: MSI support updates Thomas Petazzoni
  2016-09-01 15:41 ` [PATCH 1/2] arm64: dts: marvell: remove msi-parent from PCIe on Armada 3700 Thomas Petazzoni
@ 2016-09-01 15:41 ` Thomas Petazzoni
  2016-09-14 14:21   ` Gregory CLEMENT
  1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2016-09-01 15:41 UTC (permalink / raw)
  To: linux-arm-kernel

This commit adds a reference to the appropriate MSI controller in the
description of the PCIe controllers on Marvel Armada 7K and 8K
platforms.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi | 3 +++
 arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi  | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
index ceb83b0..ff469e1 100644
--- a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
@@ -177,6 +177,7 @@
 			#interrupt-cells = <1>;
 			device_type = "pci";
 			dma-coherent;
+			msi-parent = <&gic_v2m0>;
 
 			bus-range = <0 0xff>;
 			ranges =
@@ -202,6 +203,7 @@
 			#interrupt-cells = <1>;
 			device_type = "pci";
 			dma-coherent;
+			msi-parent = <&gic_v2m0>;
 
 			bus-range = <0 0xff>;
 			ranges =
@@ -228,6 +230,7 @@
 			#interrupt-cells = <1>;
 			device_type = "pci";
 			dma-coherent;
+			msi-parent = <&gic_v2m0>;
 
 			bus-range = <0 0xff>;
 			ranges =
diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
index 2d863f2..43cecf0 100644
--- a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
@@ -177,6 +177,7 @@
 			#interrupt-cells = <1>;
 			device_type = "pci";
 			dma-coherent;
+			msi-parent = <&gic_v2m0>;
 
 			bus-range = <0 0xff>;
 			ranges =
@@ -202,6 +203,7 @@
 			#interrupt-cells = <1>;
 			device_type = "pci";
 			dma-coherent;
+			msi-parent = <&gic_v2m0>;
 
 			bus-range = <0 0xff>;
 			ranges =
@@ -228,6 +230,7 @@
 			#interrupt-cells = <1>;
 			device_type = "pci";
 			dma-coherent;
+			msi-parent = <&gic_v2m0>;
 
 			bus-range = <0 0xff>;
 			ranges =
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: marvell: enable MSI for PCIe on Armada 7K/8K
  2016-09-01 15:41 ` [PATCH 2/2] arm64: dts: marvell: enable MSI for PCIe on Armada 7K/8K Thomas Petazzoni
@ 2016-09-14 14:21   ` Gregory CLEMENT
  0 siblings, 0 replies; 6+ messages in thread
From: Gregory CLEMENT @ 2016-09-14 14:21 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Thomas,
 
 On jeu., sept. 01 2016, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> This commit adds a reference to the appropriate MSI controller in the
> description of the PCIe controllers on Marvel Armada 7K and 8K
> platforms.

Applied on mvebu/dt64

Thanks,

Gregory

>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi | 3 +++
>  arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi  | 3 +++
>  2 files changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
> index ceb83b0..ff469e1 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
> @@ -177,6 +177,7 @@
>  			#interrupt-cells = <1>;
>  			device_type = "pci";
>  			dma-coherent;
> +			msi-parent = <&gic_v2m0>;
>  
>  			bus-range = <0 0xff>;
>  			ranges =
> @@ -202,6 +203,7 @@
>  			#interrupt-cells = <1>;
>  			device_type = "pci";
>  			dma-coherent;
> +			msi-parent = <&gic_v2m0>;
>  
>  			bus-range = <0 0xff>;
>  			ranges =
> @@ -228,6 +230,7 @@
>  			#interrupt-cells = <1>;
>  			device_type = "pci";
>  			dma-coherent;
> +			msi-parent = <&gic_v2m0>;
>  
>  			bus-range = <0 0xff>;
>  			ranges =
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
> index 2d863f2..43cecf0 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
> @@ -177,6 +177,7 @@
>  			#interrupt-cells = <1>;
>  			device_type = "pci";
>  			dma-coherent;
> +			msi-parent = <&gic_v2m0>;
>  
>  			bus-range = <0 0xff>;
>  			ranges =
> @@ -202,6 +203,7 @@
>  			#interrupt-cells = <1>;
>  			device_type = "pci";
>  			dma-coherent;
> +			msi-parent = <&gic_v2m0>;
>  
>  			bus-range = <0 0xff>;
>  			ranges =
> @@ -228,6 +230,7 @@
>  			#interrupt-cells = <1>;
>  			device_type = "pci";
>  			dma-coherent;
> +			msi-parent = <&gic_v2m0>;
>  
>  			bus-range = <0 0xff>;
>  			ranges =
> -- 
> 2.7.4
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 1/2] arm64: dts: marvell: remove msi-parent from PCIe on Armada 3700
  2016-09-01 15:41 ` [PATCH 1/2] arm64: dts: marvell: remove msi-parent from PCIe on Armada 3700 Thomas Petazzoni
@ 2017-02-15 14:12   ` Gregory CLEMENT
  2017-02-15 14:21     ` Thomas Petazzoni
  0 siblings, 1 reply; 6+ messages in thread
From: Gregory CLEMENT @ 2017-02-15 14:12 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Thomas,
 
 On jeu., sept. 01 2016, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> Following the switch of the Aardvark PCIe controller driver to the
> generic MSI support, the msi-parent property in the PCIe controller,
> pointing to itself is no longer needed: since the MSI irq domain is
> associated to the PCIe controller Device Tree node, this is sufficient
> for the interrupt resolution logic to work.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> Please only apply once "pci: pci-aardvark: move to MSI handling using
> generic MSI support" is merged, or it will break MSI support on Armada
> 3700.

What is the status of this patch?
Can I remove it from my mailbox?

it seemed that "pci: pci-aardvark: move to MSI handling using generic
MSI support" was never merged.

Thanks,

Gregory

> ---
>  arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> index c476253..e56a34a 100644
> --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> @@ -187,7 +187,6 @@
>  			bus-range = <0x00 0xff>;
>  			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
>  			#interrupt-cells = <1>;
> -			msi-parent = <&pcie0>;
>  			msi-controller;
>  			ranges = <0x82000000 0 0xe8000000   0 0xe8000000 0 0x1000000 /* Port 0 MEM */
>  				  0x81000000 0 0xe9000000   0 0xe9000000 0 0x10000>; /* Port 0 IO*/
> -- 
> 2.7.4
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 1/2] arm64: dts: marvell: remove msi-parent from PCIe on Armada 3700
  2017-02-15 14:12   ` Gregory CLEMENT
@ 2017-02-15 14:21     ` Thomas Petazzoni
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2017-02-15 14:21 UTC (permalink / raw)
  To: linux-arm-kernel

Hello,

On Wed, 15 Feb 2017 15:12:44 +0100, Gregory CLEMENT wrote:

> What is the status of this patch?
> Can I remove it from my mailbox?

Yes, remove it from your inbox, I'll resend once the patch it depends
on has been merged.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-02-15 14:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-01 15:41 [PATCH 0/2] arm64: marvell: MSI support updates Thomas Petazzoni
2016-09-01 15:41 ` [PATCH 1/2] arm64: dts: marvell: remove msi-parent from PCIe on Armada 3700 Thomas Petazzoni
2017-02-15 14:12   ` Gregory CLEMENT
2017-02-15 14:21     ` Thomas Petazzoni
2016-09-01 15:41 ` [PATCH 2/2] arm64: dts: marvell: enable MSI for PCIe on Armada 7K/8K Thomas Petazzoni
2016-09-14 14:21   ` Gregory CLEMENT

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.