* WTF: patch "[PATCH] ARC: export __udivdi3 for modules" was seriously submitted to be applied to the 4.7-stable tree?
@ 2016-09-05 13:04 gregkh
2016-09-06 16:52 ` Vineet Gupta
0 siblings, 1 reply; 2+ messages in thread
From: gregkh @ 2016-09-05 13:04 UTC (permalink / raw)
To: vgupta; +Cc: stable
The patch below was submitted to be applied to the 4.7-stable tree.
I fail to see how this patch meets the stable kernel rules as found at
Documentation/stable_kernel_rules.txt.
I could be totally wrong, and if so, please respond to
<stable@vger.kernel.org> and let me know why this patch should be
applied. Otherwise, it is now dropped from my patch queues, never to be
seen again.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
>From c57653dc94d0db7bf63067433ceaa97bdcd0a312 Mon Sep 17 00:00:00 2001
From: Vineet Gupta <vgupta@synopsys.com>
Date: Fri, 19 Aug 2016 13:59:02 -0700
Subject: [PATCH] ARC: export __udivdi3 for modules
Some module using div_u64() was failing to link because the libgcc 64-bit
divide assist routine was not being exported for modules
Reported-by: avinashp@quantenna.com
Cc: stable@vger.kernel.org
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
diff --git a/arch/arc/kernel/arcksyms.c b/arch/arc/kernel/arcksyms.c
index 4d9e77724bed..000dd041ab42 100644
--- a/arch/arc/kernel/arcksyms.c
+++ b/arch/arc/kernel/arcksyms.c
@@ -28,6 +28,7 @@ extern void __muldf3(void);
extern void __divdf3(void);
extern void __floatunsidf(void);
extern void __floatunsisf(void);
+extern void __udivdi3(void);
EXPORT_SYMBOL(__ashldi3);
EXPORT_SYMBOL(__ashrdi3);
@@ -45,6 +46,7 @@ EXPORT_SYMBOL(__muldf3);
EXPORT_SYMBOL(__divdf3);
EXPORT_SYMBOL(__floatunsidf);
EXPORT_SYMBOL(__floatunsisf);
+EXPORT_SYMBOL(__udivdi3);
/* ARC optimised assembler routines */
EXPORT_SYMBOL(memset);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: WTF: patch "[PATCH] ARC: export __udivdi3 for modules" was seriously submitted to be applied to the 4.7-stable tree?
2016-09-05 13:04 WTF: patch "[PATCH] ARC: export __udivdi3 for modules" was seriously submitted to be applied to the 4.7-stable tree? gregkh
@ 2016-09-06 16:52 ` Vineet Gupta
0 siblings, 0 replies; 2+ messages in thread
From: Vineet Gupta @ 2016-09-06 16:52 UTC (permalink / raw)
To: gregkh; +Cc: stable
On 09/05/2016 06:04 AM, gregkh@linuxfoundation.org wrote:
> The patch below was submitted to be applied to the 4.7-stable tree.
>
> I fail to see how this patch meets the stable kernel rules as found at
> Documentation/stable_kernel_rules.txt.
>
> I could be totally wrong, and if so, please respond to
> <stable@vger.kernel.org> and let me know why this patch should be
> applied. Otherwise, it is now dropped from my patch queues, never to be
> seen again.
Hi Greg,
This again is a fallout of gcc 6.x usage - the generated code now has a reference
to a libgcc routine which was not called before - hence the need for export in
modules.
Thx,
-Vineet
>
> thanks,
>
> greg k-h
>
> ------------------ original commit in Linus's tree ------------------
>
> From c57653dc94d0db7bf63067433ceaa97bdcd0a312 Mon Sep 17 00:00:00 2001
> From: Vineet Gupta <vgupta@synopsys.com>
> Date: Fri, 19 Aug 2016 13:59:02 -0700
> Subject: [PATCH] ARC: export __udivdi3 for modules
>
> Some module using div_u64() was failing to link because the libgcc 64-bit
> divide assist routine was not being exported for modules
>
> Reported-by: avinashp@quantenna.com
> Cc: stable@vger.kernel.org
> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
>
> diff --git a/arch/arc/kernel/arcksyms.c b/arch/arc/kernel/arcksyms.c
> index 4d9e77724bed..000dd041ab42 100644
> --- a/arch/arc/kernel/arcksyms.c
> +++ b/arch/arc/kernel/arcksyms.c
> @@ -28,6 +28,7 @@ extern void __muldf3(void);
> extern void __divdf3(void);
> extern void __floatunsidf(void);
> extern void __floatunsisf(void);
> +extern void __udivdi3(void);
>
> EXPORT_SYMBOL(__ashldi3);
> EXPORT_SYMBOL(__ashrdi3);
> @@ -45,6 +46,7 @@ EXPORT_SYMBOL(__muldf3);
> EXPORT_SYMBOL(__divdf3);
> EXPORT_SYMBOL(__floatunsidf);
> EXPORT_SYMBOL(__floatunsisf);
> +EXPORT_SYMBOL(__udivdi3);
>
> /* ARC optimised assembler routines */
> EXPORT_SYMBOL(memset);
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-06 16:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-05 13:04 WTF: patch "[PATCH] ARC: export __udivdi3 for modules" was seriously submitted to be applied to the 4.7-stable tree? gregkh
2016-09-06 16:52 ` Vineet Gupta
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.