[PATCH v2 1/4] ARM: dts: imx23: Remove skeleton.dtsi inclusion

[PATCH v2 1/4] ARM: dts: imx23: Remove skeleton.dtsi inclusion

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@nxp.com>

Remove skeleton.dtsi to avoid the following build warning with W=1:

Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Changes since v1:
- Remove skeleton.dtsi dependency (Rob)

 arch/arm/boot/dts/imx23.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx23.dtsi b/arch/arm/boot/dts/imx23.dtsi
index 440ee9a..9d0e9e1 100644
--- a/arch/arm/boot/dts/imx23.dtsi
+++ b/arch/arm/boot/dts/imx23.dtsi
@@ -9,10 +9,12 @@
  * http://www.gnu.org/copyleft/gpl.html
  */
 
-#include "skeleton.dtsi"
 #include "imx23-pinfunc.h"
 
 / {
+	#address-cells = <1>;
+	#size-cells = <1>;
+
 	interrupt-parent = <&icoll>;
 
 	aliases {
-- 
1.9.1

[PATCH v2 2/4] ARM: dts: imx28: Remove skeleton.dtsi inclusion

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@nxp.com>

Remove skeleton.dtsi to avoid the following build warning with W=1:

Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Changes since v1:
- Remove skeleton.dtsi dependency (Rob)

 arch/arm/boot/dts/imx28.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index 0ad893b..3aabf65 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -10,10 +10,12 @@
  */
 
 #include <dt-bindings/gpio/gpio.h>
-#include "skeleton.dtsi"
 #include "imx28-pinfunc.h"
 
 / {
+	#address-cells = <1>;
+	#size-cells = <1>;
+
 	interrupt-parent = <&icoll>;
 
 	aliases {
-- 
1.9.1

[PATCH v2 3/4] ARM: dts: imx23: Fix build warnings with W=1

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@nxp.com>

Fix the following build warnings with W=1:

Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

While at it, also pass the 'device_type' property as recommended by the
ePAPR specification.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Changes since v1:
- None

 arch/arm/boot/dts/imx23-evk.dts           | 3 ++-
 arch/arm/boot/dts/imx23-olinuxino.dts     | 3 ++-
 arch/arm/boot/dts/imx23-sansa.dts         | 3 ++-
 arch/arm/boot/dts/imx23-stmp378x_devb.dts | 3 ++-
 arch/arm/boot/dts/imx23-xfi3.dts          | 3 ++-
 5 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/imx23-evk.dts b/arch/arm/boot/dts/imx23-evk.dts
index 57e2997..bd06402 100644
--- a/arch/arm/boot/dts/imx23-evk.dts
+++ b/arch/arm/boot/dts/imx23-evk.dts
@@ -16,7 +16,8 @@
 	model = "Freescale i.MX23 Evaluation Kit";
 	compatible = "fsl,imx23-evk", "fsl,imx23";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x08000000>;
 	};
 
diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts b/arch/arm/boot/dts/imx23-olinuxino.dts
index a8b1c53..109f516 100644
--- a/arch/arm/boot/dts/imx23-olinuxino.dts
+++ b/arch/arm/boot/dts/imx23-olinuxino.dts
@@ -19,7 +19,8 @@
 	model = "i.MX23 Olinuxino Low Cost Board";
 	compatible = "olimex,imx23-olinuxino", "fsl,imx23";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x04000000>;
 	};
 
diff --git a/arch/arm/boot/dts/imx23-sansa.dts b/arch/arm/boot/dts/imx23-sansa.dts
index 4ec32f4..9cf40d3 100644
--- a/arch/arm/boot/dts/imx23-sansa.dts
+++ b/arch/arm/boot/dts/imx23-sansa.dts
@@ -48,7 +48,8 @@
 	model = "SanDisk Sansa Fuze+";
 	compatible = "sandisk,sansa_fuze_plus", "fsl,imx23";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x04000000>;
 	};
 
diff --git a/arch/arm/boot/dts/imx23-stmp378x_devb.dts b/arch/arm/boot/dts/imx23-stmp378x_devb.dts
index 455169e..aab0293 100644
--- a/arch/arm/boot/dts/imx23-stmp378x_devb.dts
+++ b/arch/arm/boot/dts/imx23-stmp378x_devb.dts
@@ -16,7 +16,8 @@
 	model = "Freescale STMP378x Development Board";
 	compatible = "fsl,stmp378x-devb", "fsl,imx23";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x04000000>;
 	};
 
diff --git a/arch/arm/boot/dts/imx23-xfi3.dts b/arch/arm/boot/dts/imx23-xfi3.dts
index 025cf94..2b5df8d 100644
--- a/arch/arm/boot/dts/imx23-xfi3.dts
+++ b/arch/arm/boot/dts/imx23-xfi3.dts
@@ -48,7 +48,8 @@
 	model = "Creative ZEN X-Fi3";
 	compatible = "creative,x-fi3", "fsl,imx23";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x04000000>;
 	};
 
-- 
1.9.1

[PATCH v2 4/4] ARM: dts: imx28: Fix build warnings with W=1

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@nxp.com>

Fix the following build warnings with W=1:

Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

While at it, also pass the 'device_type' property as recommended by the
ePAPR specification.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Changes since v1:
- None

 arch/arm/boot/dts/imx28-apf28.dts            | 3 ++-
 arch/arm/boot/dts/imx28-apx4devkit.dts       | 3 ++-
 arch/arm/boot/dts/imx28-cfa10036.dts         | 3 ++-
 arch/arm/boot/dts/imx28-duckbill.dts         | 3 ++-
 arch/arm/boot/dts/imx28-eukrea-mbmx283lc.dts | 3 ++-
 arch/arm/boot/dts/imx28-eukrea-mbmx287lc.dts | 3 ++-
 arch/arm/boot/dts/imx28-evk.dts              | 3 ++-
 arch/arm/boot/dts/imx28-m28.dtsi             | 3 ++-
 arch/arm/boot/dts/imx28-m28cu3.dts           | 3 ++-
 arch/arm/boot/dts/imx28-sps1.dts             | 3 ++-
 arch/arm/boot/dts/imx28-tx28.dts             | 3 ++-
 11 files changed, 22 insertions(+), 11 deletions(-)

diff --git a/arch/arm/boot/dts/imx28-apf28.dts b/arch/arm/boot/dts/imx28-apf28.dts
index 070e59c..b6976fb 100644
--- a/arch/arm/boot/dts/imx28-apf28.dts
+++ b/arch/arm/boot/dts/imx28-apf28.dts
@@ -16,7 +16,8 @@
 	model = "Armadeus Systems APF28 module";
 	compatible = "armadeus,imx28-apf28", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x08000000>;
 	};
 
diff --git a/arch/arm/boot/dts/imx28-apx4devkit.dts b/arch/arm/boot/dts/imx28-apx4devkit.dts
index 1092b76..ce6115e 100644
--- a/arch/arm/boot/dts/imx28-apx4devkit.dts
+++ b/arch/arm/boot/dts/imx28-apx4devkit.dts
@@ -5,7 +5,8 @@
 	model = "Bluegiga APX4 Development Kit";
 	compatible = "bluegiga,apx4devkit", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x04000000>;
 	};
 
diff --git a/arch/arm/boot/dts/imx28-cfa10036.dts b/arch/arm/boot/dts/imx28-cfa10036.dts
index 570aa33..d016a3b 100644
--- a/arch/arm/boot/dts/imx28-cfa10036.dts
+++ b/arch/arm/boot/dts/imx28-cfa10036.dts
@@ -16,7 +16,8 @@
 	model = "Crystalfontz CFA-10036 Board";
 	compatible = "crystalfontz,cfa10036", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x08000000>;
 	};
 
diff --git a/arch/arm/boot/dts/imx28-duckbill.dts b/arch/arm/boot/dts/imx28-duckbill.dts
index ce1a7ef..b5bc3f5 100644
--- a/arch/arm/boot/dts/imx28-duckbill.dts
+++ b/arch/arm/boot/dts/imx28-duckbill.dts
@@ -16,7 +16,8 @@
 	model = "I2SE Duckbill";
 	compatible = "i2se,duckbill", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x08000000>;
 	};
 
diff --git a/arch/arm/boot/dts/imx28-eukrea-mbmx283lc.dts b/arch/arm/boot/dts/imx28-eukrea-mbmx283lc.dts
index 7c1572c..28dab6d 100644
--- a/arch/arm/boot/dts/imx28-eukrea-mbmx283lc.dts
+++ b/arch/arm/boot/dts/imx28-eukrea-mbmx283lc.dts
@@ -23,7 +23,8 @@
 	model = "Eukrea Electromatique MBMX283LC";
 	compatible = "eukrea,mbmx283lc", "eukrea,mbmx28lc", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x04000000>;
 	};
 };
diff --git a/arch/arm/boot/dts/imx28-eukrea-mbmx287lc.dts b/arch/arm/boot/dts/imx28-eukrea-mbmx287lc.dts
index e773144..08125e5 100644
--- a/arch/arm/boot/dts/imx28-eukrea-mbmx287lc.dts
+++ b/arch/arm/boot/dts/imx28-eukrea-mbmx287lc.dts
@@ -22,7 +22,8 @@
 	model = "Eukrea Electromatique MBMX287LC";
 	compatible = "eukrea,mbmx287lc", "eukrea,mbmx283lc", "eukrea,mbmx28lc", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x08000000>;
 	};
 };
diff --git a/arch/arm/boot/dts/imx28-evk.dts b/arch/arm/boot/dts/imx28-evk.dts
index a5ba669..4cd8216 100644
--- a/arch/arm/boot/dts/imx28-evk.dts
+++ b/arch/arm/boot/dts/imx28-evk.dts
@@ -16,7 +16,8 @@
 	model = "Freescale i.MX28 Evaluation Kit";
 	compatible = "fsl,imx28-evk", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x08000000>;
 	};
 
diff --git a/arch/arm/boot/dts/imx28-m28.dtsi b/arch/arm/boot/dts/imx28-m28.dtsi
index 214bb15..1bcba90 100644
--- a/arch/arm/boot/dts/imx28-m28.dtsi
+++ b/arch/arm/boot/dts/imx28-m28.dtsi
@@ -15,7 +15,8 @@
 	model = "DENX M28";
 	compatible = "denx,m28", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x08000000>;
 	};
 
diff --git a/arch/arm/boot/dts/imx28-m28cu3.dts b/arch/arm/boot/dts/imx28-m28cu3.dts
index 2df63be..c4c4cc7 100644
--- a/arch/arm/boot/dts/imx28-m28cu3.dts
+++ b/arch/arm/boot/dts/imx28-m28cu3.dts
@@ -16,7 +16,8 @@
 	model = "MSR M28CU3";
 	compatible = "msr,m28cu3", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x08000000>;
 	};
 
diff --git a/arch/arm/boot/dts/imx28-sps1.dts b/arch/arm/boot/dts/imx28-sps1.dts
index 0ce3cb8..5ddfb16 100644
--- a/arch/arm/boot/dts/imx28-sps1.dts
+++ b/arch/arm/boot/dts/imx28-sps1.dts
@@ -16,7 +16,8 @@
 	model = "SchulerControl GmbH, SC SPS 1";
 	compatible = "schulercontrol,imx28-sps1", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x08000000>;
 	};
 
diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
index 0ebbc83..b4d4dbb 100644
--- a/arch/arm/boot/dts/imx28-tx28.dts
+++ b/arch/arm/boot/dts/imx28-tx28.dts
@@ -35,7 +35,8 @@
 		usbotg = &usb0;
 	};
 
-	memory {
+	memory at 0 {
+		device_type = "memory";
 		reg = <0 0>; /* will be filled in by U-Boot */
 	};
 
-- 
1.9.1

[PATCH v2 4/4] ARM: dts: imx28: Fix build warnings with W=1

[Shawn Guo]

On Mon, Sep 05, 2016 at 04:27:50PM -0300, Fabio Estevam wrote:
> diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> index 0ebbc83..b4d4dbb 100644
> --- a/arch/arm/boot/dts/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/imx28-tx28.dts
> @@ -35,7 +35,8 @@
>  		usbotg = &usb0;
>  	};
>  
> -	memory {
> +	memory at 0 {
> +		device_type = "memory";
>  		reg = <0 0>; /* will be filled in by U-Boot */

I'm curious to know if the unit-address will be fixed up or not when
'reg' property gets updated by U-Boot.

Shawn

>  	};
>  
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v2 4/4] ARM: dts: imx28: Fix build warnings with W=1

[Lothar Waßmann]

Hi,

On Thu, 8 Sep 2016 22:03:38 +0800 Shawn Guo wrote:
> On Mon, Sep 05, 2016 at 04:27:50PM -0300, Fabio Estevam wrote:
> > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> > index 0ebbc83..b4d4dbb 100644
> > --- a/arch/arm/boot/dts/imx28-tx28.dts
> > +++ b/arch/arm/boot/dts/imx28-tx28.dts
> > @@ -35,7 +35,8 @@
> >  		usbotg = &usb0;
> >  	};
> >  
> > -	memory {
> > +	memory at 0 {
> > +		device_type = "memory";
> >  		reg = <0 0>; /* will be filled in by U-Boot */
> 
> I'm curious to know if the unit-address will be fixed up or not when
> 'reg' property gets updated by U-Boot.
> 
No. U-Boot does not change the unit name, when updating in the reg
property. But that does not do any harm (for now), thus the change is
OK.


Lothar Wa?mann

[PATCH v2 4/4] ARM: dts: imx28: Fix build warnings with W=1

[Shawn Guo]

On Fri, Sep 09, 2016 at 09:14:41AM +0200, Lothar Wa?mann wrote:
> Hi,
> 
> On Thu, 8 Sep 2016 22:03:38 +0800 Shawn Guo wrote:
> > On Mon, Sep 05, 2016 at 04:27:50PM -0300, Fabio Estevam wrote:
> > > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> > > index 0ebbc83..b4d4dbb 100644
> > > --- a/arch/arm/boot/dts/imx28-tx28.dts
> > > +++ b/arch/arm/boot/dts/imx28-tx28.dts
> > > @@ -35,7 +35,8 @@
> > >  		usbotg = &usb0;
> > >  	};
> > >  
> > > -	memory {
> > > +	memory at 0 {
> > > +		device_type = "memory";
> > >  		reg = <0 0>; /* will be filled in by U-Boot */
> > 
> > I'm curious to know if the unit-address will be fixed up or not when
> > 'reg' property gets updated by U-Boot.
> > 
> No. U-Boot does not change the unit name, when updating in the reg
> property. But that does not do any harm (for now), thus the change is
> OK.

This is confusing when people is looking at nodes in /proc/device-tree.
Why cannot we give it a reasonable default configuration instead of
<0 0>?

Shawn

[PATCH v2 4/4] ARM: dts: imx28: Fix build warnings with W=1

[Javier Martinez Canillas]

Hello Shawn,

On Mon, Sep 12, 2016 at 8:09 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Fri, Sep 09, 2016 at 09:14:41AM +0200, Lothar Wa?mann wrote:
>> Hi,
>>
>> On Thu, 8 Sep 2016 22:03:38 +0800 Shawn Guo wrote:
>> > On Mon, Sep 05, 2016 at 04:27:50PM -0300, Fabio Estevam wrote:
>> > > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
>> > > index 0ebbc83..b4d4dbb 100644
>> > > --- a/arch/arm/boot/dts/imx28-tx28.dts
>> > > +++ b/arch/arm/boot/dts/imx28-tx28.dts
>> > > @@ -35,7 +35,8 @@
>> > >           usbotg = &usb0;
>> > >   };
>> > >
>> > > - memory {
>> > > + memory at 0 {
>> > > +         device_type = "memory";
>> > >           reg = <0 0>; /* will be filled in by U-Boot */
>> >
>> > I'm curious to know if the unit-address will be fixed up or not when
>> > 'reg' property gets updated by U-Boot.
>> >
>> No. U-Boot does not change the unit name, when updating in the reg
>> property. But that does not do any harm (for now), thus the change is
>> OK.
>
> This is confusing when people is looking at nodes in /proc/device-tree.
> Why cannot we give it a reasonable default configuration instead of
> <0 0>?
>

Another option is to not have a memory node if the start address is
not known at build time, since U-boot creates a memory node if is not
found in the FDT.

> Shawn
>

Best regards,
Javier

[PATCH v2 3/4] ARM: dts: imx23: Fix build warnings with W=1

[Stefan Wahren]

> Fabio Estevam <festevam@gmail.com> hat am 5. September 2016 um 21:27
> geschrieben:
> 
> 
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Fix the following build warnings with W=1:
> 
> Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but
> no unit name
> 
> While at it, also pass the 'device_type' property as recommended by the
> ePAPR specification.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Patch 1 and 3 works for my Olinuxino board.

Tested-by: Stefan Wahren <stefan.wahren@i2se.com>

[PATCH v2 4/4] ARM: dts: imx28: Fix build warnings with W=1

[Fabio Estevam]

Hi Shawn,

On Thu, Sep 8, 2016 at 11:03 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Mon, Sep 05, 2016 at 04:27:50PM -0300, Fabio Estevam wrote:
>> diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
>> index 0ebbc83..b4d4dbb 100644
>> --- a/arch/arm/boot/dts/imx28-tx28.dts
>> +++ b/arch/arm/boot/dts/imx28-tx28.dts
>> @@ -35,7 +35,8 @@
>>               usbotg = &usb0;
>>       };
>>
>> -     memory {
>> +     memory at 0 {
>> +             device_type = "memory";
>>               reg = <0 0>; /* will be filled in by U-Boot */
>
> I'm curious to know if the unit-address will be fixed up or not when
> 'reg' property gets updated by U-Boot.

Should I resend this series and keep imx28-tx28.dts unmodified?

[PATCH v2 4/4] ARM: dts: imx28: Fix build warnings with W=1

[Shawn Guo]

On Fri, Nov 04, 2016 at 06:51:06PM -0200, Fabio Estevam wrote:
> Hi Shawn,
> 
> On Thu, Sep 8, 2016 at 11:03 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> > On Mon, Sep 05, 2016 at 04:27:50PM -0300, Fabio Estevam wrote:
> >> diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> >> index 0ebbc83..b4d4dbb 100644
> >> --- a/arch/arm/boot/dts/imx28-tx28.dts
> >> +++ b/arch/arm/boot/dts/imx28-tx28.dts
> >> @@ -35,7 +35,8 @@
> >>               usbotg = &usb0;
> >>       };
> >>
> >> -     memory {
> >> +     memory at 0 {
> >> +             device_type = "memory";
> >>               reg = <0 0>; /* will be filled in by U-Boot */
> >
> > I'm curious to know if the unit-address will be fixed up or not when
> > 'reg' property gets updated by U-Boot.
> 
> Should I resend this series and keep imx28-tx28.dts unmodified?

Yeah, probably the best thing we can do.

Shawn