From: Anshuman Khandual <khandual@linux.vnet.ibm.com> To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org Subject: [PATCH V2 2/2] mm: Add sysfs interface to dump each node's zonelist information Date: Tue, 6 Sep 2016 11:04:32 +0530 [thread overview] Message-ID: <1473140072-24137-2-git-send-email-khandual@linux.vnet.ibm.com> (raw) In-Reply-To: <1473140072-24137-1-git-send-email-khandual@linux.vnet.ibm.com> Each individual node in the system has a ZONELIST_FALLBACK zonelist and a ZONELIST_NOFALLBACK zonelist. These zonelists decide fallback order of zones during memory allocations. Sometimes it helps to dump these zonelists to see the priority order of various zones in them. Particularly platforms which support memory hotplug into previously non existing zones (at boot), this interface helps in visualizing which all zonelists of the system at what priority level, the new hot added memory ends up in. POWER is such a platform where all the memory detected during boot time remains with ZONE_DMA for good but then hot plug process can actually get new memory into ZONE_MOVABLE. So having a way to get the snapshot of the zonelists on the system after memory or node hot[un]plug is desirable. This change adds one new sysfs interface (/sys/devices/system/memory/system_zone_details) which will fetch and dump this information. Example zonelist information from a KVM guest. [NODE (0)] ZONELIST_FALLBACK (0) (node 0) (zone DMA c00000000140c000) (1) (node 1) (zone DMA c000000100000000) (2) (node 2) (zone DMA c000000200000000) (3) (node 3) (zone DMA c000000300000000) ZONELIST_NOFALLBACK (0) (node 0) (zone DMA c00000000140c000) [NODE (1)] ZONELIST_FALLBACK (0) (node 1) (zone DMA c000000100000000) (1) (node 2) (zone DMA c000000200000000) (2) (node 3) (zone DMA c000000300000000) (3) (node 0) (zone DMA c00000000140c000) ZONELIST_NOFALLBACK (0) (node 1) (zone DMA c000000100000000) [NODE (2)] ZONELIST_FALLBACK (0) (node 2) (zone DMA c000000200000000) (1) (node 3) (zone DMA c000000300000000) (2) (node 0) (zone DMA c00000000140c000) (3) (node 1) (zone DMA c000000100000000) ZONELIST_NOFALLBACK (0) (node 2) (zone DMA c000000200000000) [NODE (3)] ZONELIST_FALLBACK (0) (node 3) (zone DMA c000000300000000) (1) (node 0) (zone DMA c00000000140c000) (2) (node 1) (zone DMA c000000100000000) (3) (node 2) (zone DMA c000000200000000) ZONELIST_NOFALLBACK (0) (node 3) (zone DMA c000000300000000) Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com> --- Changes in V2: - Added more details into the commit message - Added sysfs interface file details into the commit message - Added ../ABI/testing/sysfs-system-zone-details file .../ABI/testing/sysfs-system-zone-details | 9 +++++ drivers/base/memory.c | 46 ++++++++++++++++++++++ 2 files changed, 55 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-system-zone-details diff --git a/Documentation/ABI/testing/sysfs-system-zone-details b/Documentation/ABI/testing/sysfs-system-zone-details new file mode 100644 index 0000000..9c13b2e --- /dev/null +++ b/Documentation/ABI/testing/sysfs-system-zone-details @@ -0,0 +1,9 @@ +What: /sys/devices/system/memory/system_zone_details +Date: Sep 2016 +KernelVersion: 4.8 +Contact: khandual@linux.vnet.ibm.com +Description: + This read only file dumps the zonelist and it's constituent + zones information for both ZONELIST_FALLBACK and ZONELIST_ + NOFALLBACK zonelists for each online node of the system at + any given point of time. diff --git a/drivers/base/memory.c b/drivers/base/memory.c index dc75de9..8c9330a 100644 --- a/drivers/base/memory.c +++ b/drivers/base/memory.c @@ -442,7 +442,52 @@ print_block_size(struct device *dev, struct device_attribute *attr, return sprintf(buf, "%lx\n", get_memory_block_size()); } +static ssize_t dump_zonelist(char *buf, struct zonelist *zonelist) +{ + unsigned int i; + ssize_t count = 0; + + for (i = 0; zonelist->_zonerefs[i].zone; i++) { + count += sprintf(buf + count, + "\t\t(%d) (node %d) (%-10s %lx)\n", i, + zonelist->_zonerefs[i].zone->zone_pgdat->node_id, + zone_names[zonelist->_zonerefs[i].zone_idx], + (unsigned long) zonelist->_zonerefs[i].zone); + } + return count; +} + +static ssize_t dump_zonelists(char *buf) +{ + struct zonelist *zonelist; + unsigned int node; + ssize_t count = 0; + + for_each_online_node(node) { + zonelist = &(NODE_DATA(node)-> + node_zonelists[ZONELIST_FALLBACK]); + count += sprintf(buf + count, "[NODE (%d)]\n", node); + count += sprintf(buf + count, "\tZONELIST_FALLBACK\n"); + count += dump_zonelist(buf + count, zonelist); + + zonelist = &(NODE_DATA(node)-> + node_zonelists[ZONELIST_NOFALLBACK]); + count += sprintf(buf + count, "\tZONELIST_NOFALLBACK\n"); + count += dump_zonelist(buf + count, zonelist); + } + return count; +} + +static ssize_t +print_system_zone_details(struct device *dev, struct device_attribute *attr, + char *buf) +{ + return dump_zonelists(buf); +} + + static DEVICE_ATTR(block_size_bytes, 0444, print_block_size, NULL); +static DEVICE_ATTR(system_zone_details, 0444, print_system_zone_details, NULL); /* * Memory auto online policy. @@ -783,6 +828,7 @@ static struct attribute *memory_root_attrs[] = { #endif &dev_attr_block_size_bytes.attr, + &dev_attr_system_zone_details.attr, &dev_attr_auto_online_blocks.attr, NULL }; -- 2.1.0
WARNING: multiple messages have this Message-ID (diff)
From: Anshuman Khandual <khandual@linux.vnet.ibm.com> To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org Subject: [PATCH V2 2/2] mm: Add sysfs interface to dump each node's zonelist information Date: Tue, 6 Sep 2016 11:04:32 +0530 [thread overview] Message-ID: <1473140072-24137-2-git-send-email-khandual@linux.vnet.ibm.com> (raw) In-Reply-To: <1473140072-24137-1-git-send-email-khandual@linux.vnet.ibm.com> Each individual node in the system has a ZONELIST_FALLBACK zonelist and a ZONELIST_NOFALLBACK zonelist. These zonelists decide fallback order of zones during memory allocations. Sometimes it helps to dump these zonelists to see the priority order of various zones in them. Particularly platforms which support memory hotplug into previously non existing zones (at boot), this interface helps in visualizing which all zonelists of the system at what priority level, the new hot added memory ends up in. POWER is such a platform where all the memory detected during boot time remains with ZONE_DMA for good but then hot plug process can actually get new memory into ZONE_MOVABLE. So having a way to get the snapshot of the zonelists on the system after memory or node hot[un]plug is desirable. This change adds one new sysfs interface (/sys/devices/system/memory/system_zone_details) which will fetch and dump this information. Example zonelist information from a KVM guest. [NODE (0)] ZONELIST_FALLBACK (0) (node 0) (zone DMA c00000000140c000) (1) (node 1) (zone DMA c000000100000000) (2) (node 2) (zone DMA c000000200000000) (3) (node 3) (zone DMA c000000300000000) ZONELIST_NOFALLBACK (0) (node 0) (zone DMA c00000000140c000) [NODE (1)] ZONELIST_FALLBACK (0) (node 1) (zone DMA c000000100000000) (1) (node 2) (zone DMA c000000200000000) (2) (node 3) (zone DMA c000000300000000) (3) (node 0) (zone DMA c00000000140c000) ZONELIST_NOFALLBACK (0) (node 1) (zone DMA c000000100000000) [NODE (2)] ZONELIST_FALLBACK (0) (node 2) (zone DMA c000000200000000) (1) (node 3) (zone DMA c000000300000000) (2) (node 0) (zone DMA c00000000140c000) (3) (node 1) (zone DMA c000000100000000) ZONELIST_NOFALLBACK (0) (node 2) (zone DMA c000000200000000) [NODE (3)] ZONELIST_FALLBACK (0) (node 3) (zone DMA c000000300000000) (1) (node 0) (zone DMA c00000000140c000) (2) (node 1) (zone DMA c000000100000000) (3) (node 2) (zone DMA c000000200000000) ZONELIST_NOFALLBACK (0) (node 3) (zone DMA c000000300000000) Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com> --- Changes in V2: - Added more details into the commit message - Added sysfs interface file details into the commit message - Added ../ABI/testing/sysfs-system-zone-details file .../ABI/testing/sysfs-system-zone-details | 9 +++++ drivers/base/memory.c | 46 ++++++++++++++++++++++ 2 files changed, 55 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-system-zone-details diff --git a/Documentation/ABI/testing/sysfs-system-zone-details b/Documentation/ABI/testing/sysfs-system-zone-details new file mode 100644 index 0000000..9c13b2e --- /dev/null +++ b/Documentation/ABI/testing/sysfs-system-zone-details @@ -0,0 +1,9 @@ +What: /sys/devices/system/memory/system_zone_details +Date: Sep 2016 +KernelVersion: 4.8 +Contact: khandual@linux.vnet.ibm.com +Description: + This read only file dumps the zonelist and it's constituent + zones information for both ZONELIST_FALLBACK and ZONELIST_ + NOFALLBACK zonelists for each online node of the system at + any given point of time. diff --git a/drivers/base/memory.c b/drivers/base/memory.c index dc75de9..8c9330a 100644 --- a/drivers/base/memory.c +++ b/drivers/base/memory.c @@ -442,7 +442,52 @@ print_block_size(struct device *dev, struct device_attribute *attr, return sprintf(buf, "%lx\n", get_memory_block_size()); } +static ssize_t dump_zonelist(char *buf, struct zonelist *zonelist) +{ + unsigned int i; + ssize_t count = 0; + + for (i = 0; zonelist->_zonerefs[i].zone; i++) { + count += sprintf(buf + count, + "\t\t(%d) (node %d) (%-10s %lx)\n", i, + zonelist->_zonerefs[i].zone->zone_pgdat->node_id, + zone_names[zonelist->_zonerefs[i].zone_idx], + (unsigned long) zonelist->_zonerefs[i].zone); + } + return count; +} + +static ssize_t dump_zonelists(char *buf) +{ + struct zonelist *zonelist; + unsigned int node; + ssize_t count = 0; + + for_each_online_node(node) { + zonelist = &(NODE_DATA(node)-> + node_zonelists[ZONELIST_FALLBACK]); + count += sprintf(buf + count, "[NODE (%d)]\n", node); + count += sprintf(buf + count, "\tZONELIST_FALLBACK\n"); + count += dump_zonelist(buf + count, zonelist); + + zonelist = &(NODE_DATA(node)-> + node_zonelists[ZONELIST_NOFALLBACK]); + count += sprintf(buf + count, "\tZONELIST_NOFALLBACK\n"); + count += dump_zonelist(buf + count, zonelist); + } + return count; +} + +static ssize_t +print_system_zone_details(struct device *dev, struct device_attribute *attr, + char *buf) +{ + return dump_zonelists(buf); +} + + static DEVICE_ATTR(block_size_bytes, 0444, print_block_size, NULL); +static DEVICE_ATTR(system_zone_details, 0444, print_system_zone_details, NULL); /* * Memory auto online policy. @@ -783,6 +828,7 @@ static struct attribute *memory_root_attrs[] = { #endif &dev_attr_block_size_bytes.attr, + &dev_attr_system_zone_details.attr, &dev_attr_auto_online_blocks.attr, NULL }; -- 2.1.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-09-06 5:34 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-06 5:34 [PATCH V2 1/2] mm: Export definition of 'zone_names' array through mmzone.h Anshuman Khandual 2016-09-06 5:34 ` Anshuman Khandual 2016-09-06 5:34 ` Anshuman Khandual [this message] 2016-09-06 5:34 ` [PATCH V2 2/2] mm: Add sysfs interface to dump each node's zonelist information Anshuman Khandual 2016-09-06 6:11 ` kbuild test robot 2016-09-06 6:49 ` Anshuman Khandual 2016-09-06 6:49 ` Anshuman Khandual 2016-09-06 8:31 ` [PATCH V3] " Anshuman Khandual 2016-09-06 8:31 ` Anshuman Khandual 2016-09-06 9:05 ` kbuild test robot 2016-09-07 12:32 ` Anshuman Khandual 2016-09-07 12:32 ` Anshuman Khandual 2016-09-06 20:36 ` Dave Hansen 2016-09-06 20:36 ` Dave Hansen 2016-09-07 3:08 ` Kees Cook 2016-09-07 3:08 ` Kees Cook 2016-09-07 4:00 ` Anshuman Khandual 2016-09-07 4:00 ` Anshuman Khandual 2016-09-08 2:46 ` [PATCH V4] " Anshuman Khandual 2016-09-08 2:46 ` Anshuman Khandual 2016-09-08 7:44 ` kbuild test robot 2016-09-08 20:24 ` Dave Hansen 2016-09-08 20:24 ` Dave Hansen 2016-09-12 5:27 ` Anshuman Khandual 2016-09-12 5:27 ` Anshuman Khandual 2016-09-12 18:13 ` David Rientjes 2016-09-12 18:13 ` David Rientjes 2016-09-17 4:26 ` Anshuman Khandual 2016-09-17 4:26 ` Anshuman Khandual 2016-09-20 0:54 ` David Rientjes 2016-09-20 0:54 ` David Rientjes 2016-10-13 14:38 ` Anshuman Khandual 2016-10-13 14:38 ` Anshuman Khandual 2016-09-09 13:36 ` Michal Hocko 2016-09-09 13:36 ` Michal Hocko 2016-09-12 5:24 ` Anshuman Khandual 2016-09-12 5:24 ` Anshuman Khandual
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1473140072-24137-2-git-send-email-khandual@linux.vnet.ibm.com \ --to=khandual@linux.vnet.ibm.com \ --cc=akpm@linux-foundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.