* [PATCH] net: arc_emac: mark arc_mdio_reset() static
@ 2016-09-06 8:21 Baoyou Xie
2016-09-06 22:59 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Baoyou Xie @ 2016-09-06 8:21 UTC (permalink / raw)
To: davem, wxt, heiko, marex
Cc: netdev, linux-kernel, arnd, baoyou.xie, xie.baoyou
We get 1 warning when building kernel with W=1:
drivers/net/ethernet/arc/emac_mdio.c:107:5: warning: no previous prototype for 'arc_mdio_reset' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
so this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/net/ethernet/arc/emac_mdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/arc/emac_mdio.c b/drivers/net/ethernet/arc/emac_mdio.c
index 058460b..a22403c 100644
--- a/drivers/net/ethernet/arc/emac_mdio.c
+++ b/drivers/net/ethernet/arc/emac_mdio.c
@@ -104,7 +104,7 @@ static int arc_mdio_write(struct mii_bus *bus, int phy_addr,
* @bus: points to the mii_bus structure
* Description: reset the MII bus
*/
-int arc_mdio_reset(struct mii_bus *bus)
+static int arc_mdio_reset(struct mii_bus *bus)
{
struct arc_emac_priv *priv = bus->priv;
struct arc_emac_mdio_bus_data *data = &priv->bus_data;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: arc_emac: mark arc_mdio_reset() static
2016-09-06 8:21 [PATCH] net: arc_emac: mark arc_mdio_reset() static Baoyou Xie
@ 2016-09-06 22:59 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-09-06 22:59 UTC (permalink / raw)
To: baoyou.xie; +Cc: wxt, heiko, marex, netdev, linux-kernel, arnd, xie.baoyou
From: Baoyou Xie <baoyou.xie@linaro.org>
Date: Tue, 6 Sep 2016 16:21:56 +0800
> We get 1 warning when building kernel with W=1:
> drivers/net/ethernet/arc/emac_mdio.c:107:5: warning: no previous prototype for 'arc_mdio_reset' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> so this patch marks this function with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-06 23:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-06 8:21 [PATCH] net: arc_emac: mark arc_mdio_reset() static Baoyou Xie
2016-09-06 22:59 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.