All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bimmy Pujari <bimmy.pujari@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S45 04/10] i40e: Remove 100 Mbps SGMII support for X722
Date: Tue,  6 Sep 2016 18:05:06 -0700	[thread overview]
Message-ID: <1473210312-29592-5-git-send-email-bimmy.pujari@intel.com> (raw)
In-Reply-To: <1473210312-29592-1-git-send-email-bimmy.pujari@intel.com>

From: Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>

This patch fixes the problem where driver shows 100 Mbps as a supported speed, 
and allows it to be configured for advertising on X722 devices. This patch 
fixes the problem by not setting the 100 Mbps SGMII flag for X722 devices. 

Without this patch, the user incorrectly thinks that 100 Mbps is supported 
and hence might try to advertise it on X722 devices when it is actually not 
a supported speed. 

Signed-off-by: Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>
Change-ID: I8c3d7c4251a9402d98994ed29749b7b895a0f205
---
Testing Hints: Test on Copperpeak that 100 Mbps is not listed as
supported or advertised on ethtool. Also ensure we are not able
to configure the speed to 100 Mbps.

HSD-number: 10021180

 drivers/net/ethernet/intel/i40e/i40e_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 68c1253..e83b317 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -8591,7 +8591,6 @@ static int i40e_sw_init(struct i40e_pf *pf)
 			     I40E_FLAG_WB_ON_ITR_CAPABLE |
 			     I40E_FLAG_MULTIPLE_TCP_UDP_RSS_PCTYPE |
 			     I40E_FLAG_NO_PCI_LINK_CHECK |
-			     I40E_FLAG_100M_SGMII_CAPABLE |
 			     I40E_FLAG_USE_SET_LLDP_MIB |
 			     I40E_FLAG_GENEVE_OFFLOAD_CAPABLE;
 	} else if ((pf->hw.aq.api_maj_ver > 1) ||
-- 
2.4.11


  parent reply	other threads:[~2016-09-07  1:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07  1:05 [Intel-wired-lan] [next PATCH S45-V2 00/10] i40e/i40evf updates Bimmy Pujari
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 01/10] i40evf: remove unnecessary error checking against i40evf_up_complete Bimmy Pujari
2016-09-08 16:47   ` Bowers, AndrewX
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 02/10] i40e: Limit TX descriptor count in cases where frag size is greater than 16K Bimmy Pujari
2016-09-08 16:53   ` Bowers, AndrewX
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 03/10] i40evf: remove unnecessary error checking against i40e_shutdown_adminq Bimmy Pujari
2016-09-08 16:59   ` Bowers, AndrewX
2016-09-07  1:05 ` Bimmy Pujari [this message]
2016-09-09 20:38   ` [Intel-wired-lan] [next PATCH S45 04/10] i40e: Remove 100 Mbps SGMII support for X722 Bowers, AndrewX
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 05/10] i40e: fix deleting mac filters Bimmy Pujari
2016-09-08 21:19   ` Bowers, AndrewX
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 06/10] i40e: add encap csum VF offload flag Bimmy Pujari
2016-09-08 17:26   ` Bowers, AndrewX
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 07/10] i40e: cleanup ATR auto_disable_flags use Bimmy Pujari
2016-09-09 19:50   ` Bowers, AndrewX
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 08/10] i40e: check conflicting ntuple/sideband rules when re-enabling ATR Bimmy Pujari
2016-09-08 20:57   ` Keller, Jacob E
2016-09-09 20:10   ` Bowers, AndrewX
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 09/10] i40e: removing unreachable code Bimmy Pujari
2016-09-08 17:43   ` Bowers, AndrewX
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 10/10] i40e/i40evf: Changed version to 1.6.16 Bimmy Pujari
2016-09-08 17:43   ` Bowers, AndrewX
  -- strict thread matches above, loose matches on Subject: below --
2016-09-06 19:39 [Intel-wired-lan] [next PATCH S45 00/10] i40e/i40evf updates Bimmy Pujari
2016-09-06 19:40 ` [Intel-wired-lan] [next PATCH S45 04/10] i40e: Remove 100 Mbps SGMII support for X722 Bimmy Pujari
2016-09-06 20:10   ` Wyborny, Carolyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473210312-29592-5-git-send-email-bimmy.pujari@intel.com \
    --to=bimmy.pujari@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.