All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bowers, AndrewX <andrewx.bowers@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S45 02/10] i40e: Limit TX descriptor	count in cases where frag size is greater than 16K
Date: Thu, 8 Sep 2016 16:53:06 +0000	[thread overview]
Message-ID: <26D9FDECA4FBDD4AADA65D8E2FC68A4A0F9FC82A@ORSMSX104.amr.corp.intel.com> (raw)
In-Reply-To: <1473210312-29592-3-git-send-email-bimmy.pujari@intel.com>

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Bimmy Pujari
> Sent: Tuesday, September 06, 2016 6:05 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S45 02/10] i40e: Limit TX descriptor
> count in cases where frag size is greater than 16K
> 
> From: Alexander Duyck <alexander.h.duyck@intel.com>
> 
> The i40e driver was incorrectly assuming that we would always be pulling no
> more than 1 descriptor from each fragment.  It is in fact possible for us to end
> up with the case where 2 descriptors worth of data may be pulled when a
> frame is larger than one of the pieces generated when aligning the payload
> to either 4K or pieces smaller than 16K.
> 
> To adjust for this we just need to make certain to test all the way to the end
> of the fragments as it is possible for us to span 2 descriptors in the block
> before us so we need to guarantee that even the last 6 descriptors have
> enough data to fill a full frame.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Change-ID: Ic2ecb4d6b745f447d334e66c14002152f50e2f99
> ---
> Testing Hints:
>         This is hard to reproduce.  Patch submitted to customer for
>         testing.  Best effort would be to try testing TSO, if possible
>         TSO with iSCSI to verify nothing there is broken.
> 
> HSD-number: 10021204
> 
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c   | 7 ++-----
>  drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 7 ++-----
>  2 files changed, 4 insertions(+), 10 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>



  reply	other threads:[~2016-09-08 16:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07  1:05 [Intel-wired-lan] [next PATCH S45-V2 00/10] i40e/i40evf updates Bimmy Pujari
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 01/10] i40evf: remove unnecessary error checking against i40evf_up_complete Bimmy Pujari
2016-09-08 16:47   ` Bowers, AndrewX
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 02/10] i40e: Limit TX descriptor count in cases where frag size is greater than 16K Bimmy Pujari
2016-09-08 16:53   ` Bowers, AndrewX [this message]
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 03/10] i40evf: remove unnecessary error checking against i40e_shutdown_adminq Bimmy Pujari
2016-09-08 16:59   ` Bowers, AndrewX
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 04/10] i40e: Remove 100 Mbps SGMII support for X722 Bimmy Pujari
2016-09-09 20:38   ` Bowers, AndrewX
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 05/10] i40e: fix deleting mac filters Bimmy Pujari
2016-09-08 21:19   ` Bowers, AndrewX
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 06/10] i40e: add encap csum VF offload flag Bimmy Pujari
2016-09-08 17:26   ` Bowers, AndrewX
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 07/10] i40e: cleanup ATR auto_disable_flags use Bimmy Pujari
2016-09-09 19:50   ` Bowers, AndrewX
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 08/10] i40e: check conflicting ntuple/sideband rules when re-enabling ATR Bimmy Pujari
2016-09-08 20:57   ` Keller, Jacob E
2016-09-09 20:10   ` Bowers, AndrewX
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 09/10] i40e: removing unreachable code Bimmy Pujari
2016-09-08 17:43   ` Bowers, AndrewX
2016-09-07  1:05 ` [Intel-wired-lan] [next PATCH S45 10/10] i40e/i40evf: Changed version to 1.6.16 Bimmy Pujari
2016-09-08 17:43   ` Bowers, AndrewX
  -- strict thread matches above, loose matches on Subject: below --
2016-09-06 19:39 [Intel-wired-lan] [next PATCH S45 00/10] i40e/i40evf updates Bimmy Pujari
2016-09-06 19:39 ` [Intel-wired-lan] [next PATCH S45 02/10] i40e: Limit TX descriptor count in cases where frag size is greater than 16K Bimmy Pujari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26D9FDECA4FBDD4AADA65D8E2FC68A4A0F9FC82A@ORSMSX104.amr.corp.intel.com \
    --to=andrewx.bowers@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.