All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoyou Xie <baoyou.xie@linaro.org>
To: benjamin.gaignard@linaro.org, vincent.abriou@st.com, airlied@linux.ie
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn
Subject: [PATCH] drm/sti: mark symbols static where possible
Date: Wed,  7 Sep 2016 19:05:07 +0800	[thread overview]
Message-ID: <1473246307-889-1-git-send-email-baoyou.xie@linaro.org> (raw)

We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/sti/sti_mixer.c:361:6: warning: no previous prototype for 'sti_mixer_set_matrix' [-Wmissing-prototypes]
drivers/gpu/drm/sti/sti_dvo.c:109:5: warning: no previous prototype for 'dvo_awg_generate_code' [-Wmissing-prototypes]

In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/gpu/drm/sti/sti_dvo.c   | 3 ++-
 drivers/gpu/drm/sti/sti_mixer.c | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c
index 00881eb..4545ad0 100644
--- a/drivers/gpu/drm/sti/sti_dvo.c
+++ b/drivers/gpu/drm/sti/sti_dvo.c
@@ -106,7 +106,8 @@ struct sti_dvo_connector {
 	container_of(x, struct sti_dvo_connector, drm_connector)
 
 #define BLANKING_LEVEL 16
-int dvo_awg_generate_code(struct sti_dvo *dvo, u8 *ram_size, u32 *ram_code)
+static int
+dvo_awg_generate_code(struct sti_dvo *dvo, u8 *ram_size, u32 *ram_code)
 {
 	struct drm_display_mode *mode = &dvo->mode;
 	struct dvo_config *config = dvo->config;
diff --git a/drivers/gpu/drm/sti/sti_mixer.c b/drivers/gpu/drm/sti/sti_mixer.c
index 7d9aea8..b78cec5 100644
--- a/drivers/gpu/drm/sti/sti_mixer.c
+++ b/drivers/gpu/drm/sti/sti_mixer.c
@@ -358,7 +358,7 @@ int sti_mixer_set_plane_status(struct sti_mixer *mixer,
 	return 0;
 }
 
-void sti_mixer_set_matrix(struct sti_mixer *mixer)
+static void sti_mixer_set_matrix(struct sti_mixer *mixer)
 {
 	unsigned int i;
 
-- 
2.7.4

             reply	other threads:[~2016-09-07 11:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07 11:05 Baoyou Xie [this message]
2016-09-08  9:35 ` [PATCH] drm/sti: mark symbols static where possible Emil Velikov
2016-09-08  9:35   ` Emil Velikov
2016-09-08  9:56   ` Arnd Bergmann
2016-09-08  9:56     ` Arnd Bergmann
2016-09-09 12:46     ` Emil Velikov
2016-09-08 10:07 ` Benjamin Gaignard
2016-09-15 11:39 Baoyou Xie
2016-09-15 15:15 ` Vincent ABRIOU
2016-09-15 15:15   ` Vincent ABRIOU
2016-09-25  7:57 Baoyou Xie
2016-09-27 16:35 ` Sean Paul
2016-09-27 16:35   ` Sean Paul
2016-09-27 19:07   ` Benjamin Gaignard
2016-09-27 19:07     ` Benjamin Gaignard
2016-09-28  7:27     ` Vincent ABRIOU
2016-09-28  7:27       ` Vincent ABRIOU
2016-09-29  9:27       ` Daniel Vetter
2016-09-29  9:27         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473246307-889-1-git-send-email-baoyou.xie@linaro.org \
    --to=baoyou.xie@linaro.org \
    --cc=airlied@linux.ie \
    --cc=arnd@arndb.de \
    --cc=benjamin.gaignard@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vincent.abriou@st.com \
    --cc=xie.baoyou@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.