From: Emil Velikov <emil.l.velikov@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Baoyou Xie <baoyou.xie@linaro.org>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Vincent Abriou <vincent.abriou@st.com>,
David Airlie <airlied@linux.ie>,
xie.baoyou@zte.com.cn,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/sti: mark symbols static where possible
Date: Fri, 9 Sep 2016 13:46:28 +0100 [thread overview]
Message-ID: <CACvgo530EGJ3go6iSn2+w-+Wxbh+q_41fW-eeoivunpC=uUd8g@mail.gmail.com> (raw)
In-Reply-To: <8179856.bd6bOcXQvk@wuerfel>
On 8 September 2016 at 10:56, Arnd Bergmann <arnd@arndb.de> wrote:
> On Thursday, September 8, 2016 10:35:17 AM CEST Emil Velikov wrote:
>> On 7 September 2016 at 12:05, Baoyou Xie <baoyou.xie@linaro.org> wrote:
>> > We get 2 warnings when building kernel with W=1:
>> As you're going through DRM I was wondering if you have a rough number
>> of warnings we get at the various W levels 1,2,...
>
> I've looked at the W=1 warnings overall, and the count I got a
> month ago was 648 warnings for drivers/gpu/::
>
> 471 -Werror=missing-prototypes
> 12 -Werror=type-limits
> 124 -Werror=unused-but-set-variable
> 41 -Werror=unused-const-variable=
>
> vs for the whole kernel
>
> 2033 -Werror=missing-prototypes
> 58 -Werror=suggest-attribute=format
> 167 -Werror=type-limits
> 1398 -Werror=unused-but-set-variable
> 1526 -Werror=unused-const-variable=
>
> but that was after I had already fixed some of the other warnings
> locally. It shouldn't be hard to fix all of them for any given
> subsystem, often a single line change gets rid of a number
> of individual warnings.
>
Considering the LOC in the kernel, the number are quite small. Still a
fair bit to go.
> My basic idea however is not to do it by subsystem but instead
> do it one warning at a time for the entire kernel and then enable
> that warning by default without W=1.
>
Makes perfect sense. Thanks Arnd !
Keep up the good work gents.
Regards,
Emil
next prev parent reply other threads:[~2016-09-09 12:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 11:05 [PATCH] drm/sti: mark symbols static where possible Baoyou Xie
2016-09-08 9:35 ` Emil Velikov
2016-09-08 9:35 ` Emil Velikov
2016-09-08 9:56 ` Arnd Bergmann
2016-09-08 9:56 ` Arnd Bergmann
2016-09-09 12:46 ` Emil Velikov [this message]
2016-09-08 10:07 ` Benjamin Gaignard
2016-09-15 11:39 Baoyou Xie
2016-09-15 15:15 ` Vincent ABRIOU
2016-09-15 15:15 ` Vincent ABRIOU
2016-09-25 7:57 Baoyou Xie
2016-09-27 16:35 ` Sean Paul
2016-09-27 16:35 ` Sean Paul
2016-09-27 19:07 ` Benjamin Gaignard
2016-09-27 19:07 ` Benjamin Gaignard
2016-09-28 7:27 ` Vincent ABRIOU
2016-09-28 7:27 ` Vincent ABRIOU
2016-09-29 9:27 ` Daniel Vetter
2016-09-29 9:27 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACvgo530EGJ3go6iSn2+w-+Wxbh+q_41fW-eeoivunpC=uUd8g@mail.gmail.com' \
--to=emil.l.velikov@gmail.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=benjamin.gaignard@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.abriou@st.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.