All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging/lustre/lov: add missing header dependencies
@ 2016-09-08  8:48 ` Baoyou Xie
  0 siblings, 0 replies; 7+ messages in thread
From: Baoyou Xie @ 2016-09-08  8:48 UTC (permalink / raw)
  To: oleg.drokin, andreas.dilger, gregkh, bobijam.xu, jinshan.xiong,
	lai.siyao, mike.rapoport, amitoj1606
  Cc: lustre-devel, devel, linux-kernel, arnd, baoyou.xie, xie.baoyou

We get 1 warning when building kernel with W=1:
drivers/staging/lustre/lustre/lov/lov_object.c:956:23: warning: no previous prototype for 'lov_lsm_get' [-Wmissing-prototypes]
drivers/staging/lustre/lustre/lov/lov_object.c:972:6: warning: no previous prototype for 'lov_lsm_put' [-Wmissing-prototypes]
drivers/staging/lustre/lustre/lov/lov_object.c:979:5: warning: no previous prototype for 'lov_read_and_clear_async_rc' [-Wmissing-prototypes]

In fact, these functions are declared in ../llite/vvp_internal.h,
so this patch add missing header dependencies.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/staging/lustre/lustre/lov/lov_object.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
index f9621b0..912c416 100644
--- a/drivers/staging/lustre/lustre/lov/lov_object.c
+++ b/drivers/staging/lustre/lustre/lov/lov_object.c
@@ -38,6 +38,7 @@
 #define DEBUG_SUBSYSTEM S_LOV
 
 #include "lov_cl_internal.h"
+#include "../llite/vvp_internal.h"
 
 /** \addtogroup lov
  *  @{
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [lustre-devel] [PATCH] staging/lustre/lov: add missing header dependencies
@ 2016-09-08  8:48 ` Baoyou Xie
  0 siblings, 0 replies; 7+ messages in thread
From: Baoyou Xie @ 2016-09-08  8:48 UTC (permalink / raw)
  To: oleg.drokin, andreas.dilger, gregkh, bobijam.xu, jinshan.xiong,
	lai.siyao, mike.rapoport, amitoj1606
  Cc: lustre-devel, devel, linux-kernel, arnd, baoyou.xie, xie.baoyou

We get 1 warning when building kernel with W=1:
drivers/staging/lustre/lustre/lov/lov_object.c:956:23: warning: no previous prototype for 'lov_lsm_get' [-Wmissing-prototypes]
drivers/staging/lustre/lustre/lov/lov_object.c:972:6: warning: no previous prototype for 'lov_lsm_put' [-Wmissing-prototypes]
drivers/staging/lustre/lustre/lov/lov_object.c:979:5: warning: no previous prototype for 'lov_read_and_clear_async_rc' [-Wmissing-prototypes]

In fact, these functions are declared in ../llite/vvp_internal.h,
so this patch add missing header dependencies.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/staging/lustre/lustre/lov/lov_object.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
index f9621b0..912c416 100644
--- a/drivers/staging/lustre/lustre/lov/lov_object.c
+++ b/drivers/staging/lustre/lustre/lov/lov_object.c
@@ -38,6 +38,7 @@
 #define DEBUG_SUBSYSTEM S_LOV
 
 #include "lov_cl_internal.h"
+#include "../llite/vvp_internal.h"
 
 /** \addtogroup lov
  *  @{
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] staging/lustre/lov: add missing header dependencies
  2016-09-08  8:48 ` [lustre-devel] " Baoyou Xie
@ 2016-09-08 17:59   ` James Simmons
  -1 siblings, 0 replies; 7+ messages in thread
From: James Simmons @ 2016-09-08 17:59 UTC (permalink / raw)
  To: Baoyou Xie
  Cc: oleg.drokin, andreas.dilger, gregkh, bobijam.xu, jinshan.xiong,
	lai.siyao, mike.rapoport, amitoj1606, devel, arnd, xie.baoyou,
	linux-kernel, lustre-devel


> We get 1 warning when building kernel with W=1:
> drivers/staging/lustre/lustre/lov/lov_object.c:956:23: warning: no previous prototype for 'lov_lsm_get' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/lov/lov_object.c:972:6: warning: no previous prototype for 'lov_lsm_put' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/lov/lov_object.c:979:5: warning: no previous prototype for 'lov_read_and_clear_async_rc' [-Wmissing-prototypes]
> 
> In fact, these functions are declared in ../llite/vvp_internal.h,
> so this patch add missing header dependencies.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

Nak. The header vvp_internal.h is meant to private to the llite layer.
Looking at the coming patch updates I see lov_lsm_[put|get] will not be
used in the lov later. Now lov_read_and_clear_async is still used in
both layers. The header used for this case is cl_object.h. Might rename 
that function to be consistent with the rest of the header. I will look 
into a cleanup for this.

> ---
>  drivers/staging/lustre/lustre/lov/lov_object.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
> index f9621b0..912c416 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_object.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_object.c
> @@ -38,6 +38,7 @@
>  #define DEBUG_SUBSYSTEM S_LOV
>  
>  #include "lov_cl_internal.h"
> +#include "../llite/vvp_internal.h"
>  
>  /** \addtogroup lov
>   *  @{
> -- 
> 2.7.4
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [lustre-devel] [PATCH] staging/lustre/lov: add missing header dependencies
@ 2016-09-08 17:59   ` James Simmons
  0 siblings, 0 replies; 7+ messages in thread
From: James Simmons @ 2016-09-08 17:59 UTC (permalink / raw)
  To: Baoyou Xie
  Cc: oleg.drokin, andreas.dilger, gregkh, bobijam.xu, jinshan.xiong,
	lai.siyao, mike.rapoport, amitoj1606, devel, arnd, xie.baoyou,
	linux-kernel, lustre-devel


> We get 1 warning when building kernel with W=1:
> drivers/staging/lustre/lustre/lov/lov_object.c:956:23: warning: no previous prototype for 'lov_lsm_get' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/lov/lov_object.c:972:6: warning: no previous prototype for 'lov_lsm_put' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/lov/lov_object.c:979:5: warning: no previous prototype for 'lov_read_and_clear_async_rc' [-Wmissing-prototypes]
> 
> In fact, these functions are declared in ../llite/vvp_internal.h,
> so this patch add missing header dependencies.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

Nak. The header vvp_internal.h is meant to private to the llite layer.
Looking at the coming patch updates I see lov_lsm_[put|get] will not be
used in the lov later. Now lov_read_and_clear_async is still used in
both layers. The header used for this case is cl_object.h. Might rename 
that function to be consistent with the rest of the header. I will look 
into a cleanup for this.

> ---
>  drivers/staging/lustre/lustre/lov/lov_object.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
> index f9621b0..912c416 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_object.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_object.c
> @@ -38,6 +38,7 @@
>  #define DEBUG_SUBSYSTEM S_LOV
>  
>  #include "lov_cl_internal.h"
> +#include "../llite/vvp_internal.h"
>  
>  /** \addtogroup lov
>   *  @{
> -- 
> 2.7.4
> 
> _______________________________________________
> devel mailing list
> devel at linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [lustre-devel] [PATCH] staging/lustre/lov: add missing header dependencies
  2016-09-08 17:59   ` [lustre-devel] " James Simmons
  (?)
@ 2016-09-09  1:45   ` Baoyou Xie
  -1 siblings, 0 replies; 7+ messages in thread
From: Baoyou Xie @ 2016-09-09  1:45 UTC (permalink / raw)
  To: lustre-devel

Looks like it's better to clean it up :)

On 9 September 2016 at 01:59, James Simmons <jsimmons@infradead.org> wrote:

>
> > We get 1 warning when building kernel with W=1:
> > drivers/staging/lustre/lustre/lov/lov_object.c:956:23: warning: no
> previous prototype for 'lov_lsm_get' [-Wmissing-prototypes]
> > drivers/staging/lustre/lustre/lov/lov_object.c:972:6: warning: no
> previous prototype for 'lov_lsm_put' [-Wmissing-prototypes]
> > drivers/staging/lustre/lustre/lov/lov_object.c:979:5: warning: no
> previous prototype for 'lov_read_and_clear_async_rc' [-Wmissing-prototypes]
> >
> > In fact, these functions are declared in ../llite/vvp_internal.h,
> > so this patch add missing header dependencies.
> >
> > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>
> Nak. The header vvp_internal.h is meant to private to the llite layer.
> Looking at the coming patch updates I see lov_lsm_[put|get] will not be
> used in the lov later. Now lov_read_and_clear_async is still used in
> both layers. The header used for this case is cl_object.h. Might rename
> that function to be consistent with the rest of the header. I will look
> into a cleanup for this.
>
> > ---
> >  drivers/staging/lustre/lustre/lov/lov_object.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c
> b/drivers/staging/lustre/lustre/lov/lov_object.c
> > index f9621b0..912c416 100644
> > --- a/drivers/staging/lustre/lustre/lov/lov_object.c
> > +++ b/drivers/staging/lustre/lustre/lov/lov_object.c
> > @@ -38,6 +38,7 @@
> >  #define DEBUG_SUBSYSTEM S_LOV
> >
> >  #include "lov_cl_internal.h"
> > +#include "../llite/vvp_internal.h"
> >
> >  /** \addtogroup lov
> >   *  @{
> > --
> > 2.7.4
> >
> > _______________________________________________
> > devel mailing list
> > devel at linuxdriverproject.org
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lustre.org/pipermail/lustre-devel-lustre.org/attachments/20160909/4f158d1a/attachment-0001.htm>

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [lustre-devel] [PATCH] staging/lustre/lov: add missing header dependencies
  2016-09-08  8:48 ` [lustre-devel] " Baoyou Xie
@ 2016-09-26 18:23   ` James Simmons
  -1 siblings, 0 replies; 7+ messages in thread
From: James Simmons @ 2016-09-26 18:23 UTC (permalink / raw)
  To: Baoyou Xie
  Cc: oleg.drokin, andreas.dilger, gregkh, bobijam.xu, jinshan.xiong,
	lai.siyao, mike.rapoport, amitoj1606, devel, arnd, xie.baoyou,
	Linux Kernel Mailing List, Lustre Developement


> We get 1 warning when building kernel with W=1:
> drivers/staging/lustre/lustre/lov/lov_object.c:956:23: warning: no previous prototype for 'lov_lsm_get' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/lov/lov_object.c:972:6: warning: no previous prototype for 'lov_lsm_put' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/lov/lov_object.c:979:5: warning: no previous prototype for 'lov_read_and_clear_async_rc' [-Wmissing-prototypes]
> 
> In fact, these functions are declared in ../llite/vvp_internal.h,
> so this patch add missing header dependencies.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

Nak. I have a patch coming soon from our server code branch that removes 
lov_lsm_get() and makes lov_lsm_put used only in the lov layer.
The patch is ready but I need to test it first.

> ---
>  drivers/staging/lustre/lustre/lov/lov_object.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
> index f9621b0..912c416 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_object.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_object.c
> @@ -38,6 +38,7 @@
>  #define DEBUG_SUBSYSTEM S_LOV
>  
>  #include "lov_cl_internal.h"
> +#include "../llite/vvp_internal.h"
>  
>  /** \addtogroup lov
>   *  @{
> -- 
> 2.7.4
> 
> _______________________________________________
> lustre-devel mailing list
> lustre-devel@lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [lustre-devel] [PATCH] staging/lustre/lov: add missing header dependencies
@ 2016-09-26 18:23   ` James Simmons
  0 siblings, 0 replies; 7+ messages in thread
From: James Simmons @ 2016-09-26 18:23 UTC (permalink / raw)
  To: Baoyou Xie
  Cc: oleg.drokin, andreas.dilger, gregkh, bobijam.xu, jinshan.xiong,
	lai.siyao, mike.rapoport, amitoj1606, devel, arnd, xie.baoyou,
	Linux Kernel Mailing List, Lustre Developement


> We get 1 warning when building kernel with W=1:
> drivers/staging/lustre/lustre/lov/lov_object.c:956:23: warning: no previous prototype for 'lov_lsm_get' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/lov/lov_object.c:972:6: warning: no previous prototype for 'lov_lsm_put' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/lov/lov_object.c:979:5: warning: no previous prototype for 'lov_read_and_clear_async_rc' [-Wmissing-prototypes]
> 
> In fact, these functions are declared in ../llite/vvp_internal.h,
> so this patch add missing header dependencies.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

Nak. I have a patch coming soon from our server code branch that removes 
lov_lsm_get() and makes lov_lsm_put used only in the lov layer.
The patch is ready but I need to test it first.

> ---
>  drivers/staging/lustre/lustre/lov/lov_object.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
> index f9621b0..912c416 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_object.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_object.c
> @@ -38,6 +38,7 @@
>  #define DEBUG_SUBSYSTEM S_LOV
>  
>  #include "lov_cl_internal.h"
> +#include "../llite/vvp_internal.h"
>  
>  /** \addtogroup lov
>   *  @{
> -- 
> 2.7.4
> 
> _______________________________________________
> lustre-devel mailing list
> lustre-devel at lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-09-26 18:23 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-08  8:48 [PATCH] staging/lustre/lov: add missing header dependencies Baoyou Xie
2016-09-08  8:48 ` [lustre-devel] " Baoyou Xie
2016-09-08 17:59 ` James Simmons
2016-09-08 17:59   ` [lustre-devel] " James Simmons
2016-09-09  1:45   ` Baoyou Xie
2016-09-26 18:23 ` James Simmons
2016-09-26 18:23   ` James Simmons

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.