All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Xie XiuQi <xiexiuqi@huawei.com>, david@fromorbit.com
Cc: xfs@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: fix signed integer overflow
Date: Thu, 08 Sep 2016 23:42:01 -0700	[thread overview]
Message-ID: <1473403321.13672.35.camel@perches.com> (raw)
In-Reply-To: <1473403112-31072-1-git-send-email-xiexiuqi@huawei.com>

On Fri, 2016-09-09 at 14:38 +0800, Xie XiuQi wrote:
> Use 1U for unsigned long, or we'll meet a overflow issue with UBSAN.

trivia: misleading commit message

1U is for unsigned int not unsigned long int

WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Xie XiuQi <xiexiuqi@huawei.com>, david@fromorbit.com
Cc: linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix signed integer overflow
Date: Thu, 08 Sep 2016 23:42:01 -0700	[thread overview]
Message-ID: <1473403321.13672.35.camel@perches.com> (raw)
In-Reply-To: <1473403112-31072-1-git-send-email-xiexiuqi@huawei.com>

On Fri, 2016-09-09 at 14:38 +0800, Xie XiuQi wrote:
> Use 1U for unsigned long, or we'll meet a overflow issue with UBSAN.

trivia: misleading commit message

1U is for unsigned int not unsigned long int


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2016-09-09  6:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09  6:38 [PATCH] xfs: fix signed integer overflow Xie XiuQi
2016-09-09  6:38 ` Xie XiuQi
2016-09-09  6:42 ` Joe Perches [this message]
2016-09-09  6:42   ` Joe Perches
2016-09-09  7:16   ` Xie XiuQi
2016-09-09  7:16     ` Xie XiuQi
2016-09-13  6:57     ` Dave Chinner
2016-09-13  6:57       ` Dave Chinner
2016-09-13  7:23       ` Xie XiuQi
2016-09-13  7:23         ` Xie XiuQi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473403321.13672.35.camel@perches.com \
    --to=joe@perches.com \
    --cc=david@fromorbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    --cc=xiexiuqi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.