From: kernel@martin.sperl.org To: Zhang Rui <rui.zhang@intel.com>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Stephen Warren <swarren@wwwdotorg.org>, Lee Jones <lee@kernel.org>, Eric Anholt <eric@anholt.net>, Russell King <linux@arm.linux.org.uk>, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Cc: Martin Sperl <kernel@martin.sperl.org> Subject: [PATCH V4 0/4] thermal: bcm2835: add thermal driver Date: Fri, 9 Sep 2016 07:49:53 +0000 [thread overview] Message-ID: <1473407397-29395-1-git-send-email-kernel@martin.sperl.org> (raw) From: Martin Sperl <kernel@martin.sperl.org> Add a thermal driver for the TSENSE device of the bcm2835 SOC. If the firmware enables the HW, then the configuration is not touched. In case the firmware has not enabled the device, then we try to set it up correctly (which unfortunately can not get tested). It exposes temperature and a critical trip point (using a hardcoded default of 80C or the temperature configured in the control register by the firmware, which reads as 407C currently) The calibrations are (potentially) different for bcm2835, bcm2836 and bcm2837 and can get selected by the compatible property in the device tree. The driver also exposes the registers via debugfs. Possible future enhancements: * the device has the ability to trigger interrupts on reaching the programmed critical temperature. I have no knowledge which interrupt could be responsible for this on the ARM side, so if we get to know which irq it is we can implement that. Instead the driver right now implements polling in 1 second intervals * the device can also reset the HW after the trip point has been reached (also with some delay, so that corrective actions can get taken) - this is currently not enabled by the firmware, but could. * we could define more trip points for THERMAL_TRIP_HOT * make the trip point limits modifiable (ops.set_trip_temp) Changelog: V1 -> V2: renamed dt-binding documentation file added specific settings depending on compatible added trip point based on register setting up ctrl-register if HW is not enabled by firmware as per recommendation of Eric (untested) check that clock frequency is in range (1.9 - 5MHz - as per comment in clk-bcm2835.c) added driver to multi_v7_defconfig V2 -> V3: made a module in multi_v7_defconfig fixed typo in dt-binding document V3 -> V4: moved driver back to thermal (not using bcm sub-directory) set polling interval to 1second (was 0ms, so interrupt driven) Martin Sperl (4): dt: bindings: add thermal device driver for bcm2835 thermal: bcm2835: add thermal driver for bcm2835 soc ARM: bcm2835: add thermal node to device-tree of bcm283x ARM: bcm2835: add thermal driver to default_config .../bindings/thermal/brcm,bcm2835-thermal.txt | 17 ++ arch/arm/boot/dts/bcm283x.dtsi | 6 + arch/arm/configs/bcm2835_defconfig | 2 + drivers/thermal/Kconfig | 5 + drivers/thermal/Makefile | 1 + drivers/thermal/bcm2835_thermal.c | 327 +++++++++++++++++++++ 6 files changed, 358 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/brcm,bcm2835-thermal.txt create mode 100644 drivers/thermal/bcm2835_thermal.c -- 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: kernel@martin.sperl.org (kernel at martin.sperl.org) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V4 0/4] thermal: bcm2835: add thermal driver Date: Fri, 9 Sep 2016 07:49:53 +0000 [thread overview] Message-ID: <1473407397-29395-1-git-send-email-kernel@martin.sperl.org> (raw) From: Martin Sperl <kernel@martin.sperl.org> Add a thermal driver for the TSENSE device of the bcm2835 SOC. If the firmware enables the HW, then the configuration is not touched. In case the firmware has not enabled the device, then we try to set it up correctly (which unfortunately can not get tested). It exposes temperature and a critical trip point (using a hardcoded default of 80C or the temperature configured in the control register by the firmware, which reads as 407C currently) The calibrations are (potentially) different for bcm2835, bcm2836 and bcm2837 and can get selected by the compatible property in the device tree. The driver also exposes the registers via debugfs. Possible future enhancements: * the device has the ability to trigger interrupts on reaching the programmed critical temperature. I have no knowledge which interrupt could be responsible for this on the ARM side, so if we get to know which irq it is we can implement that. Instead the driver right now implements polling in 1 second intervals * the device can also reset the HW after the trip point has been reached (also with some delay, so that corrective actions can get taken) - this is currently not enabled by the firmware, but could. * we could define more trip points for THERMAL_TRIP_HOT * make the trip point limits modifiable (ops.set_trip_temp) Changelog: V1 -> V2: renamed dt-binding documentation file added specific settings depending on compatible added trip point based on register setting up ctrl-register if HW is not enabled by firmware as per recommendation of Eric (untested) check that clock frequency is in range (1.9 - 5MHz - as per comment in clk-bcm2835.c) added driver to multi_v7_defconfig V2 -> V3: made a module in multi_v7_defconfig fixed typo in dt-binding document V3 -> V4: moved driver back to thermal (not using bcm sub-directory) set polling interval to 1second (was 0ms, so interrupt driven) Martin Sperl (4): dt: bindings: add thermal device driver for bcm2835 thermal: bcm2835: add thermal driver for bcm2835 soc ARM: bcm2835: add thermal node to device-tree of bcm283x ARM: bcm2835: add thermal driver to default_config .../bindings/thermal/brcm,bcm2835-thermal.txt | 17 ++ arch/arm/boot/dts/bcm283x.dtsi | 6 + arch/arm/configs/bcm2835_defconfig | 2 + drivers/thermal/Kconfig | 5 + drivers/thermal/Makefile | 1 + drivers/thermal/bcm2835_thermal.c | 327 +++++++++++++++++++++ 6 files changed, 358 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/brcm,bcm2835-thermal.txt create mode 100644 drivers/thermal/bcm2835_thermal.c -- 2.1.4
next reply other threads:[~2016-09-09 7:49 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-09 7:49 kernel [this message] 2016-09-09 7:49 ` [PATCH V4 0/4] thermal: bcm2835: add thermal driver kernel at martin.sperl.org 2016-09-09 7:49 ` [PATCH V4 1/4] dt: bindings: add thermal device driver for bcm2835 kernel 2016-09-09 7:49 ` kernel at martin.sperl.org 2016-09-09 7:49 ` [PATCH V4 2/4] thermal: bcm2835: add thermal driver for bcm2835 soc kernel 2016-09-09 7:49 ` kernel at martin.sperl.org [not found] ` <1473407397-29395-3-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org> 2016-09-09 17:57 ` Eric Anholt 2016-09-09 17:57 ` Eric Anholt [not found] ` <1473407397-29395-1-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org> 2016-09-09 7:49 ` [PATCH V4 3/4] ARM: bcm2835: add thermal node to device-tree of bcm283x kernel-TqfNSX0MhmxHKSADF0wUEw 2016-09-09 7:49 ` kernel at martin.sperl.org [not found] ` <1473407397-29395-4-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org> 2016-09-09 14:25 ` Stefan Wahren 2016-09-09 14:25 ` Stefan Wahren [not found] ` <19cc8fbf-6ceb-995e-850d-9d82bdaff8d0-eS4NqCHxEME@public.gmane.org> 2016-09-09 14:58 ` Martin Sperl 2016-09-09 14:58 ` Martin Sperl [not found] ` <8876586A-98F8-4AAF-AD90-86EB12C22FDC-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org> 2016-09-09 15:36 ` Stefan Wahren 2016-09-09 15:36 ` Stefan Wahren [not found] ` <2117811305.32861.15854341-2f8e-4e20-95f4-e76f81e6fd56.open-xchange-7tX72C7vayboQLBSYMtkGA@public.gmane.org> 2016-09-09 18:12 ` Martin Sperl 2016-09-09 18:12 ` Martin Sperl 2016-09-09 19:02 ` Stefan Wahren 2016-09-09 19:02 ` Stefan Wahren 2016-09-13 9:06 ` Martin Sperl 2016-09-13 9:06 ` Martin Sperl [not found] ` <704dd583-5bd8-fa77-a4ab-18f0845b9c4e-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org> 2016-09-13 9:17 ` Stefan Wahren 2016-09-13 9:17 ` Stefan Wahren 2016-09-09 7:49 ` [PATCH V4 4/4] ARM: bcm2835: add thermal driver to default_config kernel 2016-09-09 7:49 ` kernel at martin.sperl.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1473407397-29395-1-git-send-email-kernel@martin.sperl.org \ --to=kernel@martin.sperl.org \ --cc=devicetree@vger.kernel.org \ --cc=eric@anholt.net \ --cc=lee@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=linux@arm.linux.org.uk \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=robh+dt@kernel.org \ --cc=rui.zhang@intel.com \ --cc=swarren@wwwdotorg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.