From: Marcin Nowakowski <marcin.nowakowski@imgtec.com> To: <linux-kernel@vger.kernel.org> Cc: <linux-api@vger.kernel.org>, <luto@amacapital.net>, <rostedt@goodmis.org>, Marcin Nowakowski <marcin.nowakowski@imgtec.com> Subject: [RFC PATCH 0/3] syscall/tracing: compat syscall support Date: Fri, 9 Sep 2016 10:03:26 +0200 [thread overview] Message-ID: <1473408209-17335-1-git-send-email-marcin.nowakowski@imgtec.com> (raw) This patchset adds support syscall event tracing for compat syscalls. Patch 1 removes the unnecessary syscall_nr field from syscall metadata, which was one of the obstacles for adding proper support for compat syscalls. Patch 2 adds a method to distinguish handling of syscalls for compat tasks if an arch requires that. In disussions about an earlier version of these patches (http://marc.info/?l=linux-mips&m=147259973128606&w=2) it was suggested to use audit arch for detecting syscall type. After analysing the code for various arches it seemed to me that this would add an unnecessary complexity (as would require extra APIs to enumerate and map all audit arch types) and I've just simply used compat task status to determine call type. I cannot see any added value from using the audit arch type in this context, but it is of course possible that I'm missing some vital piece of information here ... hence this change is sent as an RFC so that I can get valuable feedback on the proposed solution. Finally the last patch adds the missing compat syscall metadata. Marcin Nowakowski (3): tracing/syscalls: remove syscall_nr from syscall metadata tracing/syscalls: add handling for compat tasks tracing/syscalls: add compat syscall metadata arch/mips/kernel/ftrace.c | 4 +- arch/x86/include/asm/ftrace.h | 10 +- arch/x86/kernel/ftrace.c | 14 +++ include/linux/compat.h | 74 ++++++++++++ include/linux/ftrace.h | 2 +- include/linux/syscalls.h | 1 - include/trace/syscall.h | 2 - kernel/trace/trace.h | 11 +- kernel/trace/trace_syscalls.c | 254 +++++++++++++++++++++++++++--------------- 9 files changed, 265 insertions(+), 107 deletions(-) -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Marcin Nowakowski <marcin.nowakowski-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org, rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org, Marcin Nowakowski <marcin.nowakowski-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> Subject: [RFC PATCH 0/3] syscall/tracing: compat syscall support Date: Fri, 9 Sep 2016 10:03:26 +0200 [thread overview] Message-ID: <1473408209-17335-1-git-send-email-marcin.nowakowski@imgtec.com> (raw) This patchset adds support syscall event tracing for compat syscalls. Patch 1 removes the unnecessary syscall_nr field from syscall metadata, which was one of the obstacles for adding proper support for compat syscalls. Patch 2 adds a method to distinguish handling of syscalls for compat tasks if an arch requires that. In disussions about an earlier version of these patches (http://marc.info/?l=linux-mips&m=147259973128606&w=2) it was suggested to use audit arch for detecting syscall type. After analysing the code for various arches it seemed to me that this would add an unnecessary complexity (as would require extra APIs to enumerate and map all audit arch types) and I've just simply used compat task status to determine call type. I cannot see any added value from using the audit arch type in this context, but it is of course possible that I'm missing some vital piece of information here ... hence this change is sent as an RFC so that I can get valuable feedback on the proposed solution. Finally the last patch adds the missing compat syscall metadata. Marcin Nowakowski (3): tracing/syscalls: remove syscall_nr from syscall metadata tracing/syscalls: add handling for compat tasks tracing/syscalls: add compat syscall metadata arch/mips/kernel/ftrace.c | 4 +- arch/x86/include/asm/ftrace.h | 10 +- arch/x86/kernel/ftrace.c | 14 +++ include/linux/compat.h | 74 ++++++++++++ include/linux/ftrace.h | 2 +- include/linux/syscalls.h | 1 - include/trace/syscall.h | 2 - kernel/trace/trace.h | 11 +- kernel/trace/trace_syscalls.c | 254 +++++++++++++++++++++++++++--------------- 9 files changed, 265 insertions(+), 107 deletions(-) -- 2.7.4
next reply other threads:[~2016-09-09 8:04 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-09 8:03 Marcin Nowakowski [this message] 2016-09-09 8:03 ` [RFC PATCH 0/3] syscall/tracing: compat syscall support Marcin Nowakowski 2016-09-09 8:03 ` [RFC PATCH 1/3] tracing/syscalls: remove syscall_nr from syscall metadata Marcin Nowakowski 2016-09-09 8:03 ` Marcin Nowakowski 2016-09-09 8:03 ` [RFC PATCH 2/3] tracing/syscalls: add handling for compat tasks Marcin Nowakowski 2016-09-09 8:03 ` Marcin Nowakowski 2016-09-12 17:35 ` Andy Lutomirski 2016-09-13 5:41 ` Marcin Nowakowski 2016-09-13 5:41 ` Marcin Nowakowski 2016-09-13 19:09 ` Andy Lutomirski 2016-09-13 19:09 ` Andy Lutomirski 2016-09-09 8:03 ` [RFC PATCH 3/3] tracing/syscalls: add compat syscall metadata Marcin Nowakowski 2016-09-09 8:03 ` Marcin Nowakowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1473408209-17335-1-git-send-email-marcin.nowakowski@imgtec.com \ --to=marcin.nowakowski@imgtec.com \ --cc=linux-api@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luto@amacapital.net \ --cc=rostedt@goodmis.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.