* [PATCH] Tiny whitespace fix to make ad7192.c cleanly pass checkpatch.pl
@ 2016-09-09 13:40 Ico Doornekamp
2016-09-09 13:56 ` Crt Mori
2016-09-09 13:59 ` Lars-Peter Clausen
0 siblings, 2 replies; 6+ messages in thread
From: Ico Doornekamp @ 2016-09-09 13:40 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, Ico Doornekamp
---
drivers/staging/iio/adc/ad7192.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index 1cf6b79..5688b29 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -391,7 +391,7 @@ ad7192_show_scale_available(struct device *dev,
}
static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
- in_voltage-voltage_scale_available,
+ in_voltage - voltage_scale_available,
S_IRUGO, ad7192_show_scale_available, NULL, 0);
static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO,
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Tiny whitespace fix to make ad7192.c cleanly pass checkpatch.pl
2016-09-09 13:40 [PATCH] Tiny whitespace fix to make ad7192.c cleanly pass checkpatch.pl Ico Doornekamp
@ 2016-09-09 13:56 ` Crt Mori
2016-09-09 14:05 ` Ico Doornekamp
2016-09-09 13:59 ` Lars-Peter Clausen
1 sibling, 1 reply; 6+ messages in thread
From: Crt Mori @ 2016-09-09 13:56 UTC (permalink / raw)
To: Ico Doornekamp; +Cc: Johnathan Iain Cameron, Linux Iio
Hey.
You are missing Signed-off-by flag.
BR
Crt
On 9 September 2016 at 15:40, Ico Doornekamp <ico@pruts.nl> wrote:
> ---
> drivers/staging/iio/adc/ad7192.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 1cf6b79..5688b29 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -391,7 +391,7 @@ ad7192_show_scale_available(struct device *dev,
> }
>
> static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> - in_voltage-voltage_scale_available,
> + in_voltage - voltage_scale_available,
> S_IRUGO, ad7192_show_scale_available, NULL, 0);
>
> static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO,
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Tiny whitespace fix to make ad7192.c cleanly pass checkpatch.pl
2016-09-09 13:40 [PATCH] Tiny whitespace fix to make ad7192.c cleanly pass checkpatch.pl Ico Doornekamp
2016-09-09 13:56 ` Crt Mori
@ 2016-09-09 13:59 ` Lars-Peter Clausen
2016-09-10 15:39 ` Jonathan Cameron
1 sibling, 1 reply; 6+ messages in thread
From: Lars-Peter Clausen @ 2016-09-09 13:59 UTC (permalink / raw)
To: Ico Doornekamp, jic23; +Cc: linux-iio
Hi,
Thanks for the patch. But this not a correct change, it is a false positive
reported by checkpatch.
- Lars
On 09/09/2016 03:40 PM, Ico Doornekamp wrote:
> ---
> drivers/staging/iio/adc/ad7192.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 1cf6b79..5688b29 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -391,7 +391,7 @@ ad7192_show_scale_available(struct device *dev,
> }
>
> static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> - in_voltage-voltage_scale_available,
> + in_voltage - voltage_scale_available,
> S_IRUGO, ad7192_show_scale_available, NULL, 0);
>
> static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO,
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Tiny whitespace fix to make ad7192.c cleanly pass checkpatch.pl
2016-09-09 13:56 ` Crt Mori
@ 2016-09-09 14:05 ` Ico Doornekamp
0 siblings, 0 replies; 6+ messages in thread
From: Ico Doornekamp @ 2016-09-09 14:05 UTC (permalink / raw)
To: Crt Mori; +Cc: Johnathan Iain Cameron, Linux Iio
* On 2016-09-09 15:56:31 +0200, Crt Mori wrote:
> You are missing Signed-off-by flag.
Sorry, first time around. Retry:
Signed-off-by: Ico Doornekamp <ico@pruts.nl>
---
drivers/staging/iio/adc/ad7192.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index 1cf6b79..5688b29 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -391,7 +391,7 @@ ad7192_show_scale_available(struct device *dev,
}
static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
- in_voltage-voltage_scale_available,
+ in_voltage - voltage_scale_available,
S_IRUGO, ad7192_show_scale_available, NULL, 0);
static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO,
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Tiny whitespace fix to make ad7192.c cleanly pass checkpatch.pl
2016-09-09 13:59 ` Lars-Peter Clausen
@ 2016-09-10 15:39 ` Jonathan Cameron
2016-09-10 15:55 ` Ico Doornekamp
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Cameron @ 2016-09-10 15:39 UTC (permalink / raw)
To: Lars-Peter Clausen, Ico Doornekamp; +Cc: linux-iio
On 09/09/16 14:59, Lars-Peter Clausen wrote:
> Hi,
>
> Thanks for the patch. But this not a correct change, it is a false positive
> reported by checkpatch.
Just to explain a bit more. Checkpatch is assuming that it is looking
at two parameters. It's not. That's a string being passed into the macro.
It ultimately forms a file name in sysfs.
Jonathan
p.s. We get patches for this from time to time ;( Unfortunately it's
a somewhat obscure case for checkpatch.
>
> - Lars
>
> On 09/09/2016 03:40 PM, Ico Doornekamp wrote:
>> ---
>> drivers/staging/iio/adc/ad7192.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
>> index 1cf6b79..5688b29 100644
>> --- a/drivers/staging/iio/adc/ad7192.c
>> +++ b/drivers/staging/iio/adc/ad7192.c
>> @@ -391,7 +391,7 @@ ad7192_show_scale_available(struct device *dev,
>> }
>>
>> static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
>> - in_voltage-voltage_scale_available,
>> + in_voltage - voltage_scale_available,
>> S_IRUGO, ad7192_show_scale_available, NULL, 0);
>>
>> static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO,
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Tiny whitespace fix to make ad7192.c cleanly pass checkpatch.pl
2016-09-10 15:39 ` Jonathan Cameron
@ 2016-09-10 15:55 ` Ico Doornekamp
0 siblings, 0 replies; 6+ messages in thread
From: Ico Doornekamp @ 2016-09-10 15:55 UTC (permalink / raw)
To: linux-iio
* On 2016-09-10 17:39:27 +0200, Jonathan Cameron wrote:
> On 09/09/16 14:59, Lars-Peter Clausen wrote:
> Just to explain a bit more. Checkpatch is assuming that it is looking
> at two parameters. It's not. That's a string being passed into the macro.
> It ultimately forms a file name in sysfs.
Yeah, I figured that out eventually, after submitting the patch. Thanks
for explaining, though.
--
:wq
^X^Cy^K^X^C^C^C^C
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-10 15:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-09 13:40 [PATCH] Tiny whitespace fix to make ad7192.c cleanly pass checkpatch.pl Ico Doornekamp
2016-09-09 13:56 ` Crt Mori
2016-09-09 14:05 ` Ico Doornekamp
2016-09-09 13:59 ` Lars-Peter Clausen
2016-09-10 15:39 ` Jonathan Cameron
2016-09-10 15:55 ` Ico Doornekamp
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.