[PATCH] arm-cci: add cci_enable_port_for_self() declaration in arm-cci.h

[PATCH] arm-cci: add cci_enable_port_for_self() declaration in arm-cci.h

[Baoyou Xie]

We get 1 warning when building kernel with W=1:
drivers/bus/arm-cci.c:2027:25: warning: no previous prototype for 'cci_enable_port_for_self' [-Wmissing-prototypes]

In fact, this function is used in a few files,
but should be declared in a header file.

So this patch adds the declaration in arm-cci.h.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 include/linux/arm-cci.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/arm-cci.h b/include/linux/arm-cci.h
index 521ec1f..b88f6fb 100644
--- a/include/linux/arm-cci.h
+++ b/include/linux/arm-cci.h
@@ -30,8 +30,10 @@ struct device_node;
 
 #ifdef CONFIG_ARM_CCI
 extern bool cci_probed(void);
+extern asmlinkage void __naked cci_enable_port_for_self(void);
 #else
 static inline bool cci_probed(void) { return false; }
+static inline void ci_enable_port_for_self(void) { return; }
 #endif
 
 #ifdef CONFIG_ARM_CCI400_PORT_CTRL
-- 
2.7.4

Re: [PATCH] arm-cci: add cci_enable_port_for_self() declaration in arm-cci.h

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1776 bytes --]

Hi Baoyou,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.8-rc6 next-20160912]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/Baoyou-Xie/arm-cci-add-cci_enable_port_for_self-declaration-in-arm-cci-h/20160912-191816
config: arm64-allmodconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm64 

All errors (new ones prefixed by >>):

   In file included from drivers/bus/arm-cci.c:17:0:
>> include/linux/arm-cci.h:33:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'
    extern asmlinkage void __naked cci_enable_port_for_self(void);
                      ^

vim +33 include/linux/arm-cci.h

    27	#include <asm/arm-cci.h>
    28	
    29	struct device_node;
    30	
    31	#ifdef CONFIG_ARM_CCI
    32	extern bool cci_probed(void);
  > 33	extern asmlinkage void __naked cci_enable_port_for_self(void);
    34	#else
    35	static inline bool cci_probed(void) { return false; }
    36	static inline void ci_enable_port_for_self(void) { return; }

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 51340 bytes --]

Re: [PATCH] arm-cci: add cci_enable_port_for_self() declaration in arm-cci.h

[Suzuki K Poulose]

On 12/09/16 11:33, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/bus/arm-cci.c:2027:25: warning: no previous prototype for 'cci_enable_port_for_self' [-Wmissing-prototypes]
>
> In fact, this function is used in a few files,
> but should be declared in a header file.
>
> So this patch adds the declaration in arm-cci.h.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>  include/linux/arm-cci.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/arm-cci.h b/include/linux/arm-cci.h
> index 521ec1f..b88f6fb 100644
> --- a/include/linux/arm-cci.h
> +++ b/include/linux/arm-cci.h
> @@ -30,8 +30,10 @@ struct device_node;
>
>  #ifdef CONFIG_ARM_CCI
>  extern bool cci_probed(void);
> +extern asmlinkage void __naked cci_enable_port_for_self(void);
>  #else
>  static inline bool cci_probed(void) { return false; }
> +static inline void ci_enable_port_for_self(void) { return; }
>  #endif
>

Don't you think the above definitions should depend on

ARM_CCI400_PORT_CTRL than ARM_CCI ?


Suzuki

[PATCH] arm-cci: add cci_enable_port_for_self() declaration in arm-cci.h

[Baoyou Xie]

We get 1 warning when building kernel with W=1:
drivers/bus/arm-cci.c:2027:25: warning: no previous prototype for 'cci_enable_port_for_self' [-Wmissing-prototypes]

In fact, this function is used in a few files,
but should be declared in a header file.

So this patch adds the declaration in arm-cci.h.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 include/linux/arm-cci.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/arm-cci.h b/include/linux/arm-cci.h
index 521ec1f..b88f6fb 100644
--- a/include/linux/arm-cci.h
+++ b/include/linux/arm-cci.h
@@ -30,8 +30,10 @@ struct device_node;
 
 #ifdef CONFIG_ARM_CCI
 extern bool cci_probed(void);
+extern asmlinkage void __naked cci_enable_port_for_self(void);
 #else
 static inline bool cci_probed(void) { return false; }
+static inline void ci_enable_port_for_self(void) { return; }
 #endif
 
 #ifdef CONFIG_ARM_CCI400_PORT_CTRL
-- 
2.7.4