* [PATCH] image.bbclass: do not check size of the debugfs image
@ 2016-09-05 8:34 André Draszik
2016-09-12 15:26 ` André Draszik
0 siblings, 1 reply; 4+ messages in thread
From: André Draszik @ 2016-09-05 8:34 UTC (permalink / raw)
To: openembedded-core
The debugfs is supposed to be used in addition to the
normal image for debugging purposes, it doesn't make
sense to artificially limit its maximum size.
Signed-off-by: André Draszik <git@andred.net>
---
meta/classes/image.bbclass | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 07bd2d6..cb7d06d 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -538,6 +538,12 @@ def get_rootfs_size(d):
base_size += rootfs_alignment - 1
base_size -= base_size % rootfs_alignment
+ # Do not check image size of the debugfs image. This is not supposed
+ # to be deployed, etc. so it doesn't make sense to limit the size
+ # of the debug.
+ if (d.getVar('IMAGE_BUILDING_DEBUGFS', True) or "") == "true":
+ return base_size
+
# Check the rootfs size against IMAGE_ROOTFS_MAXSIZE (if set)
if rootfs_maxsize:
rootfs_maxsize_int = int(rootfs_maxsize)
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] image.bbclass: do not check size of the debugfs image
2016-09-05 8:34 [PATCH] image.bbclass: do not check size of the debugfs image André Draszik
@ 2016-09-12 15:26 ` André Draszik
2016-09-12 15:36 ` Burton, Ross
0 siblings, 1 reply; 4+ messages in thread
From: André Draszik @ 2016-09-12 15:26 UTC (permalink / raw)
To: openembedded-core
ping
On Mo, 2016-09-05 at 09:34 +0100, André Draszik wrote:
> The debugfs is supposed to be used in addition to the
> normal image for debugging purposes, it doesn't make
> sense to artificially limit its maximum size.
>
> Signed-off-by: André Draszik <git@andred.net>
> ---
> meta/classes/image.bbclass | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 07bd2d6..cb7d06d 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -538,6 +538,12 @@ def get_rootfs_size(d):
> base_size += rootfs_alignment - 1
> base_size -= base_size % rootfs_alignment
>
> + # Do not check image size of the debugfs image. This is not supposed
> + # to be deployed, etc. so it doesn't make sense to limit the size
> + # of the debug.
> + if (d.getVar('IMAGE_BUILDING_DEBUGFS', True) or "") == "true":
> + return base_size
> +
> # Check the rootfs size against IMAGE_ROOTFS_MAXSIZE (if set)
> if rootfs_maxsize:
> rootfs_maxsize_int = int(rootfs_maxsize)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] image.bbclass: do not check size of the debugfs image
2016-09-12 15:26 ` André Draszik
@ 2016-09-12 15:36 ` Burton, Ross
2016-09-13 7:44 ` André Draszik
0 siblings, 1 reply; 4+ messages in thread
From: Burton, Ross @ 2016-09-12 15:36 UTC (permalink / raw)
To: André Draszik; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 1618 bytes --]
Well there must have been some list/gmail snafu, as I definitely don't have
this patch locally but patchwork has it. I wonder what else I'm missing...
Ross
On 12 September 2016 at 16:26, André Draszik <git@andred.net> wrote:
> ping
>
> On Mo, 2016-09-05 at 09:34 +0100, André Draszik wrote:
> > The debugfs is supposed to be used in addition to the
> > normal image for debugging purposes, it doesn't make
> > sense to artificially limit its maximum size.
> >
> > Signed-off-by: André Draszik <git@andred.net>
> > ---
> > meta/classes/image.bbclass | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> > index 07bd2d6..cb7d06d 100644
> > --- a/meta/classes/image.bbclass
> > +++ b/meta/classes/image.bbclass
> > @@ -538,6 +538,12 @@ def get_rootfs_size(d):
> > base_size += rootfs_alignment - 1
> > base_size -= base_size % rootfs_alignment
> >
> > + # Do not check image size of the debugfs image. This is not supposed
> > + # to be deployed, etc. so it doesn't make sense to limit the size
> > + # of the debug.
> > + if (d.getVar('IMAGE_BUILDING_DEBUGFS', True) or "") == "true":
> > + return base_size
> > +
> > # Check the rootfs size against IMAGE_ROOTFS_MAXSIZE (if set)
> > if rootfs_maxsize:
> > rootfs_maxsize_int = int(rootfs_maxsize)
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 2469 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] image.bbclass: do not check size of the debugfs image
2016-09-12 15:36 ` Burton, Ross
@ 2016-09-13 7:44 ` André Draszik
0 siblings, 0 replies; 4+ messages in thread
From: André Draszik @ 2016-09-13 7:44 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
Somebody did mention last week (Monday?) on IRC that mails are not arriving.
In the mailman web interface they aren't missing though (which is what I
sometimes use to check)... Strange
Andre'
On Mo, 2016-09-12 at 16:36 +0100, Burton, Ross wrote:
> Well there must have been some list/gmail snafu, as I definitely don't
> have
> this patch locally but patchwork has it. I wonder what else I'm
> missing...
>
> Ross
>
> On 12 September 2016 at 16:26, André Draszik <git@andred.net> wrote:
>
> >
> > ping
> >
> > On Mo, 2016-09-05 at 09:34 +0100, André Draszik wrote:
> > >
> > > The debugfs is supposed to be used in addition to the
> > > normal image for debugging purposes, it doesn't make
> > > sense to artificially limit its maximum size.
> > >
> > > Signed-off-by: André Draszik <git@andred.net>
> > > ---
> > > meta/classes/image.bbclass | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> > > index 07bd2d6..cb7d06d 100644
> > > --- a/meta/classes/image.bbclass
> > > +++ b/meta/classes/image.bbclass
> > > @@ -538,6 +538,12 @@ def get_rootfs_size(d):
> > > base_size += rootfs_alignment - 1
> > > base_size -= base_size % rootfs_alignment
> > >
> > > + # Do not check image size of the debugfs image. This is not
> > > supposed
> > > + # to be deployed, etc. so it doesn't make sense to limit the size
> > > + # of the debug.
> > > + if (d.getVar('IMAGE_BUILDING_DEBUGFS', True) or "") == "true":
> > > + return base_size
> > > +
> > > # Check the rootfs size against IMAGE_ROOTFS_MAXSIZE (if set)
> > > if rootfs_maxsize:
> > > rootfs_maxsize_int = int(rootfs_maxsize)
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-13 7:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-05 8:34 [PATCH] image.bbclass: do not check size of the debugfs image André Draszik
2016-09-12 15:26 ` André Draszik
2016-09-12 15:36 ` Burton, Ross
2016-09-13 7:44 ` André Draszik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.