[PATCH] samba: unblacklist

[PATCH] samba: unblacklist

[Andreas Müller]

This should make all happy:

* arm people can build again
* others are not affected

Andreas Müller (1):
  samba: unblacklist and link with bfd on arm only

 meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

-- 
2.5.5

[PATCH] samba: unblacklist and link with bfd on arm only

[Andreas Müller]

Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
---
 meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
index 7d7fa02..53721b1 100644
--- a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
+++ b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
@@ -88,7 +88,8 @@ EXTRA_OECONF += "--enable-fhs \
                 "
 DISABLE_STATIC = ""
 
-LDFLAGS += "-Wl,-z,relro,-z,now ${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
+LDFLAGS += "-Wl,-z,relro,-z,now"
+LDFLAGS_append_arm = " ${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
 
 do_install_append() {
     if ${@bb.utils.contains('PACKAGECONFIG', 'systemd', 'true', 'false', d)}; then
@@ -317,8 +318,3 @@ FILES_${PN}-python-dbg = "${libdir}/python${PYTHON_BASEVERSION}/site-packages/.d
 
 RDEPENDS_${PN}-pidl_append = " perl"
 FILES_${PN}-pidl = "${bindir}/pidl ${datadir}/perl5/Parse"
-
-# http://errors.yoctoproject.org/Errors/Details/81004/
-# before this issue it was also failing in do_package and
-# autodetecting libpam dependency
-PNBLACKLIST[samba] ?= "BROKEN: fails to build with new binutils-2.27"
-- 
2.5.5

Re: [PATCH] samba: unblacklist and link with bfd on arm only

[Martin Jansa]

What about the other 2 issues mentioned in the comment?

On Wed, Sep 14, 2016 at 10:14 PM, Andreas Müller <
schnitzeltony@googlemail.com> wrote:

> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> ---
>  meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> index 7d7fa02..53721b1 100644
> --- a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> +++ b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> @@ -88,7 +88,8 @@ EXTRA_OECONF += "--enable-fhs \
>                  "
>  DISABLE_STATIC = ""
>
> -LDFLAGS += "-Wl,-z,relro,-z,now ${@bb.utils.contains('DISTRO_FEATURES',
> 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
> +LDFLAGS += "-Wl,-z,relro,-z,now"
> +LDFLAGS_append_arm = " ${@bb.utils.contains('DISTRO_FEATURES',
> 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
>
>  do_install_append() {
>      if ${@bb.utils.contains('PACKAGECONFIG', 'systemd', 'true', 'false',
> d)}; then
> @@ -317,8 +318,3 @@ FILES_${PN}-python-dbg = "${libdir}/python${PYTHON_
> BASEVERSION}/site-packages/.d
>
>  RDEPENDS_${PN}-pidl_append = " perl"
>  FILES_${PN}-pidl = "${bindir}/pidl ${datadir}/perl5/Parse"
> -
> -# http://errors.yoctoproject.org/Errors/Details/81004/
> -# before this issue it was also failing in do_package and
> -# autodetecting libpam dependency
> -PNBLACKLIST[samba] ?= "BROKEN: fails to build with new binutils-2.27"
> --
> 2.5.5
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [PATCH] samba: unblacklist and link with bfd on arm only

[Andreas Müller]

On Wed, Sep 14, 2016 at 11:21 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> What about the other 2 issues mentioned in the comment?
>
I am sure I am missing something. I did

* pull meta-oe
* built samba with this patch attached in a 'crowded' sysroot (good
for floating dependencies) for arm (raspi2)

-> No warnings/errors

Andreas

Re: [PATCH] samba: unblacklist and link with bfd on arm only

[Martin Jansa]

WARN: samba: samba rdepends on libpam, but it isn't a build dependency?

is reported in every report (where samba was successfully built)
http://www.openembedded.org/wiki/Bitbake_World_Status for more than a year
- pam isn't in typical 'crowded' sysroot unless you have pam in
DISTRO_FEATURES and it might be always detected when you have pam in
DISTRO_FEATURES.

There is also at least one report where it failed with ld.gold also for
qemux86, e.g.:
http://errors.yoctoproject.org/Errors/Details/75447/

I'll of course include these changes in next jenkins build to report which
failures it will re-introduce.

On Thu, Sep 15, 2016 at 12:20 AM, Andreas Müller <
schnitzeltony@googlemail.com> wrote:

> On Wed, Sep 14, 2016 at 11:21 PM, Martin Jansa <martin.jansa@gmail.com>
> wrote:
> > What about the other 2 issues mentioned in the comment?
> >
> I am sure I am missing something. I did
>
> * pull meta-oe
> * built samba with this patch attached in a 'crowded' sysroot (good
> for floating dependencies) for arm (raspi2)
>
> -> No warnings/errors
>
> Andreas
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [PATCH] samba: unblacklist and link with bfd on arm only

[Andreas Müller]

On Thu, Sep 15, 2016 at 10:03 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> WARN: samba: samba rdepends on libpam, but it isn't a build dependency?
>
> is reported in every report (where samba was successfully built)
> http://www.openembedded.org/wiki/Bitbake_World_Status for more than a year
> - pam isn't in typical 'crowded' sysroot unless you have pam in
> DISTRO_FEATURES and it might be always detected when you have pam in
> DISTRO_FEATURES.
>
> There is also at least one report where it failed with ld.gold also for
> qemux86, e.g.:
> http://errors.yoctoproject.org/Errors/Details/75447/
>
> I'll of course include these changes in next jenkins build to report which
> failures it will re-introduce.
>
I cannot check this now - tested at home - but as far as I can
remember I have pam in DISTRO_FEATURES.

Whatever:

* I will check for pam and send a follow up if necessary
* autobuilder will tell us if other archs need bfd too - if so I will take care

Andreas

Re: [PATCH] samba: unblacklist and link with bfd on arm only

[Jack Mitchell]

On 15/09/16 10:14, Andreas Müller wrote:
> On Thu, Sep 15, 2016 at 10:03 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> WARN: samba: samba rdepends on libpam, but it isn't a build dependency?
>>
>> is reported in every report (where samba was successfully built)
>> http://www.openembedded.org/wiki/Bitbake_World_Status for more than a year
>> - pam isn't in typical 'crowded' sysroot unless you have pam in
>> DISTRO_FEATURES and it might be always detected when you have pam in
>> DISTRO_FEATURES.
>>
>> There is also at least one report where it failed with ld.gold also for
>> qemux86, e.g.:
>> http://errors.yoctoproject.org/Errors/Details/75447/
>>
>> I'll of course include these changes in next jenkins build to report which
>> failures it will re-introduce.
>>
> I cannot check this now - tested at home - but as far as I can
> remember I have pam in DISTRO_FEATURES.
>
> Whatever:
>
> * I will check for pam and send a follow up if necessary
> * autobuilder will tell us if other archs need bfd too - if so I will take care
>
> Andreas
>

I built samba yesterday on master without any changes apart from 
removing the blacklist. Built on corei7 and arm64 without any 
warnings/issues. I don't have pam in my DISTRO_FEATURES. All standard 
toolchain setup.

Re: [PATCH] samba: unblacklist and link with bfd on arm only

[Andreas Müller]

On Thu, Sep 15, 2016 at 10:03 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> WARN: samba: samba rdepends on libpam, but it isn't a build dependency?
>
> is reported in every report (where samba was successfully built)
> http://www.openembedded.org/wiki/Bitbake_World_Status for more than a year
> - pam isn't in typical 'crowded' sysroot unless you have pam in
> DISTRO_FEATURES and it might be always detected when you have pam in
> DISTRO_FEATURES.
>
Just checked: libpam was in my sysroot and I received no warnings.

Andreas

Re: [PATCH] samba: unblacklist and link with bfd on arm only

[Martin Jansa]

Does your log.do_package show that it was actually linked with libpam?

more details in:
http://lists.openembedded.org/pipermail/openembedded-devel/2016-March/106583.html

On Thu, Sep 15, 2016 at 6:57 PM, Andreas Müller <
schnitzeltony@googlemail.com> wrote:

> On Thu, Sep 15, 2016 at 10:03 AM, Martin Jansa <martin.jansa@gmail.com>
> wrote:
> > WARN: samba: samba rdepends on libpam, but it isn't a build dependency?
> >
> > is reported in every report (where samba was successfully built)
> > http://www.openembedded.org/wiki/Bitbake_World_Status for more than a
> year
> > - pam isn't in typical 'crowded' sysroot unless you have pam in
> > DISTRO_FEATURES and it might be always detected when you have pam in
> > DISTRO_FEATURES.
> >
> Just checked: libpam was in my sysroot and I received no warnings.
>
> Andreas
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [PATCH] samba: unblacklist and link with bfd on arm only

[Martin Jansa]

and
http://lists.openembedded.org/pipermail/openembedded-devel/2016-March/106661.html

On Thu, Sep 15, 2016 at 7:38 PM, Martin Jansa <martin.jansa@gmail.com>
wrote:

> Does your log.do_package show that it was actually linked with libpam?
>
> more details in:
> http://lists.openembedded.org/pipermail/openembedded-devel/
> 2016-March/106583.html
>
> On Thu, Sep 15, 2016 at 6:57 PM, Andreas Müller <
> schnitzeltony@googlemail.com> wrote:
>
>> On Thu, Sep 15, 2016 at 10:03 AM, Martin Jansa <martin.jansa@gmail.com>
>> wrote:
>> > WARN: samba: samba rdepends on libpam, but it isn't a build dependency?
>> >
>> > is reported in every report (where samba was successfully built)
>> > http://www.openembedded.org/wiki/Bitbake_World_Status for more than a
>> year
>> > - pam isn't in typical 'crowded' sysroot unless you have pam in
>> > DISTRO_FEATURES and it might be always detected when you have pam in
>> > DISTRO_FEATURES.
>> >
>> Just checked: libpam was in my sysroot and I received no warnings.
>>
>> Andreas
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
>
>

Re: [PATCH] samba: unblacklist and link with bfd on arm only

[Andreas Müller]

On Thu, Sep 15, 2016 at 7:39 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> and
> http://lists.openembedded.org/pipermail/openembedded-devel/2016-March/106661.html
>
> On Thu, Sep 15, 2016 at 7:38 PM, Martin Jansa <martin.jansa@gmail.com>
> wrote:
>
>> Does your log.do_package show that it was actually linked with libpam?
>>
I think I got it now: Problem does not occur to me as I have pam in
DISTRO_FEATURE -> pam in PACKAGECONFIG -> libpam in DEPENDS. To get
'your' problem, I have to remove pam from PACKAGECONFIG explicitly.

Will report...

Andreas

Re: [PATCH] samba: unblacklist and link with bfd on arm only

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]

On Thu, Sep 15, 2016 at 09:25:08PM +0200, Andreas Müller wrote:
> On Thu, Sep 15, 2016 at 7:39 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > and
> > http://lists.openembedded.org/pipermail/openembedded-devel/2016-March/106661.html
> >
> > On Thu, Sep 15, 2016 at 7:38 PM, Martin Jansa <martin.jansa@gmail.com>
> > wrote:
> >
> >> Does your log.do_package show that it was actually linked with libpam?
> >>
> I think I got it now: Problem does not occur to me as I have pam in
> DISTRO_FEATURE -> pam in PACKAGECONFIG -> libpam in DEPENDS. To get
> 'your' problem, I have to remove pam from PACKAGECONFIG explicitly.

Right, that's what I meant by "and it might be always detected when you have pam in DISTRO_FEATURES."

Sorry that I wasn't clear.

> Will report...

Thanks

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 169 bytes --]

Re: [PATCH] samba: unblacklist and link with bfd on arm only

[Andreas Müller]

On Thu, Sep 15, 2016 at 9:31 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Thu, Sep 15, 2016 at 09:25:08PM +0200, Andreas Müller wrote:
>> On Thu, Sep 15, 2016 at 7:39 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> > and
>> > http://lists.openembedded.org/pipermail/openembedded-devel/2016-March/106661.html
>> >
>> > On Thu, Sep 15, 2016 at 7:38 PM, Martin Jansa <martin.jansa@gmail.com>
>> > wrote:
>> >
>> >> Does your log.do_package show that it was actually linked with libpam?
>> >>
>> I think I got it now: Problem does not occur to me as I have pam in
>> DISTRO_FEATURE -> pam in PACKAGECONFIG -> libpam in DEPENDS. To get
>> 'your' problem, I have to remove pam from PACKAGECONFIG explicitly.
>
> Right, that's what I meant by "and it might be always detected when you have pam in DISTRO_FEATURES."
>
> Sorry that I wasn't clear.
>
>> Will report...
>
> Thanks
>
OK in same environment I did remove samba from PACKAGECONFIG, did
cleansstate / build -> no warnings.

Just to be sure I checked do_package and samba still links against
libpam. Where is my warning???

Have no secret appends for samba (checked with bitbake-layers
show-appends). Strange

Apart from this mystery: I found [1] and will play around with it.

[1] https://lists.samba.org/archive/samba-technical/2011-May/077532.html

Andreas

Re: [PATCH] samba: unblacklist and link with bfd on arm only

[Andreas Müller]

On Thu, Sep 15, 2016 at 10:23 PM, Andreas Müller
<schnitzeltony@googlemail.com> wrote:
> Apart from this mystery: I found [1] and will play around with it.
>
> [1] https://lists.samba.org/archive/samba-technical/2011-May/077532.html
>
Would have been too easy :(

Andreas