From: Gerd Hoffmann <kraxel@redhat.com>
To: "Hervé Poussineau" <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/5] ps2: fix keyboard set 3 and misc improvements
Date: Thu, 15 Sep 2016 09:40:02 +0200 [thread overview]
Message-ID: <1473925202.8913.13.camel@redhat.com> (raw)
In-Reply-To: <1473890265-3304-1-git-send-email-hpoussin@reactos.org>
Hi,
> - Patches 1 and 2 are fixes to let Linux use set 3 if instructed so.
> - Patch 3 makes scancodes untranslated by default and translates them if required,
> instead of receiving translated scancodes by default and untranslating them if
> required.
> - Patch 4 switches to use qcodes instead of scancodes.
> - Patch 5 is a small cleanup, to prevent sending invalid keycodes to the OS.
Nice!
> Patch 3 doesn't pass checkpatch.pl, due to translation table using more than 80 columns.
Easily fixable by breaking those long lines into two.
> Patch 4 doesn't pass checkpatch.pl, due to some key mappings not implemented because of
> missing an equivalent qcode.
Hmm, yes, I've found the checkpatch warning on "#if 0" annonying in
simliar cases before. Documenting incomplete translation tables that
way looks reasonable to me ...
Beside that we can consider adding these qcodes to qemu (which shouldn't
block merging this series of course).
cheers,
Gerd
prev parent reply other threads:[~2016-09-15 7:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 21:57 [Qemu-devel] [PATCH 0/5] ps2: fix keyboard set 3 and misc improvements Hervé Poussineau
2016-09-14 21:57 ` [Qemu-devel] [PATCH 1/5] ps2: reject unknown commands, instead of blindly accepting them Hervé Poussineau
2016-09-14 21:57 ` [Qemu-devel] [PATCH 2/5] ps2: correctly handle 'get/set scancode' command Hervé Poussineau
2016-09-14 21:57 ` [Qemu-devel] [PATCH 3/5] ps2: allow keycode translation for all scancode sets Hervé Poussineau
2016-09-14 21:57 ` [Qemu-devel] [PATCH 4/5] ps2: use QEMU qcodes instead of scancodes Hervé Poussineau
2016-09-14 21:57 ` [Qemu-devel] [PATCH 5/5] ps2: do not generate invalid key codes for unknown keys Hervé Poussineau
2016-09-14 22:40 ` [Qemu-devel] [PATCH 0/5] ps2: fix keyboard set 3 and misc improvements no-reply
2016-09-14 23:01 ` no-reply
2016-09-15 7:40 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473925202.8913.13.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=hpoussin@reactos.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.