[PATCH] util-linux: split {mkfs, fsck}.minix into packages

[PATCH] util-linux: split {mkfs, fsck}.minix into packages

[Patrick Williams]

mkfs.minix and fsck.minix are likely rarely used, so split
them into their own packages to reduce the footprint of
util-linux.  This follows the pattern of cramfs support
within util-linux.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
---
 meta/recipes-core/util-linux/util-linux.inc | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-core/util-linux/util-linux.inc b/meta/recipes-core/util-linux/util-linux.inc
index bf770d8..4df8d5a 100644
--- a/meta/recipes-core/util-linux/util-linux.inc
+++ b/meta/recipes-core/util-linux/util-linux.inc
@@ -31,7 +31,9 @@ PACKAGES =+ "util-linux-agetty util-linux-fdisk util-linux-cfdisk util-linux-sfd
              util-linux-mount util-linux-readprofile util-linux-uuidd \
              util-linux-uuidgen util-linux-lscpu util-linux-fsck util-linux-blkid \
              util-linux-mkfs util-linux-mcookie util-linux-reset \
-             util-linux-mkfs.cramfs util-linux-fsck.cramfs util-linux-fstrim \
+             util-linux-mkfs.cramfs util-linux-fsck.cramfs \
+             util-linux-mkfs.minix util-linux-fsck.minix \
+             util-linux-fstrim \
              util-linux-partx util-linux-hwclock util-linux-mountpoint \
              util-linux-findfs util-linux-getopt util-linux-sulogin util-linux-prlimit"
 PACKAGES += "${@bb.utils.contains('PACKAGECONFIG', 'pylibmount', 'util-linux-pylibmount', '', d)}"
@@ -96,9 +98,12 @@ FILES_util-linux-pylibmount = "${PYTHON_SITEPACKAGES_DIR}/libmount/pylibmount.so
                                ${PYTHON_SITEPACKAGES_DIR}/libmount/__pycache__/*"
 FILES_util-linux-lscpu = "${bindir}/lscpu"
 
-FILES_util-linux-fsck = "${base_sbindir}/fsck*"
+FILES_util-linux-fsck = "${base_sbindir}/fsck ${base_sbindir}/fsck.${BPN}"
 FILES_util-linux-mkfs = "${sbindir}/mkfs"
 
+FILES_util-linux-fsck.minix = "${base_sbindir}/fsck.minix ${base_sbindir}/fsck.minix.${BPN}"
+FILES_util-linux-mkfs.minix = "${base_sbindir}/mkfs.minix ${base_sbindir}/mkfs.minix.${BPN}"
+
 FILES_util-linux-fsck.cramfs = "${sbindir}/fsck.cramfs"
 FILES_util-linux-mkfs.cramfs = "${sbindir}/mkfs.cramfs"
 
@@ -248,7 +253,8 @@ ALTERNATIVE_util-linux-swaponoff = "swapoff swapon"
 ALTERNATIVE_LINK_NAME[swapoff] = "${base_sbindir}/swapoff"
 ALTERNATIVE_LINK_NAME[swapon] = "${base_sbindir}/swapon"
 
-ALTERNATIVE_util-linux-fsck = "fsck.minix fsck"
+ALTERNATIVE_util-linux-fsck.minix = "fsck.minix"
+ALTERNATIVE_util-linux-fsck = "fsck"
 ALTERNATIVE_LINK_NAME[fsck.minix] = "${base_sbindir}/fsck.minix"
 ALTERNATIVE_LINK_NAME[fsck] = "${base_sbindir}/fsck"
 
-- 
2.9.0

Re: [PATCH] util-linux: split {mkfs, fsck}.minix into packages

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

On 14 September 2016 at 18:12, Patrick Williams <patrick@stwcx.xyz> wrote:

> mkfs.minix and fsck.minix are likely rarely used, so split
> them into their own packages to reduce the footprint of
> util-linux.  This follows the pattern of cramfs support
> within util-linux.
>

Minix is so unlikely to be used, why don't we just disable it entirely?
(--disable-minix).

Ross

[-- Attachment #2: Type: text/html, Size: 796 bytes --]

Re: [PATCH] util-linux: split {mkfs, fsck}.minix into packages

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

On Wed, Sep 14, 2016 at 10:01:01PM +0100, Burton, Ross wrote:
> On 14 September 2016 at 18:12, Patrick Williams <patrick@stwcx.xyz> wrote:
> 
> > mkfs.minix and fsck.minix are likely rarely used, so split
> > them into their own packages to reduce the footprint of
> > util-linux.  This follows the pattern of cramfs support
> > within util-linux.
> >
> 
> Minix is so unlikely to be used, why don't we just disable it entirely?
> (--disable-minix).
> 
> Ross

Sure, prefer I submit that instead?

-- 
Patrick Williams

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] util-linux: split {mkfs, fsck}.minix into packages

[Richard Purdie]

On Wed, 2016-09-14 at 21:21 -0500, Patrick Williams wrote:
> On Wed, Sep 14, 2016 at 10:01:01PM +0100, Burton, Ross wrote:
> > 
> > On 14 September 2016 at 18:12, Patrick Williams <patrick@stwcx.xyz>
> > wrote:
> > 
> > > 
> > > mkfs.minix and fsck.minix are likely rarely used, so split
> > > them into their own packages to reduce the footprint of
> > > util-linux.  This follows the pattern of cramfs support
> > > within util-linux.
> > > 
> > Minix is so unlikely to be used, why don't we just disable it
> > entirely?
> > (--disable-minix).
> > 
> > Ross
> Sure, prefer I submit that instead?

Please, might as well not bother building that!

Cheers,

Richard