* [PATCH 13/16] Enable RGMII pin functions in Firestone DT
@ 2016-09-15 20:37 Timothy Pearson
2016-09-16 1:39 ` Joel Stanley
2016-09-16 2:20 ` Andrew Jeffery
0 siblings, 2 replies; 3+ messages in thread
From: Timothy Pearson @ 2016-09-15 20:37 UTC (permalink / raw)
To: openbmc
---
arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
index 053fafe..a2a2ef2 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
@@ -72,6 +72,9 @@
&mac0 {
status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_rgmii1_default>;
+
no-hw-checksum;
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 13/16] Enable RGMII pin functions in Firestone DT
2016-09-15 20:37 [PATCH 13/16] Enable RGMII pin functions in Firestone DT Timothy Pearson
@ 2016-09-16 1:39 ` Joel Stanley
2016-09-16 2:20 ` Andrew Jeffery
1 sibling, 0 replies; 3+ messages in thread
From: Joel Stanley @ 2016-09-16 1:39 UTC (permalink / raw)
To: Timothy Pearson; +Cc: OpenBMC Maillist
On Fri, Sep 16, 2016 at 6:07 AM, Timothy Pearson
<tpearson@raptorengineering.com> wrote:
>
Missing your s-o-b and commit message.
> ---
> arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> index 053fafe..a2a2ef2 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> @@ -72,6 +72,9 @@
> &mac0 {
> status = "okay";
>
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rgmii1_default>;
> +
> no-hw-checksum;
> };
>
> --
> 1.7.9.5
>
> _______________________________________________
> openbmc mailing list
> openbmc@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 13/16] Enable RGMII pin functions in Firestone DT
2016-09-15 20:37 [PATCH 13/16] Enable RGMII pin functions in Firestone DT Timothy Pearson
2016-09-16 1:39 ` Joel Stanley
@ 2016-09-16 2:20 ` Andrew Jeffery
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Jeffery @ 2016-09-16 2:20 UTC (permalink / raw)
To: Timothy Pearson, openbmc
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
Subject should probably say for which MAC. Also, you need to add a
Signed-off-by: line (for all of your patches it seems). With that,
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
On Thu, 2016-09-15 at 15:37 -0500, Timothy Pearson wrote:
> ---
> arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> index 053fafe..a2a2ef2 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> @@ -72,6 +72,9 @@
> &mac0 {
> status = "okay";
>
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rgmii1_default>;
> +
> no-hw-checksum;
> };
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-16 2:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-15 20:37 [PATCH 13/16] Enable RGMII pin functions in Firestone DT Timothy Pearson
2016-09-16 1:39 ` Joel Stanley
2016-09-16 2:20 ` Andrew Jeffery
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.