All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: rrs@researchut.com, Bastien Nocera <hadess@hadess.net>,
	Jonathan Cameron <jic23@kernel.org>,
	linux-iio@vger.kernel.org
Subject: Re: possible odd acceleration scaling
Date: Fri, 16 Sep 2016 10:43:01 -0700	[thread overview]
Message-ID: <1474047781.32019.1.camel@linux.intel.com> (raw)
In-Reply-To: <1473868832.9913.14.camel@researchut.com>

[-- Attachment #1: Type: text/plain, Size: 662 bytes --]

Hi Ritesh,


On Wed, 2016-09-14 at 21:30 +0530, Ritesh Raj Sarraf wrote:
> Hello Bastien,
> 
> On Wed, 2016-09-14 at 17:44 +0200, Bastien Nocera wrote:
> > 
> > 
> > My guess:
> > -       return (int) (info_1->index - info_2->index);
> > +       return ((int) info_1->index - (int) info_2->index);
> > 
Can you try attached patch for both 4.7 and 4.8 kernel?

Thanks,
Srinivas

> > Ritesh, could you try to change those lines in
> > compare_channel_index()
> > in src/iio-buffer-utils.c and capture another log if it fails?
> 
> That did not seem to change anything. I've put up the log at:
> https://people.debian.org/~rrs/tmp/iio-int.txt
> 
>  

[-- Attachment #2: 0001-Fix-sorting.patch --]
[-- Type: text/x-patch, Size: 893 bytes --]

From 553fb5ace1b131c7c0f146a772168879d6f8c704 Mon Sep 17 00:00:00 2001
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Date: Fri, 16 Sep 2016 10:31:00 -0700
Subject: [PATCH] Fix sorting

Need to derefernce parameters passed to compare callback.
---
 src/iio-buffer-utils.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/iio-buffer-utils.c b/src/iio-buffer-utils.c
index 440a8b7..0b24bac 100644
--- a/src/iio-buffer-utils.c
+++ b/src/iio-buffer-utils.c
@@ -200,8 +200,8 @@ channel_info_free (iio_channel_info *ci)
 static int
 compare_channel_index (gconstpointer a, gconstpointer b)
 {
-	const iio_channel_info *info_1 = a;
-	const iio_channel_info *info_2 = b;
+	const iio_channel_info *info_1 = *(iio_channel_info **) a;
+	const iio_channel_info *info_2 = *(iio_channel_info **) b;
 
 	return (int) (info_1->index - info_2->index);
 }
-- 
2.7.4


  reply	other threads:[~2016-09-16 17:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-13 17:30 possible odd acceleration scaling Ritesh Raj Sarraf
2016-09-13 17:50 ` Jonathan Cameron
2016-09-13 18:01   ` Jonathan Cameron
2016-09-13 19:06     ` Srinivas Pandruvada
2016-09-14  9:05       ` Ritesh Raj Sarraf
2016-09-14  9:28         ` Ritesh Raj Sarraf
2016-09-14 13:50           ` Ritesh Raj Sarraf
2016-09-14 15:28             ` Srinivas Pandruvada
2016-09-14 15:44               ` Bastien Nocera
2016-09-14 16:00                 ` Ritesh Raj Sarraf
2016-09-16 17:43                   ` Srinivas Pandruvada [this message]
2016-09-16 18:26                     ` Ritesh Raj Sarraf
2016-09-16 18:35                       ` Ritesh Raj Sarraf
2016-09-16 19:31                         ` Srinivas Pandruvada
2016-09-16 19:40                           ` Pandruvada, Srinivas
2016-09-16 21:19                             ` Bastien Nocera
2016-09-16 22:30                               ` Pandruvada, Srinivas
2016-09-16 22:51                                 ` Bastien Nocera
2016-09-14 11:34   ` Bastien Nocera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474047781.32019.1.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=hadess@hadess.net \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=rrs@researchut.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.