All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	rrs@researchut.com, Jonathan Cameron <jic23@kernel.org>,
	linux-iio@vger.kernel.org
Subject: Re: possible odd acceleration scaling
Date: Wed, 14 Sep 2016 17:44:32 +0200	[thread overview]
Message-ID: <1473867872.6389.16.camel@hadess.net> (raw)
In-Reply-To: <1473866880.35049.5.camel@linux.intel.com>

On Wed, 2016-09-14 at 08:28 -0700, Srinivas Pandruvada wrote:
> On Wed, 2016-09-14 at 19:20 +0530, Ritesh Raj Sarraf wrote:
> Hello Srinivas,
> 
> On Wed, 2016-09-14 at 14:58 +0530, Ritesh Raj Sarraf wrote:
> > 
> >  
> > And linked are debug logs with both, 1.1 and 1.2
> > 
> > https://people.debian.org/~rrs/tmp/1.1.log
> > https://people.debian.org/~rrs/tmp/1.2.log
> > 
> 
> 
> After reverting your changes[1], and applying Bastien's change [2],
> it is better
> as in now it can detect all orientation types. But they do not align
> with the
> actual physical orientation of the device. They are flipped to the
> actual
> orientation of the device. Logs linked [3]. Tested on Linux 4.8-rc6
> 
> rrs@learner:/var/tmp/Debian-Build/Result$ monitor-sensor 
>     Waiting for iio-sensor-proxy to appear
> +++ iio-sensor-proxy appeared
> === Has accelerometer (orientation: right-up)
> === Has ambient light sensor (value: 0.000000, unit: lux)
>     Accelerometer orientation changed: normal
>     Accelerometer orientation changed: right-up
>     Accelerometer orientation changed: bottom-up
>     Accelerometer orientation changed: right-up
> 
> 
> I was surprised why the sorting function didn't work (it should be
> qsort compliant). We need some way not to depend on the order of
> scan_elements read from file system. So we need to fix this.

My guess:
-       return (int) (info_1->index - info_2->index);
+       return ((int) info_1->index - (int) info_2->index);

Ritesh, could you try to change those lines in compare_channel_index()
in src/iio-buffer-utils.c and capture another log if it fails?

Cheers

  reply	other threads:[~2016-09-14 15:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-13 17:30 possible odd acceleration scaling Ritesh Raj Sarraf
2016-09-13 17:50 ` Jonathan Cameron
2016-09-13 18:01   ` Jonathan Cameron
2016-09-13 19:06     ` Srinivas Pandruvada
2016-09-14  9:05       ` Ritesh Raj Sarraf
2016-09-14  9:28         ` Ritesh Raj Sarraf
2016-09-14 13:50           ` Ritesh Raj Sarraf
2016-09-14 15:28             ` Srinivas Pandruvada
2016-09-14 15:44               ` Bastien Nocera [this message]
2016-09-14 16:00                 ` Ritesh Raj Sarraf
2016-09-16 17:43                   ` Srinivas Pandruvada
2016-09-16 18:26                     ` Ritesh Raj Sarraf
2016-09-16 18:35                       ` Ritesh Raj Sarraf
2016-09-16 19:31                         ` Srinivas Pandruvada
2016-09-16 19:40                           ` Pandruvada, Srinivas
2016-09-16 21:19                             ` Bastien Nocera
2016-09-16 22:30                               ` Pandruvada, Srinivas
2016-09-16 22:51                                 ` Bastien Nocera
2016-09-14 11:34   ` Bastien Nocera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473867872.6389.16.camel@hadess.net \
    --to=hadess@hadess.net \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=rrs@researchut.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.